linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Harry Yoo <harry.yoo@oracle.com>, Rakie Kim <rakie.kim@sk.com>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	Joshua Hahn <joshua.hahnjy@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v6 04/10] mm,slub: Use node-notifier instead of memory-notifier
Date: Mon,  9 Jun 2025 11:21:41 +0200	[thread overview]
Message-ID: <20250609092149.312114-5-osalvador@suse.de> (raw)
In-Reply-To: <20250609092149.312114-1-osalvador@suse.de>

slub is only concerned when a numa node changes its memory state,
so stop using the memory notifier and use the new numa node notifer
instead.

Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/slub.c | 28 +++++++++-------------------
 1 file changed, 9 insertions(+), 19 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index f92b43d36adc..3ff0b94f3eeb 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -6146,7 +6146,7 @@ int __kmem_cache_shrink(struct kmem_cache *s)
 	return __kmem_cache_do_shrink(s);
 }
 
-static int slab_mem_going_offline_callback(void *arg)
+static int slab_mem_going_offline_callback(void)
 {
 	struct kmem_cache *s;
 
@@ -6160,21 +6160,12 @@ static int slab_mem_going_offline_callback(void *arg)
 	return 0;
 }
 
-static int slab_mem_going_online_callback(void *arg)
+static int slab_mem_going_online_callback(int nid)
 {
 	struct kmem_cache_node *n;
 	struct kmem_cache *s;
-	struct memory_notify *marg = arg;
-	int nid = marg->status_change_nid;
 	int ret = 0;
 
-	/*
-	 * If the node's memory is already available, then kmem_cache_node is
-	 * already created. Nothing to do.
-	 */
-	if (nid < 0)
-		return 0;
-
 	/*
 	 * We are bringing a node online. No memory is available yet. We must
 	 * allocate a kmem_cache_node structure in order to bring the node
@@ -6214,17 +6205,16 @@ static int slab_mem_going_online_callback(void *arg)
 static int slab_memory_callback(struct notifier_block *self,
 				unsigned long action, void *arg)
 {
+	struct node_notify *nn = arg;
+	int nid = nn->nid;
 	int ret = 0;
 
 	switch (action) {
-	case MEM_GOING_ONLINE:
-		ret = slab_mem_going_online_callback(arg);
-		break;
-	case MEM_GOING_OFFLINE:
-		ret = slab_mem_going_offline_callback(arg);
+	case NODE_ADDING_FIRST_MEMORY:
+		ret = slab_mem_going_online_callback(nid);
 		break;
-	case MEM_ONLINE:
-	case MEM_CANCEL_OFFLINE:
+	case NODE_REMOVING_LAST_MEMORY:
+		ret = slab_mem_going_offline_callback();
 		break;
 	}
 	if (ret)
@@ -6300,7 +6290,7 @@ void __init kmem_cache_init(void)
 			sizeof(struct kmem_cache_node),
 			SLAB_HWCACHE_ALIGN | SLAB_NO_OBJ_EXT, 0, 0);
 
-	hotplug_memory_notifier(slab_memory_callback, SLAB_CALLBACK_PRI);
+	hotplug_node_notifier(slab_memory_callback, SLAB_CALLBACK_PRI);
 
 	/* Able to allocate the per node structures */
 	slab_state = PARTIAL;
-- 
2.49.0



  parent reply	other threads:[~2025-06-09  9:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09  9:21 [PATCH v6 00/10] Implement numa node notifier Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 01/10] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 02/10] mm,memory_hotplug: Remove status_change_nid_normal and update documentation Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 03/10] mm,memory_hotplug: Implement numa node notifier Oscar Salvador
2025-06-10  8:10   ` David Hildenbrand
2025-06-16  8:30     ` Oscar Salvador
2025-06-16  8:39       ` David Hildenbrand
2025-06-16  8:50         ` Oscar Salvador
2025-06-16  8:52           ` David Hildenbrand
2025-06-16 11:45             ` Oscar Salvador
2025-06-16 12:21               ` David Hildenbrand
2025-06-16 12:32                 ` Oscar Salvador
2025-06-16 12:35                   ` David Hildenbrand
2025-06-16 12:55                     ` Oscar Salvador
2025-06-09  9:21 ` Oscar Salvador [this message]
2025-06-10  7:50   ` [PATCH v6 04/10] mm,slub: Use node-notifier instead of memory-notifier David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 05/10] mm,memory-tiers: " Oscar Salvador
2025-06-10  7:51   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 06/10] drivers,cxl: " Oscar Salvador
2025-06-10  7:51   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 07/10] drivers,hmat: " Oscar Salvador
2025-06-10  7:52   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 08/10] kernel,cpuset: " Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 09/10] mm,mempolicy: " Oscar Salvador
2025-06-10  7:52   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 10/10] mm,memory_hotplug: Drop status_change_nid parameter from memory_notify Oscar Salvador
2025-06-10  7:55   ` David Hildenbrand
2025-06-10  8:02     ` Oscar Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609092149.312114-5-osalvador@suse.de \
    --to=osalvador@suse.de \
    --cc=42.hyeyoo@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=harry.yoo@oracle.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rakie.kim@sk.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox