From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A00C61DB2 for ; Mon, 9 Jun 2025 09:22:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 203096B0095; Mon, 9 Jun 2025 05:22:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B5196B0096; Mon, 9 Jun 2025 05:22:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 054966B0098; Mon, 9 Jun 2025 05:22:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DB9366B0095 for ; Mon, 9 Jun 2025 05:22:10 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8920EBE956 for ; Mon, 9 Jun 2025 09:22:10 +0000 (UTC) X-FDA: 83535320820.21.AA5EAF4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 64A40C000A for ; Mon, 9 Jun 2025 09:22:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ca74/9dN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XaHzAjfD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ca74/9dN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XaHzAjfD; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749460928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=hkkZ/+E/9+PMQlOEmqDUgS7BBS9+dgmApBe1r0vtsER6LoP3EEdVkgVk7eY9nuxjAKEVFq sWzLJZEBNqPBhoKr0VMii9Mvbcv8wcXEvrYllxhaIuBAnuVL/rAqWD23mYPLC+ehzYHQvv E+bHzREiz9ZYcH46zpssq+nUKs0k3IE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749460928; a=rsa-sha256; cv=none; b=bEBM5zK4TJSBRQr7ugMZHGCIGtOTsxB4QcH02zxSIieO3aSgPBfW0oflqsw/2FW+SEI5ic E2TEDf+OhJIaUkdrVKvcjEeHZpw/FlA8wBi5cKKTJhN/IXx7EvRZb8XzxGmKHEzsAjpDLt FTKfX+ZsqQkpkBZTMbLVJ9iF7oNhaok= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ca74/9dN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XaHzAjfD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ca74/9dN"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=XaHzAjfD; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 314FE211A3; Mon, 9 Jun 2025 09:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749460921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=Ca74/9dNOIT1PSSJUGfATW1dc6BjKirD6/1ElzvxYAMAuKEKQFis1ASB6U+Hkrluhekvrn hTxL6PZlWa/QHABtAg67uvPa2ckzs6NufwxWfRhQl0dzjlBD4C3smy/tCeu9kjcsr5qlyT ye30K/a2HEv+HVqhFaQBtv0hugZGWds= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749460921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=XaHzAjfD2Ihg5YAp+3Wbk+KeYbFCP8kPpSLqG1cWj62ggHm6qNMg24O6qQ5nZtMIZ/Wlru L0zFbV5pG9l3+qAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749460921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=Ca74/9dNOIT1PSSJUGfATW1dc6BjKirD6/1ElzvxYAMAuKEKQFis1ASB6U+Hkrluhekvrn hTxL6PZlWa/QHABtAg67uvPa2ckzs6NufwxWfRhQl0dzjlBD4C3smy/tCeu9kjcsr5qlyT ye30K/a2HEv+HVqhFaQBtv0hugZGWds= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749460921; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=XaHzAjfD2Ihg5YAp+3Wbk+KeYbFCP8kPpSLqG1cWj62ggHm6qNMg24O6qQ5nZtMIZ/Wlru L0zFbV5pG9l3+qAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 85E0713A85; Mon, 9 Jun 2025 09:22:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id GJXuHbinRmjJGAAAD6G6ig (envelope-from ); Mon, 09 Jun 2025 09:22:00 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joshua Hahn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v6 01/10] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Date: Mon, 9 Jun 2025 11:21:38 +0200 Message-ID: <20250609092149.312114-2-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250609092149.312114-1-osalvador@suse.de> References: <20250609092149.312114-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 64A40C000A X-Stat-Signature: 81e1g4u4ypso6a38jbogs9y7phu3ux1a X-Rspam-User: X-HE-Tag: 1749460928-891891 X-HE-Meta: U2FsdGVkX1/9SEHPGCZ5OrTOPkz2s88C8XMg8JSCH7GHTvN96fI4O8f1fGA4s2WqVBprlh6oquOIFZzlhfRckIelsPXihppCuyFy1SLz7L0BL3TzCReBckQ0O6zycjQ0toZQI8bE6o72UCJXf2ZniHvpnvdJRos4ea/4HtIqUEhsOvIHkagtZgELLkFSnvakjYNfmY1YonjMwhMFsGWJvfLtZp0SsKVJpQWIFsdI8UcCws5F2rSNqIu9OPg+ctoswPEg46QCFpSp+i17sx+qcMjEZCrpKA1RXwPC4BStWJG0DG02chqlXR5sKlaU/TfcnOdbAMK9oCYIQlm370Wb7M3vIQfrgnLy1CH8eXgKKWLn1qbJ0ApaMLGaf94kPTdJq+JSNsx1T+oi9kpyNn/KFReoL8jxs4WLwD+o7McCOA5MjgEyWgG1eeyegunlYUzWLC3vv9Pa4ZMVcPeECg2zyByiy/TKBAvMAocG0w4Q6FSfYk9p3Nl36/hfeuVzMF5TKptIU69SRhHwhgf6p5URr5+BoE6nKn7SdvgAsSFE8bD4KDjuf64AsGMb7BR1WDCnB9qrbevzB+XJug7tK5GR4RCO/hsucQiqIO3CkOsNbVxGot82U6AgRg9WK1JoA4769cnzZIYP/Nr8cjP0kOqBg5nQqS8er59SurrPq4/6cFOYpCIT2uZzmfupoTLb+ySKcOKL2IT4O8es4F06/0GQvBQU5vxQeB4kElVtcWWXQaptyaBMLAB6DjjMoVcE+sawK1qK5D03v01HjGyEuC3DKKa5ZwHxgHzuG4cJMDEGCJSwroJ2w8VpOo3Ckw2Is7zOpXXoxqpS3VcUDwxgFAVNOJVWI1fO/JMTVj0bFg6+jIbXcukvrggXpT3MATPj7wQy1Dq4DYXUdplxA6z8Lt2SK9zPpcN8USmqhcPWxvow7myD22KZY7Ue4ARlEOkcYkcZTZfBmriHEb1R7ZSoSVp 96ws0GuL NjI0JekahKbs00jdopSTs62P1OjimRMajG8mIvwN3jkacPCHv5fo4n2fMO23eEeJVYEIsZZ3KeHOSUKed1dDd4zOZfn9tcwsCP5/D2GOhRaNJAlYpHhHzh/rD85ZZs68FeFA1IPqMntMZSG2O6uwCcQROEeE6VZpVCcoxqjP0fm1VZUD+LMXtv2OpGmPmMeqW98DUbL+VK4wLDMJnF6pdVCKMnThxvS9KA74ogUvBzcntUqc6fcpbm9FC3hDguEzmHqZ5+rmlRYyWDVBtOPotFgH95rWHbuX2veeIMY4oCKV6UNU3qIidg/xBX2n/SyWLMsCqRcc7BQZZuSiZqf+F+jm4FwXv9sknAWZK6t7ExlaM09srFIQZXA4YHKfBvD6PtXk3qqRSr/Vf9QHxvGXEwoBgxf3iqLr4fkvwhaTqg4LgI3I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, slab_mem_going_online_callback() checks whether the node has N_NORMAL memory in order to be set in slab_nodes. While it is true that getting rid of that enforcing would mean ending up with movables nodes in slab_nodes, the memory waste that comes with that is negligible. So stop checking for status_change_nid_normal and just use status_change_nid instead which works for both types of memory. Also, once we allocate the kmem_cache_node cache for the node in slab_mem_online_callback(), we never deallocate it in slab_mem_offline_callback() when the node goes memoryless, so we can just get rid of it. The side effects are that we will stop clearing the node from slab_nodes, and also that newly created kmem caches after node hotremove will now allocate their kmem_cache_node for the node(s) that was hotremoved, but these should be negligible. Suggested-by: David Hildenbrand Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Harry Yoo Acked-by: David Hildenbrand --- mm/slub.c | 34 +++------------------------------- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index be8b09e09d30..f92b43d36adc 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -447,7 +447,7 @@ static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node) /* * Tracks for which NUMA nodes we have kmem_cache_nodes allocated. - * Corresponds to node_state[N_NORMAL_MEMORY], but can temporarily + * Corresponds to node_state[N_MEMORY], but can temporarily * differ during memory hotplug/hotremove operations. * Protected by slab_mutex. */ @@ -6160,36 +6160,12 @@ static int slab_mem_going_offline_callback(void *arg) return 0; } -static void slab_mem_offline_callback(void *arg) -{ - struct memory_notify *marg = arg; - int offline_node; - - offline_node = marg->status_change_nid_normal; - - /* - * If the node still has available memory. we need kmem_cache_node - * for it yet. - */ - if (offline_node < 0) - return; - - mutex_lock(&slab_mutex); - node_clear(offline_node, slab_nodes); - /* - * We no longer free kmem_cache_node structures here, as it would be - * racy with all get_node() users, and infeasible to protect them with - * slab_mutex. - */ - mutex_unlock(&slab_mutex); -} - static int slab_mem_going_online_callback(void *arg) { struct kmem_cache_node *n; struct kmem_cache *s; struct memory_notify *marg = arg; - int nid = marg->status_change_nid_normal; + int nid = marg->status_change_nid; int ret = 0; /* @@ -6247,10 +6223,6 @@ static int slab_memory_callback(struct notifier_block *self, case MEM_GOING_OFFLINE: ret = slab_mem_going_offline_callback(arg); break; - case MEM_OFFLINE: - case MEM_CANCEL_ONLINE: - slab_mem_offline_callback(arg); - break; case MEM_ONLINE: case MEM_CANCEL_OFFLINE: break; @@ -6321,7 +6293,7 @@ void __init kmem_cache_init(void) * Initialize the nodemask for which we will allocate per node * structures. Here we don't need taking slab_mutex yet. */ - for_each_node_state(node, N_NORMAL_MEMORY) + for_each_node_state(node, N_MEMORY) node_set(node, slab_nodes); create_boot_cache(kmem_cache_node, "kmem_cache_node", -- 2.49.0