linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Harry Yoo <harry.yoo@oracle.com>, Rakie Kim <rakie.kim@sk.com>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>,
	Joshua Hahn <joshua.hahnjy@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v6 09/10] mm,mempolicy: Use node-notifier instead of memory-notifier
Date: Mon,  9 Jun 2025 11:21:46 +0200	[thread overview]
Message-ID: <20250609092149.312114-10-osalvador@suse.de> (raw)
In-Reply-To: <20250609092149.312114-1-osalvador@suse.de>

mempolicy is only concerned when a numa node changes its memory state,
because it needs to take this node into account for the auto-weighted
memory policy system.
So stop using the memory notifier and use the new numa node notifer
instead.

Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Rakie Kim <rakie.kim@sk.com>
---
 mm/mempolicy.c | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 72fd72e156b1..693319c2652d 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -3793,20 +3793,17 @@ static int wi_node_notifier(struct notifier_block *nb,
 			       unsigned long action, void *data)
 {
 	int err;
-	struct memory_notify *arg = data;
-	int nid = arg->status_change_nid;
-
-	if (nid < 0)
-		return NOTIFY_OK;
+	struct node_notify *nn = data;
+	int nid = nn->nid;
 
 	switch (action) {
-	case MEM_ONLINE:
+	case NODE_ADDED_FIRST_MEMORY:
 		err = sysfs_wi_node_add(nid);
 		if (err)
 			pr_err("failed to add sysfs for node%d during hotplug: %d\n",
 			       nid, err);
 		break;
-	case MEM_OFFLINE:
+	case NODE_REMOVED_LAST_MEMORY:
 		sysfs_wi_node_delete(nid);
 		break;
 	}
@@ -3845,7 +3842,7 @@ static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj)
 		}
 	}
 
-	hotplug_memory_notifier(wi_node_notifier, DEFAULT_CALLBACK_PRI);
+	hotplug_node_notifier(wi_node_notifier, DEFAULT_CALLBACK_PRI);
 	return 0;
 
 err_cleanup_kobj:
-- 
2.49.0



  parent reply	other threads:[~2025-06-09  9:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-09  9:21 [PATCH v6 00/10] Implement numa node notifier Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 01/10] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 02/10] mm,memory_hotplug: Remove status_change_nid_normal and update documentation Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 03/10] mm,memory_hotplug: Implement numa node notifier Oscar Salvador
2025-06-10  8:10   ` David Hildenbrand
2025-06-16  8:30     ` Oscar Salvador
2025-06-16  8:39       ` David Hildenbrand
2025-06-16  8:50         ` Oscar Salvador
2025-06-16  8:52           ` David Hildenbrand
2025-06-16 11:45             ` Oscar Salvador
2025-06-16 12:21               ` David Hildenbrand
2025-06-16 12:32                 ` Oscar Salvador
2025-06-16 12:35                   ` David Hildenbrand
2025-06-16 12:55                     ` Oscar Salvador
2025-06-09  9:21 ` [PATCH v6 04/10] mm,slub: Use node-notifier instead of memory-notifier Oscar Salvador
2025-06-10  7:50   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 05/10] mm,memory-tiers: " Oscar Salvador
2025-06-10  7:51   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 06/10] drivers,cxl: " Oscar Salvador
2025-06-10  7:51   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 07/10] drivers,hmat: " Oscar Salvador
2025-06-10  7:52   ` David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 08/10] kernel,cpuset: " Oscar Salvador
2025-06-09  9:21 ` Oscar Salvador [this message]
2025-06-10  7:52   ` [PATCH v6 09/10] mm,mempolicy: " David Hildenbrand
2025-06-09  9:21 ` [PATCH v6 10/10] mm,memory_hotplug: Drop status_change_nid parameter from memory_notify Oscar Salvador
2025-06-10  7:55   ` David Hildenbrand
2025-06-10  8:02     ` Oscar Salvador

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250609092149.312114-10-osalvador@suse.de \
    --to=osalvador@suse.de \
    --cc=42.hyeyoo@gmail.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=harry.yoo@oracle.com \
    --cc=joshua.hahnjy@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rakie.kim@sk.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox