From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9299CC61DB2 for ; Mon, 9 Jun 2025 06:56:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 279F76B007B; Mon, 9 Jun 2025 02:56:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22BA46B0088; Mon, 9 Jun 2025 02:56:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 142F06B0089; Mon, 9 Jun 2025 02:56:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E8F1C6B007B for ; Mon, 9 Jun 2025 02:56:35 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8CF19C1308 for ; Mon, 9 Jun 2025 06:56:35 +0000 (UTC) X-FDA: 83534953950.27.B512A26 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf05.hostedemail.com (Postfix) with ESMTP id C72D1100002 for ; Mon, 9 Jun 2025 06:56:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of husong@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=husong@kylinos.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749452193; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=TV0eTkygVXrCdMW5XYREjzTWo/GGvD03Y51HG2HJ5wg=; b=Vo/xPb0YfAB9m3EbsG82TIweCJF7RR2mL7aXhv8oYx2oupTMRkeNlMgRMn6gwfK0NyoVve w1EpvHR21zSM1orlCmfYHET6CeYrdd4sjdjVPUkVJ76gxFFbpTdHLimuQdWOgNF6XJazz8 Hdbl+cmwp0+sv9Mb3OwZGLXS2/3aYX8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749452193; a=rsa-sha256; cv=none; b=EmEWYf/3Xk6xG6pTFncHiqErAY0PeVPg6zoMMaYpiFhxVp767yxV3KxC0CUBNDxXx/BZoi OSkCOo+fVPHh00COzMPEnh+sTck/upZO+Eg1F6enpHrjtEW5PuXjNvmv/YZdExGKBaEbY6 LZ17KCTpqrblhOyaE0B4/g6/JrACPgk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf05.hostedemail.com: domain of husong@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=husong@kylinos.cn X-UUID: da94afec44fe11f0b29709d653e92f7d-20250609 X-CTIC-Tags: HR_CC_COUNT, HR_CC_DOMAIN_COUNT, HR_CC_NAME, HR_CC_NO_NAME, HR_CTE_8B HR_CTT_MISS, HR_DATE_H, HR_DATE_WKD, HR_DATE_ZONE, HR_FROM_NAME HR_SJ_LANG, HR_SJ_LEN, HR_SJ_LETTER, HR_SJ_NOR_SYM, HR_SJ_PHRASE HR_SJ_PHRASE_LEN, HR_SJ_WS, HR_TO_COUNT, HR_TO_DOMAIN_COUNT, HR_TO_NO_NAME IP_UNTRUSTED, SRC_UNTRUSTED, IP_UNFAMILIAR, SRC_UNFAMILIAR, DN_TRUSTED SRC_TRUSTED, SA_UNTRUSTED, SA_LOWREP, SA_EXISTED, SN_UNTRUSTED SN_LOWREP, SN_EXISTED, SPF_NOPASS, DKIM_NOPASS, DMARC_NOPASS X-CID-UNFAMILIAR: 1 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:221b8a28-7d67-404f-b161-761a707210be,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:18,FILE:0,BULK:0,RULE:Release_Ham,ACTIO N:release,TS:28 X-CID-INFO: VERSION:1.1.45,REQID:221b8a28-7d67-404f-b161-761a707210be,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:18,FILE:0,BULK:0,RULE:Release_HamU,ACTION :release,TS:28 X-CID-META: VersionHash:6493067,CLOUDID:01d4378e4e31474b0669c5966d371f7c,BulkI D:250609145624TAPJGJ8R,BulkQuantity:0,Recheck:0,SF:16|19|23|43|66|74|78|10 2,TC:nil,Content:0|50,EDM:-3,IP:-2,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,B EC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_USA,TF_CID_SPAM_FSD X-UUID: da94afec44fe11f0b29709d653e92f7d-20250609 X-User: husong@kylinos.cn Received: from localhost.localdomain [(223.104.40.206)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1542986758; Mon, 09 Jun 2025 14:56:22 +0800 From: Hu Song To: muchun.song@linux.dev Cc: osalvador@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hu Song Subject: [PATCH] hugetlbfs:inode: initialize 'error' variable at definition to reduce code redundancy Date: Mon, 9 Jun 2025 14:56:15 +0800 Message-Id: <20250609065615.108240-1-husong@kylinos.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C72D1100002 X-Stat-Signature: 94zk4wofxswcs86enxu6kp7mde6j7o93 X-Rspam-User: X-HE-Tag: 1749452191-190564 X-HE-Meta: U2FsdGVkX1/7TttrKKmBRRbDJo4cIaXyQErCzyiZ7GecSeQcF5kajmxBc+EQabAv56qEJkk7+3YdGwUmAQ/5RKVv+cZd2OI/aOHJlYsRtInRGy1z/txrKlsLzFf1Kyrx2tzRPj3qBTrBf4BkFMvg/iOCitY4eYKxMgoDVrG4f5ghNaYduPg7Z3h7AuF64Naw13HK6t4mL4MTKbuUwbq1jO/tAUCQN8w1AJbBdxABRTtMdHGyhQ0cVsIyFXJnBqDts6HrbvHcQcpvsy8c82l+uGRtvtovh2xvOza+NAI9JHEt8TzwUpIpURsnkHyr7bbxffjYIYSyDME8SwmcRtbGtj9bY+5kBKs3qBWIQuqZHzlgsd2847A1cY4mUXr75+3npwwAU0nucEwoj7tsKbHt+hwhC2CM7yGXxX50J0e5U/kGfjl0MFUczSHGzXbNCZwwvSyKNx6/XnTT1z7SOAdfOtlsl48HBjcst6Mkdx4MTnePY8+8Oz1HEx1G773NxcnuITSaxGfbNK0plXAeWKihV5X8z3mp+RW65EKHtHTK+kY2SRAdNGTYUmh96KBL7pa4+/5vAPaEoBeEpQ5JApBhNbnk2bN/0iVZXzAPB18H1Ry2eye/bBA3EjcPnuXnQfwjFPUVAz2n3o5ZG1zawaFeTXfp1yYMK+UXtgyx5BffsXBuDVU1aPFX9ROjQ4cYEej/PK1Bx3nIMq/mLuSfzmvdS4p60tA23FSTKre7tpZgAYmxxqu/bI58CAqaW79iVp/yrDZ+ftrWe5kzCFwI+e8iqRf7kLofjJYHeQis3E/XOcYuEs7nwQwXFky4niIToLzokjvsqPKhtLVIKhWN4iN/7YpHGBreG5YDZLYjWnfg18h3diyFlwxd2nJtqgZreht0if/4DOoDD8l4/y+rOk0CYcRWNClHeWXlnEeUleBjpdeqzhor3D8CPsubRJH5xpRkNfqX1NRGzBvVO2jaH6W zSky9Lw/ zDKj9hD7kUOdqmu4T7fBYltUbCvvUqWiW5Qkn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Initialize the error variable to -ENOMEM at definition in init_hugetlbfs_fs().This removes the need for a separate initialization later and makes the code slightly more concise, while still preserving the original logic. No functional change intended. Signed-off-by: Hu Song --- fs/hugetlbfs/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index e4de5425838d..390cddd5872c 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -1600,7 +1600,7 @@ static int __init init_hugetlbfs_fs(void) { struct vfsmount *mnt; struct hstate *h; - int error; + int error = -ENOMEM; int i; if (!hugepages_supported()) { @@ -1608,7 +1608,6 @@ static int __init init_hugetlbfs_fs(void) return -ENOTSUPP; } - error = -ENOMEM; hugetlbfs_inode_cachep = kmem_cache_create("hugetlbfs_inode_cache", sizeof(struct hugetlbfs_inode_info), 0, SLAB_ACCOUNT, init_once); -- 2.25.1