From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09899C61DB2 for ; Mon, 9 Jun 2025 06:48:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79A546B007B; Mon, 9 Jun 2025 02:48:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74AD36B0088; Mon, 9 Jun 2025 02:48:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 660CC6B0089; Mon, 9 Jun 2025 02:48:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 498FA6B007B for ; Mon, 9 Jun 2025 02:48:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B7A32161146 for ; Mon, 9 Jun 2025 06:48:13 +0000 (UTC) X-FDA: 83534932866.27.76296C7 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf14.hostedemail.com (Postfix) with ESMTP id 1A9B4100007 for ; Mon, 9 Jun 2025 06:48:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749451692; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7tacKUF0NSvn/O3a7z2hu8tY26unq+lvWSdYdn3u7iA=; b=YOGJzYdp9HShrzLjVYLJ+vEZCRBWbAzXcbt2IK58VgpsDr5PrfP6kY/uVeY5e4cao0gn8R ydrTRwq4A1skjj+d1AyHmy+LkocRt1oyR6mv+pFYo8SHb7XGem5mzw1o9z1KdbcdKuE4wz ljMQvF6jR3X42hxN9/Bbnm1sypCr33M= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of rakie.kim@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=rakie.kim@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749451692; a=rsa-sha256; cv=none; b=tH5yvbDAEdbvVDBcGvVZGVLMCYMTBCGFTc1ytXeMIYkbPX+mwmiSsxXNsNHNRUU0F0WTHY 0cpImsvmMBJNljHPnNcFMzIn6lgUvl9hBH+ZzUjgnm9yatbf1VIQmj9JArVqRcCn30DUHv l8Y77I0TgiYwbmzsOGtj5+OgDgj8vTw= X-AuditID: a67dfc5b-669ff7000002311f-1f-684683a6ee63 From: Rakie Kim To: Oscar Salvador Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , kernel_team@skhynix.com Subject: Re: [PATCH v5 09/10] mm,mempolicy: Use node-notifier instead of memory-notifier Date: Mon, 9 Jun 2025 15:47:55 +0900 Message-ID: <20250609064800.1830-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.48.1.windows.1 In-Reply-To: <20250605142305.244465-10-osalvador@suse.de> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNLMWRmVeSWpSXmKPExsXC9ZZnoe6yZrcMg40zNS0m9hhYzFm/hs3i 6/pfzBb3lz1jsVi18BqbxeVdc9gs7q35z2pxZlqRxezGPkYHTo+ds+6ye7QcecvqsenTJHaP EzN+s3h8fHqLxeP9vqtsHmcWHGH32Hy62uPzJrkAzigum5TUnMyy1CJ9uwSujB9ts5gLjvFV zHq6lqmBcQ93FyMnh4SAicSN/kXMMHbn121ANgcHm4CSxLG9MSBhEQE1iWmvGtm7GLk4mAWe M0kcbDjCDpIQFoiQeHxvCxOIzSKgKjH/zS6wOC/QnIsLH7JDzNSUaLh0D6yGU8BS4nXXCTBb SIBH4tWG/YwQ9YISJ2c+YQGxmQXkJZq3zmYGWSYhcJlN4tyLXVDHSUocXHGDZQIj/ywkPbOQ 9CxgZFrFKJSZV5abmJljopdRmZdZoZecn7uJERjky2r/RO9g/HQh+BCjAAejEg9vwnTXDCHW xLLiytxDjBIczEoivAL3nTOEeFMSK6tSi/Lji0pzUosPMUpzsCiJ8xp9K08REkhPLEnNTk0t SC2CyTJxcEo1MCp9Kqs03Tr93caokH7u+I0elbyqdmf+hMix5ysa3zjnprT5mOwDi3ttivvj +hcYnFnxju/dz5OX/FcZWaklK92Z0lsg2JbxvWXjdumDq9cpfZfoS+nuab8+b4VL6gTPKEaO be/KHlZvf7izYrb0Nu6StOX+9zMW5vJrPrq04UzG/7Vy2wLEtiixFGckGmoxFxUnAgAfrxd1 bgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsXCNUNNS3dZs1uGwb0p0hYTewws5qxfw2bx df0vZov7y56xWKxaeI3N4vDck6wWl3fNYbO4t+Y/q8WZaUUWh649Z7WY3djH6MDtsXPWXXaP liNvWT02fZrE7nFixm8Wj49Pb7F4vN93lc3j220Pj8UvPjB5nFlwhN1j8+lqj8+b5AK4o7hs UlJzMstSi/TtErgyfrTNYi44xlcx6+lapgbGPdxdjJwcEgImEp1ftzF3MXJwsAkoSRzbGwMS FhFQk5j2qpG9i5GLg1ngOZPEwYYj7CAJYYEIicf3tjCB2CwCqhLz3+wCi/MCzbm48CE7xExN iYZL98BqOAUsJV53nQCzhQR4JF5t2M8IUS8ocXLmExYQm1lAXqJ562zmCYw8s5CkZiFJLWBk WsUokplXlpuYmWOqV5ydUZmXWaGXnJ+7iREYxMtq/0zcwfjlsvshRgEORiUe3oTprhlCrIll xZW5hxglOJiVRHgF7jtnCPGmJFZWpRblxxeV5qQWH2KU5mBREuf1Ck9NEBJITyxJzU5NLUgt gskycXBKNTAWCsz3z5HTb3j4dsKTLRIeJzifd4e2a9kJJ5YmGR/dLbrmttyLBasv2y3n+xDu t9BBiSND6N4hrQm7piR+qfFwm6vlz6H9X1rq7fOf0ob7WZodlnv9DK96qf/5+DbO5c+P/clv 4Tb5pLbx9C35LUeVVAqqvKwmKOqwSf11nr7LOW/3ac7a42eVWIozEg21mIuKEwG+CYdFXgIA AA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 1A9B4100007 X-Stat-Signature: bjfq3qo13ehezoqs9h5f3bqiuskmqhxw X-Rspam-User: X-HE-Tag: 1749451690-918621 X-HE-Meta: U2FsdGVkX19fIZ/eA4O8F+Y4C+Dl1jwyjI/yQgdZPQOb2CfMrwAkaQENMLQPYLKuqaFmkqiKwXNumvxE+Q8+33WhILFrc1uUHTctW7F2Xj3UjoV/PW5hpMnIMZq8FaHwJ/SW6MkYC1ajBFWuh53y1M5e4KDB5LHkVNq9/x6YROhe5hfNoTsh3nkgKg/r/JpCYiX9GHQcSzSBybI1BwxN9nXEw8BknLJZFu2Nn7RhV3Wn+n5xW+DXA6CXvAlIW8Uj5q7OL1fZrhVRHd9vxokq49l9XzMwhpQ6ZpqlSQnBlO0QMD4+NlPKaYLZR1353vf54L6/9SgWT1dQ0kegKKMY23Jl4ojQ/pl4M36cSkH5sFib+W1Pun7IzzyRyCWwt6dOhR7rR64h/d3Xffvx6vyDM0t6/WxPUuGtpF/H2fl2NHAEOd12l2V5h1r+jGMstAePZXENNONp7CunB1FfDPjEw92/HxxVO47jqCw1PJO8jlcX2T02G+Ra1gS3N9eY246UlmH7WwqCWdMLuWFkMiF4JvABwsYH8Cd2Yz26XLnfHZErT+H2RUCZ28CW3GGMTuB9xYhspue0VXN7rEB6iwxPZFektOw0p5FqDm6u9rjf8apwbvfFI8CKMN/kJcGP2IEgkJU9reIJIykTk5/BlZxTmDNY3hCeF48e8crr8p727TnaDWZmZNUBZL7HuPpX4BVd6l8VEzzKTWIuZZN1u+sgWsth9yl85es3UxvPca/1ga5qmP1F+9ehAhiA6RZxQ4wlCJMC7bN23RJQK4C187xL2YEG8MlCFcKBfnSSDZePGqU3/RmUVjMJGSmzSI8b3UUXzD3oJCSGd5rJQnZL8HUFLpqJtWq5e4SJcB9doQRiJICU6fYlcHozB+0nEI7dNMNVB+ksCcoZSxl+Var56RDNSWt5b1dEWDWpQ+801pVTbzIaHqNzpswi/0hGQ56M5PixjTlCGG7OpFQF9KEU7Le Nw2TU/Cs xPleyRCtt4m5zsGvq6LzVCU9C7bcmC/kytq9Nz4ZIzVqgEFXQn54zGboS/zYgSReYRJsuUe4S+m14FR+qcTCmpPltfcXwa+CmSDLk5KqQMiJrDkxnv+T3q8sBguGgeYOBgQGeY0+mOOE2MFE4BG/qKuReGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 5 Jun 2025 16:23:00 +0200 Oscar Salvador wrote: > mempolicy is only concerned when a numa node changes its memory state, > because it needs to take this node into account for the auto-weighted > memory policy system. > So stop using the memory notifier and use the new numa node notifer > instead. > > Signed-off-by: Oscar Salvador > Reviewed-by: Jonathan Cameron > Reviewed-by: Harry Yoo > Reviewed-by: Vlastimil Babka > --- > mm/mempolicy.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > index 72fd72e156b1..1b87628f3cfc 100644 > --- a/mm/mempolicy.c > +++ b/mm/mempolicy.c > @@ -3793,20 +3793,20 @@ static int wi_node_notifier(struct notifier_block *nb, > unsigned long action, void *data) > { > int err; > - struct memory_notify *arg = data; > - int nid = arg->status_change_nid; > + struct node_notify *arg = data; > + int nid = arg->nid; > > if (nid < 0) > return NOTIFY_OK; > > switch (action) { > - case MEM_ONLINE: > + case NODE_ADDED_FIRST_MEMORY: > err = sysfs_wi_node_add(nid); > if (err) > pr_err("failed to add sysfs for node%d during hotplug: %d\n", > nid, err); > break; > - case MEM_OFFLINE: > + case NODE_REMOVED_LAST_MEMORY: > sysfs_wi_node_delete(nid); > break; > } > @@ -3845,7 +3845,7 @@ static int __init add_weighted_interleave_group(struct kobject *mempolicy_kobj) > } > } > > - hotplug_memory_notifier(wi_node_notifier, DEFAULT_CALLBACK_PRI); > + hotplug_node_notifier(wi_node_notifier, DEFAULT_CALLBACK_PRI); > return 0; > > err_cleanup_kobj: > -- > 2.49.0 > Reviewed-by: Rakie Kim Rakie