From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D014AC677C4 for ; Mon, 9 Jun 2025 04:32:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75EEF6B0099; Mon, 9 Jun 2025 00:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70F8D6B009A; Mon, 9 Jun 2025 00:32:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58A706B009B; Mon, 9 Jun 2025 00:32:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B8716B0099 for ; Mon, 9 Jun 2025 00:32:45 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DA5FD160DE2 for ; Mon, 9 Jun 2025 04:32:44 +0000 (UTC) X-FDA: 83534591448.20.D9480FF Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf02.hostedemail.com (Postfix) with ESMTP id E66C280005 for ; Mon, 9 Jun 2025 04:32:42 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749443563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jv1VNdGF1SJexFFCRwCLNS0P5u+hO2+D7s4IndxHXuM=; b=vxh7lKcyer5JHpz5MnQkn8nMrsXVhvrCqQ4wL+nAlSxJLuvBsb5iAb7c+8fX4M064cSMJn h9SFpgOAqpDQ+ZXqWF9cUrAA2Th03sB+bhoM0uxphUwF6DNbawIF8ME9EBlRYFb1+VBOV/ 1s/n/Qqcy4Zn2vaV0AO+idcfAS8Wi0o= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749443563; a=rsa-sha256; cv=none; b=ebItD+0pSWgP61dAqJ6rXjtBkSag2dDynQPmcLBv8C3EEdAnirQJvGZhzfDbOqVKbCcHOo Jr9g6ELybW6S0pAxLzulGutoWp2Kda2PAeVqmub02Z0WO8bEPqXQ+JcJ44S/C5UGTczluj H296jGWUnk59tHB4eUSf145YT2hj8J4= X-AuditID: a67dfc5b-669ff7000002311f-8f-684663e4e1a1 From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Subject: [PATCH net-next 7/9] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Mon, 9 Jun 2025 13:32:23 +0900 Message-Id: <20250609043225.77229-8-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250609043225.77229-1-byungchul@sk.com> References: <20250609043225.77229-1-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGefe+57Ll4rSsjgZdRiEI2gWLPxFRRPUWUVEfIoNy6cGtptm8 NKXI0rK8FRVUa9akMlNzOs1pSeSSvFWK19lN8fZBUklN0kW1g0R9e3j+v+d5vvx5rLnC+POG 6DjJFK0zalkVUY345AYNhG/Xr7Y1zgWrvYiFwh9meNxbyYC1oALB5PRHDiZq61h4kDuFwdqc SuC7fQbD4Js+DnryhghUpzkx9F2tZyEr1YPhQmW+Aloqshm4OfMIgzO5l4O251YWvhT9ZmDI lUWgwfKEQE/2ZnhjWwhTTV8R1NqdCpjKzGHhRquNhf7UHgStr/sI3D2fjcD+0s2A54eV3byc lj/pVtAqy2eO2hzxtCw/kKa7WzF1FFxhqWP8Okc/dVaztP62h9CqygkFzUoZZem3wQ+Ejr3s YKm9vIPQt7Zajk44luwTQlUbIySjIUEyrdoUptKPO88rYrJV5pJiD5eMPvPpSMmLQoh433mP /NXvJws4WbNCgOh2T2NZ+wprxIm+Oi+j4rEwyoiDVo8iHfH8fCFGTHunkBkirBTb29IYWauF dWKWc5Sb7VwqFpa8wjKuFNaLve442dZ4EVd7Pp7F54kNdwaIjGDvrP2eRraxN5ny7C6WV0Uh hxdThl+j2Uo/sSbfTa4hwfJf3PIvbvkvbkO4AGkM0QlROoMxJFifGG0wB4efjHIg74Pknf15 uBKNtxxwIYFHWh912K1teg2jS4hNjHIhkcdaX7XQs1WvUUfoEpMk08mjpnijFOtCi3miXaRe O3U6QiNE6uKkE5IUI5n+XhW80j8Z3SjdW/7+nafx5/EQ40MavJcLUm5nzLbqVbt9XvjQp8N1 gSOhuw7m2torqvs3pJLSwi9dATssK3/FnNmys/NiV1Gmue3yns7u+29vNh0baj41mtFUc+lB 2UzkghU5GfyRuDG//oyuOb2HPp74RhqX96/IVCadQ0FlxRsq2pep59r3Yy2J1evWBGJTrO4P nGIdbhwDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA03Se0hTcRQHcH73d1+OBrdldTFCmkUgZQlZhyyRQrv4x+q/IIkcemmjTdc2 xQXia2SaWmlhzVkr05xKEyunUhLT1PXGaayHzuaDoFiZJuqCckjkf1/O+Zxz/jksln0jI1h1 plHUZyo1clpCShTxxTsn05NVu6tKEVgdrTS0LOTCvfFOCqzNHQjmFj8yMNs3QEP97XkM1jdm En45ljBM9fsZ8DVOk/C4xInBf2mQhgpzEENRZxMBvXVuCt52VFJwdakBg7NgnAFPt5WGsdY/ FEy7KkhwW+wk+CoTod+2AeZffEPQ53ASMF9eR0P1kI2GCbMPwVCvn4TawkoEjh4vBcEFK50o Fx7a3xNCl2WUEWzt2cKDpmihzDuEhfbmUlpo/1nFCJ/ePaaFwetBUujqnCWEiuIALcxMfSCF 7z0jtFD/5QchOB6OkMJLWx9zbO0JyYEMUaPOEfW7EtIkqp/OQkJXKcltux9kCtAoW4bCWJ7b w7+ea2ZCmea2817vIg7lcC6Wn/UPkGVIwmIuQPFT1iBRhlh2HafjS14RIUNy2/hhTwkVylIu jq9wBpiVnZF8S9tTHOJh3F5+3GsMlWXLxDXchFf4Wt59Y5IMEbx81nFTFirj5cniR7X4MpJa VinLf2VZpWwIN6NwdWaOVqnWxMUYzqhMmercmPQsbTta/oHGvN9XOtGc54gLcSySr5Gm1SSp ZJQyx2DSuhDPYnm4lPMdVsmkGUrTOVGfdUqfrRENLrSJJeUbpSnHxTQZd1ppFM+Iok7U/+sS bFhEARr8rKHajFPl9vMs52Gepfrc6+92mU1VyVtORm6WLETVHLugSTTRnuiWFFSdMFPNPlpo 0rpKz87UHhSL8u6cbKiD/h/xin2K0qPa9PoorQ7Nu2/lZ2jzklJb7dfM0d3EweD+LPbrE+WO sQj/UmAiPF+R5rW/ed7TUb314qGXctKgUsZGY71B+RdVujwW/wIAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E66C280005 X-Stat-Signature: w946cqjaa6kop4hp98frkpp66mjqg5xm X-Rspam-User: X-HE-Tag: 1749443562-923541 X-HE-Meta: U2FsdGVkX198GoFn99DHqvJc7Lknm3eiotCbq8sD/ibWzww1l5zbrDV4mnGHql38Ta9CIH1t/vuog4Dv2uaYjJNoBPvQ17K1L3FsgspxkHrk44JAj4jJA4IPR3SIG7vHjLQf37KN2z6i6lhiHDVVeB3EIwxJTVvVhH4UNb9diX5USnZ/emCc/20T02fOPs5aPaLbOA8y81/L0Ar+wRuczFcjsja/UFKeaToJN3DdjO/RaotkgDxPGbRRM5DqGsHHjVIm86pek4ETRDL+vMep3lrH4B+SsJX1pM+Gw/XvOuezf465+LMrTQOCZdP7ZNsZCXaQnXX6LfORBNMcBAohZOLCIEVe9dX7f4K+E9pfOqcMoZ7T4scYTwvkXiaRGDVMm4L8X2HFXOUSxsPo2+6+ObzeZIPjRdV3ejTG6N4YOtLtrT9Ynv3Icm/BMrdFidccUNjLCMdFEdJRJkS4J3rpZKUSldp8aPNl5Tz+xWtNL3OaAjYBwRfyRp7LuoQibQhvX1nN4CywG6AYuIgBoHllDVF4BioxEWQAQcG8z/qU+jkNdRlSw5ln13uzaaDZoHCzlWA/NANbia5M2t/f+/hpxiazs96zsKpdT+eNHhDzXWNude72qgPeCIjYV84poOVWwocdwW8sX4EZLD+o+YNauB++p5AiMxCXUDIUC58+TmOTDMEYK5U441+qaxXwfqxvvV7eii8wrtGbS9h7MVJn93S8sIOnhi/KqDDHdz3Mp4TuaDuztGiM3ZQ+duWvzcKp7hWgfLx35rmO7Ko/SIvgBnd0g/ImJWoJ5IHntA2wyVpDnvh2dGRxj6fhtHy6X3Ki2/lwI9VsCNS7+XkofMRK93A/mcsM+FTUBT7zTp4oor8BpfONYdjRm9rhAgnCpOrgNpJxA1t6ozao9RtnH4tcn7RM4bTXAIs9Yo5ftdECXwzbfZssl3MmRWVj3dpFsCH0t0dRwNfEWoGwvrqeJmM FmbGzn+L Mh5YMU+zqqts67Zob8uYoaqLnbGS9+mXFk1UvAl3lIRiBC7XFrwX/pZl2DgWmrA89hykFykbEhXvpmyyWtDVFEN0TqHDse8i67q8FbYJAWDcg1Q+oHk7nq9S6kL/gjQIgRyqsqZT2ua25Nb6eS7VvEygLuh4UaxLiti59aXRqoLCwe6rb7NBriL4yFHMd0ZK5VeUhnIBBAOOact4h4gT1xM94FG6j1KIopMjl7MrgHLaC2fqqVv0C6B02vnGq3URbsKOz+deHuwYH3XLdhQ+KmEnJJj2T+9IxEJuKc1NcVKl5VS+bHrbINL1q2lkDg8XPg4aNhZ9pnnqSEQE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry Reviewed-by: Ilias Apalodimas Reviewed-by: Toke Høiland-Jørgensen Reviewed-by: Pavel Begunkov --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 93f2c31baf9b..387913b6c8bf 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -437,12 +437,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1