From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FA8C61CE7 for ; Sat, 7 Jun 2025 22:30:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 574A26B0088; Sat, 7 Jun 2025 18:30:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54C0B6B0089; Sat, 7 Jun 2025 18:30:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 462FB6B008A; Sat, 7 Jun 2025 18:30:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 21F406B0088 for ; Sat, 7 Jun 2025 18:30:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B6A8E5708E for ; Sat, 7 Jun 2025 22:30:48 +0000 (UTC) X-FDA: 83530050576.28.B6DC892 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 019A0180003 for ; Sat, 7 Jun 2025 22:30:46 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="EUf/s7bN"; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749335447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+r7csaANowaC7xOdgPeDbbd+i40Df8JF1gIW3XemZQw=; b=LdVLE91hec0stCbicXHz14EdofwwTME7IGHnDkYXdIEQftf61dBTY4lU8VrONDMEL6EU6e h/u7yRtmiCpR+eWJadW8ErdDT21tYJN0VwpqMge8nkG61hr3jyWuT4iyokCHqfqkmT51lK fq58spVHG7enmYhpVIoERzexhYL6fEs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="EUf/s7bN"; spf=pass (imf16.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749335447; a=rsa-sha256; cv=none; b=8Wugxe0UDaH94irjoVYThUzC1dbMata7IPPNMx66CYQOi+unLhtfaxK4L4YBfS2EPAMg0Y KM2tt3plqPocpdBrbrJsFet7x+5Ta2HI165X82ISV3qC6IJlYzYxSvwwv5x7MgihibfAuW OcQyCTw+4O/9/UShOYaMY1xM12xkwAs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 109EE5C5AB7; Sat, 7 Jun 2025 22:28:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1917AC4CEE4; Sat, 7 Jun 2025 22:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749335445; bh=qcloExUfsY7aY8d5UHyxw1OU1O8AuVB0ZXCQRZyssQE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EUf/s7bN1tgf8SfUZhdpQST6yBiYjIi1298ew3t0gh69xXK/nBsQbzDQ9z5IiSV3x R35icygV7p1MY37ezpLgm+T0hJbgca1NDd5BF8ar/1s7/NTnGNTqeHHPYTJ+/Y2M0m KpVza48mdN3dG5/Q+rsISkM0lVvbZgjaWuRj80nw= Date: Sat, 7 Jun 2025 15:30:44 -0700 From: Andrew Morton To: Joshua Hahn Cc: kernel test robot , Oscar Salvador , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Jonathan Cameron , Harry Yoo , Vlastimil Babka Subject: Re: [akpm-mm:mm-new 61/87] drivers/cxl/core/region.c:2437:22: error: invalid use of undefined type 'struct node_notify' Message-Id: <20250607153044.679f7bf380bf1d0d1a373c38@linux-foundation.org> In-Reply-To: <20250606192345.3440658-1-joshua.hahnjy@gmail.com> References: <202506070030.otNokpsc-lkp@intel.com> <20250606192345.3440658-1-joshua.hahnjy@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 019A0180003 X-Stat-Signature: ftg9npq8gxcxcc4iko3q17iiy9gu4i8x X-Rspam-User: X-HE-Tag: 1749335446-727079 X-HE-Meta: U2FsdGVkX1/2T+j/fZPCsz5UpVDM8oiTyytZNr3n9cW4e8n9zxRdIngVutwx4xPIvz+UA0SUVe1/YxzhrEELakD2KyOwMYBpOVGENtHdh5zRWrrVoxgr8i7AVeH0bRs9TI6LDAwTYsw97uCkyuSQr0UAGkMOqTeZLTQo0lG+Qj7ADdo7Ji9RdF0YT1eirl+DTmAe7wkl2QELlyydoscvYU7a6yXPEtdScKPsmyxs6S1qb18422aCUVbS/8yH5Y7trBXjRdQoTDUkpeFk+hlk5IpNIU9TeBHox9cavAC0GxbpFLe28ejVJcWudMGobwN2L/QldLkHDMAzaAeqQqAKyXBef7cXe1K52sZTmMcN9bmxqF48+fJxis+lQWt57Q2rtNJTHtOXVR0FfY5sVtrkwAfxlx6go5yz9xFMjVoFUBLF7dtX4IEOSzGEJ5gsddKt/x+dT9evk/hawC/QNztICn8/a5e8Z6qkNNtbaEnsWUyjJVIQuqMbAUJp6jTS+Q7iUH0TiYi9dqLjAjPfT4Y3+x6AeUDAUfRBTxZ/wSFfpZkDpzAOpEqQfFQzYQzhLcckx34pZOqS+HUPcU2ZDZSACRt51WVVeABCUKhu3pxjJtifNK9iKj0TY6oq0/YIxJMU83pV13z9LmgyYt0PlB4p7Q9ebwrNSYistMT/h6rZTD14vz+20P0ue2tdbhOs3cCsQ6ajOty6Ywfl7EGo6rDmvjcJ62WKCrop16lOxm7rovDgjT25z+5engjhg3CehJbaJ9z8yWKF9M+WvqloX2e/AaVFbWeJ0Fg1Y+gVg+EVOl9WBd9zIfh9tHEIaUlpT3UF6oQVX0q4Ag/cDEyflHCSc9UfU/HT0GovVQFqjTGuivaG85U5ULpLJOYuq4q2ZovG7LGSnmJx4tWxA/azofFpbkw0ngPGxGmS9P8mwCbiqrRLcHhyzkuqh8do/s/AxkHFP8fj4tFdLGxf3Yp+AjZ qU8jEwRG auJLKGeYJXSDtR4F4nAfKYxSBfaIZa57AJP1XYp3FQ0SM4u+zhE/wfxOvyL3jwmR/tPP3nYIgHmDJYCVL0jlgTyt4GqqkiVmnCrWp7kJ6Zwr9d6C+PVSQLs6T0teX0EGyjnlOanirCySkvQxo1hueOr+TcvllikXdWA5AYuiLHB0L5ex2z5oTMQ4C9qjYsEk74TKrYV6BZT7GFn870iLpiFnnHIJkmsBYr11isMQU20At9NRm/t1eAPuG3ng2KMnDJBG8lNYNUbyhLkWPWthWIsg8bPQJmNjAepUpLxJ6nl7IxPtZKa3Edm4Ddq2CC9kq9oKRJ4tHwPuSH7QsSzgvm1rTJBo9dY6lreBJIw07Fn0ucHKdtMv8hCsUScWRjkMV4tlq/jLPpXanwhaFR5nvvAmhnmuNhQXtWBSo2LUJeCfj4UQBEowZIv2Eu/+Gnf53ulRdYfiC+u7dXYBXhc82RCaBxTA35w64bs+4WAk/Ew79jxsl0BA9CZ7Ipw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 12:23:45 -0700 Joshua Hahn wrote: > On Sat, 7 Jun 2025 00:19:17 +0800 kernel test robot wrote: > > > Hi Oscar, > > > > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > > head: b9f05ab60cb240a64e898221de50a037553840c7 > > commit: 7bd79eaa2076cde601d828532a09ea50e20a976f [61/87] drivers,cxl: use node-notifier instead of memory-notifier > > config: loongarch-randconfig-001-20250606 (https://download.01.org/0day-ci/archive/20250607/202506070030.otNokpsc-lkp@intel.com/config) > > compiler: loongarch64-linux-gcc (GCC) 15.1.0 > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250607/202506070030.otNokpsc-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202506070030.otNokpsc-lkp@intel.com/ > > > > All errors (new ones prefixed by >>): > > > > drivers/cxl/core/region.c: In function 'cxl_region_perf_attrs_callback': > > >> drivers/cxl/core/region.c:2437:22: error: invalid use of undefined type 'struct node_notify' > > 2437 | int nid = mnb->nid; > > | ^~ > > drivers/cxl/core/region.c:2440:46: error: 'NODE_ADDED_FIRST_MEMORY' undeclared (first use in this function) > > 2440 | if (nid == NUMA_NO_NODE || action != NODE_ADDED_FIRST_MEMORY) > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > drivers/cxl/core/region.c:2440:46: note: each undeclared identifier is reported only once for each function it appears in > > drivers/cxl/core/region.c: In function 'shutdown_notifiers': > > drivers/cxl/core/region.c:3487:9: error: implicit declaration of function 'unregister_node_notifier'; did you mean 'unregister_module_notifier'? [-Wimplicit-function-declaration] > > 3487 | unregister_node_notifier(&cxlr->node_notifier); > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > | unregister_module_notifier > > drivers/cxl/core/region.c: In function 'cxl_region_probe': > > drivers/cxl/core/region.c:3528:9: error: implicit declaration of function 'register_node_notifier'; did you mean 'register_module_notifier'? [-Wimplicit-function-declaration] > > 3528 | register_node_notifier(&cxlr->node_notifier); > > | ^~~~~~~~~~~~~~~~~~~~~~ > > | register_module_notifier > > >From what I can see, it seems like struct node_notify is conditionally > defined under #ifdef CONFIG_MEMORY_HOTPLUG, but the callsite unconditionally > declares struct node_notify *mnb = arg. Yup. Also, - struct memory_notify *mnb = arg; + struct node_notify *mnb = arg; `mnb' is no longer an appropriate identifier! Maybe nnb?