From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299DBC5B543 for ; Sat, 7 Jun 2025 10:30:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 737E06B0088; Sat, 7 Jun 2025 06:30:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E8D56B0089; Sat, 7 Jun 2025 06:30:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FE256B008A; Sat, 7 Jun 2025 06:30:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 41A496B0088 for ; Sat, 7 Jun 2025 06:30:25 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B6EE61A1D4A for ; Sat, 7 Jun 2025 10:30:24 +0000 (UTC) X-FDA: 83528235168.11.3AE85EE Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf17.hostedemail.com (Postfix) with ESMTP id B3C4940010 for ; Sat, 7 Jun 2025 10:30:22 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LF6Qqkoi; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749292222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IE7X6x8OHAkTg697FSnh0gpU0EcjCgRFSk8bs9ZLu1g=; b=oUzg0NprYbBhmNCXpHBB6LwWYvIjz48k746ie+NbkFFd/Zje8DJYU2S3jhHh1B062692Qg IJp+gb8gXpMeWYft1iaErAnXpsCHTgq4RBmILzgECq+qvdyuXX5pGp8sIhsDiw3V9W0DqT ziBke3PC5pZAzpaVZGMMFeT0C2lhsZ4= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LF6Qqkoi; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749292222; a=rsa-sha256; cv=none; b=Avfjlnl6Xh9wZc5RA9nUEFu/pFIQ/KaFfCfy2YEmWM0y8JFkspUgxSMaW9g2/SykFv9VG/ QcZtlBpTejz35ZGusz32AYbGT3OpR1gJS6r5jQ0cl5KhM9rw35+BmQn9VXygrYpi72bxtx /lKnYD1mgiGdIrRdKkuKpbNt5U7t0uI= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-7426c44e014so2507053b3a.3 for ; Sat, 07 Jun 2025 03:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749292221; x=1749897021; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IE7X6x8OHAkTg697FSnh0gpU0EcjCgRFSk8bs9ZLu1g=; b=LF6Qqkoi6wXn20FTVJROxzJd92sDi3zXBuX8eIL6f1o8hWD3nNjDgWqEaCGTEnAx3O AEKqZe06XSNQoU5ixyerzd6usUgmEputJAKCTBjKzCjrHtrMnEgsFRSbtSQdVPsr9TYF xyLI8ROeX6mypEX96JaP7I8awJsu6rCiJD6diXsG2sW/Oqwclxu36WCmzx/TSyRp7w63 9m0emp/JrARKHsm7wVpqdd+Ij5A9KWataaiW1yz4otvkuHAurX3G+JX4QycCIpahMFMR 1zPuvWBGP3RtTswmrks908zHzb6nzc687gKTvwj/ouBg8RBvGKyeBnllOz47bTKrgM3d PJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749292221; x=1749897021; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IE7X6x8OHAkTg697FSnh0gpU0EcjCgRFSk8bs9ZLu1g=; b=g9hF0/FYHXsmnTpH2WT1WkrHg57n7Cb0pk+8ET56i8SQXGbd0L4F+ilwVnpe7+0kRh wXTYkEGFre28x9+8nIEXyplmcDecIjF4+F5TRtQ7eTAMY5Wa6cyGczbD879K+yWLvTZP GIVVUaHFLFv25VVqNiN1f6P1H/RSzfDK4agFdPKKy6vPG2owiZ2DSDS2nDNmzfURIk2S e7uMNMAoNBGFcXQ52bNU/E8ibNm9SnraSCNGFiQ7RgsoFXQHkfd4nEyXznEiUr3cr26Y lwIeqhdRgBISErNBk5+X5RJvJt1nsLuWjxD2nyPhU/frfnisXD/PA72B+gZpPQS038ls qcZw== X-Forwarded-Encrypted: i=1; AJvYcCXBGdqyc/ctiPFozOcvq33mBAq7ncYw9NDfQ7OC0VrbR0ZDQm8CeBWNkpe/WKPztdEgv2n3WQPJ5g==@kvack.org X-Gm-Message-State: AOJu0YxVNuNrKq0ppL6Qk4rr0wgIEtKHAA1Y/HZlaSJoYJspmVNPNXe6 LE05dxrH53wAkrVlkoXLXaNMK5lZV72LmZv8tP38QEhCWuGo7nJzbcCX X-Gm-Gg: ASbGnct7uY6hTNy7AF5rUSNoZ9S2767Syuaww/WesepIBBu+DvmX1IbQgR6F8dE2dVy xHjKfQur6qzpC8Mh3ztkq/DjwQRsz1I5Y8UNLRgomkCPTJzvGNOTU2AbycaZr+2tdctreixLUxr DilzZBnCVOSZYSwQguF2mEDRxUNDZpyMLWiCrnJCbbpuSRgvLN2cuuhzV54nkkCqLmqKaL/5zJc Jz9qg3IqmAKkXvCVW8Y6k7Cbad+LLze0yMXIdpctiSTSyXuODvHrYTrbgsYQA6ilq/lsa2L+nX/ 3oifMjNtSbRI0Ul+j9VStHhu3MDXDtTRIwjHK3ItGh++wC9Y3woyXAwKdCn5gtXcfQG1 X-Google-Smtp-Source: AGHT+IHS4E582z/SnH7fI8JfMS6qlHo/a7BVD3y+bqEg+XzD7UN+PrUslIyVIHHn5dbKrBsLZbhzVw== X-Received: by 2002:a05:6a00:9a4:b0:736:a6e0:e66d with SMTP id d2e1a72fcca58-74827e7ea01mr8869585b3a.6.1749292221553; Sat, 07 Jun 2025 03:30:21 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.145.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482b0836bdsm2598807b3a.93.2025.06.07.03.30.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 07 Jun 2025 03:30:21 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: lorenzo.stoakes@oracle.com Cc: 21cnbao@gmail.com, Liam.Howlett@oracle.com, akpm@linux-foundation.org, david@redhat.com, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lokeshgidra@google.com, surenb@google.com, v-songbaohua@oppo.com, vbabka@suse.cz, zhengqi.arch@bytedance.com, zhengtangquan@oppo.com Subject: Re: [PATCH v3] mm: use per_vma lock for MADV_DONTNEED Date: Sat, 7 Jun 2025 22:30:12 +1200 Message-Id: <20250607103012.25332-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <5fc1de4d-7c2d-4f5f-9fb2-65bef5b6931b@lucifer.local> References: <5fc1de4d-7c2d-4f5f-9fb2-65bef5b6931b@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B3C4940010 X-Stat-Signature: xxtufeh4ypdumjc3n313m3epw6yo7jfs X-Rspam-User: X-HE-Tag: 1749292222-262030 X-HE-Meta: U2FsdGVkX19M88xWvJOhpIzjQU2oNH6WkUh/QmMtiNi++ooejNOJyPo6CzMo+/AUe6gyn8MjLh13VAbtD9ydJaBEmVKCRYpDufpSHxhfkLb3Dt/JHvdP256JmmsBf6ALDsKT+t8TWyxG0xSG+WwYPDXO+Yb0wXNqq8aT1I54/zC4M1T4vdDpUmNUekb4IDUXhxKPZ4nj8E2TO97W//zTDx77Nh3KwSQ7rh3fYixBonJfMeLjlACobTm0hD6AkGzUz+5bj7iAjZUzHeFOzM2nUzif0F0h/j8J3GHNUTWzk7eHksKbacomDViqfrdoX9lnjU7UjTF0rFhGDSgRb78e8U3rjRBgxEmvjrIzwc299KUOVYdSoQf9qwujksKnhkCetsbpIu1xhvIykEkRY/H9oL0fBDG44bY/l/kgM/bWoC7tGn5S3RW1sLS0kPZr1xXhZ5T0GcNRSFcmDaWF36cCr2+4WVV2vsuQ+qjVDfMaIN+3MxEobR/nCfIlpcnhL8iEVEiktVqQzgrieorSUnKXXPI+pvcs2q2ifromLGJZ3IzcEulEj89uluizgnpGuSXW+pkjtLh0DDddNvri3PqovZ7hpK/fEDD7a0+Fhjqwby4ZxHrx78Gjl5qJAhFydKlk5O2sbm43C/Fv+JfdP7qfpe7FWwi1MqGYKR9Qq90qQG/Nkn9hR1vGnEYINyoJYLzmDs/6PBDrCeEtwyx8BCv+CMgb+hGjhjs2h+X0Fzz5F5jCsGI2ehBLSFb6vz5YMfDwxlxlJPHqXgAEwZSs31aUlqEMcnmuvn7bcHPfYFJNtAKC3BhzTGhvd4a5sINcKy77vOxonwOicm3iAVDsdZOJhFNiE/+Gukt/rjMn7NAw5BhwET9zDjO7tQRXNhede/FFUNBkGzyC7/q9f+F9QupmTu1HY1I5mnC598avCAAoB+pDr8Iln0pS3InfG8+qlDZua9s+f2iCnwvvFxSdPia IImW2rJS YmVqI5V9WZdT6WhDm6TIeVaQCyy4yMtS2feA4snb2FTj1FQrPCXVjH0PF5FbSmeFO89XPX7IXnLTW24cKGUvyLeqTe10JvBlxPJC8dd8eq2woe5+TdPLuuHAnd8g2A1vqUAKUceI79S5LZeRCpnMV1Z/AUm0MucsSkuKUs6ixz5cvsHPJD/pMsxDthUyjAceEU1RIHPw0HFp5MCGVljAMArv3jG+uitzF9nXihkhWjVIxDS8lKexjXBKdRvPPaqxyzO48BGqpAiiYIWk+otvofeKK7apUTaWO3IP2w2++sx/wxADZb6pZeOn3u0cqkg8+oWbsNHyBHHn2K2aKS6CsbLKgS0a9WIkUiYVXIFpxKLLjonvSsE+hl25BpVLIaNBAWlU/okhFU0BVfpfrdWSCchBLlcpWaV17ZN2rmE41KkZA5Kxii0u/VZYTdA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > Sort of a nice-to-have/thought but: > > Actually, when I proposed the refactor I wondered whether we'd use more state in > madv_behaviour here but turns out we don't so we may as well just switch back to > using int behavior here? > > If we do that then we can adjust process_madvise_remote_valid() with: > > static bool process_madvise_remote_valid(int behavior) > { > + /* Due to lack of address untag atomicity, we need mmap lock. */ > + VM_WARN_ON_ONCE(madvise_lock(behavior) != MADVISE_VMA_READ_LOCK); process_madvise_remote_valid() is called before vector_madvise(), so I'm not sure what this code is supposed to do. Are you trying to do something like: VM_WARN_ON_ONCE(get_lock_mode(behavior) == MADVISE_VMA_READ_LOCK); If so, that seems problematic — the same madvise operation might be allowed to use the per-VMA lock for local processes, but disallowed for remote ones. I suppose this will only start to make sense after we support per-VMA locking for remote madvise operations such as "case MADV_XXX": diff --git a/mm/madvise.c b/mm/madvise.c index 8382614b71d1..9815445284d5 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1641,7 +1641,8 @@ int madvise_set_anon_name(struct mm_struct *mm, unsigned long start, * take mmap_lock for writing. Others, which simply traverse vmas, need * to only take it for reading. */ -static enum madvise_lock_mode get_lock_mode(struct madvise_behavior *madv_behavior) +static enum madvise_lock_mode get_lock_mode(struct mm_struct *mm, + struct madvise_behavior *madv_behavior) { int behavior = madv_behavior->behavior; @@ -1659,6 +1660,9 @@ static enum madvise_lock_mode get_lock_mode(struct madvise_behavior *madv_behavi case MADV_COLLAPSE: case MADV_GUARD_INSTALL: case MADV_GUARD_REMOVE: ... + case MADV_XXX: + return current->mm == mm ? MADVISE_VMA_READ_LOCK : + MADVISE_MMAP_READ_LOCK; case MADV_DONTNEED: case MADV_DONTNEED_LOCKED: Thanks Barry