From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF102C61CE7 for ; Sat, 7 Jun 2025 09:33:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F310F6B0088; Sat, 7 Jun 2025 05:33:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE1CB6B0089; Sat, 7 Jun 2025 05:33:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD0946B008A; Sat, 7 Jun 2025 05:33:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BCE3B6B0088 for ; Sat, 7 Jun 2025 05:33:57 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D76C1161B27 for ; Sat, 7 Jun 2025 09:33:56 +0000 (UTC) X-FDA: 83528092872.24.CC08BDA Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf24.hostedemail.com (Postfix) with ESMTP id 0598D180008 for ; Sat, 7 Jun 2025 09:33:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FXIKYbuy; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749288835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zgdEJ/cU6wnqCBIWwveSAYSn7+5OkM6oE2wu1ZdN47M=; b=VYnbWgp5r0w5wEXknP2V018JMDeBvL6GTryAS3WJHNZ8oBnHgS3VqrrzqxeYStgoBDKOEw Okrmg5EAUvMbj4APnqhDUGPtISupwIs4cL0+w5/RP9VsuM92tE4dqLVfSU0cvz4kLTyNQR F6vQZ9s7kqUII9oSwR4iuLVPHRE668Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749288835; a=rsa-sha256; cv=none; b=DTAhBS26QhfRNIRMyTJEOfTu9Y+MI/x8qdtHGCf2MvT2yvOKrVwMIXHNEps96bM2q0/4MI WgbM78YciTyBXIkE7KrAgqelp1Bw0K2SrTv7pMfu2owcJ1P9I26aWuMvvfbrnCURhC0JrZ LExxD/aqV3IM3QZzZsZeUNAJFkkEL4c= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FXIKYbuy; spf=pass (imf24.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-747d59045a0so1982269b3a.1 for ; Sat, 07 Jun 2025 02:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749288834; x=1749893634; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zgdEJ/cU6wnqCBIWwveSAYSn7+5OkM6oE2wu1ZdN47M=; b=FXIKYbuyIzIma1XDBY1XWuqCkkoJxyqtkWv0aeUPcU66+M7t49Tf/AJoPgGx90g6k2 z3CQRflV5zvju4XZNwhCzp0wpKTB6onvtroVSrl/8xEl590hiEEOlkGTeEQwisPQqw+z OoNTZaadHy34e/9jfVAerCXK16XZkgqIJFcD0/r8hPJ0z4goJxhTNoCS5WZ5NcjCjqgS kFJbfH79QGFSdDLRQrLjdgtb0V51dTdVJPpfgTr1Ebm0BelvAogvpAmXUMrYqthWtqLB PlgPOBK2yyuNt7zbb+DyJhIyptkvzlDukJLUTWu/e9i7OUt+MW2VKTf89cANtwy2PoKH CrHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749288834; x=1749893634; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zgdEJ/cU6wnqCBIWwveSAYSn7+5OkM6oE2wu1ZdN47M=; b=vuSi6Fz4j9rmaUdi9yomU9TZGhDKn6WNSmtEZrjkXaJcEuHoOyz8lVApYiDD6R0NfH hjqCUk/wWDB8S6jwXxF3l6ye5R2WNY9Iik31GH8i62Zm8ABFztT6cP8aigfa8vM073Z7 Nm8e+sIsyAdHzGseIOovhodUxP6LyRS1TYXtCobSFmrNaTQ9G3+czekdbBk9inyAiPz0 6g9d9Ln+2XqzG++KF3yTZZJu8irYE75tqJ3tvR9xoSzwgoh2KVS89GTRahB6h7PBGYYk NmsKlZF8pTQQH5Zd8yuKiYuhcbPONWdaq2hMTZRVbO3P1LD5ZbDzjPvqTG1DVMnpLTKk 2ugA== X-Forwarded-Encrypted: i=1; AJvYcCVb9YcklOJy76YcUf41AShV0Bc9ljOg4FNrWkur/sNTOsMdVGvsJ0jb/mpSHyrquVJzVppLe0ghew==@kvack.org X-Gm-Message-State: AOJu0YxZAbV3XtLzXS84bR76PmLyY+Br91o/tnY2deD6UA8Y3lKh1buA wNsOd5n39q/CVJGxZM/TBQqd/wYePdm5qgRvgn+BWKkF9DiI48j/EE8y X-Gm-Gg: ASbGncsgu2j5O8Q9WdbwJjM+NQFa6olrrs9obSd2xTblO99/dkFFR4Yf0rTVD6EVxRh CUzSVjA1vxVISOdpq08cRwzp87GOl/P/8CSbblEyes6Xg+Q/8MZwaUP81Zv9c3ia6YKtzlUN54X eb4I6PRfwnJF0embi3t5xGtYnUcippm+UpjXINZnpnIDrJj0FK5GGsnMt7dYYitwKNGHFzzRwBu JQ0DTCEkoFfU7ak4drsKRG2re4mj5NK8JzMwfdnOwLlMFG5K3Yn914gIcFyc2rPg995Tzf/B0dF YIzjznZTq6iwPl21tlhzADGWrhYouQt1/VgfUdZ2PNYSOz0RnPjSBHlGk3E3ScVHmKnC X-Google-Smtp-Source: AGHT+IGUIlX0BLBrtpZ0sdzWykKmUsclqHT4YHF/03/LX41TjmfuFUCagyty3GHMnITyJWpy288DzA== X-Received: by 2002:a05:6a00:9145:b0:748:323f:ba21 with SMTP id d2e1a72fcca58-748323fbb7bmr4918326b3a.1.1749288833628; Sat, 07 Jun 2025 02:33:53 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.145.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482af7b09dsm2427850b3a.43.2025.06.07.02.33.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 07 Jun 2025 02:33:53 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: lorenzo.stoakes@oracle.com, akpm@linux-foundation.org Cc: 21cnbao@gmail.com, Liam.Howlett@oracle.com, david@redhat.com, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lokeshgidra@google.com, surenb@google.com, v-songbaohua@oppo.com, vbabka@suse.cz, zhengqi.arch@bytedance.com, zhengtangquan@oppo.com Subject: Re: [PATCH v3] mm: use per_vma lock for MADV_DONTNEED Date: Sat, 7 Jun 2025 21:33:44 +1200 Message-Id: <20250607093344.15699-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) In-Reply-To: <69846ab3-de03-48bc-acd7-60e8a458c263@lucifer.local> References: <69846ab3-de03-48bc-acd7-60e8a458c263@lucifer.local> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0598D180008 X-Stat-Signature: o85t8buaymxn7n5n78g9kunt6s4rxy7m X-Rspam-User: X-HE-Tag: 1749288834-507258 X-HE-Meta: U2FsdGVkX1/sJNVzQ1xbitqtMw4Ow/JiRnYIwKgHLEqnTEqaZX2Agz3w1GITx3cXRdErBKdAtQY2HOgaB9d8JIozLjLp6pOmYGpbnS6XzZb9qJgQ3mhJsC0f/4IYv7Ip1cOUZKTsTGmtSEfAN4cl8lB4U0Kma5TIF1tp6VeYtlR37+XSoCP4AGpVclPZNbhC7M0aWVqexysvz4BKetd24FsUBcLuzK+Y36Yk5Ps5Wz/c+vUvwaRzpBtlyPnG0UKF3GjplnWMplFVco/0WZsDTdlhFBIOC9TFUb1oOp+NlJA0v7YHZnPpmDwroOseZZjsXWUHU0Pj3Loz7O9SVylYqr4XEXqVpZquLm5KvohucPLO0u4D0+woLQ4CneWJ2O5BBlhJMz7U6uoK4H1BoMz2czuvfILE98Nof28Y6pOQD1yAvekOL3iX9L8MjtvHuzaqL9+bLGUc5mLSdpSDGRbd78koIVL0wL/UrsdWM3HFUUp2VxxOTKuVfyYaEdDvHv/qy/YOjBaU6xvKv+g1c9hFFhJTMSLl0CXevGbIyTsSyZ3Kt7GTMQtsh0UZLI0/Zcuq88a98xqPkTBxhF9eZr4G731oGl6NAbj/zdRvELqh/H7NoJrmkrenqqAIJZIH+rJx+QLP0XttkzzCfga5nZUH6E8ut4hiXOsy8d04OamDzL8/UggB9M5OsRV7q6xbt0jbhKzg+6D2kgG4hSB6zHiHg2Pc0Z5w17u7pWbvYLG7UJWTiNCqJ+C3bIGVuFTnqjmaIXr//0qMKwq01FMkcoGxit/O+gxYYiskFmZJzosIJiHSBiOAr4aHNN3DQEo23Rt1nV4+dMluwEgbMJwF8wAFeyOCwA9VreAN/wpsIEUAKt8hpSDjqpDsEn9Pi84mfKfKghjVQXoIZW2uDJxYRr0neYwCR++gmlsC7e3Ve5/AkzmSWMkZiZMz+OOrm4gDloVIWSRqSgmU+Pie8Kq/OLt UqoiC6qd D/h+OyLvrP2TFCTGT2CTYQu2mQzhVWNuZQM90U/fW06Vy5HttXH1BZj7K6SaM2Tg28NkzhF/9XQFBUG6nTWKg5e+0IOhbvTfCdP9F2Ga5IYC7Pn8ObSRpy54lvx47Lvd1N06G4pc3LYCOtLbLUDgpKniEQlFPqTfNNdBkzGagr4vDOkRUBduxmXnkLzf9A8FoOvXoyafispO/PM/SNItsgAodk6luZzx6ZUpaT/BNHzAYTMDYdhEFeXwP8vbilxu91m6q4YTC+9axGbLwAY4ZqgkJfd6TlNAEqI0SBsCFRZY5AtF0ifAD8ljbYBzUglzn2NYMU1Ehjhix8M5C4KXOd8jzyxdbVQeB4LSQile7ZpREZs1/x7CDFeqk9dHnz23PC+ofoabduE5MI8YotQhEMNhvb3dcxo1ECiczBKbG2c7XT6Zb552XeFLL56D3WPSI1AlJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > > Whoops, I should add R-b only applies with the fix-patch proposed in [0]. > > [0]: https://lore.kernel.org/all/CAGsJ_4x1RbQ+GKKc1rrTaNA8Xd+W8K-Zu6-kwVYNKzB0OWiowQ@mail.gmail.com/ > > Barry - Probably worth respinning a v4 to pick that up to make things > clear, you can propagate my tag with that. Sure. It's a small, non-functional change: diff --git a/mm/madvise.c b/mm/madvise.c index a94e6a7ee387..8382614b71d1 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -1534,8 +1534,7 @@ int madvise_walk_vmas(struct mm_struct *mm, unsigned long start, if (madv_behavior && madv_behavior->lock_mode == MADVISE_VMA_READ_LOCK) { vma = try_vma_read_lock(mm, madv_behavior, start, end); if (vma) { - error = madvise_vma_behavior(vma, &prev, start, end, - madv_behavior); + error = visit(vma, &prev, start, end, arg); vma_end_read(vma); return error; } > > Cheers, Lorenzo Thanks Barry