From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84230C5B543 for ; Sat, 7 Jun 2025 07:09:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 042086B0088; Sat, 7 Jun 2025 03:09:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F35FC6B0089; Sat, 7 Jun 2025 03:09:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E248F6B008A; Sat, 7 Jun 2025 03:09:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C353A6B0088 for ; Sat, 7 Jun 2025 03:09:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6BD331218AE for ; Sat, 7 Jun 2025 07:09:27 +0000 (UTC) X-FDA: 83527728774.15.F818076 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) by imf09.hostedemail.com (Postfix) with ESMTP id E860014000C for ; Sat, 7 Jun 2025 07:09:24 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=DvzOTVF+; spf=pass (imf09.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.135.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749280165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=z/krpcC5+Q8k+YXt8s+yCpztxjJjdN6J7MqhMLLd7Ic=; b=6+Im9e/sE1CZZTNtw6YPigLDpwBmZZiotjCkFS4ekpZv2rPTTq+a4IYd/bP2U9U5jhMO38 BcL5M/qh6MJGGOb8IZMZbh8Rc9GtjnaWHHxnpc7YXr9Jh8uCceZ1Y/E0+1oQCwzdJbA5sU /ydyV11DcZDqWSeqX6ulFuqgprwIA6M= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=DvzOTVF+; spf=pass (imf09.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.135.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749280165; a=rsa-sha256; cv=none; b=EC2WAEavkfIZHnThNftoEPgr4C30GiuGuq4QFsMpSidOQSM8uaH4NOCEo9vgCJGh+l3fCi 7ELdEMco6N+Xg2/00TAJvMvfLQqW/J+qIDYxGIZ9BMhGRlO8lM7t7igkm04UEcxjLbgVa8 X5NHnB2Vb/0r8UJ81VAj8ezbz6pR5kw= Received: from pps.filterd (m0167068.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5576qlK1013789 for ; Sat, 7 Jun 2025 03:09:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : message-id : mime-version : subject : to; s=pps01; bh=z/krpcC5+Q8k+YXt8s+yCpztxjJjdN6J7MqhMLLd7Ic=; b=DvzOTVF+x70NlsJlBRdHh/QIJv8huEMULJpHKYe2rRiT3Avf5qSjXH7swZc153GqwnYx MWo6DqD0/L7XbsIedV/EKwh+3g6Gk8jcqySTPapkR7UvLqh5bQ1JSEeYBgF+GnU3cQ6o mJQxj6+EGeRZcKHLJd5ZoLCqda13vvoaSP8MLHT0Dbzz8ixK5Vi9+2noWzOQJXPwQbA0 fQZ2/M8ai9u/cWUFIFd9lHvzkc6rR0VYsJEuubM0pCiLu06Ywi101RIlun0CxjPlJ3kl GENI5tMBXROsa9wLdShPcG74zFT7XWLTAjp6Gqx7MseojQlhIDMaRpBUHLjiXl7uo80n fg== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 474fq104mg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 07 Jun 2025 03:09:23 -0400 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4a5882b7339so31805641cf.2 for ; Sat, 07 Jun 2025 00:09:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749280162; x=1749884962; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z/krpcC5+Q8k+YXt8s+yCpztxjJjdN6J7MqhMLLd7Ic=; b=qMAnUAT/0cZfI4k65Kxmdy8gbkbBJveCXysf+pcFwXH8Q2EGMNSoOTdaPsMiJPpTaT zMu+JzBlpzVRHrmHJ/fULk7sFBMniAqnz9bIRCaK24xdwZi1mW2BpbVtw+0WD/PJ/IX5 g7p36+hn0WqvRlj35I7XZ70v3TIdK+LtJEF6kJijUSS8vTUHTi6zqcP0Xto1gMDlR+hk BMrMtEOmJlR9mkzb/piIcxUbD6yiEpfqsgOrisDoyZzkAZpM455waMFwRgXlF3jJwzHq 8L4kKT6Zf9bgbAnXJwZOBc5O2yTWrxPpO7SoGZCRicZ7LXCpEAvh8ZqFXEq7QODz13Z+ eTpw== X-Gm-Message-State: AOJu0Yzg1Q2m7yhxYUR39gALMu84FUkSKtQPjnG0re4HEA74UI1MdHdE hrvJ1kPZEBuwQTSwHNTqU1pJrBVlvYV6wBZNjCoF/Mz8R0EJ4SsO6nGKLJoXzSuNDGO+07ZE2TW w1wa5+eD4HHUbhL1RO/8brsrwrLdA6D0noV6skpUlt5unkNxP X-Gm-Gg: ASbGncvgVOkq1an/4c4KGcybS1a23XevqqQ3Pz2kRkN5HtEqZ4erjGGYnpNHEF5vkce fK54qj9M8QOPo05jA5wNqibXVY7nQ721AubbdsrvRo5GG6u9aAT6VjKShPhqzRDwOC8ErQ2XAp4 Z0dD9HNN0C3HoHHjQCEwzqD98+R3zMDtMqLy976daUZvssoJO0gmi5hQnoAitjvLA9twwHRKiQW JUXHxYTlrh/ggDcRycwlGFI4UL7tJCVpGKa3DGfv3AlASVRSC8M/BX47W6FpmzO95LUwt+Vf+QR EztZwO3UOS1d9ZUUDqsKgWidSYlezzmQ6pVoJEFJw0XTnuD7Av9wEXtKxw== X-Received: by 2002:a05:622a:4a8f:b0:4a3:be83:d6b0 with SMTP id d75a77b69052e-4a5b9a052dfmr119047761cf.5.1749280162140; Sat, 07 Jun 2025 00:09:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEYVW7VoORAiaelziMMTIvFym2LcQn3e6X1vw+8iYUJxJbzbv/EROMD5hvUwruYlFDCX6whCw== X-Received: by 2002:a05:622a:4a8f:b0:4a3:be83:d6b0 with SMTP id d75a77b69052e-4a5b9a052dfmr119047411cf.5.1749280161721; Sat, 07 Jun 2025 00:09:21 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a619852c15sm27010011cf.51.2025.06.07.00.09.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Jun 2025 00:09:21 -0700 (PDT) From: Tal Zussman Date: Sat, 07 Jun 2025 03:09:19 -0400 Subject: [PATCH] mm/debug: Use BUILD_BUG_ON_INVALID() for VIRTUAL_BUG_ON() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250607-virtual_bug_on_invalid-v1-1-b792ac2b0920@columbia.edu> X-B4-Tracking: v=1; b=H4sIAJ7lQ2gC/x3MTQqAIBBA4avErBNUyn6uEiGaUw2EhZYE0d2Tl t/ivQciBsIIffFAwESRdp8hygKm1fgFGblskFzWXPGGJQrnZTZtr0XvXpNPZiPHWuFkZWWjBO8 gx0fAme5/PIzv+wGm2ZVEaAAAAA== X-Change-ID: 20250607-virtual_bug_on_invalid-81d24b276109 To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749280160; l=953; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=mhLto2qWPPXbTI4doOngzdXYLr3HbKBvzuotTiFjvmQ=; b=j6xJXhKdQFfB0/D/hkNsTvlbP86SnSCmk9xHT/sp56nQo6cFCo5wu57DaFCoUQ5A33nnd4fHl O1Eg+O+uFWSBrIIfM7VRJh9AeDXSw/u1lsqrnsBHxCoto9WHPXmJq5p X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-ORIG-GUID: K97AAeaFZOunK-sWZIbAvY0jGexsfwmq X-Proofpoint-GUID: K97AAeaFZOunK-sWZIbAvY0jGexsfwmq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA3MDA1MCBTYWx0ZWRfX68IM/eZ+Gcmq p18fnMJB6Y2iiMP+UZK2/JUquDijA/cmeNGEZar2B6eQMAJlP05bcc123LJFm2FfsQPwaxEYtGn nQMdArkQsR0qVqqM68IvZLrw3Nisic+aDuLwfAyEEA3r5yWM+RBHRsMZXUidFYgJOxerxj1und9 DzgpDEcqLZx5m1z2RihUtAbV0FhI1c3qvD/f3gy64UacT/yLetOBGJKUpLyW952cTjsE6SVdGNO vtYKq8w5pTMF5tS4tCwhZOheDAuSEKk9g2TebY3NscrlDsCrgQRFEq/HCS6n+t+RCixT/RIPjZF cRNGEql/rhtfIfA0til6IFI12F+/5u00gO2tHCdoXM6QOpbDcNw0C7e9K8MnLWX5qX4R/e7hznG c3IunMdP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-07_03,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=10 spamscore=0 mlxscore=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 mlxlogscore=726 impostorscore=0 clxscore=1015 lowpriorityscore=10 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506070050 X-Rspamd-Queue-Id: E860014000C X-Stat-Signature: nk4d191ajfda8qg66gfc9zaggfhmnehx X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749280164-920873 X-HE-Meta: U2FsdGVkX1/uctLE3NlgGFPp5jhkZopz1UhXdd+IIHo1WtpPjIc/NTUw8B3cfYautQAwfN46euurUGaHFKlaZ7QFMPeeN/azdVNE4UvJ+eCr6677Z5B3wT1/q3clFrBknj1ek51CKSGGqC8/1objIgAwBRy++7SJTIZjc/UXO2WAhtNPO5vEguLI6fJx2A/A8BKwqyVVsYoMV/qf5eSnEmobfZHqjegvNxdNXggH/6rPGgRqw2JD2aZCG8CrX8dYMUsCnGHdvbxWy564MgkaVvLG5UkeW2u0wnzMu1R6M68PcATRbLbaQOzRrI6djrdgcnKbMpC5NaUL/Y0qgoWlekUl9/mXgsTTZUqvhjPPwfqHKFYxB9oiMesRRggML06rHF92sRcEbBlkqBKgSElygY87MXW6/YMxBsW/oWyoBAPsLYusT+ad4YBovTeYQe4iw2WE4RK1/eD5hBDBkhh5/dmSXXXCFhaeMsbORl1i6+LVmRy9IDbrbdZvxEpvK/4RlWsopL7JpxfRiAED2ozPe7bpzrQqqJCtEMI5ItmaII5+x0fCV8KSiQvkpg/EAaeygbx/IpNyKwAhjjyfqSycPOiJ4RH2q7V1U3U/jFoRAekCZek1WKSXTofw3Aqn+1izKj8L/CQwc9gWBPMV2V+pN7PgAL1TVFjayOiCqucrXkOgPKPinsiQcTK1WxwHYYwsOkPPB2F+vM5pVa943sT7jJPsKoVbDAVR2E3+kRjMbISCTjPUW2+gpi4AhttWqmEuegpcN275NxyQDti7T7pMIxQFLBlzMfzsvzm43mAQFYfnnOqw+rwS+eV+GFXiRYGtkWN+2dIIeLDm8CvVf0+oZ6ZktPgGsNs3q8IRjxVErUFZO65trpqoBS1BUeznnEwVJhZ212ceoo8f9xAUZ8YpxfCUCcGMyBosUoca+JhY8MmHzAxXU0Hd2qlUeNdpeAKp/Oo7Gd1Isbe+MbTSHY8 8KzYMI1N Y6Mq3YARcZF5O4/dE7kv1AlUmLHkyfPUg25za/4urBPOzTp3sr6T05U3zb0+3LdPHKuSkAiXgMOoMkQcVPkYoZiCaNFWfsS5Lf+QPZjTTp1RwLdazlK8ytKk8mOLFwR69WTErrpArF8jGCmXuyOyOLiYyDtMTVWEmxB2tJ0o3aNTopb3oR95v41wjcJfZmRpphEFlJnstUWkdaJM4AJigu6S0O+qFzSmmQDJr+fcqy0N1YujKZHATLQwQs7n4R9IX6U58Q3nAvLkOw+p6KU4WVp4MUmPTuID7msVkDThOI9ncpWzRh4ZbDnwJzPdjIA6L+TbvNZ+EquYTMmtq7suZl2ok+C2wyaJV17HswZdGJLN9bPO0eMgeRAiua5iiGRnoRE8iVsxc4fFu4SQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This allows the compiler to validate the condition even with CONFIG_DEBUG_VIRTUAL disabled, and aligns VIRTUAL_BUG_ON() with the other macros in mmdebug.h. Signed-off-by: Tal Zussman --- include/linux/mmdebug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h index a0a3894900ed..012aef40e7a9 100644 --- a/include/linux/mmdebug.h +++ b/include/linux/mmdebug.h @@ -129,7 +129,7 @@ void vma_iter_dump_tree(const struct vma_iterator *vmi); #ifdef CONFIG_DEBUG_VIRTUAL #define VIRTUAL_BUG_ON(cond) BUG_ON(cond) #else -#define VIRTUAL_BUG_ON(cond) do { } while (0) +#define VIRTUAL_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond) #endif #ifdef CONFIG_DEBUG_VM_PGFLAGS --- base-commit: efe99fabeb11b030c89a7dc5a5e7a7558d0dc7ec change-id: 20250607-virtual_bug_on_invalid-81d24b276109 Best regards, -- Tal Zussman