From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0FC5C5B543 for ; Sat, 7 Jun 2025 06:40:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C4B56B0098; Sat, 7 Jun 2025 02:40:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 474396B0099; Sat, 7 Jun 2025 02:40:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38B646B009A; Sat, 7 Jun 2025 02:40:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1CF336B0098 for ; Sat, 7 Jun 2025 02:40:29 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 997AF1A02C3 for ; Sat, 7 Jun 2025 06:40:28 +0000 (UTC) X-FDA: 83527655736.17.8A3C673 Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) by imf13.hostedemail.com (Postfix) with ESMTP id 4BB862000A for ; Sat, 7 Jun 2025 06:40:26 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=UJ23Ly3P; spf=pass (imf13.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749278426; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NCb2N0Fk92a1P9JTghKE8MY8Out64G9+V7YULXAPf30=; b=nt3Q2v3HPrl4Rb++RacA27ATZu9UqtZQB/lPyTUmhL8c9qT/pBUp7GeCri9xEplEo7qmle apCZWZJ2pp210o7gPiKCiDDMAGUF+7B+lH6W9SogRS/+ItGv1crkgp7+tlOj9s26FwKCa8 yh9FV60sJo3Gb1KtEJnrKigY/MqSxDg= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=UJ23Ly3P; spf=pass (imf13.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749278426; a=rsa-sha256; cv=none; b=dasVdyKjgziefV8NElMAmz+bTLCSgsdq0kVGizMXvWdf25TgQ4tp4THXAyD+10hiwNs3Yw QGMl+OJD5W6hxJxJzcDSNiH82Z6dFj7nQznjVR0mBIZbhEEC3u0x3cpYuDwyeQCJFBb5+b UEGp1O4SrLD+6KhtWmbY0PdnzfdvI2I= Received: from pps.filterd (m0167075.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55760JIM027717 for ; Sat, 7 Jun 2025 02:40:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : in-reply-to : message-id : mime-version : references : subject : to; s=pps01; bh=NCb2N0Fk92a1P9JTghKE8MY8Out64G9+V7YULXAPf30=; b=UJ23Ly3PeQAsrR9GxRQF+LR37pMg61M2pNRwZFHWN2ngpt1OnwDq+m0fnF1OXyjanmOq h1MaijbAfqApYu09GD66kyIxBrhGJ9/oFh9b/kExIpb5sHJua9hJAdMrYhQwIyp+gANG mTns6/G3b+UGWuGsKmprp2PGpIsWro8+gySO/Oy/Ec1VWVMy5/NfnO+vqi+GD6kEfbbM o+WUot4Bd8ArzATXdFsSqn8mwtie2Hk17V5Gr/Up/CVEnrzP1sGIhNPvz4f6+JRZQS/8 3aw7a7cW68SLJ9jWBpeBOcZ5rb+677ic/l3sT1GnnI2Z96FJW2sRaDVJiGa2NVmHzG4M 3g== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 4743n0mb10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 07 Jun 2025 02:40:25 -0400 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-6c8f99fef10so2937847a12.3 for ; Fri, 06 Jun 2025 23:40:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749278424; x=1749883224; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NCb2N0Fk92a1P9JTghKE8MY8Out64G9+V7YULXAPf30=; b=LqvN6H3YU1HsbgD7/B1I3ikMCjdxhVTTmU3/o2Vjo4nHtw5o2WnQcs4uWDlzYrSpPG 2zZ043KdvV06Vqf3D9DVyxBAbAYtvZ1RB3ZOLzBpkhkvjwRqbiiQ/j4ssBGKF9lzkbha 01xVqwFeuj/0wImnZ6Egmpahtck/8dQwD5WOT+qI/61JZ0u2kgcKbPmFrjh2v+9U47aB DAHQxg8bZTjPHGjMtmcjUc5dtOP3OWmbbzizCe6h/6wjLpwvx5ev3umYLVinp0X94Iwk PedV2OCqXjD/ocujBrfBPotHWIl3Uqvd+bcd/p12mtLZqi8gGjVT0LXtqBxTpx8/J0u/ uClQ== X-Gm-Message-State: AOJu0YxyYT22UmfoiDpw9Hs4IhA3SFaMSVQahz4QrSeqTicoyNq80KsV x958AIetfhI7xOsA+6Tprcsh2s7yyx4CQ+/TkBr97+IXKovJZPoWKEFA2EDTSvYDmf1J17eP3Ie raOULZkn5Lxo2XUYbBbVX5lBGrrBb897t5QV9uxjj6/2IlsaxJ8vzVuRE X-Gm-Gg: ASbGncvQfmrG2Qsqg8PEP1hmgujlz3iAjh/7pkBOeYm5qNrZTlOPK9TkP4ArvQDrxb9 WgpLRVHIEqtSBkDHI4GwNnC3O4Q+VBkWKmAhyffHURRUhhQzF1AU1kbN7z/o1D46ZsrJYds/Eah MEnyPCJYtb+txaWiKek+Nz1Z9L/j51j8p3YF0Nso1Mpd8O3SWw7EGamTCHnO4KDvqaCOQtxU8Mj Ol7vjVQcNSJDNDu7bEDDWF8Wxd8zrYvbNrGgaCdGttwCaq+W+G3pERvged4HCMugWxoIg3kYNW4 SzWWrAS0lS7DPmTSm1KoLpguCOolWtulAHIyGnmQGHzjTM5I5eKT6lFne3vM2OraT8Lu X-Received: by 2002:a17:90b:58d0:b0:311:df4b:4b94 with SMTP id 98e67ed59e1d1-313472c4cf2mr10532428a91.4.1749278423960; Fri, 06 Jun 2025 23:40:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFY98CY2YVyggGLeAbDV8ar/PXW0sOfH78h7Uor9zXD3xjSJRiEh9rmijJ2dx5XASHXOijwJw== X-Received: by 2002:a05:620a:1921:b0:7d0:98a1:7aba with SMTP id af79cd13be357-7d22987fa6emr771839185a.17.1749278411587; Fri, 06 Jun 2025 23:40:11 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb09ac95e5sm24461256d6.43.2025.06.06.23.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 23:40:11 -0700 (PDT) From: Tal Zussman Date: Sat, 07 Jun 2025 02:40:03 -0400 Subject: [PATCH v2 4/4] userfaultfd: remove UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250607-uffd-fixes-v2-4-339dafe9a2fe@columbia.edu> References: <20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu> In-Reply-To: <20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu> To: Andrew Morton , Peter Xu , "Jason A. Donenfeld" , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749278406; l=1546; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=BCiqmyiBck+kr/OASD2ROBkgeX+5AW3Pps9lr6jrizo=; b=ejkjZoE1iwXmZVjGzc4EEQx+Dppi+NjcO9zdi6poqefulL2rmdjseAjaKNWamrHSbTvuzD+FU fLY2ZocKMooBdDYNZGuFJ7IfSw+VD6eiII8yG3hEK03A2qopBgdanbr X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA3MDA0NyBTYWx0ZWRfXz40nMQcGRI2R HY/eora0D0Sk3vRAnVuWhxpMDLRJUW2wBgXYclVp1urHtchfgfEM32RLW5omj1vShh3WMCcPUG/ MdF+KfQ7sNzqYCQ0GsZBLalrVf7FsUrCSyyDP4fe4KRbE5sx09S9a93bGXYRmQ4M50cmXS6L5gj p0o0+3xu/3AgbVfvhZ6Egd8xThC87lvvz4IYtvJ9610heYPTF1FaL4WZyBu5vJUP6WMO+ptm96P vpJlHU4GxXZV1rDD7loArVqpwIcb6d5mEwInfrdnsNpq1L8bXXsvbO2PEql29zBwgbhmnis/4he e5tN2BuzOVSQh1b42mnusJM3COdBwfU1ANdIY4lljVLyGFSjDrzHvGfKknRI2bd2m7ayrkwXny7 n0h25gdH X-Proofpoint-ORIG-GUID: OTaCuOxrTqgB3EJXsBEszq75tNjMC3D- X-Proofpoint-GUID: OTaCuOxrTqgB3EJXsBEszq75tNjMC3D- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-07_03,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=10 mlxscore=0 lowpriorityscore=10 mlxlogscore=499 spamscore=0 adultscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506070047 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4BB862000A X-Stat-Signature: az8a3wijj3616jktew4z98krsez9hapn X-Rspam-User: X-HE-Tag: 1749278426-556293 X-HE-Meta: U2FsdGVkX19pjWUq1QBNqjkaGIBxhyvr41LIqJl42U+sh3XqH5TTU1CJ7dB8z5OklrKWDWSl8AlbgS+YdQARwYhX+HA05po2KL1ZYgZ0GhOwRMitqQpUmtj9QPp2uJzACMIO2Pma2WOYjDCCP9XHOG0s5+ZFTyoUDr9KuPF2KHHY9C8JuBScOpCffGqDimETqTGzjXKMqA7pKaDvVl+LrCntYX93l8B4xh5bu6mRH9ov7biNWQuHEqrZVzL46gCe/XUWzzXJpPvE2pLpeuawh5ESsPUtuloFm28bCaXru75F38zuyYNRH7kkumxm87goaA3d+mSI+JBr8nV+bIS+FjJRgquLk41uYQ4wlpPNdFLgXRcCWJvs0keYsVu2L8dxsyMZtJ02k/WC/mJYA6R1VsYn2rOrjwtyVV4lFWMcmMm+2KQ4VwRbmFIomviWk2qt2GJKTCfsH1nB6xm79ZsgzhgaTmPwUF39ZAkuYxWyBzLTJSsLDFc8bc9Kous0mxCg9hokNV501oa4z+v3t79LkriaR61hXG2ZkVXkqwNE54T2WUVHc1oy48j21rpSZzd9vn2ejVH/oC4Qbfkg/kIJYAv3ZfAR/8AKyv0wwshT2gVfRVER7aotvaLZmXPXZpvqWpw8nK0PgXpJhDoXvtBKRjkP2+v1PrRvW6K5xhHFQ07cVWXicsHeiDCnFl2oqsj+5zuSe8S77Uo/5AFrWPnzPEU1AxI8W7x70x2REeBRQT8tX5z8XayFh7ZOUpILtg31hDtlBeWMz42PlordovC0uLxrikRj3ONTpxDpOiE6v862vzx9sBHgmBEDXdB7oPVhrqrCapvBcaxuNTR81/laOi3A3VoU32RFfe6MWb1r6+DbcDPuUr6LD23BIPxdrLdgi/V2UJgOVtFCbGMrup3rZmXvWofYdIGIeUMWIaJLqb/yTrLMNPAzSAK0OAKUJm/pMXpImVe/3dZ6JcyReGO gitMR0Z5 wbcKf13Rl1Xj9KSHO+4FXI0PqDP+RUzv2aMQr5UprEJ1OkxIBdYoEr7bpi+lkFVwnd/Mtjp/F6+tCXRD6iXQzjgCZJHhbUCVUr2ouVnQI06aO7YCp+E9iECu1oFrFS4/F0nrN8h0pK744Fn7OoCyaDaVAhZnKwKzV9e2zQWcAahi2r/igQddqoP/f3A6HUlbou86OKiup5WEAJuutvXs+awvJ1+Ry2lgGjrvxd/lFYIv+pEwM9LvgBHj/5EsNhnlTYFzNw0bkZ9PY0bGY5qizVsZvN947lccpkRFT/TLwYzG1qKmr8MHBMRirPFHU83BNRoJ8hWONccKdzHzXiOub+9gGnZfpQ7cIBRZPNibNKc6TjUoi4Olk1N1c80tmdWxa6fGMetJSYxU0z9GuXiQpcuT/lZlBPGz4/Hgl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET have been unused since they were added in commit 932b18e0aec6 ("userfaultfd: linux/userfaultfd_k.h"). Remove them and the associated BUILD_BUG_ON() checks. Acked-by: David Hildenbrand Acked-by: Peter Xu Signed-off-by: Tal Zussman --- fs/userfaultfd.c | 2 -- include/linux/userfaultfd_k.h | 4 ---- 2 files changed, 6 deletions(-) diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c index 10e8037f5216..ef054b3154b2 100644 --- a/fs/userfaultfd.c +++ b/fs/userfaultfd.c @@ -2118,8 +2118,6 @@ static int new_userfaultfd(int flags) /* Check the UFFD_* constants for consistency. */ BUILD_BUG_ON(UFFD_USER_MODE_ONLY & UFFD_SHARED_FCNTL_FLAGS); - BUILD_BUG_ON(UFFD_CLOEXEC != O_CLOEXEC); - BUILD_BUG_ON(UFFD_NONBLOCK != O_NONBLOCK); if (flags & ~(UFFD_SHARED_FCNTL_FLAGS | UFFD_USER_MODE_ONLY)) return -EINVAL; diff --git a/include/linux/userfaultfd_k.h b/include/linux/userfaultfd_k.h index f3b3d2c9dd5e..ccad58602846 100644 --- a/include/linux/userfaultfd_k.h +++ b/include/linux/userfaultfd_k.h @@ -30,11 +30,7 @@ * from userfaultfd, in order to leave a free define-space for * shared O_* flags. */ -#define UFFD_CLOEXEC O_CLOEXEC -#define UFFD_NONBLOCK O_NONBLOCK - #define UFFD_SHARED_FCNTL_FLAGS (O_CLOEXEC | O_NONBLOCK) -#define UFFD_FLAGS_SET (EFD_SHARED_FCNTL_FLAGS) /* * Start with fault_pending_wqh and fault_wqh so they're more likely -- 2.39.5