From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2772C5B543 for ; Sat, 7 Jun 2025 06:40:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38BD66B0088; Sat, 7 Jun 2025 02:40:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 362CC6B0089; Sat, 7 Jun 2025 02:40:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 251436B008A; Sat, 7 Jun 2025 02:40:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 09BF76B0088 for ; Sat, 7 Jun 2025 02:40:13 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 913D01A182B for ; Sat, 7 Jun 2025 06:40:12 +0000 (UTC) X-FDA: 83527655064.21.C1015CE Received: from mx0b-00364e01.pphosted.com (mx0b-00364e01.pphosted.com [148.163.139.74]) by imf20.hostedemail.com (Postfix) with ESMTP id 32B881C0007 for ; Sat, 7 Jun 2025 06:40:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=dSyraRB2; spf=pass (imf20.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749278410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=D8SoV7GNRZ/POy1AfaBjZVHTioJpzoc5dpPSb0goGb4=; b=BBvUCXL3McIhPBPj0HhDucMErPFSDHUJigMDzfXbhRt3APE4ZmNDkc+Cgxq+K/elTg+s58 M4hmNMNdpfXmtT0KFZeByQQpuHO4sVAzA90UtZHqkbRGwc+XnIbSzOaogTWzdH4smmOcvH AWzsDbpDTR71TJOVNMHW42kUnn6Jlps= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=columbia.edu header.s=pps01 header.b=dSyraRB2; spf=pass (imf20.hostedemail.com: domain of tz2294@columbia.edu designates 148.163.139.74 as permitted sender) smtp.mailfrom=tz2294@columbia.edu; dmarc=pass (policy=none) header.from=columbia.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749278410; a=rsa-sha256; cv=none; b=E0a2h1lUhO2BhRAyGM7wZJGvgcT7cE9vfnXSPZ4RSmFSZ8ujJT9+gFA3BEG+lDEpWRrN02 o0puXduiqpPtWLU0aAorV9AMcrlPlE/ayp6kvAinnlllSmlHwUokX4t2JZYZEKywvkOBgK Ow/0bqz26W51YOrJvaXRzVI9aF43sno= Received: from pps.filterd (m0167076.ppops.net [127.0.0.1]) by mx0b-00364e01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5574a6JK010432 for ; Sat, 7 Jun 2025 02:40:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h=cc : content-transfer-encoding : content-type : date : from : message-id : mime-version : subject : to; s=pps01; bh=D8SoV7GNRZ/POy1AfaBjZVHTioJpzoc5dpPSb0goGb4=; b=dSyraRB2ONIpp28BYsxxClRORvQx3jgBC8loF446yrgl8ZPTLef3GCDyWjzjntSVPisj U6RTRNWkQp6iK1eqLiLdlD46lbSWmK988NNEJLavQRhZr4O54wyJsKmCKgsKLf06+1uY /YayqxjLKljrJb+JjMyJyINlg5f1DzZ6usELMFnTA9PerZQXyN7rlciJuuDSCDYPsrQ6 paQQtLwNLyidsW5TOMLosnX9Kqy+XJ3swTubzomLIBFOHjBem9EwaAbUbGjl7dK8PIRq HAgfyXWwgKy+7GGBnK+Z038qZptKty0UYRyRFTwhQDd72XAod2wGgSZr6rj30vUBdfqu UQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0b-00364e01.pphosted.com (PPS) with ESMTPS id 474ehw0885-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sat, 07 Jun 2025 02:40:08 -0400 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d0981315c8so286359785a.0 for ; Fri, 06 Jun 2025 23:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749278408; x=1749883208; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D8SoV7GNRZ/POy1AfaBjZVHTioJpzoc5dpPSb0goGb4=; b=aiLdpH/wjZcrKhHIKV+QSV7RTOFyFZxWJxuwwokH4hHUXqOrl56t/tHrFr/dQU01Jg OMlF05upUkG/oHlQqAaMLnrLrt37JWsKOfB7w+NQFyPIP3Le5NKKSVrXUSwcYevKttGE Fbz+8hD8o6UsWPKvx1ksI+q9X9cchPljHaHwTmTqcHHRBk3ITSWDrjenwHh1gbpu0Rdy nyxNdQsxnClbvILvZNZe5fwWC5QtnJy6hb+hpFDCfm59xZ+ZZT9Z/TC/DLQjDfNkh+Qi R2TF5HCGslKL7xew/MJ0/0Vvj8vKqVIsUYzoUcOvefNbNFnaGZwRuIoBFsHRA9XL3ux1 PoFw== X-Gm-Message-State: AOJu0YwnCuj++WMMPgvpZo7ocvEGELw8+Zc338/zg8ImYD61EpgqpBcd +Lxg4aDhde4Rly1HKRBHnHeaJSeucOs3MDj67yg1c/19x0BosRtlQcEv+JX+xYvOwB0Prqz9/0w YoGWmWphGFaQUz6Steg37LpETdDTRMjsbRCl9CocumUrriIVf X-Gm-Gg: ASbGnct9N/mwX8D9kEalXlxAEh7OPn+/JCdAbquBirbCLZHRR085p8gJYnEoqBI2jO4 jNqPSEQ0TzNPKoPiA2wcf0BlbgMLlpOp/O5EWX1cPokyJL8ID+a3UA0Tf1gXqBB90X5rkAozE8Y 2fNlSoQhNVmZ5lJd0CdY3r1sFPFAPozdQD/pkAH2UapISZVDRfHJw2xbHPKPGolsLvHuKEpYw85 ioIlLHEHktlAfAnyVK3QukkSWGlUPlIyDI49UXZX8+GknFq3YAHgSA8K44cwnznMk60zNJUYbm8 dPsjFa1D/PPdBKgShQV7sWbGF51TkFEPkNvoyCSp4V0s9e0hh3MSezIryj+2zLOA9h8W X-Received: by 2002:a05:620a:1720:b0:7d0:95f6:44a with SMTP id af79cd13be357-7d2299b1db6mr941290585a.40.1749278407953; Fri, 06 Jun 2025 23:40:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGvruxEqfqrfa2x24Cr04nM5CvxBokXk40odRYVazuqhuEJPnDjkZTGkboqou31Aw/jxrNuLQ== X-Received: by 2002:a05:620a:1720:b0:7d0:95f6:44a with SMTP id af79cd13be357-7d2299b1db6mr941288085a.40.1749278407558; Fri, 06 Jun 2025 23:40:07 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fb09ac95e5sm24461256d6.43.2025.06.06.23.40.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 23:40:07 -0700 (PDT) From: Tal Zussman Subject: [PATCH v2 0/4] mm: userfaultfd: assorted fixes and cleanups Date: Sat, 07 Jun 2025 02:39:59 -0400 Message-Id: <20250607-uffd-fixes-v2-0-339dafe9a2fe@columbia.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAL/eQ2gC/02MTQ7CIBBGr9LMWgwwhaor72G6aGGwk2hrwBJN0 7uLdePyfT9vgUSRKcGpWiBS5sTTWEDvKnBDN15JsC8MWmojDSoxh+BF4BcloWqNqHplyCKUwyP SVpT9pS08cHpO8b25s/qmP42V+K/JSkhxdBYPrsEg6+bsptt877nbk5+hXdf1A6ntrVGnAAAA X-Change-ID: 20250531-uffd-fixes-142331b15e63 To: Andrew Morton , Peter Xu , "Jason A. Donenfeld" , David Hildenbrand , Alexander Viro , Christian Brauner , Jan Kara , Andrea Arcangeli Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1749278406; l=1697; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=IUl6q/76PM2j47USWUISFhP3xI3SXkKWlPHUmyQ2co0=; b=lnSgx8nHQ6hUrpebJcn/0ZTXN5o9vDh3IWCSaS25Evw95Igi7YpCvU7IU300F2Y5DsQdwhvOO DEZRX4fDF72DN7PEbegaLBdpEPBDbT8XtxjG4/LpuJKu3U8HJHP/Ey9 X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjA3MDA0NyBTYWx0ZWRfX/9GRecdX6R0Y PsdoJXscJsf1oYYalTw5+LavDqqDlMFaT56C5EMF/PxhTGh5/+X5PjPn+qAYr8lDQMXfSivHpAe rhL3Ii2l/WwpHOj0sVuU1E1jEMtpZirE9dV0s9WgTCTZE7Htn7cg87kzjulzywlE3H3u9AfBM1J MKfpckgETq38Mi4fk9+7zgYJASaR5e9v2OJwK7CdKuDzdiqxKNzQNHFqNSjfg35ujlkM3d5XE8r 5zB1jKkurxkj0lT3XHg/OZ8SQqEU4O4zBlLpu8aSMo2GzCnWxByzY3awfsrT21y5dSCVaNMxDUr orkAUJGzsf6RejxVRRxLdlIEanFzkqoJQxeFTfcWj1NYaV0X5DrhAyS7YldwRyNkxeK2SIzgfgm RBNeQd6t X-Proofpoint-GUID: -7fdOP_X9MN8AefbwrCj54XxwNjkkG4X X-Proofpoint-ORIG-GUID: -7fdOP_X9MN8AefbwrCj54XxwNjkkG4X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-07_03,2025-06-05_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 mlxscore=0 suspectscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=10 impostorscore=0 mlxlogscore=559 bulkscore=10 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2505160000 definitions=main-2506070047 X-Rspamd-Queue-Id: 32B881C0007 X-Stat-Signature: 8unofmitanmrksp4m9u4bxgz4ihf8njn X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1749278410-824442 X-HE-Meta: U2FsdGVkX18usA8E6Zif/qvw+tOZc0/VrGVnL9fY281m9RZoOgHQJ402jFPyDqaaaGH6Yaq2MvN25bRyM4kHSGorxkK1pvwwq8PbrCdzZzwzPLNgHJG1wk+GDBr/4BzZB8wdSodFwPcbPuSnUX3zYwa4o9tq/dZI3UtZkmFS/pMmNK7atpD4QgzBmardegx22hfQHmSImBQBub5l2TfqGZoGUbkKTmPdWQmb77h6xDr7S5efgM/+FP5NcRmcC6yOUXidoO+BYT5BX3+gr786yZwJONKyaUGOOKhzz/9HJYzcXzugflP8mNdyestEK4vUYr/j/EItattdNOS6BORYJvLVK5+n9TE6yb3/dSotNOnNzPjpVfVf7zYG4i7jallXxUdL027ow7BL+uNXR3aj3K4lJLXWeFS/PRjthxk5ZrkP+c1vmTir7xLtOtDdz4VR5MJ8XZUTmNCPwq0evOW+4E6oaY6p3J0f0cqVgAjZRlzTgY7K0QCeftBrfCs2iDzGBKMgd2DTKxvZEhz1BJQgRZBJaeio2fFBEBzxblU6oWvFVhXo11Dca69EL2+DaZ+WCWUCzTLnyLlAgoxo4Gn4hlebt1bKeu5CEzzfR+FBJZQyTYDbkF+6HgAvNUf8we08M1WoPvUVs3VAUgeXRZsCLSNBdxej45rPNMKKn6ZXicDJVia4bMytOLmVWdkZzWgtd3RQmMEfMnoIsL3QvKALXk49BOtKkqcrlnPrnq1Sj7/S3SUb89Wm4h8pbxm0WP3pmeZ43aoRLdXm3OiGE8fSPOHjzquXxIvp+QivyqLtRb97Rh668QgllzPezstJU7Qw6NC4L3FukSxIXckIOO56HP3xSz5wwf49lmu4xO2KvB+UU5EepcKOoCDNPsSC48w0q+UNp8d7Vnju5/eq5tJS/jSP9KibDlEpB3YF17V31BfT2ccfwwFenNtOw4kVANlMup5BEYlotqBPqqlIsw4 FUgoFM46 iCQGCNJq35aLzT3/l7DpcCHvX185W15mUic9me+ZvBa7NAlfUumz2tnstJxHTdlpcq11SQuKD7POBYbUoML64qtp/LRZh5Z3fUvkdIG/drdN9G205dv9kc+ZehoKqBpokwcHsRS5v2ii/y52yQHndn4wbUvkCMeMefBUiq7TPcWdV7J4nk9ih4Ozg3kOGY8/IE0mv34hcDFhmfnv/du3atNDEaviONmxpfVZn9jUqvK188PEHOZ7gKJj5idvBKdeTQBfU5fzp3XkYe7OiMcasPW806is6YsxXX2sU0qGfZRlUseCynaclZOjhFcN6+EAY2od8pp/9AMZzCkEHy/GRTmnHl2UQvdS9K/rGhOTi8KWCDibep5026GXdHyOuCXZxAxjZpJdfjMfoxXA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Two fixes and two cleanups for userfaultfd. I added a patch converting BUG_ON()s in the userfaultfd code to VM_WARN_ON_ONCE() this time around. Note that the third patch yields a small change in the ABI, but we seem to have concluded that that's acceptable in this case. --- Changes in v2: - Remove Pavel Emelyanov from To: due to bouncing email. - Propagate tags. (David, Peter) - Add a patch converting userfaultfd BUG_ON()s to VM_WARN_ON_ONCE(). - Move the "different uffd" check in Patch 3 (prev. Patch 2) before the vma_can_userfault() check due to the wp_async bug, as per James. - Change the added BUG_ON() in Patch 3 to a VM_WARN_ON_ONCE, as per James and David. - Reorder the assertions in Patch 3 to simplify them and avoid the wp_async bug, as per James. - Update the Patch 3 commit message to include more details, as per Peter. - Link to v1: https://lore.kernel.org/r/20250603-uffd-fixes-v1-0-9c638c73f047@columbia.edu --- Tal Zussman (4): userfaultfd: correctly prevent registering VM_DROPPABLE regions userfaultfd: remove (VM_)BUG_ON()s userfaultfd: prevent unregistering VMAs through a different userfaultfd userfaultfd: remove UFFD_CLOEXEC, UFFD_NONBLOCK, and UFFD_FLAGS_SET fs/userfaultfd.c | 76 +++++++++++++++++++++++-------------------- include/linux/userfaultfd_k.h | 6 +--- mm/userfaultfd.c | 66 ++++++++++++++++++------------------- 3 files changed, 74 insertions(+), 74 deletions(-) --- base-commit: 546b1c9e93c2bb8cf5ed24e0be1c86bb089b3253 change-id: 20250531-uffd-fixes-142331b15e63 Best regards, -- Tal Zussman