From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC5EC61CE7 for ; Fri, 6 Jun 2025 19:23:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54B696B008C; Fri, 6 Jun 2025 15:23:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 522756B0092; Fri, 6 Jun 2025 15:23:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461BE6B0093; Fri, 6 Jun 2025 15:23:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 277FF6B008C for ; Fri, 6 Jun 2025 15:23:51 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CB6F81601AF for ; Fri, 6 Jun 2025 19:23:50 +0000 (UTC) X-FDA: 83525950620.21.CEB0F8B Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf08.hostedemail.com (Postfix) with ESMTP id 04078160011 for ; Fri, 6 Jun 2025 19:23:48 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mSBgZdZg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749237829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xqQ/zcvbPdp6A7pyU4L8ztg/UtBL60Hxd9tSiPIjUzU=; b=Ur0OLCkwXxZo8e5vHUwaRRqZru/cn7u/gfazgLpPXyjkwzcnyDB8JnbjHnoaejTlTFasJi UtuN31yQ70yds0QxBeg9BqNg/viHBwbn3Z2KkZqSDFRD2tU4q9hCHeBJdgB5OBLgaezWR1 RniQ9URdmcRpN3e+ZLSE8KPxe7T+MME= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mSBgZdZg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of joshua.hahnjy@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=joshua.hahnjy@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749237829; a=rsa-sha256; cv=none; b=UgM0dJUvuKHwB9DygX+nV6NH4eO/q3k7XflA+2yNA/s9PZzBQVUbkiJn/rc6Pz77mlnjrW xDo3NfkhpDoIvtjj/dtqV98NjNzi+Ui+1aX5wDgSCcDHWy0JTO/TsoxPFDu5Sa1lwkw53x SWW2T/qfIkeTCYUAfXLMopRuXKpDcN8= Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-70e1d8c2dc2so23669837b3.3 for ; Fri, 06 Jun 2025 12:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749237828; x=1749842628; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xqQ/zcvbPdp6A7pyU4L8ztg/UtBL60Hxd9tSiPIjUzU=; b=mSBgZdZgK6BarXvHOPir+p1D/ruLjeTo4eN3AybIRFg4sLXaLp3Gbuj4tLecYYT7C4 AZGjU0TlrQGhFxajMuOoL+NnDivKMN0VfC735nSfxbjiFFKwQV1ixF3xesA5/nhUJ/3V AT5R8FaKUoSSVw/wnmYKtMDoLoKqT09gNQisxlQlzCj7qryHAEH68Letzb0zj7IVf0+f PCM6RI6qkNR1N8qqxbrRhmiBIpA7IVfDtMZ5mXCnv89BVhFoT9hPgcAaJVKR4zrv9I29 vnE6SN+BD1oHLRgJo0griXMBV3X0gD+tU2XZBhMZBJEP55SYwmXJp+IL7Sd44DovDzvS nNpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749237828; x=1749842628; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xqQ/zcvbPdp6A7pyU4L8ztg/UtBL60Hxd9tSiPIjUzU=; b=vxUxQc8cdJsALhQZgrvez4uDuhxTqjOA4JGSvDrRu0vKIpg3hyrBqDGhQB66PX97AK 2Yqz34s0Ar+rw6moriC5aoCgTfI2BBFZBA94qwOecWQhrtWEDHFueJ+Fl8OOUVrXiwVw IP6dz9eEE69CbJ+XdkWFvsx7bHlMn8MqljwAOfW4T8BWrO+UlXV7ek8+Tr3rZzpcgCVU RDdOiz9BPis1sa4VCDCZ1BjqAV1b/Kn2oNGbWDySIzsq4fcQYUDBcI2Uvc/rvmp11tSd eenWBmozb1b7t3/dUicp+nfELhg8rCtadRUcFyjqxxiwZdeMctxtyXsaJw7j9ocsTfEz lmSg== X-Forwarded-Encrypted: i=1; AJvYcCUmGK4IOkMpQP2mTheGV73g3yqtqEIJO/FPIhc5H2U1BS+nXFl7gXVGAbuiwYFWOcZ7FLTF0ONkJg==@kvack.org X-Gm-Message-State: AOJu0YzSuKgfAdkUDSiWvCKOehEbgjzN6fb57V9Zk1qXB+GMxPnOWyVK m38+wPkosfdcj/BL2OLZRPWqp99I3op2qjJiZrJ9a3YPfh4tfC1/Kv1I X-Gm-Gg: ASbGncvdkYpJsO6iCTgyoGaR6y3RXF4qj2gb9GkCXXBndt1qvfWSW1bC7fRAySt/yZI iW4Eyz0jiiO4RAOComQYewQIDWm0tU3G6br7Oyjfy/mKZb/eiYXBdU7thDpxzIqlm4mveOXbg8R Taao/er2+P/f8WQMs45YP5bG27aMaDuy5kiDbqNjfaLKsG+ZXuQNkMp6ofKEtMwtMlHYrYgi+qL hOJynWUfNw/vt4pj+LVSLwjt0sv6tD05qQgSwpRy/CNGQ9eHJmVRVjVF7AYXG1nfn+5SJg3V53m glRosePbazSCj73K/OkFl8M3zjX0m3+0xdXPdJax1U6g6tdqTmJEklRmEj1xbg== X-Google-Smtp-Source: AGHT+IFGb3uDxAv2h38tlgnumCIU/bedcMQ7x8nYpWSiVRUEgMfnHPiE0TBuxyal9rWa7F/gazzaAQ== X-Received: by 2002:a05:690c:620e:b0:710:e8a8:771d with SMTP id 00721157ae682-710f770f5e4mr66524407b3.24.1749237828001; Fri, 06 Jun 2025 12:23:48 -0700 (PDT) Received: from localhost ([2a03:2880:25ff:4a::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-710f9a0e6efsm3578727b3.89.2025.06.06.12.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 12:23:47 -0700 (PDT) From: Joshua Hahn To: kernel test robot Cc: Oscar Salvador , oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Jonathan Cameron , Harry Yoo , Vlastimil Babka Subject: Re: [akpm-mm:mm-new 61/87] drivers/cxl/core/region.c:2437:22: error: invalid use of undefined type 'struct node_notify' Date: Fri, 6 Jun 2025 12:23:45 -0700 Message-ID: <20250606192345.3440658-1-joshua.hahnjy@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <202506070030.otNokpsc-lkp@intel.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 04078160011 X-Stat-Signature: c7sibdx3zoqxkzodi78y4px4efipbyg9 X-Rspam-User: X-HE-Tag: 1749237828-334746 X-HE-Meta: U2FsdGVkX18624YckRQIlZ01nFKc1JINwxP7jKrbyH/a7NlfrFmEAwlg2vuEckJJLoPkwt9Q7Rf0+S5cB9WGQa0rr/l23A0Jld9e+/TOK96OBNeZVT7zwzuYUqsr4d5m9oaMSzgalsdSDBOmRT6OLCM1CH4tgFhJ3P1GLUKz3FnLbJN+OA78az5urVQCTJW8yD1uQoH6f7Ua9qaaI5SLhe695PZOm4HqWO4IDrhYskkXwz6lyYQpGH1J5wGAEfBVLx8KpZu+hDsOgARAVj2YGnIGcNYI+ejrdVCfqM1xpnDb0H4fJWKXqYdkWVEZlyIjKRDZ4TthXV8sEgiXKyKxhCncHPkMtSuNvHIr4+JRf4jCQdLuGJCyANpZnBEDjahw45AW5D0486jHSXKaQbcRp/vVjZjRaRKNBgY3DyaBdMEaHiXHQSC0dP9OkUNxi5Mquf9H1z/U2BBk0YgW2b6LBKJkYYDc9PZizpTlHZk5M6iYoBTQqq441WTDpKghO5gkaor7LKHball9KD6E22XZ55fz2NJnAYm8cYKQLLJbksKEQiWprVNl8shIerZkDb2fGDL/Iew46fPeZLzN+41+w/BTmA1fo48c9MorsbJ7Fi3aMDeGYOiwLlmNCR00RbBdx5+lJchtxVxavlAz5ZJD0IEIaT2n+U+fY3GywXMaYwcbZEEazywxAqJwoV3Xe3Nsc28+7Wb0e/LubVTdzlAfPWqn+QyeYv9Wx5yV51yPNZJzGU28reAQgNBhQe6M4E0jleZmk1Aem7Tj/srGrYf02P6AXG4WEHI1tWUcROHrIlYQKvzbPg1oJq/elHbVNKFXcCFoTPw0s20/xY/1ZMdAusEvtGLm0h2RwthNM4p0GDrDGRPGXLPWD5pP012lgagDlv7KSf5WQAeNotpXvCBQnoShjf9nC9B6c5krMIryh8F4TQmtEJt+iXCq4XvwbJDcBTXC6DdUDTHCwiIQq6U AoKJ4C+x 4gBkZ5oQx90pw9fi3qX08onpf0i0m1nsh6a3HvIiNyogr7D9BsMHqVEoFPRvQ2YbOML33+6oAgSkuxctK7g81UYJr01puBOj383TViKesLQnO1mEd3FLJ2Ocs1VJHBadJV+9J0j/0HoeO2TeOTkiznRFp/NGLz58pGwZqVjhxa7RkjLTdkflm6wcMjUvT2d1+O+BoMBNHpvSC9Bb7XXRD+ByA1yDR7gQvCDceigkM+F+Kw/aKfpKxX2G4vVMZnbju9jRR9od1fHpE1kLQpa6P8RMa+JDSEL5AlsoYpQWY0nvL1GDDnZSfer8OCXjrJ5hpAX3Y+5uhtPJRDfpf0jx+tldykMMBhdxn8Nz9ZIPZ+96cVS+QopUh631tGwyYwN+WSjQB3rVuHTHwUW36JILGm120JI3PxGREY/URP6XCYELaim3Au8QqA21KDGapaH7yUm+JvWpTgMGOkM+TyToqHxEaHnvexcWGDQfOGkQ5nU2r/WUsFWWU+w9G4Td67sfVaC/oyDQa2x/wqurh0ugLGTq1dvEH3Uzk4ontULeoKLtZf7vc2tkyrYTTd1O9hEO1d0tfzaoPQiwFRMV5ooYiHIZGkUBYSDdSaIKZG/ESIR5+laA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 7 Jun 2025 00:19:17 +0800 kernel test robot wrote: > Hi Oscar, > > FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new > head: b9f05ab60cb240a64e898221de50a037553840c7 > commit: 7bd79eaa2076cde601d828532a09ea50e20a976f [61/87] drivers,cxl: use node-notifier instead of memory-notifier > config: loongarch-randconfig-001-20250606 (https://download.01.org/0day-ci/archive/20250607/202506070030.otNokpsc-lkp@intel.com/config) > compiler: loongarch64-linux-gcc (GCC) 15.1.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250607/202506070030.otNokpsc-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202506070030.otNokpsc-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > drivers/cxl/core/region.c: In function 'cxl_region_perf_attrs_callback': > >> drivers/cxl/core/region.c:2437:22: error: invalid use of undefined type 'struct node_notify' > 2437 | int nid = mnb->nid; > | ^~ > drivers/cxl/core/region.c:2440:46: error: 'NODE_ADDED_FIRST_MEMORY' undeclared (first use in this function) > 2440 | if (nid == NUMA_NO_NODE || action != NODE_ADDED_FIRST_MEMORY) > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/cxl/core/region.c:2440:46: note: each undeclared identifier is reported only once for each function it appears in > drivers/cxl/core/region.c: In function 'shutdown_notifiers': > drivers/cxl/core/region.c:3487:9: error: implicit declaration of function 'unregister_node_notifier'; did you mean 'unregister_module_notifier'? [-Wimplicit-function-declaration] > 3487 | unregister_node_notifier(&cxlr->node_notifier); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > | unregister_module_notifier > drivers/cxl/core/region.c: In function 'cxl_region_probe': > drivers/cxl/core/region.c:3528:9: error: implicit declaration of function 'register_node_notifier'; did you mean 'register_module_notifier'? [-Wimplicit-function-declaration] > 3528 | register_node_notifier(&cxlr->node_notifier); > | ^~~~~~~~~~~~~~~~~~~~~~ > | register_module_notifier >From what I can see, it seems like struct node_notify is conditionally defined under #ifdef CONFIG_MEMORY_HOTPLUG, but the callsite unconditionally declares struct node_notify *mnb = arg. Sent using hkml (https://github.com/sjp38/hackermail)