From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 631C8C5B543 for ; Fri, 6 Jun 2025 01:50:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFC1B6B0096; Thu, 5 Jun 2025 21:50:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AACDE6B009E; Thu, 5 Jun 2025 21:50:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C26F6B00A8; Thu, 5 Jun 2025 21:50:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 811106B0096 for ; Thu, 5 Jun 2025 21:50:58 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E090E5C6CA for ; Fri, 6 Jun 2025 01:50:57 +0000 (UTC) X-FDA: 83523297354.22.F6BB66F Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by imf04.hostedemail.com (Postfix) with ESMTP id 325EC40012 for ; Fri, 6 Jun 2025 01:50:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mDzRafhy; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749174655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hhz+Km85VQd4z5S8bVbR0oFrFuZI2aVyvPqn6ExTKH8=; b=PKExpH0GqfTNQE2yQIM5XDKvbu1hOwtc8CY4PWY+E/dcnxJpf4O5DEVmDQKMYw0xt16UkU tEfhePBgFfw1snbusPtNhIZ541Jp/doVHv6M9L7+5DrFBQGeCFsoj3jvcGG1dL5uNibuU1 Kc+GCXZ+hhv37Sbcp7rRri2kPYxGhj8= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=mDzRafhy; spf=pass (imf04.hostedemail.com: domain of lkp@intel.com designates 198.175.65.20 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749174655; a=rsa-sha256; cv=none; b=54tBq52sAzccuh3h6aQyRzs1XAHjY4/CNz46elXe2dU0y51LfE5pwb6kzzJmZjCjADB8Jb qEuUUh9fBDLCjEbtT9s6nhDd1ZeqLcFF3fsRfYC93HuYjr811TZIbLgmrmA8EXWiIIBR43 45UNoOorTmZ4Md8ZgHcEDG9EtDcrezY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749174655; x=1780710655; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=/DJv+NPpUjWWWztYNwh9gNVvsQab8+O1fHBH0SOuxb8=; b=mDzRafhy9+oU4c26TBCbdOFB4XeUaJD+zU6IjvpaiZfhQkyionghjzMn qqA4oP9+ZIjrKIxGs/CmdJ778zo7RiENoAIOQY9LN87DBfujvGg3MEbpr PZ3lmsrYfqQzmeyS6qHp3YhhGtsRh18xonWFwruWdzRpzYugI3MfUWayZ 97S1hkcsdBrdLVM8CDnNm3kE4w0PC5xfZKKVvPNgrrvsyRGyVqhBNHFlL 2yBHVHvGIHvzkqwZm7LmJP+U9EGiWz8uBVfx1iTVlodBvKcKDr006ijLj kt72mOgNeSmvpImiwB/VfTc352gJ/4OFwrKTgmtJ92sxBaYVkBYkqEDvz g==; X-CSE-ConnectionGUID: EOhgpXDYRwKRYiRihb4fhg== X-CSE-MsgGUID: +Tu7vKO+Rjemr9+4jX9eUg== X-IronPort-AV: E=McAfee;i="6800,10657,11455"; a="51020248" X-IronPort-AV: E=Sophos;i="6.16,213,1744095600"; d="scan'208";a="51020248" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2025 18:50:53 -0700 X-CSE-ConnectionGUID: QnSp8KYWQReB4kmtCIqw5Q== X-CSE-MsgGUID: FTnBe6xFRp+SkcA369UidQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,213,1744095600"; d="scan'208";a="150514855" Received: from lkp-server01.sh.intel.com (HELO e8142ee1dce2) ([10.239.97.150]) by orviesa003.jf.intel.com with ESMTP; 05 Jun 2025 18:50:52 -0700 Received: from kbuild by e8142ee1dce2 with local (Exim 4.96) (envelope-from ) id 1uNMEL-0004dX-0P; Fri, 06 Jun 2025 01:50:49 +0000 Date: Fri, 6 Jun 2025 09:50:39 +0800 From: kernel test robot To: Oscar Salvador , Andrew Morton Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, Oscar Salvador Subject: Re: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier Message-ID: <202506060918.HDCPogq9-lkp@intel.com> References: <20250605142305.244465-5-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250605142305.244465-5-osalvador@suse.de> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 325EC40012 X-Stat-Signature: akt4wbcmjysanbuqaogipf9wtnmzcpnk X-Rspam-User: X-HE-Tag: 1749174654-467053 X-HE-Meta: U2FsdGVkX199jJyREgY0soUTQXPqySui890s0Rxj3mv+QI2M7rNv3DNPF9iZ/a2P7oU2PeWZHj9aFC2s/CE9g1JM9XuO59qQuP7QCfqWlWTJFUh7sIeTtVVpqDJpJF+7AMUpOPzZF22XSMnEq2Qx5FAAQB+i0fMS6+JJI1XRizyatq+U6HOrm7gPrdCOGgAT3h9E+EZ3tS8YTt6pqi76KrQhS0st8+3rKnrJr8fiCcO/7gviBMsqoGvISsovd5V5xh4RIr4cPVEjhjA5Biq1BloY6UpXLrcTqZLrBLnyYjBOBsUJllmpnpFf5Odd6pTCTQ1LBxfUV+2hPPCDik2GZ/aVkNtdcJiAAYt2H7ZYjWzhwolAigrmso7NcfRGqULO6YaxlPg/Hsx4vPqt34vUxRr4VgDav0dkN7fHFjXiajOjiD08RbqqF4v2zX0m0zpAEhwn/2GxFzoS5sk9j9j6ub2HFyeXP8Ogfr2jxqfza4mdisfnPLPpiKU06mJYmn07pkmBsM1MBTDo75JDNXON751PSkML9b/b4MnVTX1GapZixzUxRoQrMW6zn5TykloBR1q2/jKkWvN+EMpTz8OGVQPBxfhQXQjIoyUwzmSK40GW6PXgCk0hgwCxYl5vBtNtWs78DhZx3Mgc1Ub1yHs26XVDvCY9OiaQYphFisXJrNIfw2EJdc14PBf8UYUIwDOo6EZYUp3B4OkBDtao1Dvsi85RfVtnQ+6q+wi7NFY9RxotCRVAQ9JM+DdkZKwCEzN3/+Kd0vjbdwdV57vG2nYzd7lkriUXoGvyitYgJqjZLm1+dklHtBcdXeCkwECyBJaS4zrXwP5g/m0mOHAjwYGu1jRJNGvqGDnn81Q7WdZsc+DEWkt/ccIx3ysUVeG5NaGPGJ4b2CsXD4XkczfUvjNouIb97RXKkDIYGfAg/1hhzOun964usG253uLvbLbZk+eFKMwIH6cWIJir/GRJI2W VFq2V+iQ h6FFS/utvz0ponzfl6jxqLuIylWZv+LyqJs2BaT+4xZsnx/6FH+s3rlwTgp8YAdr45GOpHvPCbEjt+5n3LhVnFh/tWCuhBinHxS0zG44FoDikvY4S9HzUhxB+T4lu4au02V+N6FLEz9j2jJgeKkyCv3an6tQwDJgOTlpPxliqkaO9uEEWsXjI0c38ZjRxG4t82M8Sw4Iu+yhBH1vUxIokKD+qc9NOu3t4J66NtLavBTaRDzHX1zdgANt47Kg1gAi6znTEIseBiHEyddCIzy9k4t6O66RH+PHppt5XwZ5vxYC96aCXGfYIpSGA+aupDfj+j7iaZd+F3x4f0khNbTDtD70M7dWBqPkI//V10BWL4JpR74PX9cP4Oi71TGXnx5Wcgrv8bakC1PZe20cZunK9sVfB2Hamoc2O+4EtyxxPM58F6gc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Oscar, kernel test robot noticed the following build errors: [auto build test ERROR on driver-core/driver-core-testing] [also build test ERROR on driver-core/driver-core-next driver-core/driver-core-linus rafael-pm/linux-next rafael-pm/bleeding-edge tj-cgroup/for-next linus/master v6.15 next-20250605] [cannot apply to akpm-mm/mm-everything vbabka-slab/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Oscar-Salvador/mm-memory_hotplug-Remove-status_change_nid_normal-and-update-documentation/20250605-232305 base: driver-core/driver-core-testing patch link: https://lore.kernel.org/r/20250605142305.244465-5-osalvador%40suse.de patch subject: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier config: riscv-randconfig-001-20250606 (https://download.01.org/0day-ci/archive/20250606/202506060918.HDCPogq9-lkp@intel.com/config) compiler: riscv64-linux-gcc (GCC) 11.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250606/202506060918.HDCPogq9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202506060918.HDCPogq9-lkp@intel.com/ All errors (new ones prefixed by >>): mm/slub.c: In function 'slab_mem_going_online_callback': >> mm/slub.c:6168:23: error: invalid use of undefined type 'struct node_notify' 6168 | int nid = narg->nid; | ^~ mm/slub.c: In function 'slab_memory_callback': mm/slub.c:6220:14: error: 'NODE_ADDING_FIRST_MEMORY' undeclared (first use in this function) 6220 | case NODE_ADDING_FIRST_MEMORY: | ^~~~~~~~~~~~~~~~~~~~~~~~ mm/slub.c:6220:14: note: each undeclared identifier is reported only once for each function it appears in mm/slub.c:6223:14: error: 'NODE_REMOVING_LAST_MEMORY' undeclared (first use in this function) 6223 | case NODE_REMOVING_LAST_MEMORY: | ^~~~~~~~~~~~~~~~~~~~~~~~~ mm/slub.c: In function 'kmem_cache_init': mm/slub.c:6300:9: error: implicit declaration of function 'hotplug_node_notifier'; did you mean 'hotplug_memory_notifier'? [-Werror=implicit-function-declaration] 6300 | hotplug_node_notifier(slab_memory_callback, SLAB_CALLBACK_PRI); | ^~~~~~~~~~~~~~~~~~~~~ | hotplug_memory_notifier cc1: some warnings being treated as errors vim +6168 mm/slub.c 6162 6163 static int slab_mem_going_online_callback(void *arg) 6164 { 6165 struct kmem_cache_node *n; 6166 struct kmem_cache *s; 6167 struct node_notify *narg = arg; > 6168 int nid = narg->nid; 6169 int ret = 0; 6170 6171 /* 6172 * If the node's memory is already available, then kmem_cache_node is 6173 * already created. Nothing to do. 6174 */ 6175 if (nid < 0) 6176 return 0; 6177 6178 /* 6179 * We are bringing a node online. No memory is available yet. We must 6180 * allocate a kmem_cache_node structure in order to bring the node 6181 * online. 6182 */ 6183 mutex_lock(&slab_mutex); 6184 list_for_each_entry(s, &slab_caches, list) { 6185 /* 6186 * The structure may already exist if the node was previously 6187 * onlined and offlined. 6188 */ 6189 if (get_node(s, nid)) 6190 continue; 6191 /* 6192 * XXX: kmem_cache_alloc_node will fallback to other nodes 6193 * since memory is not yet available from the node that 6194 * is brought up. 6195 */ 6196 n = kmem_cache_alloc(kmem_cache_node, GFP_KERNEL); 6197 if (!n) { 6198 ret = -ENOMEM; 6199 goto out; 6200 } 6201 init_kmem_cache_node(n); 6202 s->node[nid] = n; 6203 } 6204 /* 6205 * Any cache created after this point will also have kmem_cache_node 6206 * initialized for the new node. 6207 */ 6208 node_set(nid, slab_nodes); 6209 out: 6210 mutex_unlock(&slab_mutex); 6211 return ret; 6212 } 6213 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki