From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65FFCC5B549 for ; Fri, 6 Jun 2025 08:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA20D6B007B; Fri, 6 Jun 2025 04:58:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7AD76B0088; Fri, 6 Jun 2025 04:58:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8FF96B0089; Fri, 6 Jun 2025 04:58:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B72B16B007B for ; Fri, 6 Jun 2025 04:58:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4C2631010EF for ; Fri, 6 Jun 2025 08:58:31 +0000 (UTC) X-FDA: 83524374822.29.4CB6D34 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf03.hostedemail.com (Postfix) with ESMTP id 3AC5920006 for ; Fri, 6 Jun 2025 08:58:28 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=csZOTLbX; spf=pass (imf03.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749200309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ymOcQmc1za1KFmVBfx7ccy1EEL2Tdf1lKKtdHUAzlqI=; b=mwPg5zReiN92UH2OcDBGrizqGs2U2ForMshZJTRVWaZ1XjGr1GyFqiZUt6+h5x4KzSXPZW cPi2hlHyZLBuX4lV/2FGIJ8ZIf0Qtl2ApZ7vymQ2YByYTkSHPjiGy3ZmsrIhwejxfCtgj+ IW5ejzTmpDs9CtAhxS2lZOjqyt2tdv8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=csZOTLbX; spf=pass (imf03.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.182 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749200309; a=rsa-sha256; cv=none; b=AzG1NTczyGABQjOvZ3YBpE65bjS6MeUsLmHxK1+RWFiKqcD9lTVdVB+Sbx6da/A4rsxBts 7lC4A/U+j/1iL2ZQat3d5q5kPpKnLuxnx+B8XQsJ0iD+qoFPLPFESRUQwuQhY4ISllOMa5 +VQmGJ0XqxWAvnz9heKx36nTZxZqaJQ= Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-234c5b57557so17955715ad.3 for ; Fri, 06 Jun 2025 01:58:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1749200307; x=1749805107; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ymOcQmc1za1KFmVBfx7ccy1EEL2Tdf1lKKtdHUAzlqI=; b=csZOTLbXKraPw/ot49Qq+py1X2+8z+ZD1qxvFaoZyWUioGXgHV+EFl5Ce1gK+qzuyt 8jz9L4TLWvTarVvYkNdlRjCBLdX2naSN4tCmMM0o9Ic++XSWeEE8trienhfuGOPg8p/g fmAHA07fJ61mlXXkoM/Oe77OhsIF35VMaQCUc5kigawp+E8Jpi7WegG40dYDbbpjxexT qetrfAMQCLcFciyKsu6teyQEOtuPOVF/KDIYeV0oFjxx8YARQtEA2R8p2Be3X2E09ocR NcXQh5FEMBP448VrgiTHKdBaXDez1W5BfIz4vOugohbGpUQU22CGTmEblBL9EF4vzta5 hU7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749200307; x=1749805107; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ymOcQmc1za1KFmVBfx7ccy1EEL2Tdf1lKKtdHUAzlqI=; b=CoKtrRnBOr4QLF9BPMkL3YoLnTxNzwG2KbgbBmW8O2bSLTlOdvtyyjXgGfIHjVET8I zuYLoNYTuOQ3kA4I/evJlmdVz4UtmmTsK6nyLlnxH70iAZ7BPySDhLx/zt804RFgklkf +zYqj5LJXgvG4Uezgopgm7u0ly+fziEgzLiooVJ5/KdK9qvDFK1+kvsx6acBKK3KDTbJ 0hULoixteGMhBMtjom38oXEHzZAyAoCXAAa3KYMj/Wc8hFMT8gYckNOpOueYrGCt8sRc dS99uA747ZU5NZwNNy/aSvemohBdX4T2kIqnaPiUIhnLs+F/RFyrezyHuPjHOWaXAmRC GJkg== X-Forwarded-Encrypted: i=1; AJvYcCV3F4bF0uPc0/mQ7MEMbWt5rVErhzb7vWTravqOOa/R8BjZAIjeS+eceGSgrdNMxXY+Yrr1aYWmug==@kvack.org X-Gm-Message-State: AOJu0Ywu8eer5vAa6nB/gGCzMAqHdJJqQ+yr48TjYkkOk5Hq6DdUVm5k yYSuftXsgXhK0PTjj1L7Zp6rfGPE2g4PfTBQj05KkptdG1f+Nj8DOnSvY78rVRbF0C0= X-Gm-Gg: ASbGncuqKAsoLGBfySqs0uQEylOeJA32A8R7p9oF/rgYbAwYW4QAFYZaB0e5wwtQ+n/ w1kEcNKYr8/H2sdSUe20z5EDz/ghIjuM4B6GCJH2utWqW7Z/JhD+P9OwcL5TG+iDMeZ27unyjWR z3hmAe3o/qnndXMugViXc8S/KiTcWeZbQbIsOJAz6YaJpKu3/H4De6u0HPtKFsuUdj/YgTCjlGl g196mLx9cRSvmYTQlxjNtly4zGg5LCYCemwGlTfv8LZVWdbUfezt3moYNKwerj9xfEoR8D/FwNG 5dkxLNr61Qeq/Xtw0Nk5c9AnbLJt9CNd+yG0EhTjdyyIyW1H367SKs9C8rZ8WFsWUlGDwrzFCHs 4sp0= X-Google-Smtp-Source: AGHT+IGSu1cXHwIHRp8Sg3wueJ136zK9blpmz4N1Qjg/nEzAL2VqPuiwWwZjy4fAHlq7m7EMtekxZA== X-Received: by 2002:a17:903:40cb:b0:235:7c6:ebbf with SMTP id d9443c01a7336-23601d82e5cmr39668735ad.35.1749200306814; Fri, 06 Jun 2025 01:58:26 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-236034037a4sm8121785ad.141.2025.06.06.01.58.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 01:58:26 -0700 (PDT) From: lizhe.67@bytedance.com To: david@redhat.com Cc: akpm@linux-foundation.org, dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, muchun.song@linux.dev, peterx@redhat.com Subject: Re: [PATCH v4] gup: optimize longterm pin_user_pages() for large folio Date: Fri, 6 Jun 2025 16:58:19 +0800 Message-ID: <20250606085819.89839-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 3AC5920006 X-Stat-Signature: 1sj1o97psy13zq5kqp9zc34rjt135h6y X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749200308-683447 X-HE-Meta: U2FsdGVkX19nBlmwe4+wQvPFP5bBF/mLTjXP13wfPk3d26xBdV2JaRgrWoUmtV45WybGyFn2U2FI6YKKSCFu6vFR6PMEjvEL0ZdrsT7trirB4KcU9P6NavuPaJyMAOgAcgVi2z8ErGeisE19hQx+/8sB9bTXESBZ/3QMhM3XqmTWReRSy+fYsbRiHH66QhzsEV7vIDlS51jDN/SMlvvrzR/1ND+u0sI8mc2EIHJxCLOXZot46jQ6enq5D8+zHxHhJp2RXaUdEQLVgMDyypoAYjudvsxjTlQJbXxKKnnJXGcSoet3wKYWrGPIlME3Rs1qgyfwEstUipXBfnFmakuIDMi0Bgws+mSM1/Y6lPcNb1i5EZgE9CBAJQGe+9oeLEEhwFmdF2mM0bCfolt3OH1YhrXknA8gkU7wLjw2b+ADjDcFIgOJs9Rd999a/P/wOxRs8EzkfNQabGXbdRyxulzynFUOavBk8IPu+0LEFNGOtpAyaGng3ZLXwrBEFzhsnumsdX6xP/fq9m/7MlLwKqBNRGyQkfsGlKMERjX/MTB9TUvCw6Fjj28IwwZrsQGl86AhMJqLGbE+rfnueMSVOIljDDEkB2rpmxOPDWLqeELSULQQN4N5wB/iTQeB0I+VOit9aOb2YECqUhQoflN2Ac/hmwQhORtPP6Dd/2/9IzRSUq8pXsHxKh6gGovkptg9PHNZIWJkFOfG3EZnzXmLWC913v6/vUwz/Gp7xSTX6SFj77bUq7DPBkAzOFM7+CYnxB2tSZ/WfX4LOM2jqMVRXjUKtGVTuZwZr9acLICHLEia36TKMZqh/AG4ZR8G7oYDTxLHfpfsJgnoGXGUUuMTyl81wVh3NFTjBRgiHoQjuXTDntx8PN1CWy0bws2WgPksikvB4thUY2VNa5JvPq8tl0VS0OEaOFiHr2Wd37Hch1nHNY9U5qCCY0XiCIzd0d3Zjsxq/91+NWdsgMH3qHLt3IN itHKRneq joh0CpMVFbqJItjv3UCwijLiV//Wyv6ZP2QJdrKpKxveDBmmbHdslZ65b7Z9YJp6kw8krJupweV8cYtqhn/MUih9USmNqFagIDZFzzagcuzCU/ite2W1+9nz9gtAAwmrbcD6uVt/9v9WSSJNM2gb9uOzYuTV0ChAi1mhKFd8l0TwIf7Bhy6r9w/x8ZE4SM8vR/fS4T7/wVP3m785oCLw0+bamD/dNlwABAIzrI/Ee3LXcoW76MEcNpnAH5lBBb6rWbPA2onzFb/NWHb6H+6An0+r01OVZkvSF1lH+VFQ3wybUSi4MhDFq/UntDfTzx+cxZ/Cxm8s+7jXJIK3fkIdIq/gJlOxvr4ZX3MOqXZ7hhPRWdzelzNdvKYHn+mJMq4ILHGLjnQte4fDxFqXcsIs7aKmZpc1nf6JMkk9xRiCo8Z74P9k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 10:50:34 +0200, david@redhat.com wrote: > On 06.06.25 10:27, lizhe.67@bytedance.com wrote: > > On Fri, 6 Jun 2025 09:58:45 +0200, david@redhat.com wrote: > > > >> On 06.06.25 09:37, lizhe.67@bytedance.com wrote: > >>> On Fri, 6 Jun 2025 10:37:42 +0800, david@redhat.com wrote: > >>> > >>>>> * Returns the number of collected folios. Return value is always >= 0. > >>>>> */ > >>>>> @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( > >>>>> struct list_head *movable_folio_list, > >>>>> struct pages_or_folios *pofs) > >>>>> { > >>>>> - struct folio *prev_folio = NULL; > >>>>> bool drain_allow = true; > >>>>> - unsigned long i; > >>>>> - > >>>>> - for (i = 0; i < pofs->nr_entries; i++) { > >>>>> - struct folio *folio = pofs_get_folio(pofs, i); > >>>>> + struct folio *folio; > >>>>> + long i = 0; > >>>>> > >>>>> - if (folio == prev_folio) > >>>>> - continue; > >>>>> - prev_folio = folio; > >>>>> + for (folio = pofs_get_folio(pofs, i); folio; > >>>>> + folio = pofs_next_folio(folio, pofs, &i)) { > >>>> > >>>> Nit: indentation is still off? > >>> > >>> In my editor (vim with ts=4), after applying this patch, the folio on > >>> this line would be positioned directly below the folio on the previous > >>> line. > >> > >> Documentation/process/coding-style.rst > >> > >> "Tabs are 8 characters" > >> > >> :) > >> > >> Good choice on using vim. This is what I have in my .vimrc regarding tabs > >> > >> set tabstop=8 > >> set shiftwidth=8 > >> set noexpandtab > >> > >> set smartindent > >> set cindent > > > > I truly appreciate your correction and guidance. I sincerely apologize > > for the formatting issue that I've caused. > > > > I noticed that Andrew has already integrated this patch into the mm-new > > branch. > > mm-new is for new stuff, unless it's in mm-unstable -> mm-stable, it's > still considered rather "experimental". > > > I'm just wondering if there's still a need for me to send out a > > v5 patch. I'm happy to do whatever is necessary to ensure everything is > > in order. > > Feel free to just send a simple fixup as reply to this patch. Thank you. I'll send a fixup reply right away. Thanks, Zhe