From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE180C5B549 for ; Fri, 6 Jun 2025 08:27:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 789B36B0093; Fri, 6 Jun 2025 04:27:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 761386B0095; Fri, 6 Jun 2025 04:27:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 69E556B0096; Fri, 6 Jun 2025 04:27:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4BBBE6B0093 for ; Fri, 6 Jun 2025 04:27:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DD513BA526 for ; Fri, 6 Jun 2025 08:27:24 +0000 (UTC) X-FDA: 83524296408.02.DBE3434 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 3EE082000E for ; Fri, 6 Jun 2025 08:27:22 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Ib9rzitd; spf=pass (imf03.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749198443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=extr3XZ/haT3dc79zffQPJHDsai5V/OpqWCLpKSp2E0=; b=jwbywGD22FXBNd1rhP5ckc8QTPyLz8BHcJQMvyQPh36Apa2ZsV2ZjJtkLYIvlf4qaoeIyU m5hEHapU1hB3vMlHxc9z+MfAbsJM0vFaF9XP8NZSnbiMktO6bbdnhGP6zoW2Mtd9IYCzU/ gHyvQBzoBCt2QuQY357tq3XxqUtaU1g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Ib9rzitd; spf=pass (imf03.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749198443; a=rsa-sha256; cv=none; b=zdsaMzY48vzx7RC1qzaYSKzvVM+SN+Ei2Sd0wa3DZecGjCuOUF6XzjMHX5ymPPes1xks14 lfG8gDI8TEGaWWRXVHZw2xC/4gqp3E1VeGWPTYS2PiD/FbVl40Q7u+ouweOb/Ez97bMihR qQxxOojBtpQ/q9QCFwTyj93fRQToUUk= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-22c33677183so16780365ad.2 for ; Fri, 06 Jun 2025 01:27:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1749198441; x=1749803241; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=extr3XZ/haT3dc79zffQPJHDsai5V/OpqWCLpKSp2E0=; b=Ib9rzitdwGSdAfAHGoHSst5Cu9DvZbIJiLCl3jLs1XEwxUgql0dEFBLf+UKwurW8nf 1uBRCz/r9DKz5JUm7QIJ09N2cdB6cTjsmB3cfvI9NTZvMumIMisjL8QbrO2SI83cYZUB 0/HUy3cM0RaLXCgmGT0s4KceJ7DIZvVtp+1MAVEExJbnARO/OhLGFEmmJHmYZclAeu7d kVE3tRHmTPTVzQuyYAgb9jifaRo5xE4GGUK546Ueu19s6RqEYBaGLH6Ai+PLxl0CYjqi 4tjvuLF4l1iCqV6YUG5IEM3Jp2958eRTQOipiQr+lqjlMlo+Ec6FwafPYMORuCtIdyQD O7oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749198441; x=1749803241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=extr3XZ/haT3dc79zffQPJHDsai5V/OpqWCLpKSp2E0=; b=dr8TbxG09Cce/YJZQv8V58iUEHiHAK43P6n72cb7L2swzsDZr/d4Tvj12W6qWd5u67 rKrOE5vIj6leXuB04o2XMZbH5J3by8rmjzwOjI/LSNQOI62fr6Djn0hgjH/rA8My9NTU gCQFd+vHD/NoVIEZl5JlwHw/OH+ENOzaB3SQMBSlG3bUeQrtjZ9g4zqvLvKa7LOpQvrv V2GoYxA0/Gl7O5owTKKwfALqkLUuEPCamlGsTOl1S80VGgZm9Xy0Zi4lAUjrh7FjyfVw VM7Q672PaUFhExrMjles6imYOVwuhk8BrJoXXWFF/XVixXD0wMbgfrmF/dS8AIKjMfnc hy3A== X-Forwarded-Encrypted: i=1; AJvYcCXVll/DTfHqT8jN/CCOWlFZqWsfg+M5LrhQVX2yg2u4iI/zW2lY8VGElAOxRi704AShprTtuAH8OA==@kvack.org X-Gm-Message-State: AOJu0YzWwz+tzO57MFdFY774syqulnEJuplcBeUH3W++dFrJ8Z2d3g6v jlwOVYmLGDxkTBBRvZmbyZ1x5ZyZEzJQU0ubYFZ1Shpf0/MHv8arGyeViEhSg8PZafQ= X-Gm-Gg: ASbGncvRbsW/VgdEk2LgMdxtn/y1ptS73YWSZK37L8Ktnt+DYoRmuedgcm6He+SooyE 1TTTNHxCt+Dl2q4J7DNelnEk6IKDWGQGFH4CtgL8enMqIreyjGTQBNv5TvB5elXIlE9r/XGgsS9 e7DOWfPWzoETaolbXOdfSSZi5O/VLXEJZTgtjsSPS9a9c5y3Jkb8E5gowplzYH5woeyBRpgPAok DduF7infHtBOrljJXpUjVMwIt5FhUYteSFFRu4fYYnhyYbcGkusbYDy8VMU7ZkkrDd4DZWVmxZa MvvVSNe11wfQQK0igc9mRPO/gG17uq+rWe+f9Ci4Y2ZkxEu2JUOhuuXbKJQiYclyt58Li57kxjh 6oAUQTSF2TP/Ozw== X-Google-Smtp-Source: AGHT+IFUlGXn2qNj4ZqTz0dX5zZ8LVzeKqWCQat20Jw46/I0Y3IPj/UjlGDTiNQPDJuEycZswR0MVw== X-Received: by 2002:a17:902:cf10:b0:235:ef79:2997 with SMTP id d9443c01a7336-23601debd78mr32214005ad.47.1749198441000; Fri, 06 Jun 2025 01:27:21 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603092f38sm7684535ad.79.2025.06.06.01.27.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 01:27:20 -0700 (PDT) From: lizhe.67@bytedance.com To: david@redhat.com, akpm@linux-foundation.org Cc: dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, muchun.song@linux.dev, peterx@redhat.com Subject: Re: [PATCH v4] gup: optimize longterm pin_user_pages() for large folio Date: Fri, 6 Jun 2025 16:27:13 +0800 Message-ID: <20250606082713.87113-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <6f0ee0d4-60a9-4453-a08e-2353b234dac1@redhat.com> References: <6f0ee0d4-60a9-4453-a08e-2353b234dac1@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: x8er87u74f11qprwxfiypffdjtu63x7e X-Rspamd-Queue-Id: 3EE082000E X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749198442-592249 X-HE-Meta: U2FsdGVkX18tqhq2F99K6O2Dx+lvtcRWMB9bys8Ow8vNXXSqxBLP9M7Xg3E6SuVHgYP2XaQ0LzI701Gy4rtk87t23dTp5kdtSfTjJUS3aRoBJV2WOQytJDbugKj4UIzTTqFxngTslTBXGsHCg60nRdY/5gMCR9GzO81lGkRDowVaBEkhYW73MiqCBFqXR9luMrMNntPblQ3Pu1VQcEMi9DQpeIyetQMVxSuWJE5hfkZgim+NAcMZvgXfGSWz7CZnuIn0ScU8fp9/wpUxuyEJ/Ve3q2FtW4ApsljZukpHGj3uVpEDPAf/cxaEUciJPVV7Ydr/dYz4Y4Cwdsp583TvBHdMgTKzBZbNg7D3Z8qjtF+KH8Wu33CreyI7p0iplXy4vDLtoP6zP3h73/eiBcDIZsHE4ihNn4+H8FKvf+90jqLhGLviph04WeRmBW9vlJIeYXlC6b8VQlsFq4XWJzp/DmpTS7WMbpl6yY15TQm5nmcVBnU+jH3yfnWeQ+pEubnzod/Uyzk7k3niUgRSRXp1p1rrEd60XisgACk3TpA31StCx2Un3C+cHfL4/f5VKrvCGHLWtm+D1qnw7VUB47JWmd975Bzd+DiC0dpfthbg7LqcJUiKHR0Pc6j2pol0a9Fyw+4UkSyRxQhT8Y8LM/2M+apSa6x92TMk9FccjfM16ZccEGi5YNgYJ3yulrSPEntNI5nMkFocOqvwICoNDfZrvKAl2OJD3tuVRattLf7xzJ2XGJi/lWoDPwVUVlBnsMf+G5OwT+bs+7ggwHLMCqjLObnQZ09YZYIGX36nLhTc/G2ynqo0kYQxrybcjuaqc8X76RvYnjf0rHbw1pv5N2DA+Q4CQ241v4Cmjhq0F/rcXUJVpirWOhdXei13AvQn38rGzCIz6eNEEvkEcmYmy+qH6ssqUw9o+9KtLyqvDn/YJpig5w71jEpJ1IMTYvBdlRWPiz7KkmO2UcvFCihlTtK bmswVQyp h4zs0N16WfgrQRkoyFh2AF+0Fkw83jozS/cfOcyHgzK2wp+r0hq/cW3sSxwRZYxM3VQWY4daO0O1FY3NL07V5c9Z/6oqlQVLWaId/X/wkw3Cus+NQWw//ePI6GoQnVg/Op019KqCxIsZ8FsUyTdJ63jMBVZo1BFqxrDrNxgFWPphUvr5nIB5o8W9E9I8oQDUySfNQf/7rMjy6vf2sazaRApBLBNHqmifdvU2tar55AkH7pJF8jspFq73t8HHApPB5nWT/EM4M3tQ2Mae74+qqhf/TbTuCTZxR/S2c3v34L/DpT7iFVSRDJqInGtmV0O2wQJWLHuMbZfiHyZ+U1gJeRrWr40g+Zwu40z8dhtMnJhx15m+dg47o7Y5LfsOunxLU0jDNcJ3czA9x5KS8Q4AyVDkQ7IzHOwG2MNqWFrQWr4XpXpM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 09:58:45 +0200, david@redhat.com wrote: > On 06.06.25 09:37, lizhe.67@bytedance.com wrote: > > On Fri, 6 Jun 2025 10:37:42 +0800, david@redhat.com wrote: > > > >>> * Returns the number of collected folios. Return value is always >= 0. > >>> */ > >>> @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( > >>> struct list_head *movable_folio_list, > >>> struct pages_or_folios *pofs) > >>> { > >>> - struct folio *prev_folio = NULL; > >>> bool drain_allow = true; > >>> - unsigned long i; > >>> - > >>> - for (i = 0; i < pofs->nr_entries; i++) { > >>> - struct folio *folio = pofs_get_folio(pofs, i); > >>> + struct folio *folio; > >>> + long i = 0; > >>> > >>> - if (folio == prev_folio) > >>> - continue; > >>> - prev_folio = folio; > >>> + for (folio = pofs_get_folio(pofs, i); folio; > >>> + folio = pofs_next_folio(folio, pofs, &i)) { > >> > >> Nit: indentation is still off? > > > > In my editor (vim with ts=4), after applying this patch, the folio on > > this line would be positioned directly below the folio on the previous > > line. > > Documentation/process/coding-style.rst > > "Tabs are 8 characters" > > :) > > Good choice on using vim. This is what I have in my .vimrc regarding tabs > > set tabstop=8 > set shiftwidth=8 > set noexpandtab > > set smartindent > set cindent I truly appreciate your correction and guidance. I sincerely apologize for the formatting issue that I've caused. I noticed that Andrew has already integrated this patch into the mm-new branch. I'm just wondering if there's still a need for me to send out a v5 patch. I'm happy to do whatever is necessary to ensure everything is in order. Thanks, Zhe