From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A071AC5B549 for ; Fri, 6 Jun 2025 07:37:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 382076B0089; Fri, 6 Jun 2025 03:37:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35B8B6B008A; Fri, 6 Jun 2025 03:37:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26FE46B008C; Fri, 6 Jun 2025 03:37:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 04D9A6B0089 for ; Fri, 6 Jun 2025 03:37:38 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9C1B8827C2 for ; Fri, 6 Jun 2025 07:37:38 +0000 (UTC) X-FDA: 83524170996.26.DB328FB Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf19.hostedemail.com (Postfix) with ESMTP id CA4011A000D for ; Fri, 6 Jun 2025 07:37:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=DOZOB0Y5; spf=pass (imf19.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749195456; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=33c7y+CazJ/DvZvuneiI8heu0XV0fCbhYkEnt57IjrM=; b=loOpyHh3wI3mNNnxZ+KYHSsYzYopsB69CTnpDOklqqmDSweZVeUS33a35F2F+WiqkmacFy kssmyEsC8wAGvnqdEpbMzh15V+i/jCb+gn4ds5e5uUowxx+Dx/wc/3c3oi9PFYIKIwwc2O xpeQokJ8f5QGCmW4Xa4FS5kiCd9IwWs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=DOZOB0Y5; spf=pass (imf19.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749195456; a=rsa-sha256; cv=none; b=IQZdV8RJh8YFtvK3SPSZmrCxXdNOlpke3TkDbkEveCiJVUpZrwDCHK6PhmVuVc+iK2h//P onqjQ4MYQfXEqmkMgyc7Zj5ySgctJPPih652DJQ2dHlCU7qKphQMaYWbod9VOx9X7Li/tv 2f4AzTkDP++5/4VQWz+1IvrggEK44bY= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7390d21bb1cso1578257b3a.2 for ; Fri, 06 Jun 2025 00:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1749195454; x=1749800254; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=33c7y+CazJ/DvZvuneiI8heu0XV0fCbhYkEnt57IjrM=; b=DOZOB0Y5YVvKYtsB6P0K5CVj94Xit54DXBOlycs3skLMI3AclXXTEqyJqqeiOBwCe8 w/ygvwWM+BarDEh4lWf/29Usg0qu3v3riWmacl3LwqoxCQUGKcd1IR2FGUSIdNsA8uPA 7jTriOo3BM5xIKSm02aZk4Mir5uX2J/H0Q/ZylHK+Z0LeOLhbDwgR4r+jaXFsfTg6BMx O8X7+fTZX2Ajj5qlftYcYkZeEg7r33tl17kB1gUorkpckLuW7btEH9C0yF7uNmTY9/z0 KXtuMgrTgqJCfLj2BXXALmWdHWq3UjmDbmXiXIJNlnLm2hfRbiWKZ5J7Wp8rAD0CcMmE dpDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749195454; x=1749800254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=33c7y+CazJ/DvZvuneiI8heu0XV0fCbhYkEnt57IjrM=; b=StLSTh8pDn+FFRtOIEctF8Glw1zsFZekolAkOdWcYGoVnL2NJvAe0bXNGGN5XJH+gQ XQqwS8CHg1L6reWeNr9SaIFwgsmEHu78bQK3LOIXC43OB+bJO+hW0cKLoUDOgj2Zm1xX b2PC694IE1gc4nmiQVLhd39UMiQ/Yhu457OEAVsneSHllWwqaGdFe2TUktbFu4+IhB7O WCA7cwhwBzA4npxsMxjGwg2P4FBpyRXnAVUacgpzV6O6efU1sQmr4kqCsysFGHkhhgZC zRB32v7P1HfjVNZRYG85m5fN5uIdjgr4AAqCkMG7P/8iLgyAZ8LkBIH0R56MRgq/KyJZ aDTg== X-Forwarded-Encrypted: i=1; AJvYcCVzEgYZUS8D+RyuLAUPm85C/idgx1FUdxvdljRosrUyDDyeMmzel6cXGLTLpi/CpXX7b4Ba6ple5w==@kvack.org X-Gm-Message-State: AOJu0YxHQ4o9Ha0e4x8srYkAZnQGjP0cMXx8nx9VrpZoXAtWQ/b0fmyl YYd32QLRfFU1pRaE+upgCRNnnOHTxGkqTGFkjChAmmPdZV4H8RRXP/vV9/8EWgy7ya0= X-Gm-Gg: ASbGncs29K3SoL2iDkOx8WCx+hWPPfVn3ae224Qa38sS3nsPshEooMn/zuwbaZVUEr4 2LPdcGx192+UUzVqCrVhvDSAQwbXO0qp1YE05PqIAmYWmfU3ZqbICoBV/o3pXb7L6GKl9zLaaRO VkYNCLWGUeA7IjJqAbQ4EzQhK0/xGlhulLLq7gM7xNsH7FPOZWdrQrRKnvk29/ZxUwqxNFUEUsI Vesj6UHPJnsL8uyTdcRLdOvQUFjsGcKonykh9zxnwi25A1Cmr290gbzo6a5d39EIzTEn6fge3xZ czQelArNuW7USoXRUSSbFHxV2aGaBNNcXOdNQqMfM4wrG7Rym3LHmF7lKUgFaSe9OVnS11y+6yQ /UNYKTbWsCfe+xF+YmoIT+NG5 X-Google-Smtp-Source: AGHT+IFJifjuABwe6hOSGhqTuhjmPR0mvt7WzgY42R+ZoxvG04mzhQgG888ikvN2I5zB6ByvxkY2fw== X-Received: by 2002:a05:6a00:21ce:b0:736:b101:aed3 with SMTP id d2e1a72fcca58-74827e52515mr3436900b3a.1.1749195454387; Fri, 06 Jun 2025 00:37:34 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.12]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7482b0eb0f1sm713508b3a.169.2025.06.06.00.37.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 00:37:34 -0700 (PDT) From: lizhe.67@bytedance.com To: david@redhat.com Cc: akpm@linux-foundation.org, dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lizhe.67@bytedance.com, muchun.song@linux.dev, peterx@redhat.com Subject: Re: [PATCH v4] gup: optimize longterm pin_user_pages() for large folio Date: Fri, 6 Jun 2025 15:37:27 +0800 Message-ID: <20250606073727.82993-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <8b68e7f0-46b8-4814-99a2-02f0044cda9c@redhat.com> References: <8b68e7f0-46b8-4814-99a2-02f0044cda9c@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: CA4011A000D X-Stat-Signature: drtz8ej5tba7ifsor8i8hw8hqrsoogws X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749195455-194377 X-HE-Meta: U2FsdGVkX19RrOHcFAU6wblQwNCwdCOxNMzFY76ZaHoZ763heELdym4AoZVLV5TTDrj5CfNdBL07tqYVb5iOPDdUISdG9fmNe9M/wptMHO3AxXjxJmlvoIDrVqK4aG9n+Js2rk7z7LfBsI1ZSo6siwwUWS4/Ep8LpQCxfp6EW0NFHcQYMNW+Vn6J89TgzYmdtYBCKPu69VxNg3lm2GHdpHegiGd5m/I2l0xUU2t+xJHR9ECKAJSa6ruLRvIUzr3bkj0SqSAzZw8ePejRD0L5LH0x5yF48E6CdCLYPSM9yW6Wew6VAQdSfMSwXjUme5AVrncUHcsvam/hqaPPMq1vZV/AlDvh4ZGcZaqiCrCkdS/28jDz1oU8e+tf5OL8dQJ0W7NcZnprvKFttbzaupwX+P0kK2793e7Z5f3B5CWhVQpsOdjA5Z2SzkkM/5qCCjkXknHOFT9d8zrJh0gtlWoQhqF1htkGOs+ePPmXWJIkNpRxFMxn1F+e5IyS4PVRXr7ZAHdk9P2DNkLyQGnNcNwbJEhSqbu+KyfiQG8f9iukCkhsiYKNh/JM2CJbqyAgyxmkBhQd9Y9o0IbXsx2ZbX1MuIC2PqxndP3lWCUgBw9bpxCof4Rn0KpYP9tqh8QSD5Krn2lmtFHz8Z/bcLNCsbNxvoXYBZdzesMb0lYiX6KXJIBD1ZehIpWOt4cPQzNs7ZIma4bs9R6HlSkw4vRDu2sViqmXTCaKZ7hVGIGZzNQ4kulefFSmykfpaSND5C4qZUYyv6YvreSR+XO1t0qtaVkrlTW0Oau3Y/nu04sw7iRrBteTbjQBet8Ws7pb07fAXYFv7diDvUSBhRgB82jEkP+t73wBwcxf7REkWvtMKHUgTrl2xwQkC7QJHyIAsax3BKySmsHqlxYz0Nxy8x+U1J60MsKeiqS2cl/yboK7vGbuk2V4q2UxePanc+ZjnmKHmE6yHmnekAQ+94fQQNFDg7X ZKv4nNqH nxXH05RVecy3D9oHcParfOCNG+6mZg9/+6k5uz7NoCJUIPixWtxO9BF8JdulvfBMKB4GGcKSq2rYBJF7w+m0bJxa+gEVjn5u+Oxxt+uDy8H03WObhP8+kKswh5L9yrWeZRwTYPTmJQ4Xqtf0N1OWgF4Te2gvlePJBasakYlg5LD67ISLaGGdR3XukaGvNRQbLyrPMH6K7XAM1FYZZvisRnImm/VSRk4Vr9rOkCYqgkDOXzz4afsS2hoLIK+iaGQDIDYh6Ee+iuqje0C5AhRQ2jMpCfBccSjERCj3lKl9X06/l7hAzxpCVPNVou/C2VJ9ZXS7hIAFC1McGPZ4GODVa3VKz2iJyaYal0FmF4OXaNPP9HBnU+/FZNrYiQ8q3ZsByAdlH+QQpjGb77uBumNL6ClRG8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 10:37:42 +0800, david@redhat.com wrote: > > * Returns the number of collected folios. Return value is always >= 0. > > */ > > @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( > > struct list_head *movable_folio_list, > > struct pages_or_folios *pofs) > > { > > - struct folio *prev_folio = NULL; > > bool drain_allow = true; > > - unsigned long i; > > - > > - for (i = 0; i < pofs->nr_entries; i++) { > > - struct folio *folio = pofs_get_folio(pofs, i); > > + struct folio *folio; > > + long i = 0; > > > > - if (folio == prev_folio) > > - continue; > > - prev_folio = folio; > > + for (folio = pofs_get_folio(pofs, i); folio; > > + folio = pofs_next_folio(folio, pofs, &i)) { > > Nit: indentation is still off? In my editor (vim with ts=4), after applying this patch, the folio on this line would be positioned directly below the folio on the previous line. The discrepancy here might be due to issues with web display or email rendering? > Acked-by: David Hildenbrand Thank you very much for your review! Thanks, Zhe