From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE065C5B543 for ; Thu, 5 Jun 2025 19:01:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 76AA26B00C0; Thu, 5 Jun 2025 15:01:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 719BF6B00C1; Thu, 5 Jun 2025 15:01:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60A8E6B00C2; Thu, 5 Jun 2025 15:01:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3E8B86B00C0 for ; Thu, 5 Jun 2025 15:01:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B9AB41A1439 for ; Thu, 5 Jun 2025 19:01:49 +0000 (UTC) X-FDA: 83522266338.28.C660EB8 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by imf16.hostedemail.com (Postfix) with ESMTP id DE3B218001D for ; Thu, 5 Jun 2025 19:01:47 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b="c//ilo4F"; spf=pass (imf16.hostedemail.com: domain of cachen@purestorage.com designates 209.85.210.45 as permitted sender) smtp.mailfrom=cachen@purestorage.com; dmarc=pass (policy=reject) header.from=purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749150107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EvQGqFjBY2VQZAN4E6Y1iA2gvyPMQ+dVqRjn6svmGM8=; b=osPBrrYa8a/wQiqwBvfp4bFFT3XBJBS2dkfmkZgPoh6J7kFXynVk20G5YmHltrnS/4cZyN 912DbGjLuZweSaCbpiSURsQlMn/jNXLM+TAb5p0zUhZojtMX+DrfyMdJw6cECPJFttUvim BoVQaXAlW3xzGVkySscuwQSrmj2HPB4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b="c//ilo4F"; spf=pass (imf16.hostedemail.com: domain of cachen@purestorage.com designates 209.85.210.45 as permitted sender) smtp.mailfrom=cachen@purestorage.com; dmarc=pass (policy=reject) header.from=purestorage.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749150107; a=rsa-sha256; cv=none; b=o4g3jTVBCe9eci4kitWUSy27WMMd23fU3RJe6GZ46j3lNqXfuymiBumMJj3cSPYLkJPVXY GCU0YUJyxL/KHwgqTWuaYAIIoPDaumHHRUhnItoeU+GEjWYBiENsqhN3itzOMKYJPXYJ6y 1eLCsT8T13zbombmbJi8JmQcZTf6XnQ= Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-735b7028ca9so123154a34.0 for ; Thu, 05 Jun 2025 12:01:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1749150106; x=1749754906; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EvQGqFjBY2VQZAN4E6Y1iA2gvyPMQ+dVqRjn6svmGM8=; b=c//ilo4Fwj0shFkt9oanIuAqpXtmSnv48xmOFRrBMfolxcEwv75ltyQfqb4BUS+H0S fjqfNWq/Hbllbo9XMbqFJQbh9eKSLqoe4VTeuMFNtzxEKQ0MptW0auAH7bY4eH/kwUzV wspAa/E3/C/9KWEmtaJV7LQrO1IJCMNj+Nu1zs9oKM0EuJF0mCx3bkCMHxumuzu44w8d EdDeZ8GiOxa7pzm1vLdRMU76Amn/aZ1XbSGOz4Jta5RLr0PQQS+0l1h3oTl9ZobkRM4X kRx6L9yH/5lpuGNMHzmaT2WDiPSoKTf2YddSph1+Klgar0Z81AnzA3DFWqZ+N/Z+ZTh6 5ZUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749150106; x=1749754906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EvQGqFjBY2VQZAN4E6Y1iA2gvyPMQ+dVqRjn6svmGM8=; b=H1i/AGrMSn+PbL0Xz8q11m6XaxGq1QQfbC5ZhYXgi37TENo8jWCXjGPIclEWDCnSKI UhLjpWy/GM8ONBIqhhmpUVbPOdeti8OHA9+RkYL1xpgPo7ozHTTs7+iaMvpZ8dhCLKuI G4xPWJUBukU2ROYcS+q1UOjAVH9H1h5UtM172Pb3yLUfxTqItuxt8bF2pO4YCXlex8WW ipA4uk9ql0UaF9rRnv0x11bYR+uxa6u1Uqzov9r2pxqILOlPJuBPPIUewZ/zmaMeOGTY FM66FPM7hCCxMhsfZK4OWd+tIjumARVpI52D7ler+fiS/gORahUX/RjRqlTFKz+wLEFi y7sw== X-Gm-Message-State: AOJu0YyPmtwTlgtcL08dNmd4sX5GYt5ZxE5Xbhtn6hkWgAZlXwwjLxcp TeUbk89SZBVXqabOvj/MfHqic88aZmfZKrhScyMzzZkhDK8QbtzZRgRR2644xjoUQC/68eZBJtf xMnntonIw8vLWxyJLUgABgVAKpwUwNTX9P6qfxpldYADs8uDudFWkgRb4xKn4bZ6TIkwtG5ZwAf iof4i0CXCO8/kZoY508RskOuJ1n9kt8q03r+Bncg== X-Gm-Gg: ASbGncvz9vqXhc2wHJDUc/ZOeAAPiIRTQ4SMZIsgA41NaCiqnBcK4sVOF7YHRi27QaQ d7YorYddkmrXm0f2P1DQO2NReV3s/bj+E4vht4zRrgoM67OVs0FRXqrmQIOQ/PL3cn/Vl27JAbV GtWqVjr8PH7CXFfztxPKSxYRctV3jYdubk1IbXhrPJgPn8qkD69cnMf721Oa4eqqcbuQazc4POR GW3QVcXyZcczCJ0azR6DEB2N3x3wPr1AdFhv7HmBW/VMo86AVinmaPnSI/OIV35FUyW6xwXBahE 71T96S4GodkWggJu28iSeHvRwTHAvh1A1U2lWcGcbJYDs701uB3p1eI6bxglu20Re2fuL+hWcfO VD2KrEjSbBernAWCK X-Google-Smtp-Source: AGHT+IH6+hf5Q5QV+9s8jOTH8B3tdE2v5WYkE10k0eIS5mblZWZSqAElbAeEzRbws1Oyr789b1jOIg== X-Received: by 2002:a05:6830:6c08:b0:727:274a:ce32 with SMTP id 46e09a7af769-73888da1987mr158815a34.2.1749150106422; Thu, 05 Jun 2025 12:01:46 -0700 (PDT) Received: from dev-cachen2.dev.purestorage.com ([2620:125:9007:640:ffff::a1fd]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-7388a050780sm12967a34.35.2025.06.05.12.01.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 12:01:45 -0700 (PDT) From: Casey Chen To: linux-mm@kvack.org, surenb@google.com, kent.overstreet@linux.dev Cc: yzhong@purestorage.com, cachen@purestorage.com Subject: [PATCH 1/1] alloc_tag: remove empty module tag section from linker script Date: Thu, 5 Jun 2025 13:01:28 -0600 Message-Id: <20250605190128.2287011-2-cachen@purestorage.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250605190128.2287011-1-cachen@purestorage.com> References: <20250605190128.2287011-1-cachen@purestorage.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DE3B218001D X-Stat-Signature: fipopyjm8ky73e1o9zbasqcm9j4z4ch5 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749150107-182509 X-HE-Meta: U2FsdGVkX1/fKxnS/si9frxAqJs2SCji72ZGn51Z3NVlwHGp3G00Btl0h8aEhaiXScpJ9kmDvVPEstXQYyE2s8xu3T1Z/jF8zOk0aEOi6HW1kxrF12BrdCZdAvhDxmAq9JIHoYzu1FpKq5IH/4pjojKCdE99ZH4MUkMpoOA4kNANZhTH5GbJoYAoD5aPsK10vEfH2WxNXneA0KquAxIITIwU172tKnSWw9hjXPxpg+vCL85zOqf8ixKflN8rwcGlKa3+UZuBw/9WdYI37Zi7aVVL7ScXbOCEaE8hYzkFuNOomf7a2RhW9k+//LNpZLgTbjOJSaquFabeuPtvP4RTkBDal/VeqD1CVRMVNl0zupNVU+4Z8HBosFx+vfvjSZHVLPNOnVxgb/T+NSVFfKkkN8/x84r4OebFY/anidfT8/6C4yJZSoSDlI6WVN874t0qne3fSHjdAsEQx/Pp30fyvHf5vxRgvZi1j7gwRGn/EmCkKuHFfM5RuummkPpXLMvZy8h0rVm7AXnMeADm0i25uVuJPJ+CQ8Dx7suzgRlnXbIvMnyXNqRVXxJF7hDr/t2IuwQP1hW6IH2nyZMMDXEDUhQsB9hY3wlc//GyrQuCQB2bvZi+LbRJY4hLeTv7sbpEil4rtA4aD97jG/+57Pa6N8XUUiANoikkIouK23Z+yVkMfrjZKNvQtx00T5q4b86uqoMaFWwntX2FOXb1GJ+8N1hqzsN+4DjsI5FzTsT69TaFEJA69c2IDZqORZcaHVcrdmHIG5p2YUwf3lrobUyjWYIn9qL4sSoariJ9o+a7blCAguXgZhTaAe2GPWkrgrTjYTZ/IsR8o8igoh1fNJ1CuR6eHtV++bHhAmDCehEv75Hyt/jnzNGOvOQLZ+m4uPalJJWuunn4H0x+1HziAxfFehJ+ojAw+hRawV9df0+XvYhAKi8y86xz0sd1MZwLOYuAAnZosegFQIj6vw70e7T /YKLJEzt nEA3vtRv4VYGiCY4u65/YkJ1/tZ6tE9XngO521tTrWX8rkubZ4IF5w4Ttl4J6IVtT3Qt5ExUk+AuQEoTWfpiRBedhtn2710CmI9NPYtP1OhOe8D5khV/xxLVbvpnPuXfauASWR9hXXbrwxOlnvcymg4rwlAaG9Xc5Z6JBmagfXctYiHi2p67dR/xdsliscJBLOQAyUtyJO38mKhvHLFTCm8uo9i31rLlQ/blKiBt0oSlVfuYT2Dd+2GaEXdu/id00v0hKIUXol5O3uBdXzwSauL9+R6ikMf5bF9vVm8vIBLDI91fFEqKxcho4xnOz323bH/JKJZH/JZzBrB94EtyYG/czB/bEnxdHrSleLRn06eOPy3JJij7KuZdCa/x5oYXq6eCn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The empty MOD_CODETAG_SECTIONS() macro added an incomplete .data section in module linker script, which caused symbol lookup tools like gdb to misinterpret symbol addresses e.g., __ib_process_cq incorrectly mapping to unrelated functions like below. (gdb) disas __ib_process_cq Dump of assembler code for function trace_event_fields_cq_schedule: Removing the empty section restores proper symbol resolution and layout, ensuring .data placement behaves as expected. Fixes: 22d407b164ff ("lib: add allocation tagging support for memory allocation profiling") Signed-off-by: Casey Chen Reviewed-by: Yuanyuan Zhong --- scripts/module.lds.S | 5 ----- 1 file changed, 5 deletions(-) diff --git a/scripts/module.lds.S b/scripts/module.lds.S index 711c6e029936..c071ca4beedd 100644 --- a/scripts/module.lds.S +++ b/scripts/module.lds.S @@ -50,17 +50,12 @@ SECTIONS { .data : { *(.data .data.[0-9a-zA-Z_]*) *(.data..L*) - MOD_CODETAG_SECTIONS() } .rodata : { *(.rodata .rodata.[0-9a-zA-Z_]*) *(.rodata..L*) } -#else - .data : { - MOD_CODETAG_SECTIONS() - } #endif MOD_SEPARATE_CODETAG_SECTIONS() } -- 2.34.1