From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F150DC5AE59 for ; Thu, 5 Jun 2025 19:01:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A21D6B00BA; Thu, 5 Jun 2025 15:01:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 852D96B00BC; Thu, 5 Jun 2025 15:01:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 768CE6B00C0; Thu, 5 Jun 2025 15:01:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 54C246B00BA for ; Thu, 5 Jun 2025 15:01:45 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C44041214C7 for ; Thu, 5 Jun 2025 19:01:44 +0000 (UTC) X-FDA: 83522266128.29.88F98D4 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf22.hostedemail.com (Postfix) with ESMTP id CB716C0008 for ; Thu, 5 Jun 2025 19:01:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=MypNEaPz; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf22.hostedemail.com: domain of cachen@purestorage.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=cachen@purestorage.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749150103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=TS4EBHY4kpLodC5ODHnF80TpB+bXTaW3abjeTrFUCQg=; b=uOClWS1gBuR35t/IclI6UPjEbb6l1TULvniULSCxRsjcxbrlTn0s89Std0vRo0ESOhB+km hk4KYBtZaZaDgz3C5qaQLnehV7JHmqASbHugLhpLGS5MFwrvkXCuBYVcrVoVYi2H9M89go GACHGNsYqJrgzmSINL/kkH35TdyCWN4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749150103; a=rsa-sha256; cv=none; b=giPefd25KPqvjrGlI6+y9inKJiPAejrLoY0Zh+7e8yL4iy/T47qFrokb3p6iS9vlopuCed deeC+hBjtEGA0Os0LUucrRuFPo8UTa8eAjwO7insu0CgpLcgf7Ri4m4EvWuGcs8sv3jqjh cpDcyrdZ8j23O45KDR3jECE0kKQYF/8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=purestorage.com header.s=google2022 header.b=MypNEaPz; dmarc=pass (policy=reject) header.from=purestorage.com; spf=pass (imf22.hostedemail.com: domain of cachen@purestorage.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=cachen@purestorage.com Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-736eb213dfdso174064a34.0 for ; Thu, 05 Jun 2025 12:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1749150101; x=1749754901; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TS4EBHY4kpLodC5ODHnF80TpB+bXTaW3abjeTrFUCQg=; b=MypNEaPzKPnGXpkWsyID2gNW6vvW7GQTqdedHaRcqngxDat/9zsRPeYC/xQOzNb+U5 4SG6ujaVV7+pajv9rXyiNj1pGgMdiDDdBTt7o8PnT/9pSPxiCqxU52RDSO7bu01joDDf wHY13bijlXuCxyDjY/fOdauwRpOX6jQSKZEloFs7l1ff/X5gHE3BP5QJqRzi8UJji5d2 SnsQvXYriDq01yBaM/EwJ3nQWLKGN6KGwiTDINFuv9sPL+q8hKzqy3tJpXd/QxU2Np8h gOoESmVovWUQ1X6UdDGGK20bNWjxZps+AfdXP2vhpUzyBo76oGPhk3Ypg++rYxRc1W+y 2SkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749150101; x=1749754901; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TS4EBHY4kpLodC5ODHnF80TpB+bXTaW3abjeTrFUCQg=; b=Q8d3CkojdfX2ZR/dI0WjtcJ+uShzTH3xMZZZVNs3mUwcwk8VnSFTAacgpfSoqQ/UBu SjHCc73SjRxPp8XJdVpzFWBdRZGf2EBivPlFSSK0obOUWO2uQKnss+nAMNrfEkjqk3Y9 7hYnhe7z42QYnwxkpR2b0FHEsB8pa6huHL+DeJn/reTf3XWUDwuHop9SbXLCwFS5QeJP koRYYr+kcQZWHT+9URavnGn/ahb6NbfP4j4gJE7Orzu2RhjMeHcj9NQ3CYGWhHKlAhyd ryt7biQ+Z4WofQOueN85Qcw998jzrrw8sgn2w43X15lIPuQ7yKbpYkF3+J44LseTPT16 4lDg== X-Gm-Message-State: AOJu0YzUprXlhxM8JQ433Ae8kyBzpatX6U+BT/EGz5bqno4eoQPcCMqZ 0PRYb2o5KUJD87lCRcl/sy6hs9sg0nz58ejd591mCJgctBQuGGtbJPioRNJFsghBSYqO4OVDpKn bp7XC+Xf6+tYObifBUmW9B2NfocRrU9MSwhBYbstf1gfDXdepWzNN7z8twktcDVrOq4t0iTjU1a Bn/pxSiC80pnYkuCAYO2HkrzPGuSIMx2jzHqz+Mw== X-Gm-Gg: ASbGncvKv1juGDe64v07UsuefeJxT7YtIF9amJsd37qu4rrWEGiv0bWnwscvpJM1VqG SEmSSVrbCNdJeQtmHQ9bFYtoZVLgwe3eoU7bGMOv4NE8dLksthMX0zbVaaMTRr3uw7ZpT4gvJCi F/C7Qm5fm51IERO2C8FFMebPr7eU6HtJ+i/gzodWnE6aPN55bfLqbgxYWRWphScuwCAkuNTTYge REPbGJM6L0g93DJf14aAZ+nRhY4SOhen8vMauiX+Q1R0Q0MMCHFANw+ns9dwNLH+CUiTqI8lwiW JFQwdE2b+PhY3igDo+c55NM7i0644HcEZ1/EqFoPgoMhkRgz16A3Pgb03rIdHXT+/qzXl2Y= X-Google-Smtp-Source: AGHT+IE9Ay5uGRzRttz2Vns1Dlnwpd8maniDWjAa/bUNpGC7zA8gFujXniJ+9Vs8YnxOl0tBb77IEA== X-Received: by 2002:a05:6830:6405:b0:72a:1900:59f2 with SMTP id 46e09a7af769-73888ed1cd0mr168488a34.3.1749150101268; Thu, 05 Jun 2025 12:01:41 -0700 (PDT) Received: from dev-cachen2.dev.purestorage.com ([2620:125:9007:640:ffff::a1fd]) by smtp.googlemail.com with ESMTPSA id 46e09a7af769-7388a050780sm12967a34.35.2025.06.05.12.01.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jun 2025 12:01:40 -0700 (PDT) From: Casey Chen To: linux-mm@kvack.org, surenb@google.com, kent.overstreet@linux.dev Cc: yzhong@purestorage.com, cachen@purestorage.com Subject: [PATCH 0/1] alloc_tag: remove empty module tag section from Date: Thu, 5 Jun 2025 13:01:27 -0600 Message-Id: <20250605190128.2287011-1-cachen@purestorage.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CB716C0008 X-Stat-Signature: st7fank4j8fuy7ny4en5pwss9ppuhft1 X-Rspam-User: X-HE-Tag: 1749150102-304103 X-HE-Meta: U2FsdGVkX182K0AkeNEAps0eiBcFH0+gqPYx8F6/VdjQqA5X0OW90zPUQ4n1X4uYDFuIxbzGaS7w4hHb0Yau9HaJMBiLLl+bJbi4QSj0EAcsBReu5ylWEIKIm5nkik1A7PmxhfyU/yhphtpxT4F9pPGLKbR2rnUPXzzOMwb9LKMeqBLv6UDkW/GVyKFWdjCp583uq5S7dgNO/vGYgYHt3s3QWy4drim1Au7MGTVeRSO2mpFaZFor2pB7btNoAy3ZCv7qQw1wSUbRAlrIICNqpGCiJUhWdIDNWevz/CHLYIWXJmaHOIsvK8/zMcfeSr97r+dqUnHvQ9lVR8VdXC6YW6trt37VMr8OJDwX38J2FZN87zuPVBnu2/0Yx4w1bn8ygsHXVtjsYBBoiin7m3b/ANvTQ62j6kgzYwsjaxSS1QhPmBQvYqgZOZlVfQBZzkkCkAmS5U6wnAIwwB7fAzPmDwWKlxZ5AWFad+cr8YTUjeLtfNiyxdtSlQ+JbERA+zuqJm3RMRrgQdQ3TlvAM6uUHyBnutxTEwNN8gSXRpdjEbxhA1H32h3WCme22EEAMhqnMXyBWUnFOv9j+1B6R8S6HlPsZjteOrJyPCzKEtRw1q4nHBNPI/qC/97ulJj/vH7Riu/fLjq9N+6lryKLW7T77W2ICWB79TDiArKm7exP0TwUEH/us02AGF0sDyvYnpRYbq2NdmXGOWLboRWp/eCEp7x+7m7WtuCvBIRrjr9MtwIJyvxuuxZltcENnURXj3uMNPfwgl1YVcR6D60Ug4Ws+7Mt0Hildtnflpbw/Y7zy/BAQAGS6WIe9mMWrZWOLEWKfEo+l+Yp7aaW5SnKULnPOF7EVkGu/PNXyLWH4oEpovcXMAtWZn5BiOZIxRcsCqVVFi52HohcXWLP7Xc+G/fPVcIQRseIkWInSUlweZwVQzeImYMJRFtRgiQrs67V0ci7Fg/xlKbdHrrUdlLcmSf RpwBoQ3h gcBgakBLtZPkdVTj53av17EMk5W+TK/iWgEYT7lS8l555rpmeSVP9rvmabp/q5soFCvYVYfu6160MP5eS3SwXm7awXk+17lWPLvnyc+QF62dvUgoKluFQWiYoQYonul6QjihOEdVwTg5gT4gTd2N5/RE79qCu0lSnzteygVCwEOgdSoEY1UcEilXctnhVAeA8oURBVVMoIa0WvHkUUEYrluVWBpUokvIG+OTd6Dbl5Es0tm8el7pHonBLYIvlwyg+QF5BtWbaSYubvqj7KYPr3+ua378AqwyESbu91AxGD0SmTSciTEZA3piGKMEohfYUQr2E X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We found gdb misinterpret symbol addresses e.g., __ib_process_cq from ib_core.ko: (gdb) disas __ib_process_cq Dump of assembler code for function trace_event_fields_cq_schedule: ... instead of (gdb) disas __ib_process_cq Dump of assembler code for function __ib_process_cq: ... The module tag section added by the empty MOD_CODETAG_SECTIONS() macro looks suspicious. With and without the fix, .data section placement looks different: Without the fix, .data is placed at 0x300: Section Headers: [Nr] Name Type Address Offset Size EntSize Flags Link Info Align ... [51] .data PROGBITS 0000000000000300 0004a180 0000000000004a20 0000000000000000 WA 0 0 32 With the fix, .data is placed at 0x0: [48] .data PROGBITS 0000000000000000 00049d20 0000000000004a20 0000000000000000 WA 0 0 32 My gcc/ld/gdb versions are as below. $ gcc --version gcc (Ubuntu 11.3.0-1ubuntu1~22.04.1) 11.3.0 $ ld --version GNU ld (GNU Binutils for Ubuntu) 2.38 $ gdb --version GNU gdb (Ubuntu 12.1-0ubuntu1~22.04.2) 12.1 Does anybody have an idea how the misinterpretation happens ? Also I don't understand the use of MOD_CODETAG_SECTIONS() very well. I am thinking it is for some future use to have module tags whose lifespan is same as the module. It is empty and shouldn't cause any issue. Casey Chen (1): alloc_tag: remove empty module tag section from linker script scripts/module.lds.S | 5 ----- 1 file changed, 5 deletions(-) -- 2.34.1