From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30B53C5B543 for ; Fri, 6 Jun 2025 01:28:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9257B6B009B; Thu, 5 Jun 2025 21:28:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D4F06B00D1; Thu, 5 Jun 2025 21:28:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 811A06B00D2; Thu, 5 Jun 2025 21:28:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 628E06B009B for ; Thu, 5 Jun 2025 21:28:06 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00CC3C1C2B for ; Fri, 6 Jun 2025 01:28:05 +0000 (UTC) X-FDA: 83523239772.04.0610D62 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf21.hostedemail.com (Postfix) with ESMTP id 5A4C81C000D for ; Fri, 6 Jun 2025 01:28:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Q0mAeVB4; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749173284; a=rsa-sha256; cv=none; b=sQtvm6d09BaI5KurmzKfW5r2iWy1WVGxbg+iwQdG/tOmvJDrSOdyD1p5yZ7iKtnH7GsFyZ fmxmX2w4QbD0YcRNrMreuIVzH62KvufOjdODPnWxAtwQ5Ux9Bn4AHVeLWHCsQR0legJTSQ uXCnHFU88PNLwCa50xNO8/f2L1Ms4qQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Q0mAeVB4; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749173284; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YTPJVKBECFEAZ0kx+Ui2PpkfFNL5mNxOjfGunpIqJmw=; b=zgQuzd1bByTwaMWG/QRIXgWMGp2kqwFRKliMTHdPWOQoUK1HanR5EaVh/2IULIpYz/RDoZ iRHg5777i5ERXVtf7BEZAROCeiaeMPThmCEWYmGaoL4gOH+AJU2aRlU+w4/Dk2AAWhubwN grV8HpDk35E82apK3bKiVd81gIG8nj4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 867D76154E; Fri, 6 Jun 2025 01:28:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0659EC4CEE7; Fri, 6 Jun 2025 01:28:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749173283; bh=0iKrL/n+MLFh0pCCbTB9JGw89j/b/nhbrgaZzkAxMu4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Q0mAeVB4rEePRqck8J74qLvSR6giowX04BXsAcszmK9avuglxP2sgBkaCq6ERXmjv CchR7WWg5EpKpXVNiJL9jtqfeKRaExqH7v8LJlCcRVdQjyHiNZ+0pKNTlVQ0343V1B pRYqZYbl/lNk1iivZ3+i+BNDs3RxKVGdSx6GxkEo= Date: Thu, 5 Jun 2025 18:28:02 -0700 From: Andrew Morton To: Kemeng Shi Cc: hughd@google.com, baolin.wang@linux.alibaba.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/7] mm: shmem: correctly pass alloced parameter to shmem_recalc_inode() to avoid WARN_ON() Message-Id: <20250605182802.ec8d869bc02583cbc9de9648@linux-foundation.org> In-Reply-To: <721923ac-4bb1-1b2b-fce5-9d957c535c97@huaweicloud.com> References: <20250605221037.7872-1-shikemeng@huaweicloud.com> <20250605221037.7872-2-shikemeng@huaweicloud.com> <20250605125724.d2e3db9c23af7627a53d8914@linux-foundation.org> <721923ac-4bb1-1b2b-fce5-9d957c535c97@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5A4C81C000D X-Stat-Signature: gpysj6ykj8tpcse4qpximm51r1xan867 X-Rspam-User: X-HE-Tag: 1749173284-228288 X-HE-Meta: U2FsdGVkX1/lvvKTD6yjS2uoQHdZIY9u6jBHuGxop0Cyc9otztZak5cp/D5nwPoBMz+ET22jSzySKg8xzhBILRC0FH2Pf1zJbTK5tP4aNPD9f79sFyq6SCTvJztLW5Ga01IQCC6SkbvG/++YS4gSXBkyIfiCMUd6uFVhHwxH5QIDFhhMmgbcss8azSTSea7LkjU0kEN5t8hX+rvdSEXrsNN7m57UrXt+7arSiudA5xFkr8HqJnoNOzEOYjczT5hyEO/r6idh/VjT0eCK74VQ1Pgz/djdxC9gbxDG2KSySPVO9lXQZz0ATsseR35VenfG5CBIXixeXtUV9+9O82OIBWe088fCBlhL/xwTLnK5Lx9m6O02XGcar32fTSXB79FgBEAWmovHIdtcyEto3TvPSWB26CvxqEmcmYarKL7BruYmknloNwUQXiYLXfxaK2vohppAQcIjdu6TwwvhijTDQrsNtkgb9Vd1+WjtoOQtC6aVGQWVwjeYFT4bbjPNbbuIkYJN3aI/iuXBFrNG9a25NZzuYw9fPflSrEOdGjQLxgqqyahYBaQf/B1Xyox1B+F8lNqfJxay5tUjC84WYWVfiA75uCidlXgQIf+BcUHnjXTIw8i8qa5BY2Ahl1xMhqNWR4KKrHkE9oArQli8ddz2fu4sqyotNmZNiDPCxlOSE02LFE/gDT4OnGI+gUuO84/bWhSzo/XcQy3hu9l52SOm3y/5QHWFt9SH8MqRj1bZZPKBJFA6LNx+BYDE6VLwWM0H6PVoptYe7KysO9A9r2uHALz1Z8G6AstW0GsaxU/ivwKF710HDnyTouJR79ljyPW2RLx+BalNVFcyH4GXhIMtEcb0aigWsm67rVjrtXgmpT7wL6Zk7VikHaWtx5hsAgEfqBVsugaJVjgdhRYCd7doMyUrgKCnrU9HJLOBVXOHlFnrbXa8uHiDZu0XXSJ3uyq/WZbbgOSIWio88e31FMR dQuNDPcs EpD1xCv4mBKivxI1mO0szkcE5HT6k2iHjx7ThQrk2nert2U9DHpJdnoImFPG9dGDjbKQvwMnZ3/BgDcQq74dtrHu5nXziED45HhyInaGI+R2yQADED7grI0lNzcUhlaO7buTDFoscE9D7izEkbvCiwYMnOGhUbpbgXvT+wVdMyPjdoHUR+fIKCFy2WC1CY5RD2c8elkdCYoDGTZJVBi23jjSUuBZrShvH1e5YfMKYYr8OdZoRwuM3wxqYcxV3A4E8WiYV1PDpwMSJU2imzgiYO6BoVSpHOoKkg+hJ6rUCpH3UOiRW7VFOKGoCHvgrN8tqQyVE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 09:11:37 +0800 Kemeng Shi wrote: > >> --- a/mm/shmem.c > >> +++ b/mm/shmem.c > >> @@ -2145,7 +2145,7 @@ static void shmem_set_folio_swapin_error(struct inode *inode, pgoff_t index, > >> * won't be 0 when inode is released and thus trigger WARN_ON(i_blocks) > >> * in shmem_evict_inode(). > >> */ > >> - shmem_recalc_inode(inode, -nr_pages, -nr_pages); > >> + shmem_recalc_inode(inode, 0, -nr_pages); > >> swap_free_nr(swap, nr_pages); > >> } > > > > Huh, three years ago. What do we think might be the userspace-visible > > runtime effects of this? > This could trigger WARN_ON(i_blocks) in shmem_evict_inode() as i_blocks > is supposed to be dropped in the quota free routine. I don't believe we've seen such a report in those three years so perhaps no need to backport. But it's a one-liner so let's backport ;) And possibly [2/7] and [3/7] should receive the same treatment. I don't think any of these need to be fast-tracked into mm-hotfixes so please resend after a suitable review period and include the cc:stable on those which -stable needs.