From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F55C5AE59 for ; Thu, 5 Jun 2025 17:30:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 821B36B00AD; Thu, 5 Jun 2025 13:30:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B0246B00BD; Thu, 5 Jun 2025 13:30:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 697ED6B00BC; Thu, 5 Jun 2025 13:30:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 44BFA6B00AB for ; Thu, 5 Jun 2025 13:30:35 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 07FCF141074 for ; Thu, 5 Jun 2025 17:30:35 +0000 (UTC) X-FDA: 83522036430.06.2E5ED26 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 1BC061C0019 for ; Thu, 5 Jun 2025 17:30:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pbyo5MZw; spf=pass (imf21.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749144633; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DTpTW2nIC4902tCIzfelfKD0ln8h1LJjLK+MmPY4A60=; b=HA787VaKvRA0kbH1J+FsYcb5YVaeL8KqwQbZxTakXiPWFyTGrNmDI3XXUBJCabkVho0wkD vbv5UJdtAlE2TQfa7o+BSxprBEJimEMpN/M2O0O+ag2sT5l7sz+pUslf/c0qq6cBBemcsj G72ONbqAFo/SPFaEo2V00eScBwYL/CY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Pbyo5MZw; spf=pass (imf21.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749144633; a=rsa-sha256; cv=none; b=sjSQHQ8eQ+D0ounP2osNRO0XiOm9Y2NYEg5+JMlyuUkwAORWlkru1924ThqImGhCs6HqPi a97+Zm3/746kNMELJhJS0oVNJshheUdoWKgAomC//oeWOKAK51jjpo0MW1B35XqCgk8l/I 31EfqmfryTi2KRgAO0vBoHL76W0VvIc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749144632; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTpTW2nIC4902tCIzfelfKD0ln8h1LJjLK+MmPY4A60=; b=Pbyo5MZwr3s2Mzy6lGpm+EI7p7Pdpb9WI4H+UNs4H5lJ36SRvSFNzGX2Nogk2u4VW3qY95 48rLuKjXQjdWti3+UR2rG7E2nSb8hZAqXaXdxhnyROnxKZqL4r1JlpQxk1pAuEP78/Y5x5 JQOOeHpr8qJPbu7IKd7uJYgxBIEy+5Q= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-KMfKJ7yiOuWxhR-EamJ4nA-1; Thu, 05 Jun 2025 13:30:31 -0400 X-MC-Unique: KMfKJ7yiOuWxhR-EamJ4nA-1 X-Mimecast-MFC-AGG-ID: KMfKJ7yiOuWxhR-EamJ4nA_1749144630 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3A856180036E; Thu, 5 Jun 2025 17:30:30 +0000 (UTC) Received: from bfoster.redhat.com (unknown [10.22.88.123]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7F63C30002C0; Thu, 5 Jun 2025 17:30:29 +0000 (UTC) From: Brian Foster To: linux-fsdevel@vger.kernel.org Cc: linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 2/7] filemap: add helper to look up dirty folios in a range Date: Thu, 5 Jun 2025 13:33:52 -0400 Message-ID: <20250605173357.579720-3-bfoster@redhat.com> In-Reply-To: <20250605173357.579720-1-bfoster@redhat.com> References: <20250605173357.579720-1-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Stat-Signature: wy9ddmaeswtowbmcihaahtq1xqpe79yf X-Rspamd-Queue-Id: 1BC061C0019 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749144632-324886 X-HE-Meta: U2FsdGVkX1/KOjJ9rfSdf2CW/dlmt4eHqyEdQ5ccZA3usPLGnjLZ/4kut6CuU2qFVGM95w8rplVsdIQJbvEI0Njxw4GcrMNeYpQ6tWCXgGhinn1VsHc4ffFxcbbVwPBjR8Z/h4P31phb8aL77EWt6evVJvKFh4X9h1AZQ88p6m7XW17zuuY3scxcCOeX0KWf3o28rtO/oe6+77l3AF5r/fwSTbfAZN97Kc4vu0aWLux09GoLjuOJd5vt8mFu4tKx6FO0e6FqUpTDlp0HmA88UfS1WwVX1nHA/tpnz5RrSn9DWYE7aIU7bmXhccncxkozU42NRToDScLMSWWtn0PuaoBXm0xEKb6ItHM7QypZ8MTYB+DmfqLfJYi7Uby/JAf7vtK3XflKOihQPpBiM8e071+qeBXCc87y3oAMggRCPrIQWLtb+NVOJ8x/lhe62by224eJJg/SB9jtXn/7HSRCb14lfFC2D2lOieZIo0yzZ44aETh3CAzQyQB5th85mr8UI3UPKHOUQTz4mIE7nUbF/QxeuH99/FJ74aZE+pveyH6n1jj3nY8w83GgMqBBr8Fg/GjuegMAGzP7KhaIWZ2UMHKsTbPxhLCsg4pAOTwKt1uLvrTOEx3Cu3lIn0Srs6m8nIByayGLcCiccHKHXnLjQa7w+MglKwH/mLAMsC7xNeP5WNWCT9e2JEjFr5KYG4iQoUC9FhiiCJtzTlLk212ieLSqDfKx1eRuKzAtGf4JcecdFEqfR3XnN2im2n2t7dsgU5qKjwNE4XKaopUUMBDqYNyxep8ixEbN+0ebSHV0Nw0OdRwMd1Br1/xVtPh6+3OKs2vJSMjNpk7VPIcCsbxFscZhh+18K9JGD2wWGNqm278AepG2/GMYcM5SskYm1YI4TPHglU3VrTQknDN2OA1tYpVaHLKj7U38aB0Zn6DF0wpu0MHX6jBDaP1k3MJ154jgXDfI+tu1Qcn/+tpzbdC qIg6DQWr R7GoiiCXPDNl+m9Q0EwNxvtrVxz/RkxM3R8/T9O6rW6ODTJ9V1DCoI3mBOs8cBaYUh5SXM2fXrL3pVVNRzf6peaUx2IXcX405a2jnS+l3Z+sNE8/GCtuZSuAHx2sX+ZaGOmVk1nN3Fqja1cN9PjA2on2pcIRVzhm8yjRU57N2jWv5dJSZAwER8ed/fNdBY+2HG/9SXuksV3IQP0PiljDV4pGVM3qshVdT5ouBn7Vgcs5BT+oZpl3Ex50/CgdeFew86zkpOpgruavW988zQMckNleYvcnXz/rgjOqt2t8VrSITr8CdNierB7WtTtNrT2f52AJmaYZm8wPonEY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Add a new filemap_get_folios_dirty() helper to look up existing dirty folios in a range and add them to a folio_batch. This is to support optimization of certain iomap operations that only care about dirty folios in a target range. For example, zero range only zeroes the subset of dirty pages over unwritten mappings, seek hole/data may use similar logic in the future, etc. Note that the helper is intended for use under internal fs locks. Therefore it trylocks folios in order to filter out clean folios. This loosely follows the logic from filemap_range_has_writeback(). Signed-off-by: Brian Foster --- include/linux/pagemap.h | 2 ++ mm/filemap.c | 42 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index e63fbfbd5b0f..fb83ddf26621 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -941,6 +941,8 @@ unsigned filemap_get_folios_contig(struct address_space *mapping, pgoff_t *start, pgoff_t end, struct folio_batch *fbatch); unsigned filemap_get_folios_tag(struct address_space *mapping, pgoff_t *start, pgoff_t end, xa_mark_t tag, struct folio_batch *fbatch); +unsigned filemap_get_folios_dirty(struct address_space *mapping, + pgoff_t *start, pgoff_t end, struct folio_batch *fbatch); /* * Returns locked page at given index in given cache, creating it if needed. diff --git a/mm/filemap.c b/mm/filemap.c index bada249b9fb7..d28e984cdfd4 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2334,6 +2334,48 @@ unsigned filemap_get_folios_tag(struct address_space *mapping, pgoff_t *start, } EXPORT_SYMBOL(filemap_get_folios_tag); +unsigned filemap_get_folios_dirty(struct address_space *mapping, pgoff_t *start, + pgoff_t end, struct folio_batch *fbatch) +{ + XA_STATE(xas, &mapping->i_pages, *start); + struct folio *folio; + + rcu_read_lock(); + while ((folio = find_get_entry(&xas, end, XA_PRESENT)) != NULL) { + if (xa_is_value(folio)) + continue; + if (folio_trylock(folio)) { + bool clean = !folio_test_dirty(folio) && + !folio_test_writeback(folio); + folio_unlock(folio); + if (clean) { + folio_put(folio); + continue; + } + } + if (!folio_batch_add(fbatch, folio)) { + unsigned long nr = folio_nr_pages(folio); + *start = folio->index + nr; + goto out; + } + } + /* + * We come here when there is no page beyond @end. We take care to not + * overflow the index @start as it confuses some of the callers. This + * breaks the iteration when there is a page at index -1 but that is + * already broke anyway. + */ + if (end == (pgoff_t)-1) + *start = (pgoff_t)-1; + else + *start = end + 1; +out: + rcu_read_unlock(); + + return folio_batch_count(fbatch); +} +EXPORT_SYMBOL(filemap_get_folios_dirty); + /* * CD/DVDs are error prone. When a medium error occurs, the driver may fail * a _large_ part of the i/o request. Imagine the worst scenario: -- 2.49.0