From: Steven Rostedt <rostedt@goodmis.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
linux-mm@kvack.org, Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>
Subject: Re: [PATCH] mmap: Remove unused events vma_mas_szero and vma_store
Date: Thu, 5 Jun 2025 16:56:50 -0400 [thread overview]
Message-ID: <20250605165650.7b0270a1@gandalf.local.home> (raw)
In-Reply-To: <20250605134910.fa50aabe5b0c13c11f6c9178@linux-foundation.org>
On Thu, 5 Jun 2025 13:49:10 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 5 Jun 2025 16:19:59 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > When the __vma_adjust() was converted to use the vma iterator it removed
> > the functions vma_mas_store() and vma_mas_remove(). These functions called
> > the tracepoints trace_vma_mas_store() and trace_vma_mas_szero()
> > respectively. The calls to these tracepoints were removed but the trace
> > events that created the tracepoints were not removed. Each trace event can
> > take up to 5K of memory, and it is allocated regardless of if they are
> > called or not.
>
> Thanks. mm.git has an identical patch from Caleb Mateos
> (https://lkml.kernel.org/r/20250411161746.1043239-1-csander@purestorage.com)
Bah, that's why I didn't send it out. I just noticed it in my queue. I
forgot to delete it.
I even replied that I was going to send this and found out that it's the
patch that started everything.
Feel free to ignore. Sorry for the noise ;-)
-- Steve
prev parent reply other threads:[~2025-06-05 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 20:19 Steven Rostedt
2025-06-05 20:31 ` Sidhartha Kumar
2025-06-05 20:49 ` Andrew Morton
2025-06-05 20:56 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605165650.7b0270a1@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox