From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C898C5B543 for ; Thu, 5 Jun 2025 15:39:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EAA206B00FB; Thu, 5 Jun 2025 11:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E06EF6B0342; Thu, 5 Jun 2025 11:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C56B96B02D0; Thu, 5 Jun 2025 11:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4E53E6B04B5 for ; Thu, 5 Jun 2025 11:38:43 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 11497160DAE for ; Thu, 5 Jun 2025 15:38:43 +0000 (UTC) X-FDA: 83521754526.08.64E1B0A Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by imf21.hostedemail.com (Postfix) with ESMTP id 2E2B21C000C for ; Thu, 5 Jun 2025 15:38:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gEdthQR2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3_7lBaAUKCMI1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3_7lBaAUKCMI1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749137921; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tWQAb+OhtwbC9L7HmigdO6nKvxjGiiyUfyog+Pwa37w=; b=LevzG+PNou2npWLX66iikIyODjYQWAX90DNBjtTAlay7JeaEgKaXsWlCWKSDRaxvpWhy2L V6otAjkWIFzMovUQUzXjQlVLjyeyhpCeLiVVzE8xjzTJKQ4AMrilTwWR3w7szzpQ4wIJoX FeeYOu2jfU9rQdeEO4NHA1pa5hZyovo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749137921; a=rsa-sha256; cv=none; b=cvb4kYa5/rfU24nAqWnDsunQ/raav4AzWkLY982BfIASYrTJfFklsJh4LtvopLUp5JONwC f0kYXb9zn2RztRa0kvnSuiNwcEBuPJ0tMKA5NUQH5zEeffqVP7onc1rpkLguKVETZfz67Y WDe9MsAcQfokNUVqbK0nJNjI1nzsCtM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gEdthQR2; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of 3_7lBaAUKCMI1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com designates 209.85.128.73 as permitted sender) smtp.mailfrom=3_7lBaAUKCMI1ijjiowwotm.kwutqv25-uus3iks.wzo@flex--tabba.bounces.google.com Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-451d2037f1eso7202935e9.0 for ; Thu, 05 Jun 2025 08:38:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749137920; x=1749742720; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tWQAb+OhtwbC9L7HmigdO6nKvxjGiiyUfyog+Pwa37w=; b=gEdthQR2fCecEM+pTrvbVJs4maF3x9Hn14xbCZ/Iu+oQy3fykIS1aq9XVxP+ieQsHJ Wy6/1zn5TKow6FDGbsAx52Xt39h9nS7wZOVabTJacaHy8G3BK8F2y35exPsemcybeKmW aFe7n08eLi+r+aiN+SNnmRinlaL1HvirLOe8RQV+e55a30Ie9GtbcQhuRdfGAqwwfjOM IVcjMKYumqjT3fRSmD6DjE4zCID1vamM3FEXWUJaG9wSMNo+9wJ1NXn2BPIAxY3GNeRc 4TRB+th7/8TQ5vpTd7GyS01r+4TpsCm5HMzB13m/vcFimZL4bfxBf5do3j7T3uOIE2N6 J8TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749137920; x=1749742720; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tWQAb+OhtwbC9L7HmigdO6nKvxjGiiyUfyog+Pwa37w=; b=YxTGqsnClEjVWfY9SgZh72kj2cQoETXWKirzZ7sa9M9MZlzG03DhdZIH0wmuY1+G/j P8d5r4xBxAvBaU/wFhtk2syaiVT8+GzxfybbjNNK6D/j2M+M3PvY0035KDDaHdkZ/9is RQA4HR7bSrrqQWxKnuIfZ9vdi2hqa7gaSAARp/GPLUrlZxYiiwhGx7iYJOi65nx3z4b1 1TsyCRvy8zZBlr3Mum68PbCjbTflSCRV9cbHrDRZ9o9mANRy47etUYyFqwtiDQ9sfRD5 UqHTIixg68oO4URONNxykKq1GcAaCT1W4mR7zvD/kRsUUzmr1FgfMClBz5Ya7umfe9In SNIg== X-Forwarded-Encrypted: i=1; AJvYcCXRuyr1ZU0Mr7ejG5u0Z6hv6nxSbOMX29T2Gz22otIjf6WMvwM9/vE2zoFFTS+0OjpuY/e9mgnFGQ==@kvack.org X-Gm-Message-State: AOJu0YxohW0bHS7vt5JAmxGzk4UCbatnv7vHmCkjOScLujJSqVpePpdo kTJ89HBMNMjeKTPBnlFX2Fwbu/Wq6idBdJ2a0+vER4zZzRDP3rtshZr3rp5hbEteW4w4dJVki7L GwA== X-Google-Smtp-Source: AGHT+IFuj5CmSrtXXuibWgxj8Zl72fdGCc2PqOrRdrgbjdA20Vn6Biy8RRbmfj7vgficiAKB3ZQs9JV+QQ== X-Received: from wmbay34.prod.google.com ([2002:a05:600c:1e22:b0:450:d398:f3ff]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a5d:5f46:0:b0:3a4:eef9:818a with SMTP id ffacd0b85a97d-3a51d966588mr6513471f8f.27.1749137919767; Thu, 05 Jun 2025 08:38:39 -0700 (PDT) Date: Thu, 5 Jun 2025 16:38:00 +0100 In-Reply-To: <20250605153800.557144-1-tabba@google.com> Mime-Version: 1.0 References: <20250605153800.557144-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.1266.g31b7d2e469-goog Message-ID: <20250605153800.557144-19-tabba@google.com> Subject: [PATCH v11 18/18] KVM: selftests: guest_memfd mmap() test when mapping is allowed From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2E2B21C000C X-Stat-Signature: b581p1fa3hu8icnp4f6zkdp9kzfpzrun X-Rspam-User: X-HE-Tag: 1749137920-962913 X-HE-Meta: U2FsdGVkX19f9I7+d6ztqQbINuqaxWLWeHOH6+xNXj/4hp7430f2YpnIvHBbA+1EtXcXbjSM5nHDLyBj9St/8VMfJ1p2l6ql04dECaoP/N4QKgxeI6r5R5C3XLv3iIWe7M/Yt0XyDXe2KxEcv0/TenEHQgdKrhw7AKPfFzDh2tCcpW4Ua3GcHkaVHqJ/COH9k78kXcPU75iR9c6GkayJpEhdUmInRxRNGiIYNVhWCQgkF0KBtormnEJlDQM4nQmeUsaSaDHNzy+V5Kg8UktZcDulv3L6qsp+euNqb/Jwp+Wmtzi6E6Xlr8ROfHA2hJjIDcm5LPsDUTw5tkcqY7DufGoJG3PV77eDHgIKIKR7A39wHXWLkNRZEKuzsPApgZ7dYICdNNhBJVfl8WW8a3azr6usVh1mn83EBivragx24+47216FGTmYnG435IiSmLO0OYDwvbUuovV4CK1/R73c//U9IKMGBJi4dzgqw7ZVnfGBaIvsDBrIIXTCUf82nfFm8f62xBxmgBI3SZJLX93Wr8TTQzKm9hrw59Y/7mwWMoUsKiuNzkR3jylkBxrPV4PIrayp/+XxOX6OsQwytpzsfOMw0Ah6Z6p0lx8s76r0T/HOc7XphSvaLx6qWWZLfrKeWJ8I3HCw9RNe052B0bD6s4NpsbMvCwYIXXEosJ2kMW63IRm6Jz8KggNKOhyDDka4iKNnYlhdS1UctOLvzUpPKnYp8s6RZkQTP5cu1jDwzepJQZrVB7MhFiSBZQQfcNAcxuEJrLs6W05XOxB4De+UkPN75qJdeq8TM54AvRHiR3koQ/Q5rMPxUgCQgQQGxxVBziIluCaLhgMri/bCM+d/K+s4EWEQosS6y3W6FD0IoZI+U9sS9EDqjz7sVGNDN+Z1mg+m06MI6abvENBXE/m42XIXf3wtPIPdA3wQWBWcTgJeuNmD7kAdepv28dSNewchx1wmwDx3/eYuyGtmiwz qaCClo8X 9nf+uAkuPm5i6V6wDVSO+mAwYhS9m+DWCOVp8o35DZo0wLYufeTr3BmHpKeZSKHci4lmFQcJkuS9MLSLBkvMyAHi7tsD6kjvSKDBafAutiqXcmnDKf756eJzpOKIEPi4SdGC1UUsG2KEfb8xLPneHqVaqjLP1eaEHp1U+aVSdKyHW+48tZOc+HZE3yYDU6YKF+LWqubz1qooXOgeq1aPtlrYYiHiF7DaLEbIcmDTwdX5H4r26EvzmNSFor9Kpl+SbfDS9jNCAEjpEqIl4lQWbuCIW7u5CCP0UMFHBt0Ce50FO2ENuwAQQfArXTlIGmjbTbU3lXp99AKGMCH8hGcgDDjq+2PUyR0xtHU/L/eEjUPaN/fARkbQRshqSDXq8YN3sDLfmRLhw0DTlPdPMfkUqB3lxb0htIQweMc9IzhLMRemPwqYzIjZ8+ZYCJ4XDPak2Sw0Z+F/+4kNlxPCNHEQIPCMhnYgdkR2gGgNndH7C1w06bIQVCdSsKomIxydlMGgmTAejwXnhyOqxgdMhFuCylJjqNi2a8oUj8mdRiGO52GZBJQ4hbjvPU5gkwC507iJGEMI98FNXKDK5qCjfGJE/kxANWYf63Z9rcR7W8jGvYdA8clPIrZKZMrDUNlmyDJ4Jow4pKf77YsWYRiffcrtv9gqPlA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Expand the guest_memfd selftests to include testing mapping guest memory for VM types that support it. Co-developed-by: Ackerley Tng Signed-off-by: Ackerley Tng Signed-off-by: Fuad Tabba --- .../testing/selftests/kvm/guest_memfd_test.c | 201 ++++++++++++++++-- 1 file changed, 180 insertions(+), 21 deletions(-) diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index 341ba616cf55..1612d3adcd0d 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -13,6 +13,8 @@ #include #include +#include +#include #include #include #include @@ -34,12 +36,83 @@ static void test_file_read_write(int fd) "pwrite on a guest_mem fd should fail"); } -static void test_mmap(int fd, size_t page_size) +static void test_mmap_supported(int fd, size_t page_size, size_t total_size) +{ + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); + TEST_ASSERT(mem == MAP_FAILED, "Copy-on-write not allowed by guest_memfd."); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmap() for shared guest memory should succeed."); + + memset(mem, val, total_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = fallocate(fd, FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE, 0, + page_size); + TEST_ASSERT(!ret, "fallocate the first page should succeed."); + + for (i = 0; i < page_size; i++) + TEST_ASSERT_EQ(mem[i], 0x00); + for (; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + memset(mem, val, page_size); + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, total_size); + TEST_ASSERT(!ret, "munmap() should succeed."); +} + +static sigjmp_buf jmpbuf; +void fault_sigbus_handler(int signum) +{ + siglongjmp(jmpbuf, 1); +} + +static void test_fault_overflow(int fd, size_t page_size, size_t total_size) +{ + struct sigaction sa_old, sa_new = { + .sa_handler = fault_sigbus_handler, + }; + size_t map_size = total_size * 4; + const char val = 0xaa; + char *mem; + size_t i; + int ret; + + mem = mmap(NULL, map_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT(mem != MAP_FAILED, "mmap() for shared guest memory should succeed."); + + sigaction(SIGBUS, &sa_new, &sa_old); + if (sigsetjmp(jmpbuf, 1) == 0) { + memset(mem, 0xaa, map_size); + TEST_ASSERT(false, "memset() should have triggered SIGBUS."); + } + sigaction(SIGBUS, &sa_old, NULL); + + for (i = 0; i < total_size; i++) + TEST_ASSERT_EQ(mem[i], val); + + ret = munmap(mem, map_size); + TEST_ASSERT(!ret, "munmap() should succeed."); +} + +static void test_mmap_not_supported(int fd, size_t page_size, size_t total_size) { char *mem; mem = mmap(NULL, page_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); TEST_ASSERT_EQ(mem, MAP_FAILED); + + mem = mmap(NULL, total_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + TEST_ASSERT_EQ(mem, MAP_FAILED); } static void test_file_size(int fd, size_t page_size, size_t total_size) @@ -120,26 +193,19 @@ static void test_invalid_punch_hole(int fd, size_t page_size, size_t total_size) } } -static void test_create_guest_memfd_invalid(struct kvm_vm *vm) +static void test_create_guest_memfd_invalid_sizes(struct kvm_vm *vm, + uint64_t guest_memfd_flags, + size_t page_size) { - size_t page_size = getpagesize(); - uint64_t flag; size_t size; int fd; for (size = 1; size < page_size; size++) { - fd = __vm_create_guest_memfd(vm, size, 0); - TEST_ASSERT(fd == -1 && errno == EINVAL, + fd = __vm_create_guest_memfd(vm, size, guest_memfd_flags); + TEST_ASSERT(fd < 0 && errno == EINVAL, "guest_memfd() with non-page-aligned page size '0x%lx' should fail with EINVAL", size); } - - for (flag = BIT(0); flag; flag <<= 1) { - fd = __vm_create_guest_memfd(vm, page_size, flag); - TEST_ASSERT(fd == -1 && errno == EINVAL, - "guest_memfd() with flag '0x%lx' should fail with EINVAL", - flag); - } } static void test_create_guest_memfd_multiple(struct kvm_vm *vm) @@ -171,30 +237,123 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) close(fd1); } -int main(int argc, char *argv[]) +static bool check_vm_type(unsigned long vm_type) { - size_t page_size; + /* + * Not all architectures support KVM_CAP_VM_TYPES. However, those that + * support guest_memfd have that support for the default VM type. + */ + if (vm_type == VM_TYPE_DEFAULT) + return true; + + return kvm_check_cap(KVM_CAP_VM_TYPES) & BIT(vm_type); +} + +static void test_with_type(unsigned long vm_type, uint64_t guest_memfd_flags, + bool expect_mmap_allowed) +{ + struct kvm_vm *vm; size_t total_size; + size_t page_size; int fd; - struct kvm_vm *vm; - TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + if (!check_vm_type(vm_type)) + return; page_size = getpagesize(); total_size = page_size * 4; - vm = vm_create_barebones(); + vm = vm_create_barebones_type(vm_type); - test_create_guest_memfd_invalid(vm); test_create_guest_memfd_multiple(vm); + test_create_guest_memfd_invalid_sizes(vm, guest_memfd_flags, page_size); - fd = vm_create_guest_memfd(vm, total_size, 0); + fd = vm_create_guest_memfd(vm, total_size, guest_memfd_flags); test_file_read_write(fd); - test_mmap(fd, page_size); + + if (expect_mmap_allowed) { + test_mmap_supported(fd, page_size, total_size); + test_fault_overflow(fd, page_size, total_size); + + } else { + test_mmap_not_supported(fd, page_size, total_size); + } + test_file_size(fd, page_size, total_size); test_fallocate(fd, page_size, total_size); test_invalid_punch_hole(fd, page_size, total_size); close(fd); + kvm_vm_release(vm); +} + +static void test_vm_type_gmem_flag_validity(unsigned long vm_type, + uint64_t expected_valid_flags) +{ + size_t page_size = getpagesize(); + struct kvm_vm *vm; + uint64_t flag = 0; + int fd; + + if (!check_vm_type(vm_type)) + return; + + vm = vm_create_barebones_type(vm_type); + + for (flag = BIT(0); flag; flag <<= 1) { + fd = __vm_create_guest_memfd(vm, page_size, flag); + + if (flag & expected_valid_flags) { + TEST_ASSERT(fd >= 0, + "guest_memfd() with flag '0x%lx' should be valid", + flag); + close(fd); + } else { + TEST_ASSERT(fd < 0 && errno == EINVAL, + "guest_memfd() with flag '0x%lx' should fail with EINVAL", + flag); + } + } + + kvm_vm_release(vm); +} + +static void test_gmem_flag_validity(void) +{ + uint64_t non_coco_vm_valid_flags = 0; + + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) + non_coco_vm_valid_flags = GUEST_MEMFD_FLAG_SUPPORT_SHARED; + + test_vm_type_gmem_flag_validity(VM_TYPE_DEFAULT, non_coco_vm_valid_flags); + +#ifdef __x86_64__ + test_vm_type_gmem_flag_validity(KVM_X86_SW_PROTECTED_VM, non_coco_vm_valid_flags); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SEV_ES_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_SNP_VM, 0); + test_vm_type_gmem_flag_validity(KVM_X86_TDX_VM, 0); +#endif +} + +int main(int argc, char *argv[]) +{ + TEST_REQUIRE(kvm_has_cap(KVM_CAP_GUEST_MEMFD)); + + test_gmem_flag_validity(); + + test_with_type(VM_TYPE_DEFAULT, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(VM_TYPE_DEFAULT, GUEST_MEMFD_FLAG_SUPPORT_SHARED, + true); + } + +#ifdef __x86_64__ + test_with_type(KVM_X86_SW_PROTECTED_VM, 0, false); + if (kvm_has_cap(KVM_CAP_GMEM_SHARED_MEM)) { + test_with_type(KVM_X86_SW_PROTECTED_VM, + GUEST_MEMFD_FLAG_SUPPORT_SHARED, true); + } +#endif } -- 2.49.0.1266.g31b7d2e469-goog