From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782D6C5AE59 for ; Thu, 5 Jun 2025 15:39:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD2496B0089; Thu, 5 Jun 2025 11:38:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA36E6B02D2; Thu, 5 Jun 2025 11:38:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BE32A6B00A2; Thu, 5 Jun 2025 11:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5ED916B0342 for ; Thu, 5 Jun 2025 11:38:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 12DEF140E10 for ; Thu, 5 Jun 2025 15:38:41 +0000 (UTC) X-FDA: 83521754442.04.750DFFB Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by imf07.hostedemail.com (Postfix) with ESMTP id 38BB74000C for ; Thu, 5 Jun 2025 15:38:38 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=F0zUfkOW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 3_blBaAUKCMAzghhgmuumrk.iusrot03-ssq1giq.uxm@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3_blBaAUKCMAzghhgmuumrk.iusrot03-ssq1giq.uxm@flex--tabba.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749137919; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9CTszacuPAxWQTwzIU0nGotfU9vxy8BL3CP9EQLh798=; b=fsLt7hlNQL/R4CQBlqq7sTC/d3VEidJ23E7TctP0Xy92POBrR1VysHKmd9tDDHfUjpzPVu zukXKrzMH/OOssmqVxq+oLphkxWPoHmZpUkUn61VILQ8EDRz9B7UhgnrseQCQuWBjIw4yp Qb6IeWH1Jf7Wr46uMKOAph88CFO3tbU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749137919; a=rsa-sha256; cv=none; b=b//ur8FM9qHm/m+aJxqHTQbm8wxENGHnYZBkh6FhS+VjZJ/XWOC4xJaLerJGwG9OEGk/a9 vrBSowi/ZxVY1hKgdGH8iM4oGitbYNTouK2HoCrFm2TdAXF67HJJoQoVdXk6nEAteRJkzh C3NenMiquOeqBGN65HjRH2up53y5pmA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=F0zUfkOW; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of 3_blBaAUKCMAzghhgmuumrk.iusrot03-ssq1giq.uxm@flex--tabba.bounces.google.com designates 209.85.128.74 as permitted sender) smtp.mailfrom=3_blBaAUKCMAzghhgmuumrk.iusrot03-ssq1giq.uxm@flex--tabba.bounces.google.com Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-442dc702850so6979245e9.1 for ; Thu, 05 Jun 2025 08:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749137918; x=1749742718; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=9CTszacuPAxWQTwzIU0nGotfU9vxy8BL3CP9EQLh798=; b=F0zUfkOW/OrkGQ7gNRR7JpaeTQLwUDsXof289X+Z2KeDHdhHuyq7a28zUTGsEibSfC HuZGONOdkQvr4646hw4adpsxYAfG1jkLCviCzUC7Nyg4R60a+3XNL/zOy5CM5uSx4d5F zKjXTVLNE35J5+/xBaKo3nTLNHFycUOkG0MV7jXWf6tE3odIt+ylymrDDrfR0uqxBr7j xwv08QhOu6Nb9sI1uX5OmzGSyXDxzxkoLlHjsfyLw4beK65+LCumVaygEyeVzkqDWiNG HA8WWnvs3WlMx8dvE900OV3KOIyFui7+XbnGhauE18ElBbBZUKXT8KhJxHy0y+ylM5ko JBVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749137918; x=1749742718; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9CTszacuPAxWQTwzIU0nGotfU9vxy8BL3CP9EQLh798=; b=WUvDCvEKdcrf7IeShiljS8P/OhgRIGpfe2hGR+PznO+SUzczBoGiPuRN2wo2khcSfC 0NWD/elyuBVuKdjQOjyA/w0McJltvXcJUqG7ALjG6mCIoxEtrSZotmf/IFPjfd+K1Qg8 1WW1f/JLhI5XvRrRMPf6L2xohuyYrBDNr31F+Rbgxy40rUMrE+v1EATuCQx0tgGi9fiN ocfxSdchS7pRwK9VrJHcxa427TdDeNOW3Xu/iWHXHjX2HcVvfOAYmfUq7t9r0twIsZcJ 0lBgCpfbdmwn5LJIx5Bd7eHE3loXsaCc1NQAEJLqGNEFqVwoAMPgNJsYEWAUSA5VQWvA sDfg== X-Forwarded-Encrypted: i=1; AJvYcCXObzQ5pbrlo0bCfnlR9/HtQjHRkmyjQIZi6pqlEsdEfyIbE4tJ48E5nQrzxJMQzcGirvFWNibZZw==@kvack.org X-Gm-Message-State: AOJu0YwupkfB+WfXz9wFn+B7p/c2hPwh0dq0ZCv/WWWPbn43epkePRq1 YRVbvCDOiLbpRGD20mC/O2RcUG+I4t8owIqIT8i48u95qLu4DgiHCB2NWvvTiQUPtcUyvQcqnke b2Q== X-Google-Smtp-Source: AGHT+IGIOvyaIq+arYR+kGxlz5MLXMzKAjfF3gerPhhAkuJUuarivw68VGg1S5URm28toMXSQIBmwPWvzg== X-Received: from wmbhj26.prod.google.com ([2002:a05:600c:529a:b0:451:edc8:7816]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:828f:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-451f0b26621mr61939045e9.21.1749137917744; Thu, 05 Jun 2025 08:38:37 -0700 (PDT) Date: Thu, 5 Jun 2025 16:37:59 +0100 In-Reply-To: <20250605153800.557144-1-tabba@google.com> Mime-Version: 1.0 References: <20250605153800.557144-1-tabba@google.com> X-Mailer: git-send-email 2.49.0.1266.g31b7d2e469-goog Message-ID: <20250605153800.557144-18-tabba@google.com> Subject: [PATCH v11 17/18] KVM: selftests: Don't use hardcoded page sizes in guest_memfd test From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 38BB74000C X-Stat-Signature: rb7563wz66nrtogcs13apkoux5mts7no X-Rspam-User: X-HE-Tag: 1749137918-551186 X-HE-Meta: U2FsdGVkX18qLdCmXPothZFnD5Tsuts5VZ9cBOjW3GBhKio6EnTKk1wWfHadJP/skUEjuTRIil1YVS6kdXMPtC6wQs7Zb63GfdY9QiYkM5cWO7lXI1QRk4S5pGQEO6Qj0EHT96MiqmLntocMeUQ//cIf1+M7D5sFM0BmMXZj6A0wE1GU3zEwdZIRRv7CxMyUS7TWNQxi0bumGaLJbuiZFvgrcwQmfz0XkLtwPIRj1HrQ56+Hwc8bKlAuUdAEtVr1Xd4xuqx74jgE1t+x8TzSBEpN6FoxqYMiHxXl1lkehIfUpck/NGXZHc/GMUcm5cOblR3ymkNAfky4ZD5p1DQ1lqrJgM0aCqhZsH/E83tHNEfxJHOv2h9Oif4mtpudZ3DsYvWmKbCSScq1T/iynw3QMocOZ4j8UX0plObQJndSt3HP2NYzn+i1G1IXC7JoSc7Q6VtsnphfcGqNs5Ln2SW2F7x8sb2FSe9ZM8aiXb1a4wQ0YbWqXhJPGq2nbZ/F4SS+ZxxLvV8UEAilSgnTXIEiQ5+e+X9VvLFzmI4oyEK0hOYNT6mD4+naB/SZVzbrDwahO808WaCuoc1sOl6hhEQBvi/KWrcFVJFfjKsuVeg/6z+eL7baCkteRwUZMceHRbgbMTmLhQvTEVgLCyyNucQroMgaoAaRbYSJM0xy5wySbEMNYNOAArgWhJupuYbNrDY5+tuSETzmVkRWkFYksTVgbh5f9mQcky2KemoFdh8VZCCZk9kWbZEKr+u8B7aSopQxag8MnYs/DjbMA6GXG5rckhW+0qm56FvMY3ckPif3veo7Kwy16kd+7dTdIzwHuKeYZwV73bX0FMJXx3ACZsKKCvAdI2/SXeKTV8RudNEuyWa/3HImXUHnhfB0EBTb2qVBrbNSG2pn+K3t9v2NoQk4CTTLX0rptamQivUq/GMR6MArKqeLDSrw8iQUHQQgai7xifNnHb5RegQulyDjdxr WvZOrmU4 p3dAMNNCTzVOTT+O3Jy5m2nuZB6kDIOM5wPw02DTlRiOC15FnR7fePPU240ALEBJjzvhcEYTe6kYeo1wEBvDrIV5351U3VCQ3xb1e4j6Vx4INqc4m6jqskzIGgVrMDJ6EmezzNbOUSXtWqvNWGnsLnDB/aOZiih00vyRD9HffgxPQZY133UnyYo8TgRPyQEDtbt1/6zaxjel2jWHgfEbxRtViBlrociLAQ73B5wHktg77JwVxXOecXfMTh+g5dZgAdvA+vCnK959IXvCkYCB41LsGZQzJne9TO5rn3cXNT6dkNQH1nvLHzIHIBPJtZLTxWop4GJbXt9NEm8nPylnomxIAClSwRBwzBAb4TasJbDjZHLqaMQJmUiWreR1PnhDnGZnnG4OAlYDiDPPVQVlUg0KtrkehszwIYVy48mh6QeAitjuKyl+gfyFWMKCfsZl2cXy5griyeKnOZCbR1wNWM9lDdx1CMN787Vnislc0FX71rlE6RIbSp9QiKPooz/MwdOFlY6zBPZpOZu0DxuFZC/X3WwYjwSxJ/vquDOI4fF0Fvr20ZEh1ocsP09Y8mNZHMeeIuSN8PVJlEVLG5Yv0KOTv+ZC5JZXTcHWDzbBNr+RcNqI8CtMePvHQsiQDnxqQZ9cEMz5sp2mDT9ioOk0WL9YtkeT83urEoDT4He+pXyYfzNk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Using hardcoded page size values could cause the test to fail on systems that have larger pages, e.g., arm64 with 64kB pages. Use getpagesize() instead. Also, build the guest_memfd selftest for arm64. Suggested-by: Gavin Shan Signed-off-by: Fuad Tabba --- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/guest_memfd_test.c | 11 ++++++----- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/tools/testing/selftests/kvm/Makefile.kvm b/tools/testing/selftests/kvm/Makefile.kvm index f62b0a5aba35..845fcaf8b6c9 100644 --- a/tools/testing/selftests/kvm/Makefile.kvm +++ b/tools/testing/selftests/kvm/Makefile.kvm @@ -164,6 +164,7 @@ TEST_GEN_PROGS_arm64 += arch_timer TEST_GEN_PROGS_arm64 += coalesced_io_test TEST_GEN_PROGS_arm64 += dirty_log_perf_test TEST_GEN_PROGS_arm64 += get-reg-list +TEST_GEN_PROGS_arm64 += guest_memfd_test TEST_GEN_PROGS_arm64 += memslot_modification_stress_test TEST_GEN_PROGS_arm64 += memslot_perf_test TEST_GEN_PROGS_arm64 += mmu_stress_test diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c index ce687f8d248f..341ba616cf55 100644 --- a/tools/testing/selftests/kvm/guest_memfd_test.c +++ b/tools/testing/selftests/kvm/guest_memfd_test.c @@ -146,24 +146,25 @@ static void test_create_guest_memfd_multiple(struct kvm_vm *vm) { int fd1, fd2, ret; struct stat st1, st2; + size_t page_size = getpagesize(); - fd1 = __vm_create_guest_memfd(vm, 4096, 0); + fd1 = __vm_create_guest_memfd(vm, page_size, 0); TEST_ASSERT(fd1 != -1, "memfd creation should succeed"); ret = fstat(fd1, &st1); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st1.st_size == 4096, "memfd st_size should match requested size"); + TEST_ASSERT(st1.st_size == page_size, "memfd st_size should match requested size"); - fd2 = __vm_create_guest_memfd(vm, 8192, 0); + fd2 = __vm_create_guest_memfd(vm, page_size * 2, 0); TEST_ASSERT(fd2 != -1, "memfd creation should succeed"); ret = fstat(fd2, &st2); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st2.st_size == 8192, "second memfd st_size should match requested size"); + TEST_ASSERT(st2.st_size == page_size * 2, "second memfd st_size should match requested size"); ret = fstat(fd1, &st1); TEST_ASSERT(ret != -1, "memfd fstat should succeed"); - TEST_ASSERT(st1.st_size == 4096, "first memfd st_size should still match requested size"); + TEST_ASSERT(st1.st_size == page_size, "first memfd st_size should still match requested size"); TEST_ASSERT(st1.st_ino != st2.st_ino, "different memfd should have different inode numbers"); close(fd2); -- 2.49.0.1266.g31b7d2e469-goog