From: Oscar Salvador <osalvador@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Harry Yoo <harry.yoo@oracle.com>, Rakie Kim <rakie.kim@sk.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Oscar Salvador <osalvador@suse.de>
Subject: [PATCH v5 06/10] drivers,cxl: Use node-notifier instead of memory-notifier
Date: Thu, 5 Jun 2025 16:22:57 +0200 [thread overview]
Message-ID: <20250605142305.244465-7-osalvador@suse.de> (raw)
In-Reply-To: <20250605142305.244465-1-osalvador@suse.de>
memory-tier is only concerned when a numa node changes its memory state,
specifically when a numa node with memory comes into play for the first
time, because it needs to get its performance attributes to build a proper
demotion chain.
So stop using the memory notifier and use the new numa node notifer
instead.
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
---
drivers/cxl/core/region.c | 16 ++++++++--------
drivers/cxl/cxl.h | 4 ++--
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
index c3f4dc244df7..a8477a3e175c 100644
--- a/drivers/cxl/core/region.c
+++ b/drivers/cxl/core/region.c
@@ -2432,12 +2432,12 @@ static int cxl_region_perf_attrs_callback(struct notifier_block *nb,
unsigned long action, void *arg)
{
struct cxl_region *cxlr = container_of(nb, struct cxl_region,
- memory_notifier);
- struct memory_notify *mnb = arg;
- int nid = mnb->status_change_nid;
+ node_notifier);
+ struct node_notify *mnb = arg;
+ int nid = mnb->nid;
int region_nid;
- if (nid == NUMA_NO_NODE || action != MEM_ONLINE)
+ if (nid == NUMA_NO_NODE || action != NODE_ADDED_FIRST_MEMORY)
return NOTIFY_DONE;
/*
@@ -3484,7 +3484,7 @@ static void shutdown_notifiers(void *_cxlr)
{
struct cxl_region *cxlr = _cxlr;
- unregister_memory_notifier(&cxlr->memory_notifier);
+ unregister_node_notifier(&cxlr->node_notifier);
unregister_mt_adistance_algorithm(&cxlr->adist_notifier);
}
@@ -3523,9 +3523,9 @@ static int cxl_region_probe(struct device *dev)
if (rc)
return rc;
- cxlr->memory_notifier.notifier_call = cxl_region_perf_attrs_callback;
- cxlr->memory_notifier.priority = CXL_CALLBACK_PRI;
- register_memory_notifier(&cxlr->memory_notifier);
+ cxlr->node_notifier.notifier_call = cxl_region_perf_attrs_callback;
+ cxlr->node_notifier.priority = CXL_CALLBACK_PRI;
+ register_node_notifier(&cxlr->node_notifier);
cxlr->adist_notifier.notifier_call = cxl_region_calculate_adistance;
cxlr->adist_notifier.priority = 100;
diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
index a9ab46eb0610..48ac02dee881 100644
--- a/drivers/cxl/cxl.h
+++ b/drivers/cxl/cxl.h
@@ -513,7 +513,7 @@ enum cxl_partition_mode {
* @flags: Region state flags
* @params: active + config params for the region
* @coord: QoS access coordinates for the region
- * @memory_notifier: notifier for setting the access coordinates to node
+ * @node_notifier: notifier for setting the access coordinates to node
* @adist_notifier: notifier for calculating the abstract distance of node
*/
struct cxl_region {
@@ -526,7 +526,7 @@ struct cxl_region {
unsigned long flags;
struct cxl_region_params params;
struct access_coordinate coord[ACCESS_COORDINATE_MAX];
- struct notifier_block memory_notifier;
+ struct notifier_block node_notifier;
struct notifier_block adist_notifier;
};
--
2.49.0
next prev parent reply other threads:[~2025-06-05 14:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 14:22 [PATCH v5 00/10] Oscar Salvador
2025-06-05 14:22 ` [PATCH v5 01/10] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Oscar Salvador
2025-06-05 14:22 ` [PATCH v5 02/10] mm,memory_hotplug: Remove status_change_nid_normal and update documentation Oscar Salvador
2025-06-05 14:34 ` Vlastimil Babka
2025-06-05 14:54 ` David Hildenbrand
2025-06-05 15:49 ` Oscar Salvador
2025-06-05 14:22 ` [PATCH v5 03/10] mm,memory_hotplug: Implement numa node notifier Oscar Salvador
2025-06-06 7:50 ` Oscar Salvador
2025-06-05 14:22 ` [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier Oscar Salvador
2025-06-06 1:50 ` kernel test robot
2025-06-06 7:51 ` Oscar Salvador
2025-06-06 11:56 ` David Hildenbrand
2025-06-06 12:28 ` Oscar Salvador
2025-06-06 12:35 ` David Hildenbrand
2025-06-05 14:22 ` [PATCH v5 05/10] mm,memory-tiers: " Oscar Salvador
2025-06-06 11:50 ` David Hildenbrand
2025-06-05 14:22 ` Oscar Salvador [this message]
2025-06-06 11:51 ` [PATCH v5 06/10] drivers,cxl: " David Hildenbrand
2025-06-05 14:22 ` [PATCH v5 07/10] drivers,hmat: " Oscar Salvador
2025-06-06 11:51 ` David Hildenbrand
2025-06-07 22:59 ` Andrew Morton
2025-06-05 14:22 ` [PATCH v5 08/10] kernel,cpuset: " Oscar Salvador
2025-06-06 11:52 ` David Hildenbrand
2025-06-05 14:23 ` [PATCH v5 09/10] mm,mempolicy: " Oscar Salvador
2025-06-09 6:47 ` Rakie Kim
2025-06-05 14:23 ` [PATCH v5 10/10] mm,memory_hotplug: Rename status_change_nid parameter in memory_notify Oscar Salvador
2025-06-06 11:48 ` David Hildenbrand
2025-06-06 11:30 ` [PATCH v5 00/10] Lorenzo Stoakes
2025-06-06 11:46 ` David Hildenbrand
2025-06-06 12:31 ` Oscar Salvador
2025-06-06 12:45 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250605142305.244465-7-osalvador@suse.de \
--to=osalvador@suse.de \
--cc=42.hyeyoo@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=harry.yoo@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rakie.kim@sk.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox