From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B89B1C5AE59 for ; Thu, 5 Jun 2025 14:23:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53408D0056; Thu, 5 Jun 2025 10:23:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2B628D0007; Thu, 5 Jun 2025 10:23:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AAC38D0057; Thu, 5 Jun 2025 10:23:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 720CC8D0007 for ; Thu, 5 Jun 2025 10:23:37 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1CB2F120B93 for ; Thu, 5 Jun 2025 14:23:37 +0000 (UTC) X-FDA: 83521565274.28.ED427A9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf20.hostedemail.com (Postfix) with ESMTP id 135FF1C0013 for ; Thu, 5 Jun 2025 14:23:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749133415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N4qBuDF+14Axw+50H7o0dWKI/bWuQW0F1VAgUI0Jer8=; b=kbD12TzVYsrVtEz1lKPl5MlUaTLxVoUnsm0TTOrgIPG0ssPO2xvsj7LEPCP3l7bOiCrAVK u/LpOM7T4eXYkOIxv77bt0vrJJXJqgppzF1vT9rpkrgY5xUqrDgLAxjx/zcd1K9aAraIrc /zvdbAGVDO1wHm/b1n0SVL70F1roSG8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749133415; a=rsa-sha256; cv=none; b=XgYNMZaaxSjCS8D9Ge+qRB882m4QJKN3a2AyfF+ZVNmTwhPny3bMbbBPXw1hSL6GlJdZiK /Do2Eiqw15V6RspwDNnDJ2M58g3pv5RSdBIksoBXx1ehKo6zWrDMRb8y29ZtY4SWvbjiFN ytpbtaAILkkg2pH/dlWo21vTVnu6SPs= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf20.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B2602336C3; Thu, 5 Jun 2025 14:23:17 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 20D5D137FE; Thu, 5 Jun 2025 14:23:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id UF9GBVWoQWipRwAAD6G6ig (envelope-from ); Thu, 05 Jun 2025 14:23:17 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v5 04/10] mm,slub: Use node-notifier instead of memory-notifier Date: Thu, 5 Jun 2025 16:22:55 +0200 Message-ID: <20250605142305.244465-5-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605142305.244465-1-osalvador@suse.de> References: <20250605142305.244465-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 135FF1C0013 X-Stat-Signature: e8q3ybfw7qg6sidmhenuejaq1stbnahk X-Rspam-User: X-HE-Tag: 1749133414-315283 X-HE-Meta: U2FsdGVkX18LuLpEBvhhC7UI5T/qplZCIlWMA7ypvpa1K5WapCMt+a/+/Rt0fVrLB5k3/vU+0NVqdTgwgmlBRJ/KFgjWGAW9lsB06E/jmxDzbo4GnwIpmvsccfDIyeFNvtaRtgEoBmlz07l0LXVdn5jLieuBBIWLTu2T0I3mR5tnst6TBcr8FL+NsXStRVjv6t/mZLkVCewtvgE4wdg+WAGEjAJ4q0UJ5s+VfmIct6qB0Rsg8usuPFjQ7zNGzU+lCDp+6pntQTjK7XDvVS626E3yl/SqoB15GNV1ybmqnr51EKw3SDJzuklq1nFQpbTv74HW5vWVva+4UhNZMcycpDNvW9UH6/zw4suoamNlzigE0ajihwRJPctfAvSyPK/Mho3PmTN1JCWrXjWN2fTCwhbg28bJYo4vO4GYdYJ3JN98bvbNXzkrAtlMYba50s+RCBQa4CyOs88LzmYPNnr0HycH2IzORG6lbHjghayCp6NkAysIYUACtTlwto0TdE3EG6LpDexYWsDjpaxlTglEKDxpqmHQGFX/MsirL4YvpY2Mj0aqEBqm4hSwUZLvYFWhSBtdo+CGqClCKsuRJNxyYWQjVpTPyM5BaAO16pehUxodAnTWmtLFoccq/wUXYvqv0fbzkJ1nkMFtdmH8GSE8VnuRo6J6f+70X06u0n1jy6vmLQwX74gBchAOpzzeiTE23tregidRpY+u4u7E8G77qvIDfCjs/vW84wrDcN0pVr2gcbT5AEVK1iMYJw7j8cvG7DjRt3EHDM+GJ/f8F/aQ6q1WJcxxk/UjyWIa9WjS7NnYQK2sB95ANEiqDUw3XpLPhvFYBLqOH5jAYtDgZ0JsBARZC/ptoXdgTq+vKeEegSXY+9XlF0i6scQGXbeCm17YkXmCyIsBxuASz3ubyLFDwXR+Fbjtil8Dkw1EeFGz5+Z6NtYgezApIP7epBfZLBXSYwXORKYVGrvFc9dfICL b98mF8Ao If6ZbygKrj3FeDc3upUnmbEYB59KbiFSB/kDHI/XwflT0QMhazI+3XTrkfTZOoZJo5VdvUeGnbpEXIzZeIDcAmo+XpuabHEo6lljO9XSwvlkRgEJXVn2+oz3rYkVaWigcMBc5GXyPVCmsP4MiAAzOy+t3HFXj05jxgtYUcG3y4ketfinOeGA0xQlJ0p3/xxBrjEhcojTZNmcWNEXRwTO6prXytArNa5yxNoZi53sKrPtQV6f/YGYfSiuHcQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: slub is only concerned when a numa node changes its memory state, so stop using the memory notifier and use the new numa node notifer instead. Signed-off-by: Oscar Salvador Reviewed-by: Jonathan Cameron Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka --- mm/slub.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index f92b43d36adc..b8b5b81bfd1a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -6164,8 +6164,8 @@ static int slab_mem_going_online_callback(void *arg) { struct kmem_cache_node *n; struct kmem_cache *s; - struct memory_notify *marg = arg; - int nid = marg->status_change_nid; + struct node_notify *narg = arg; + int nid = narg->nid; int ret = 0; /* @@ -6217,15 +6217,12 @@ static int slab_memory_callback(struct notifier_block *self, int ret = 0; switch (action) { - case MEM_GOING_ONLINE: + case NODE_ADDING_FIRST_MEMORY: ret = slab_mem_going_online_callback(arg); break; - case MEM_GOING_OFFLINE: + case NODE_REMOVING_LAST_MEMORY: ret = slab_mem_going_offline_callback(arg); break; - case MEM_ONLINE: - case MEM_CANCEL_OFFLINE: - break; } if (ret) ret = notifier_from_errno(ret); @@ -6300,7 +6297,7 @@ void __init kmem_cache_init(void) sizeof(struct kmem_cache_node), SLAB_HWCACHE_ALIGN | SLAB_NO_OBJ_EXT, 0, 0); - hotplug_memory_notifier(slab_memory_callback, SLAB_CALLBACK_PRI); + hotplug_node_notifier(slab_memory_callback, SLAB_CALLBACK_PRI); /* Able to allocate the per node structures */ slab_state = PARTIAL; -- 2.49.0