From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21388C5AE59 for ; Thu, 5 Jun 2025 14:23:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9570E6B0599; Thu, 5 Jun 2025 10:23:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90E4F6B059A; Thu, 5 Jun 2025 10:23:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F6426B059C; Thu, 5 Jun 2025 10:23:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5F5306B0599 for ; Thu, 5 Jun 2025 10:23:20 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 814A31D6D88 for ; Thu, 5 Jun 2025 14:23:19 +0000 (UTC) X-FDA: 83521564518.06.A898FEF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf21.hostedemail.com (Postfix) with ESMTP id 5227A1C000E for ; Thu, 5 Jun 2025 14:23:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MzPmhZd1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bjpgOHRB; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MzPmhZd1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bjpgOHRB; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749133397; a=rsa-sha256; cv=none; b=HGUTNJywXzyLlbC4WEGhobczyQ7QpsxQ1WfFIzxy7khxgQVO8DYftoAg8ivKVvsAhrT9zo h8JL7K77r7ohm9DMlluWVqGjN+zC6RcCfNCjJF8+0mf4xanlg5kq7eJtk0HLW68uQV+0YN adVbQ6klv6eVErXW0TT8ftWvbK8KbHU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MzPmhZd1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bjpgOHRB; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MzPmhZd1; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bjpgOHRB; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749133397; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=I0qpIOiygDzryZBPbPHQnyefPSnMWZgvXBVmEb4Rnc+5Lvs5yIMSrcVlzTuMsaslisSj6v NQWpP6lvUeqOSjh7OPHZABCSFgEBPd4dhj1XFabftK95IdIfQT83kRpczNNKwZDqeg5M5T 5dbWIttBHowKgKgnVrgCa4zifM619e0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9BC72337D0; Thu, 5 Jun 2025 14:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749133395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=MzPmhZd1gsuaSsw+0A6rfxBhQX5ih9ATnrWanvzcdicTib5NebXGNvIiuCdiBSvF4WLgR7 WSrodURmdQ6847M1xg81H6+KPFgKtSxsx+l+xhWjCnDMthYkLgRH/N0qAx+H7KSOq2sPoQ JTAeSzFHZXCBaQYqxeXh/0bAJNKCBXI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749133395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=bjpgOHRBiGV4Ex0Rlb4pKwv2nkuHI3mrgwx+QRtVgU+dt0lv7KUaTqVsjX3rLAS0mgfFA7 2mlRxR+Lm+WGCwCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749133395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=MzPmhZd1gsuaSsw+0A6rfxBhQX5ih9ATnrWanvzcdicTib5NebXGNvIiuCdiBSvF4WLgR7 WSrodURmdQ6847M1xg81H6+KPFgKtSxsx+l+xhWjCnDMthYkLgRH/N0qAx+H7KSOq2sPoQ JTAeSzFHZXCBaQYqxeXh/0bAJNKCBXI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749133395; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPo5dP2xx4yCEpwtQyV+S69pInSlZfneHcEHHsBK/5o=; b=bjpgOHRBiGV4Ex0Rlb4pKwv2nkuHI3mrgwx+QRtVgU+dt0lv7KUaTqVsjX3rLAS0mgfFA7 2mlRxR+Lm+WGCwCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0E7F3139CB; Thu, 5 Jun 2025 14:23:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wHfMAFOoQWipRwAAD6G6ig (envelope-from ); Thu, 05 Jun 2025 14:23:15 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v5 01/10] mm,slub: Do not special case N_NORMAL nodes for slab_nodes Date: Thu, 5 Jun 2025 16:22:52 +0200 Message-ID: <20250605142305.244465-2-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605142305.244465-1-osalvador@suse.de> References: <20250605142305.244465-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5227A1C000E X-Stat-Signature: m3nzfa3mzpozroa6ys1g4b3ezzmsp3fn X-Rspam-User: X-HE-Tag: 1749133397-284952 X-HE-Meta: U2FsdGVkX1/5CWttHKOtucAFmxXRz5J2sCCjlw8SMMcBZKhkfsYucJZvzRtD3ljT/GSBM//JigQ/dmlUA7Dr+g3wAZXsjjZZtwBU9rPub68JzC7qEJQOb9yerwsOXuwSbJct6v1Bl95uRgcPSKEvY5+8hAAqNF/dQy98rkODaYYo2RldXKuHn+BptOGnviWu+sMXjoBIL7pD/Y1kIsPj6mig8PAuJrF4vdLJ4mgiiWu0GGx3z0gobRr1kLBj7ZMjWr8nH26+8z+TCyQ14VCjvZbyHSOT0I4RtAvbgMGIyQShn7glYlJD0jtV6iWwj4NyBmQraif7d+LUwmCwBByfSiUJYpzsShDbPVK1ZE12b7S4oZA2BDEaLm4pBk2SQTfAfAb+gGjAk+l8Ixc/rdfX8EAxW3xPNCBHJ866lYvK7AP/2iZSrCvIuJesFfkUBIjkQuImEKFMAGAy63T6r2fN2ZbBNC3naPoeX4f45YLRfIci+goxgsVDzBZakhzv6b1fWS1hyNK59SF4GXzySio+XLoX/F2SS6NQ+C9ziDxyIJsqwwjkmD4AOXlN2gw98THSf3hqfRR13geO5wGmLGDjBdVHP7UhxYCeO904ab+w35tW7GxbylmPo1T4JoAdOorG1rN2dTEwF/Zhu7OF2TXXZNQ114J/erBNL2UT8l+Lk+G0yKecP/wv0c4uwG70Ld18AlRrwJBbXRP1+dUinRCJPKuSIjYr09YelC6GP/LjLVYctHaxDc2WQ7vmngbWKcr9i8vL1g9OSWHNZU1We72W1flF2bqYD3L4xQi/YTxlCZTf0bshW5dm1ovMDDY0UKaLB49VoS4JfkY0xwrDJvlbVlO6JlBZ1C+v80KZsDV6jg9FQI63/KVsETQLtM2cVGQ6KhG1h5ww2WOsGZwys+WHOHc/zuJtzzg8bpcxcGge/1/VD8wSfXRDe3tBxK4C28eIZsh0+nu7qzNkmBL1R3U eXYZfvuo vz9Qhi/gFzdzo5ID04spMXcHsD9rrT+4pkpi8WH9aftjQ5FHwLnTSNCoIlwjvXny2i93iKYamQzdkBntqEKkXxI4mO/bpXgV4Ev+JvkIyn9xsIERHxlI2zcO5zBz6HhGwpWrcsziRuCK3OZAJroR15tXeN3zgF+F3uqAP0z+F0ZWI9/kap2bi4zEyX0qjjBNUJbP3RgD1SId04CXW1qSXfNwiiBKUzOjfpWVFrnTWWLKfHTNhmM3NmF+16Eof53yXm/RXPjWQTSLQUf6f2awi6fV2BCKYLpQc0se6uKEjBVoil/iC+caVLJICtKUsO21KiGGoycOhoubniJjzXVm9VSHEgXOMQXSuYkVt8iRCGByCMAsx+TM3cCCLCQlloVqf1UI115bQ32l9cH2zD1nTIEdD4QJ8MqfnaEnkD1nLuyXH12Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Currently, slab_mem_going_online_callback() checks whether the node has N_NORMAL memory in order to be set in slab_nodes. While it is true that getting rid of that enforcing would mean ending up with movables nodes in slab_nodes, the memory waste that comes with that is negligible. So stop checking for status_change_nid_normal and just use status_change_nid instead which works for both types of memory. Also, once we allocate the kmem_cache_node cache for the node in slab_mem_online_callback(), we never deallocate it in slab_mem_offline_callback() when the node goes memoryless, so we can just get rid of it. The side effects are that we will stop clearing the node from slab_nodes, and also that newly created kmem caches after node hotremove will now allocate their kmem_cache_node for the node(s) that was hotremoved, but these should be negligible. Suggested-by: David Hildenbrand Signed-off-by: Oscar Salvador Reviewed-by: Vlastimil Babka Reviewed-by: Harry Yoo Acked-by: David Hildenbrand --- mm/slub.c | 34 +++------------------------------- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index be8b09e09d30..f92b43d36adc 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -447,7 +447,7 @@ static inline struct kmem_cache_node *get_node(struct kmem_cache *s, int node) /* * Tracks for which NUMA nodes we have kmem_cache_nodes allocated. - * Corresponds to node_state[N_NORMAL_MEMORY], but can temporarily + * Corresponds to node_state[N_MEMORY], but can temporarily * differ during memory hotplug/hotremove operations. * Protected by slab_mutex. */ @@ -6160,36 +6160,12 @@ static int slab_mem_going_offline_callback(void *arg) return 0; } -static void slab_mem_offline_callback(void *arg) -{ - struct memory_notify *marg = arg; - int offline_node; - - offline_node = marg->status_change_nid_normal; - - /* - * If the node still has available memory. we need kmem_cache_node - * for it yet. - */ - if (offline_node < 0) - return; - - mutex_lock(&slab_mutex); - node_clear(offline_node, slab_nodes); - /* - * We no longer free kmem_cache_node structures here, as it would be - * racy with all get_node() users, and infeasible to protect them with - * slab_mutex. - */ - mutex_unlock(&slab_mutex); -} - static int slab_mem_going_online_callback(void *arg) { struct kmem_cache_node *n; struct kmem_cache *s; struct memory_notify *marg = arg; - int nid = marg->status_change_nid_normal; + int nid = marg->status_change_nid; int ret = 0; /* @@ -6247,10 +6223,6 @@ static int slab_memory_callback(struct notifier_block *self, case MEM_GOING_OFFLINE: ret = slab_mem_going_offline_callback(arg); break; - case MEM_OFFLINE: - case MEM_CANCEL_ONLINE: - slab_mem_offline_callback(arg); - break; case MEM_ONLINE: case MEM_CANCEL_OFFLINE: break; @@ -6321,7 +6293,7 @@ void __init kmem_cache_init(void) * Initialize the nodemask for which we will allocate per node * structures. Here we don't need taking slab_mutex yet. */ - for_each_node_state(node, N_NORMAL_MEMORY) + for_each_node_state(node, N_MEMORY) node_set(node, slab_nodes); create_boot_cache(kmem_cache_node, "kmem_cache_node", -- 2.49.0