From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1C7C5AE59 for ; Thu, 5 Jun 2025 20:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 665C96B009C; Thu, 5 Jun 2025 16:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 615C76B00CC; Thu, 5 Jun 2025 16:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 505616B00D7; Thu, 5 Jun 2025 16:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2F1CC6B009C for ; Thu, 5 Jun 2025 16:32:28 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E40B9BF1DF for ; Thu, 5 Jun 2025 20:32:27 +0000 (UTC) X-FDA: 83522494734.14.04B4E91 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf01.hostedemail.com (Postfix) with ESMTP id 13C5640005 for ; Thu, 5 Jun 2025 20:32:25 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=usHxWW55; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749155546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QGeV37AGGqbOtzci5mbkoeoLJ0cNz7X0khWW5Zc2NXQ=; b=FfGOc5zsGmhv5uPWxRwSKpTs/qIk7+WeYjK5HsQTC3OsM3FTEYX9WX80ZjgxtekKmE3LzF gVpjC264MNCRznj2fXN9uHn4rEGi0YcxjUn6BjebMnjPYVnSfKn71jwEbvtduPZ2/rgHE1 4Z9q7UDy/DWonw9FiVK+lVwNA1UcjXs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=usHxWW55; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749155546; a=rsa-sha256; cv=none; b=XBG+04N4Q7OE1DTd4R3c5+7ubuc4PJEW3I3DdoySFdAuN+NpuXV+wsKpQqsdlSgX2cCYFj jnYYzgn9cTTUnlm3NM5WehqJ4zNV2ZOMJoOMxsITN9oQh9t7ZxuFPto5pLq5XvK702wSn2 HVS2Ajif5iQ9f1TLjyL5uqcU/6hVquo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5D96F629D1; Thu, 5 Jun 2025 20:32:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1EC3C4CEE7; Thu, 5 Jun 2025 20:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749155545; bh=wP6XVkaHObG7XcxFBVXGDerkmspfQUb/leD1YX3jPWg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=usHxWW557DGED5/uOM0nk0pWI+9x37l1D9bV8g9oHXEDSYfeXAl6SghVYVJfbnN2C LxRKlquIGFUCu84LjBhB07hHkpFx1IToM1/PGDjSKe9ivK+yg5g12GOAfr88oLwk67 QrqUecrHmW/tggK5Wu9b0yqoYssf6pMhoGOq8dkw= Date: Thu, 5 Jun 2025 13:32:24 -0700 From: Andrew Morton To: David Hildenbrand Cc: Mark Brown , Lorenzo Stoakes , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] selftests/mm: Fix test result reporting in gup_longterm Message-Id: <20250605133224.0462266f98407513b4ba93d1@linux-foundation.org> In-Reply-To: <65862fd7-16ca-4d3b-a589-4389d8df324e@redhat.com> References: <20250527-selftests-mm-cow-dedupe-v2-0-ff198df8e38e@kernel.org> <20250527-selftests-mm-cow-dedupe-v2-4-ff198df8e38e@kernel.org> <722628a8-f3fd-4fb9-ae04-2313a52ffb36@sirena.org.uk> <65862fd7-16ca-4d3b-a589-4389d8df324e@redhat.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 13C5640005 X-Rspamd-Server: rspam09 X-Stat-Signature: 1791c644jhk8ixxmyf3c4hzrmdheu1au X-HE-Tag: 1749155545-248158 X-HE-Meta: U2FsdGVkX1+VcctSTv463xi4z49woESFlzVurmt7oa40NfXW+N+UzWNNx+lEK4GfNrN1DNTa5cZvJH36+0aYTUVtl0XeCABYGs4Ol+5Kmx7mwbw/FBnp7mTKNNkpn4pAWkUWxCU7SpQTZgZpUCCV1f46wNvbsqZSwfAHe8A1+btpzbe+kH29R5yTMKHcqYtBsTWT/Jxs4uYuC+ETgeu9hm1UEtKKcnR4mF7fpoMdczTurpjJlY+WGoy6wJ8QDzj8U5/4t7djaWJTXXhcIoo6tP9eg/SsaJL0/TCq3S0XYTbru/35P3DYTwJ5Xm1crDMCEIYDo5AjwaZ+LmcSADb9CqIpdtroDNt5nPu8nj6bEl+Yy8eLK7/5lvbWLhOdJG/Ae5GCiV8H/6T9/Suqol2vzp6253dczcQY6k9Mz5AUxaFUeICbPuqylji8hZ7+2/oeohMHnOHYy4U12rZVsKUr7gRsjmtmtY67pdHItp+5vU+B3Ei4fv9KP3eI1Vd9hhjs0ln1d5e1T3oU4EJTfWCWQmjL9BBVIe2JPVD+wkQ9JdtrQjgpNYpTXAxX6pAgrfuklJm6cott80LqSwWCsjH1UkrBFChdxH6+jVbNd3rI5zDGBpdXZE3u/U/WyPsijPKwpx6/xUidRZ8tDS0+DvmDfzLnYpYlCZHGglqJbCzRWqXSLiSzPqUeNW0FrP5UEXh3zjkcL8kr6xs0wfebeRAdXRtzIG0nS7B9IPjrLYEkmaGVzzv1z2qgarKg0UhjjJiNyHujuv5xqRLQ3/dGNfbdDBWdmQ7rWHLj0L4Y1gcVMOlBIysRel/6VRIp83M125H+xLcENriqe5KO15a2TROLUMtpevcbJWvIKGvp1UJny9+7FQVrXF+wsVBkjpq7qIuqdsYScVxkQqfhDgQQX/b5Mrw8bWRUkr0ecWWSYhf73zfLXY2dGH5mRg00XTlYEs1JXss93VCx97Ri9P3RRi3 wv55tTM3 3H6ltQGxQGfF7HhwyJTbaUMDSwW0Llv4PxfPi3uVoDGlxdOuMNKabKX4tH+0b3iadb98XS4U2g3Sm8Ka5O/0uEuYP0c6EENIR+d/UG4krGdInHQuhfZ8ossikyk+DjAA7JWUNU1Bl2dZ+S6HQM9Fgfbqu/n9To7o8iz6R7sHdK1LyRsQ4PceGVgF7xxbGl/IFQGVTXytjxMLsxpMUeuARXlFaVuvuc/wXUhj2mNTkRW17h8vtEyQvOE/1LCAB6xUruB9cBB8PlYLTI1yV3A0A2VDRDhIiTCD3W9JCuxEg++HF/BLNeKYDoXoJ8RQHEnqdYtrn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 5 Jun 2025 18:48:49 +0200 David Hildenbrand wrote: > On 05.06.25 18:15, Mark Brown wrote: > > On Thu, Jun 05, 2025 at 05:00:49PM +0100, Lorenzo Stoakes wrote: > > > >> This seems to be causing tests to fail rather than be skipped if hugetlb > >> isn't configured. I bisected the problem to this patch so it's definitely > >> changed how things are handled (though of course it might just be > >> _revealing_ some previously existing bug in this test...). > > > >> Using a couple of tests as an example: > > > >> Before this patch: > > > >> # [RUN] R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (2048 kB) > >> # memfd_create() failed (Cannot allocate memory) > >> not ok 39 R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (2048 kB) > >> # [RUN] R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (1048576 kB) > >> # memfd_create() failed (Cannot allocate memory) > >> not ok 40 R/O longterm GUP-fast pin in MAP_PRIVATE file mapping ... with memfd hugetlb (1048576 kB) > > > > That's the thing with memfd being special and skipping on setup failure > > that David mentioned, I've got a patch as part of the formatting series > > I was going to send after the merge window. > > @Andew, why did this series get merged already? Late merge window hastiness :( And I saw nothing worrisome in the review.