From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27C64C5AE59 for ; Thu, 5 Jun 2025 19:57:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B06A36B0093; Thu, 5 Jun 2025 15:57:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB5B36B00C9; Thu, 5 Jun 2025 15:57:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CCCF6B00CA; Thu, 5 Jun 2025 15:57:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7CCC86B0093 for ; Thu, 5 Jun 2025 15:57:28 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 28C9C81586 for ; Thu, 5 Jun 2025 19:57:28 +0000 (UTC) X-FDA: 83522406576.18.19CEED9 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id 751FD120013 for ; Thu, 5 Jun 2025 19:57:26 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hLooBr5K; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749153446; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cL8L4Ri4mHKPm73HPK3HUE2JocwnJCqQUiFS6l8kPn4=; b=o+5qNldojsOLXpa5H3w/q3w/7X5zN+Srk6bzwLv10Csgfuq5fDuMDu7xCQ58NlhH4bzFeb cZ6TVUM/cqo5gBAoDM6vdxifc/wdooyL+XcCKiTezrN1bN33dFnR7SpO3OunCeeEkpNsZl aAEV0L2Ta55bcb8mY8QY+XxVNusIKZc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hLooBr5K; spf=pass (imf29.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749153446; a=rsa-sha256; cv=none; b=meSPRzoxK+f+ZzXTs7KsCNtm/qlt5IB9o+8OpNlCurRLZ/7BRMUCNjnyvsjoodX1IO5HND V4D9mR8+4prMQwCesbi0aoRRIoA/nr+VSn7hTfxHKGUjleYfKtgqKDgsrwBq5AzCJ4cNaf boX3EoO0dN2ONyUBxqiwZxKWq6IWX6o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id AF664A50139; Thu, 5 Jun 2025 19:57:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08152C4CEE7; Thu, 5 Jun 2025 19:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749153445; bh=1u8lfpAO42Ly1Adp2rWOcQfq7JPHMSczCMk7/C3j4QA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hLooBr5KY9DQTeDlulfLIviETs7q2vSYR7FamOkzeGc/MKCoH26Ynb9m9h8AqVn5B pdxTenQkJgFQ9M2aYtoP8thiTNlcEqaHKDqNMrHfqzZktN4uR1Kxz6U/QdLAfCeQF6 VgBLSRPPTePFj0wbig2U/E5ZfLi+J5V93V2wXL8I= Date: Thu, 5 Jun 2025 12:57:24 -0700 From: Andrew Morton To: Kemeng Shi Cc: hughd@google.com, baolin.wang@linux.alibaba.com, willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/7] mm: shmem: correctly pass alloced parameter to shmem_recalc_inode() to avoid WARN_ON() Message-Id: <20250605125724.d2e3db9c23af7627a53d8914@linux-foundation.org> In-Reply-To: <20250605221037.7872-2-shikemeng@huaweicloud.com> References: <20250605221037.7872-1-shikemeng@huaweicloud.com> <20250605221037.7872-2-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 751FD120013 X-Stat-Signature: f3dedf73oz7mgrohsnbjidbtz6pb9e6a X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749153446-212966 X-HE-Meta: U2FsdGVkX19uLloHq4k/aXMOSCCDGY+L/wig8ujh+YwvaRFbb2o+zSFGzUVdliLH2/m+AZ4bjeGy7pHMnAshMXhibbvlXsV/qbor5jPHQCoA3bI/O46l5TubxC9EEdQiAinm7S2AnR2QyiwbMrO/w1yHrz+mIJVhytHtBL7SUd6v3ZSEqVQd0M3G56J6sWu72iIrbMVJqzc4EHUn6VcsrtMXOXRQ0CQ5Wp0vKSD8GzJ5LgYqlqO0InhlUfwowbVWXyBc+V1GDseJ7tES5lLt2pmrmDtZUFmvYECuhlJbjS2I2tWOYg0omAiV5qhLQ2dEM2FvJj7IgAdbt2w3AHXFoJGxS3sWMHtf+tnSlXhBS83TmRwV0mF4jgQb6ldpSq1g4670kA2+Ev37QaHJNdg52JNsKDY3I+5RKo2mcXsrGgjsdjsomIfaJQCsV6DQ8eko1jcGYqO4STJVW3kcYxocGhmozXr1DeAfc6MEXOAsTloN0+almXN4Q2No1/Wh6z+/seOQ1ckJdQlFv/YpDWmgTBDVMf+y07/QeH7qm1Q7f39fSSOFlLk7c2XX3KEIU1tfjxY2O0vATswXcD0mFc7qZO6SHV/fprVPKpaalYmrhoZfXdiTRgcNfqjiV4DYt8JgKaIHzWBVUEP3Gt95rXFadfNFToni83Wjmg2nWY3KOF1iJhLp/i5pzMsguA6ZNWLXMM9FO/8QwzcsJZlZMj+YCWRM5nHXF15mgD+G0zFqko4evqjlFhaS7DJkAQhmApcRxGeovV+fEEUodzRC5g5t7nLMEHyvkhC2wnv/dQv5zxMUcrSwuL0AMZlxH/uuQsAhDU9vXVB+iDbqbRx0WR7a+CHAvuHaknfkwnFDbEhPxrYg+4kmXnsp6EQaxz/WsF42tgrr6/2XpDCQbvkGV4o7q2W8q8F5FAcPkK7zNTgiXurf4IcQCGFqxRMoenGLdCzi6JBBJCUkDidEUcpkUeX ofnIBiSo 7N056VNBLDcX2/EQFKky6qQtEIDdBWgIzVcsDBub+QhiHuSXt6cnMhnGHR5449qzTtbkGlef8yWbdYwxmO7vThELbDHuUQOM6wsKdHJM0w9JvSvfIdn4CqisxYjKiRTHE+dkQ9f42XKFTheqBxRk3E2i8GZTXCMw2sILkZ5QpR02VHhiAbnuZerK39DsJMiCHhkNzJmEl2RfGmgMUnXkVnfb4q6YKASJ2JvLa21HxhmwofBiNVE+pI6DUo55j8GB/FLL4cN65t36MztXeqCV60H6Jq+sKeN3lwR/cNMYD5eYXh+MQNkuNkNmve+2SKJcyNEcu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 6 Jun 2025 06:10:31 +0800 Kemeng Shi wrote: > As noted in the comments, we need to release block usage for swap entry > which was replaced with poisoned swap entry. However, no block usage is > actually freed by calling shmem_recalc_inode(inode, -nr_pages, -nr_pages). > Instead, call shmem_recalc_inode(inode, 0, -nr_pages) can correctly release > the block usage. > > ... > > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -2145,7 +2145,7 @@ static void shmem_set_folio_swapin_error(struct inode *inode, pgoff_t index, > * won't be 0 when inode is released and thus trigger WARN_ON(i_blocks) > * in shmem_evict_inode(). > */ > - shmem_recalc_inode(inode, -nr_pages, -nr_pages); > + shmem_recalc_inode(inode, 0, -nr_pages); > swap_free_nr(swap, nr_pages); > } Huh, three years ago. What do we think might be the userspace-visible runtime effects of this?