From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6CA7C5B543 for ; Thu, 5 Jun 2025 08:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 672326B0576; Thu, 5 Jun 2025 04:31:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 649EF6B0577; Thu, 5 Jun 2025 04:31:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 586CA8D0053; Thu, 5 Jun 2025 04:31:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2F9E08D0007 for ; Thu, 5 Jun 2025 04:31:58 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CF413C1E89 for ; Thu, 5 Jun 2025 08:31:57 +0000 (UTC) X-FDA: 83520679074.24.C9E895E Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 06456C000D for ; Thu, 5 Jun 2025 08:31:55 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mDBChY3z; spf=pass (imf22.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749112316; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=W1N43O0IPzCZgGOpE9PSizViGGl/Him1EwSIbXxaLPk=; b=BbC8weI6w2kubFkU1v1L/8FKg3FX2CfIFviqqjRNrB1fTU+DSpVyYxOIdjxRiOHC4UNlds UebocoFHPHp5kUXL9xcFOSrrDnskSqu7T2yrUXsQAJdWxCn0j43glR4+5TZrRi6d03KCXY TxtmyVkTppsstbu6S9fGzq+BRLZ9yVo= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mDBChY3z; spf=pass (imf22.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749112316; a=rsa-sha256; cv=none; b=Zze7lV6bBpjPN+biM8RQXqvsRI37++ZtE9pXeoAo7uSErlwoNcGoa18yC0+8W3jXmG/Et6 CanP1fXILIomrx7MgOIqQInSO24i59oVTJCF5kdx5G1uFfvR2f3eXPZkCUOUBMi0BOQRi0 gEma7YF1KmLHW2WSvDtCnYG+HrIPPxs= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-23539a1a421so6453685ad.0 for ; Thu, 05 Jun 2025 01:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749112314; x=1749717114; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=W1N43O0IPzCZgGOpE9PSizViGGl/Him1EwSIbXxaLPk=; b=mDBChY3zKWo74Yx2O/NwVRp8icgllJdy+4ykqOCbZwGEOxjeiTeuHalqvWyNv1cd9u Y487SJYIwOMAnvK7/mhVFzZqIQcoVozx8PdyfIl4DdkUMjrjzRmv9UuVGKdxgruz1ScF cgpeRK7pKL+L18+d632V7yyNq8E/8cvcMehNNi+mZkIjDL7P+KmoiVUA99XSQ3PcutSJ 3NR3siM9Oc3+OcfDAZKoVz/JpQh+Gh+C8PTL1prUWb2DQTJHC0JRqD/d7bP/n4rDPFpV 9M7D7EoVjR93zSv9frQ8QHKTttMz14BXLTWTkKdbHvctz28FUVdaujhRaYWcb3SYQfks LU1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749112314; x=1749717114; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W1N43O0IPzCZgGOpE9PSizViGGl/Him1EwSIbXxaLPk=; b=e1zlZyVs93Wy11uZOlVOcKyGtO3DUkeCLTumPMppScl+qSvTGQxv7ydZiDB22si2ux UkgPBASErxyjrC4GgxAbyPdlsm+skO9mHT6RinDiloZR7quZpZgABKBQ4gsQsxWa6NBx TaPeU9/pJnTki/DLbDq19k3to2NatNXRwZg+dSmhz7uoiywHKxE0dkNk/E6ObLD9rtE6 SSSlsbab7yZ/U2INsC2fmf0D2J0w0/ja11HOd6HfpiKtpjpQpzV6qt4Lo2wwhVUgr5Ma OKGsVCGHkF0u4Wqe+RMxU0yUzI/dxIT0Nvd8MfmDiJPWJntMWyFH3+Wa9NMPBI4PWfVF 803w== X-Gm-Message-State: AOJu0YweXJQv9E4RfrRHAKcTjUhprJp3MbPi6b7lg+l2WLHOFySfAL/k qY6Ju1sjA92ZdG1OKk0cMvT2e2roCtkkiyVDe0tfpzI3N/fx5EK5sRY6RaRMNg== X-Gm-Gg: ASbGnctvuqOpwm5Ubi0X/FH7c1OTLdieVDCUdVxjnMU+5EsqprjaWLLdUuFYk9/YaXE yPyfhJNPp3ffuMjSlotHN12gD1IUWJfmdo23G4py8GBHJfSCGPCL5XEyJip7RLUHLCRPG8CZRlc gxKetp304U5I7IVQDS3y6GUxfHuaT2VHKYSP2G/Xm77uIw3BGBJu2TqUTeXxk4qSs9BrYuLg1j0 b0SH5NmWmtmVAGbNrfaWU5vTeb+grJ+gCgBoqwKw2DVrMHWvWL1hvePhyaBX0H054fw+7RngwQN KaZsuLU50Cs4UnWMrjHwK8eC/fuQnC9RG6e6tMG5s/Oo++2WY9/RxzD+SRZoYJQXt4Y4 X-Google-Smtp-Source: AGHT+IHKZmoqe9eJZLdjSZjmAb9Z0ljuQq3KvmuBOUt5RIMd27T8fNc0ZChvbzWquciamYF2FEiKUA== X-Received: by 2002:a17:902:ce8e:b0:21a:8300:b9d5 with SMTP id d9443c01a7336-235e114f0e6mr83321845ad.23.1749112314338; Thu, 05 Jun 2025 01:31:54 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.145.159]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-235e5aafb37sm19991245ad.203.2025.06.05.01.31.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 05 Jun 2025 01:31:53 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Barry Song , Anshuman Khandual , Lorenzo Stoakes , David Hildenbrand , Oscar Salvador , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Dev Jain , Tangquan Zheng Subject: [PATCH v2] mm: madvise: use walk_page_range_vma() instead of walk_page_range() Date: Thu, 5 Jun 2025 20:31:44 +1200 Message-Id: <20250605083144.43046-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: apsru35ntjhtnxe9byxm1a46wrw73xxr X-Rspamd-Queue-Id: 06456C000D X-Rspamd-Server: rspam11 X-HE-Tag: 1749112315-604694 X-HE-Meta: U2FsdGVkX19hO/rUrkViLz37SUqyfGq4BJpK93D1qekgE47/yJqZy8Q2NjtRL+mbNPM++DmDeK4tOHNrLJMOv76m6s83OxMqIsVBiMhL6PvzT5qTBT+JSuZ1TmK3Y9Kg+q9XfCaZfXposo+bwukdSCCkZq2pTM720N1KByMThchOEpv/o4jUAjFzK0uCDaL9zozigmGGSE+U11rE6/h0D95Q4NTjRy2tWJyOglayQDgkBvUNABofAyeO6nm32pvcIQP6bf2Pl6/IOWPlxUGhNOA7HCzCMelTOenK6Stf598K4iEq9YYritvEljv9/cpeLwwUBfkarYHHTDydb7kv0opL3NkuNDjJbuviIwPJdnCkiKiwBugeoQAOAJIBrGfN+qRBhdWQIWltAJrw3SMMKISI9Im/pM5RperDXJVHG/0aOXSlYk0YPGtT19MINOVNOB6opm/AsZEAlRgOKN5xc+9hFKay8+QYJtQtmRVUfHW3/va7OcQjvEAvyQdFKkq/PMcSR80rSrnHz8ihZ5WWJyqOe8dYkloiZj0RsC8fKwiSCBrHaaP0upOsJmyFI3qWv1Mbh9MpMhEhceLI5lSlkPDom2OzvTEhORBIWno/clt6VmZI3++sDreYBafNTeFyx/NU1BANiF7azqHiv734TTlJyeDJ3rHjG/Dm/q7w3qkt6M8ALzX+Vw9jYuZwHo7YD/hMtLhPfnPuXUohWsxVkW8yUl7vA7uz30HSuMX2tOSlGx1SEIeKq07JwYs9xLYOYCQoyoVIxjd5kL74StiK8SH+A4cPhnSWQNW6Jiz4UyuAdgdj7w9jNcTIBxKXPLOETKyi19F4XGKMAcjxswn41Ndg8DZ7js2srvQalpbx2qIdhXyQArb5swgcREgcYIEnfwwvjdh+25Z/qn228rT7kcGa+dVYqJ0fWTGY1V4paCPZfTAx7VznOsvyHQXZWlJy3R6mN7XjXDTtk65l204 KTjJQAPf 1RDUXwVdphHmbgRAe8lPw/ZfTe1zPwfzEcmMenkaNY9viCHn1NCRrXW/AOniAVwPJououMDaRFk+h7EeuUWwSdSai0AJxY67svxLdbYo0MoYu7KGTuK2kb/zdEKVNt66ADmKUs9Pnc28JiNCuDxeXtXjlknb0Kwgwo9In+T1N/wWMUDYqSSluZGQK7PCDZ8B8hac7jyR7H/+qZLp7Dfqv3/2/Dsy7cW54DkrJIRDytfpZRRV2FYzb+Fyf8suCAQINc5LjCvcKlGYe3bouQmKVRP/4F9b0S1iP1VC+qa4VgTlhQuQnqyHhe7wPu8Z7/schlGcRCbApitliIgRODDcwdanh/6FghcYoQw6J2dmn4Fd4rbwGOw0wKCnKDlCKegb2gzOYuaBNMGwqiWNt0LpuIzklX/nq0QhEWw0gt/OYPXAgEWjI/t8LM4lWw/ILbd/RJ7OWjZOLHDoqWlsqfo5ROlBQwbzAY+JbseqKNE9yCfvw9RJ+WPBfkW4humEC+9NFYWOOTh/miH4lrZlqRZrRyWYOAugrCCxKBGj5ePNZCrx7pUzZBQKOzaKHGFYPSsY0qHKu0KLA8RhBHgKZm4OJ77v/BAeuo9C/m5q5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Barry Song We've already found the VMA within madvise_walk_vmas() before calling specific madvise behavior functions like madvise_free_single_vma(). So calling walk_page_range() and doing find_vma() again seems unnecessary. It also prevents potential optimizations in those madvise callbacks, particularly the use of dedicated per-VMA locking. Reviewed-by: Anshuman Khandual Reviewed-by: Lorenzo Stoakes Acked-by: David Hildenbrand Reviewed-by: Oscar Salvador Cc: "Liam R. Howlett" Cc: Vlastimil Babka Cc: Jann Horn Cc: Suren Baghdasaryan Cc: Lokesh Gidra Cc: Dev Jain Cc: Tangquan Zheng Signed-off-by: Barry Song --- -v2: * Also extend the modification to callbacks beyond madvise_free_single_vma() since the code flow is the same - Dev, Lorenzo -rfc: https://lore.kernel.org/linux-mm/20250603013154.5905-1-21cnbao@gmail.com/ mm/madvise.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/madvise.c b/mm/madvise.c index 5f7a66a1617e..56d9ca2557b9 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -282,7 +282,7 @@ static long madvise_willneed(struct vm_area_struct *vma, *prev = vma; #ifdef CONFIG_SWAP if (!file) { - walk_page_range(vma->vm_mm, start, end, &swapin_walk_ops, vma); + walk_page_range_vma(vma, start, end, &swapin_walk_ops, vma); lru_add_drain(); /* Push any new pages onto the LRU now */ return 0; } @@ -581,7 +581,7 @@ static void madvise_cold_page_range(struct mmu_gather *tlb, }; tlb_start_vma(tlb, vma); - walk_page_range(vma->vm_mm, addr, end, &cold_walk_ops, &walk_private); + walk_page_range_vma(vma, addr, end, &cold_walk_ops, &walk_private); tlb_end_vma(tlb, vma); } @@ -619,7 +619,7 @@ static void madvise_pageout_page_range(struct mmu_gather *tlb, }; tlb_start_vma(tlb, vma); - walk_page_range(vma->vm_mm, addr, end, &cold_walk_ops, &walk_private); + walk_page_range_vma(vma, addr, end, &cold_walk_ops, &walk_private); tlb_end_vma(tlb, vma); } @@ -825,7 +825,7 @@ static int madvise_free_single_vma(struct madvise_behavior *madv_behavior, mmu_notifier_invalidate_range_start(&range); tlb_start_vma(tlb, vma); - walk_page_range(vma->vm_mm, range.start, range.end, + walk_page_range_vma(vma, range.start, range.end, &madvise_free_walk_ops, tlb); tlb_end_vma(tlb, vma); mmu_notifier_invalidate_range_end(&range); @@ -1160,7 +1160,7 @@ static long madvise_guard_install(struct vm_area_struct *vma, unsigned long nr_pages = 0; /* Returns < 0 on error, == 0 if success, > 0 if zap needed. */ - err = walk_page_range_mm(vma->vm_mm, start, end, + err = walk_page_range_vma(vma, start, end, &guard_install_walk_ops, &nr_pages); if (err < 0) return err; @@ -1244,7 +1244,7 @@ static long madvise_guard_remove(struct vm_area_struct *vma, if (!is_valid_guard_vma(vma, /* allow_locked = */true)) return -EINVAL; - return walk_page_range(vma->vm_mm, start, end, + return walk_page_range_vma(vma, start, end, &guard_remove_walk_ops, NULL); } -- 2.39.3 (Apple Git-146)