From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04466C5AE59 for ; Thu, 5 Jun 2025 07:40:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F5D06B0178; Thu, 5 Jun 2025 03:40:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CF566B0179; Thu, 5 Jun 2025 03:40:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BCAB6B017A; Thu, 5 Jun 2025 03:40:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5A40B6B0178 for ; Thu, 5 Jun 2025 03:40:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CCC54141CF4 for ; Thu, 5 Jun 2025 07:40:01 +0000 (UTC) X-FDA: 83520548202.21.479ABD6 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 5B342120008 for ; Thu, 5 Jun 2025 07:39:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jO9jfDcM; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749109200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9ZIrQOTa/wSy9a4xpfBaJEawiyRe/C5BRLMFLu7DmEc=; b=DtwFRmgFr8C8wmMtAd4D6we4QObpgrVhrGNMGaYq4EngBcfiE1QZjC/OWyhO6o0DQ6+Uwb FjQyGClA1QSyNnxgw2ZVbLnwVTqj+TznwdnC47merwdqNjVa504Y2jV076woJceGhoNMAe ItLtI16NJq1SaAMsqvJgFC6sCuERYzY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jO9jfDcM; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of lizhe.67@bytedance.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=lizhe.67@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749109200; a=rsa-sha256; cv=none; b=7DuTD8/0A+oa+WER0uHUqUtGwhKKb4QEOBKjv7SBdm/nN7A75WVX5NYMTOT97rWMTUmUKV a9G4SqG5l1SYPYzLgeN3qC4tkUevvdJvQgPWhIjLXw9J6cJUS/tk+FkW/lasa9cUxOrXn6 OF2+xYSueq4FZp/fqsK5TeNnwNHY2MM= Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-74800b81f1bso631614b3a.1 for ; Thu, 05 Jun 2025 00:39:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1749109198; x=1749713998; darn=kvack.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9ZIrQOTa/wSy9a4xpfBaJEawiyRe/C5BRLMFLu7DmEc=; b=jO9jfDcMLqc4b8s2x/gRpt51GF7qW14IfEYQ428U42pxd7+V5gublAciTsPfQZq5x8 WveSTqK/cV9V3+RnPts/JPeA/ERX1wbNLyYVXGxFVeHaHL9EfJutoAOslfiW8ZO4vv7C zt8lXqzjK9gDdhkIA1k06lJY/b64gFlkOBTySHhhWLeFN8EwolSTLMzwNTKeO2r/vlHH +kqDOXjB8/yr77CS6bqHH/xpg0IsgK2p0mVHzS+0De+2sMTjj4pgHvyFPpKU4aluuOn4 ffTLVSbfqu9bzsqeCFf4zSG3ucQCvALhRXsqWPltYsl3F0/eB4W0rQUoTJVrkZiq55ZS ennA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749109198; x=1749713998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9ZIrQOTa/wSy9a4xpfBaJEawiyRe/C5BRLMFLu7DmEc=; b=DCoyk28EkghSZZcMzyYyEKnD3fh/uCn/401ZPqrzyIoqvQVSdmZfBCWsGCknn4UTUr Oj2r5FaRJuv4CB6uX9iuojnvJ5XfOzD7XvWRKdTwyXobCMxK+hkcKtpkEMm5YX/gcD66 Kd127gG8qZyYfzQ/wrSbW/Ws6a9rX6juXC4ZXZfhHGqKOC0T4EVFrbDxJRn0MIg+lJWa lbCJgMdds1uUMdHeYUEZNqx21pd3soMWrbC9RhhdQIxrEBO2g/XAg1dAwMylEEQaIdLj 2QZBFcYRI9g8E0h3RkIU3AOQUMS+u2Aio89Ok14MjTd+GZjQG1AM/ZV3H+OKle93/TlG Y0Gg== X-Forwarded-Encrypted: i=1; AJvYcCVs1Nqb3x+IC7x/dX0L5goSmSmXdFP2btjLBX/hjiPP2+4d9y5F1vmaYjwStCB6Z+rYivl2m0xB1Q==@kvack.org X-Gm-Message-State: AOJu0YywZ9COvVZwO1y4VmLFnCj51XEtp8C3TdPOYx41RHeew5Ihm1cp 8FpIQsxWeN20X/JdYSUsLDBI5l76Tmhc0dtgi/S2vcaJudDTGo2QZfsgpFg7hT9zGaA= X-Gm-Gg: ASbGncuGaIAsQQvTn7rT3d1fWnFbJ1UqHYMcUz1Usw7F+qnXrPkl4sIirE4lli84kxc uRy2+lln0A6h0ziP+cuJzbSboJmdpXHH62fj8aznec85ptGa6rCGHxVQoOQEk7xvxuV0/EQB7Jn L6gWGPYfA1U0RQhdWiQFAe0pUMUN5e+iE1Jx4DqlPXvMCA2Z6MqSvawHKcyN5vRr8O2uvK11YxF twvoXRn0npZJWyjVo8AXlBpeizJRlaSSTcbf5khMw/eH0eVaJeWTc04alzIyYZORWyv1BGen0RZ wMdAcwY0Mu2d35vNK2c3i6eUsPERXM5F8Y743Jxh83Wy5MtQG++oNcB8BDLPAmOrqOj3NTebiq9 OgVA= X-Google-Smtp-Source: AGHT+IE/Es6S0H+BL0r6JFnYM8UmDvdK7Sva5xq12q4WAUEBp/Agtr5apkK7ggUpBDLFNTqn2tqgcA== X-Received: by 2002:a05:6a21:60c1:b0:1f5:7ba7:69d8 with SMTP id adf61e73a8af0-21d22ab40bemr8127126637.15.1749109197834; Thu, 05 Jun 2025 00:39:57 -0700 (PDT) Received: from localhost.localdomain ([203.208.189.12]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747affafb01sm12705111b3a.104.2025.06.05.00.39.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 05 Jun 2025 00:39:57 -0700 (PDT) From: lizhe.67@bytedance.com To: david@redhat.com Cc: akpm@linux-foundation.org, dev.jain@arm.com, jgg@ziepe.ca, jhubbard@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, muchun.song@linux.dev, peterx@redhat.com, lizhe.67@bytedance.com Subject: Re: [PATCH v3] gup: optimize longterm pin_user_pages() for large folio Date: Thu, 5 Jun 2025 15:39:50 +0800 Message-ID: <20250605073950.1834-1-lizhe.67@bytedance.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20250605033430.83142-1-lizhe.67@bytedance.com> References: <20250605033430.83142-1-lizhe.67@bytedance.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 5B342120008 X-Stat-Signature: 7t69c8ptgsob4mfm1dqyif7m57fetp8s X-Rspam-User: X-HE-Tag: 1749109199-427653 X-HE-Meta: U2FsdGVkX1+RvaOMP6FAgCa2B11wgv8vQsKs/44wRixoSUXUyVkeCre9nS3xfV9VCxLgCdePId+1Cq5ngk1BbuyDwIXCDV+FTC/W9g6ZrxY1eAQXwpDapU/0gVsp8BGUvEUMsjoS2SgcbmnPYLeBqsC8BvwPe5NpW9A/oxvKwp3IO8eqBMGA9zRTeTYygPMUyRovd91W42Mv6nCNavCKNWXhk/A4/kYS14I9/Kj2zcHDTWxt26hJCyPRKVVaurBdU/LGjdbRqgsvmc2vQSZZL96TqvclwFJs+2Cz2TKUiIMKOXngzRm7ZgsX9HOiMVD89LG2P7/+Vd4Mkhn/wBjM84morLrVfCABEBNu9/Q3w4F6zP5HL2AwNzpnDvb12xtf+mTcrh5Qz2r+aCbqP2Djol7r1YudzEGmC7u2GENjKHISwHMBdxRTbtB5MFkb0jHbzokwCtDP+kklwk35fXSpGqxK0Xyfr6YajP659HN2pkjqrLk5Dp3iVCjAHZidqee2IukDlVsMnMQ5uocijhPxz/5dQdQVg3enigNNADjfMNzSjTQHOSnNK5zL4V9IyCgiKF4m929OSNv0AHw+bPSHF8jKtQGAwxJNT/xnp2tiExLEeLBoL4l257pY+wB8SJhYsMo6STU6aehcP2sE2VCDum/UClUTCWQk/BQ1wMG1ytOK+1x98chhoG/9bH4grmmOSXoUrnUCpplwKugoJy6nsgLkIK1OTD8f8DFSB+4qSUmy9cBGsZjsQWJ3HQhAiFgB/hfojWaVg0xt7KOORrAX3UBmTL8XZvieEa9wfstVZ2GIL6TYiA0SvWMBdjEF19jxXS9gnwLzguusdll5fNaB+YndMcvIyShVJbGaOIVL0JpVVkeHpdLDYemAZRnVw+Srgz3tfU1QyvQRJR9EtushpiwHjtqpP6IymxNO136ExDzF0/wdCQsvk/z7DyQszjgy8Iu+AtLRbV6M2YezQyA xcmRpg6Q XgUEN4+I3Gqd7kUQ5WRCneclUr8pWA3RWNtlvRejn+OKJuHMLyW0DWhkyTAIBPgW5pgJ4Sim+aTlyVQkImyV7CDqXFYRkwQ/yPOyaOi+rZ6zG/Dst+3+Y62kUJ/GaLej4Epl8UaxSFR+poULTHumt+lu31wjpaTVLEEFI7oNUknSkM3QHMa30KEmDWg0koHR/Io2QViTeWVn/r3uzS6VxECFcfb8FgQTxCkwkmCpQXxg4N68oGGtp8JVVCf3vY5dHn9LA5yllqzmCBUlql578dvVz4uRc9DwnMyQGdhxSJX1Oft27uJ0S9N7d/KGb0E6wU2KCduTRDER9JeXGYgQpj1XNKhAnTCcaVSlitFoSeDlLxslzHGf1ugBy8scsw4nUAijjJXx9KnWaiRDyhJE3fmQAQA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 5 Jun 2025 11:34:30 +0800, lizhe.67@bytedance.com wrote: > @@ -2324,16 +2349,12 @@ static void collect_longterm_unpinnable_folios( > struct list_head *movable_folio_list, > struct pages_or_folios *pofs) > { > - struct folio *prev_folio = NULL; > bool drain_allow = true; > - unsigned long i; > - > - for (i = 0; i < pofs->nr_entries; i++) { > - struct folio *folio = pofs_get_folio(pofs, i); > + struct folio *folio; > + long i = 0; > > - if (folio == prev_folio) > - continue; > - prev_folio = folio; > + for (folio = pofs_get_folio(pofs, i); folio; > + folio = pofs_next_folio(folio, pofs, &i)) { Hi David, I used three tabs for indentation here, but it doesn't seem to be the effect you wanted. Did you mean that the indentation could be achieved through tags and spaces, so that the folio on this line would be positioned directly below the folio on the previous line, but offset to the right by one space? Thanks, Zhe