From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ABCFC5AE59 for ; Thu, 5 Jun 2025 07:26:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E80C88D0053; Thu, 5 Jun 2025 03:26:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E58458D0007; Thu, 5 Jun 2025 03:26:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D94F98D0053; Thu, 5 Jun 2025 03:26:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B9FD98D0007 for ; Thu, 5 Jun 2025 03:26:29 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 46A5C140F94 for ; Thu, 5 Jun 2025 07:26:29 +0000 (UTC) X-FDA: 83520514098.18.6D40B8E Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) by imf04.hostedemail.com (Postfix) with ESMTP id 9089040011 for ; Thu, 5 Jun 2025 07:26:27 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="e/4GJM9N"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3okZBaAoKCH0sjdibsezddhpphmf.dpnmjovy-nnlwbdl.psh@flex--richardycc.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3okZBaAoKCH0sjdibsezddhpphmf.dpnmjovy-nnlwbdl.psh@flex--richardycc.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749108387; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=2MokvGMwL09D0OLQ/6NaZYaKMAEKNW/33zg2UVKOKGo=; b=3S8sq0NK5T/OEDfxiEHy/xhQvurHnCzgS3/n6+JUtSG5oQw76XNdJTPP953O7W4fzM0FM9 AaB/6tOsHm4SBmsFPuuizah4ySpRUHcUitPIWf0WKjnF6noXKwfpx5jMa1qAm7ij2IsEPy 7vvQE+y7i/TShq9ycEpvLE6pOw1fAC0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749108387; a=rsa-sha256; cv=none; b=iO5gym4B9txI4GoyDPT1wpN7NG0fryx9O9LR8Zgc+7nasgambO8AXxaN43ERKqaz3NNHc8 V7kXhpTjV6mAagndbD8yB52JJFP5X+mms490bxR7Y1e1gmUEsREtHnlL/j//nfYlFp6R/2 /z4TecY77gEMZDV7cUwnJ3geP/0/rtc= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="e/4GJM9N"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of 3okZBaAoKCH0sjdibsezddhpphmf.dpnmjovy-nnlwbdl.psh@flex--richardycc.bounces.google.com designates 209.85.216.73 as permitted sender) smtp.mailfrom=3okZBaAoKCH0sjdibsezddhpphmf.dpnmjovy-nnlwbdl.psh@flex--richardycc.bounces.google.com Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-311a6b43ed7so677602a91.1 for ; Thu, 05 Jun 2025 00:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749108386; x=1749713186; darn=kvack.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=2MokvGMwL09D0OLQ/6NaZYaKMAEKNW/33zg2UVKOKGo=; b=e/4GJM9Nhf8TsRrCg8I3QWgwLGZYJOMQCdpzsbGt+N+mpby7h+kavk0TYLETJxPt/R O0vdk0rb+zINZc7PO+8NnfMgPLwEw1Tyf7hLA8+rP1eWPhCvdEPOBwsnxAWcTjqCDmEY 92DJjAub7BOrc9zfeAZ80LFO3iN+L+hOYcaXNWg494ZxbNXKUN6TI5vvPo5wEjh5QBzt 39ioaYrp9seQvmmcbsy5FgpugzEe0sPb1JqhE0uizFhDtlMjefGZ1FlMBm9ax9UFRLI8 UW/RbjelLaAdThEDw3I6Q5VdXEaRq5MBZzj5hgBn6v/nE24bc+VM11dSCF7i2C3Jjw1X olkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749108386; x=1749713186; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2MokvGMwL09D0OLQ/6NaZYaKMAEKNW/33zg2UVKOKGo=; b=fb5G/Oy5Y9I3Lr2QZ+GLYhM2hdaHU2Sd2iDA1ADcvtLvfXysMOH9OMEgvvbMRTLVRs P3j8QcoVrLgZWaKdhxu8rA4g2H0cHvG/tHMZCt9ieRvbVTWSb3Kg7coowLPD2qeBhD0h imZ0YN1IBASvWkxBTa7JgDCWT+W795pHwERRy5vKFWZPaVSitlK/X4KCsyUMxpZY6s97 zj891D/shMsh+5mpGEqt8cpo1cRxk/PTqQ8UUZeLZ7Pz5AbGy8F0uNkW+Q2jDxOyfTsy kvfB5CntQ4DMRSxvw9VgLX8wEKkoGZNEV8zOJP7RQMUzRZVQaGSY6b+XiYDgri7HfKzr HSFg== X-Forwarded-Encrypted: i=1; AJvYcCWtkFlScll3q0DD2+iKf3Iel9ey9kXbu8pX1crbBc+wDdFpylLlo8+1SpRnSkJFscwvfIBrXNxIhQ==@kvack.org X-Gm-Message-State: AOJu0YzFKPfiqv3MoWeSGlyADBB9KfGsHPoL5ts8hO7IkXh7l3Wgm4Ym uzkzEwDnCB4QKYWNCKBk2PGu2Qh1jbCoqGv3uhPrMHY2omqxCvnauKM/bfNd8SU8Hv9SywGiV9T +5+SRNlNaVVmGwzVIUHZb X-Google-Smtp-Source: AGHT+IF2n0LbFZQXSjnvyZophImJUxlZUuR9yUDzkXjumT0nr3vwiMVMLFdVGoc+QYTRS/ncdwqUf4qaLGjxkmAI X-Received: from pjbnw10.prod.google.com ([2002:a17:90b:254a:b0:311:ff32:a85d]) (user=richardycc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2fc6:b0:311:f2bd:dc23 with SMTP id 98e67ed59e1d1-3130cd2c617mr9320607a91.15.1749108386231; Thu, 05 Jun 2025 00:26:26 -0700 (PDT) Date: Thu, 5 Jun 2025 07:25:32 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.50.0.rc0.604.gd4ff7b7c86-goog Message-ID: <20250605072532.972081-1-richardycc@google.com> Subject: [PATCH] mm/cma: pairing the trace_cma_alloc_start/finish From: Richard Chang To: Andrew Morton Cc: Martin Liu , Minchan Kim , Kalesh Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Richard Chang Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9089040011 X-Stat-Signature: 37joaqqzfhfyrwgjfjwwjbwqbmchxj4f X-Rspam-User: X-HE-Tag: 1749108387-216489 X-HE-Meta: U2FsdGVkX1/7WSxrO1P503WQ3pfRoDlaEIf0Mb0V7E2hgsWSIKpnZ6zRsmjdtaLUkmbk9cjwerUooxYHTczckurklMYp1n483nv3T5fQ/00DhhCjUZvootF2oUj8XSJLey5u5TtH/gNCWL0CQH+lXhZ1tc13LVnPL1Q7vjlLB/v85s7NC+HVRwbRVNiWiKMVwPoYZawrS8+HAGcOaaujgwZkUZfBYaqdn0R88F62jgI8NyJYsravljwzeOjb8mXZBHp5MYrchmfQUeySJLznt6FFP04+tuNVM5J5g9kzO9qPoNTHsE44YFyoPD9LVuc1lv5QTbToaESWLOh4+DHZClW5vLLps0crmMYaU2ehj+ElDPwV3MFIV4uS082DLsqz0UFjm9+WJfUsDH/Ouqcp7s7P3xZTzwv8PLr3UpY7UaPUrKFt21lIMacWfgkfsNKBG6QaZhyBr3BIOSizXX7FyNEZBHZ7KtKgXK1E59tgHfbNXC6x3WxUe1GNM3ImAosg2c6Zg6KCdp73IeMZKhMfkZTXa8wc82gkh+/DGmz+HXdTzemDLlUeNzMR1VG2L1exWVej8mIwRNa4LCe1e+O7SQXsuu6R1qGlDLkUxyaQvOSxOT/A3Bn6dfdnottrdSQ67wnXXUZZvYArRnfvqQqPzxn7Vw7ywGC2jjk2KyDaEEpCg7LqjeC1vi0Tny3lnguNJdedOws6yr/6EZmzK/FmNnXfiSt1KiygsJ/yymznt3I4XReqF/1nUk1y27cvO69VTC54tSUToGH2j2DPhOE0EsTYwbK0eRepMs1z+kc158gfAzNL705Nq28dlYWJmkozBVxm1+eICIdazqDwxcpD48R3qkLaEwVRqBohoWk055lp+eg/p6lF8D7Z5XsMY9DKi9b7VJwpYWrPMRLh4binpeNceKSUA8cH8yJGdK6QvD5btmH0BIzvNCkptUJXT4c0nIuON6IAUXGp9rB9Om2 haa789EK ObHnYrTUUHyNYi+tcpgUYwmZ9QyKyVrvwOFuEsuAeU7Hd3Euelb4pONyqHpe1NeTNkjthhNCmMoSJ/5g1waApPRvI0AOaRQ5UzAz+cOBNPMzFXWqJUmgH1sRAT6kVVafuARMeUjm5cZt/67BiJeYgMPWmXFc/tj5KznRigQGboKEQo4ZgjqU9jqX5KsEhL+ir7mHKQOL2N0pgUbc1RtOUvldMATtGPCCXFS3IF1gAIg7zPbQhLZWZsKm4072mchHZXcNIMv+mzKK734ggc9J21tWLimItNn8UiBQ04S0uNqIMwLdRbSqgKEHo2j2W7rLdHLcIG6ijUR3CKTFYo2syfexE4GwK848jrfmsU4kpQNUp2fxN+JcvIaYVblFvFb1p/6unphR7e1q9efWK350jpPodsEz/Tnsmhh+fJYLt6aBuCRh85rGygadtR4W54ncs2emGjPc0+L4BQcNbgwEjrlFTBRjoz0GtuBZHVTk0sQNYq7wmWyHw6V/5BfSpyZJl3ZkrzwlkyC4MFRM3sfa0ee11JgU0SCoO2VelwrqngSMgjzf+43peaGiO9jD4I1AyRyzh4MYttRcbhAVDvF50+AOiXbTmmXh1NcmZquYTHkoSjPENsfz6N5jUJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: In the bad input validation cases, there is no trace_cma_alloc_finish to match the trace_cma_alloc_start. Move the trace_cma_alloc_start event after the validations. Signed-off-by: Richard Chang --- mm/cma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/cma.c b/mm/cma.c index 397567883a10..bd3772773736 100644 --- a/mm/cma.c +++ b/mm/cma.c @@ -854,8 +854,6 @@ static struct page *__cma_alloc(struct cma *cma, unsigned long count, unsigned long i; const char *name = cma ? cma->name : NULL; - trace_cma_alloc_start(name, count, align); - if (!cma || !cma->count) return page; @@ -865,6 +863,8 @@ static struct page *__cma_alloc(struct cma *cma, unsigned long count, if (!count) return page; + trace_cma_alloc_start(name, count, align); + for (r = 0; r < cma->nranges; r++) { page = NULL; -- 2.50.0.rc0.604.gd4ff7b7c86-goog