From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29DF8C5B543 for ; Thu, 5 Jun 2025 05:50:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A26136B05AF; Thu, 5 Jun 2025 01:50:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9AEEB6B05B1; Thu, 5 Jun 2025 01:50:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89D426B05B2; Thu, 5 Jun 2025 01:50:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 673A76B05AF for ; Thu, 5 Jun 2025 01:50:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EE67B1618CE for ; Thu, 5 Jun 2025 05:50:32 +0000 (UTC) X-FDA: 83520272304.05.1F12F4F Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by imf23.hostedemail.com (Postfix) with ESMTP id 8F17B140002 for ; Thu, 5 Jun 2025 05:50:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=odUf7l0g; spf=pass (imf23.hostedemail.com: domain of chizhiling@163.com designates 117.135.210.3 as permitted sender) smtp.mailfrom=chizhiling@163.com; dmarc=pass (policy=none) header.from=163.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749102631; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=+c+mkab3kXPQMWH8vwkjAB2WGK4xCiCRJaS9X7+OGvk=; b=FdkN3/IM11U4pPGjGyEaxpY/yCE8+ESxlO8n5UvUyDH5CEiKK2uHqt2NUJ51ZKBicU5zhR 7U1Ei/267+r+Qiy3r7+IUdi+XoSogJIdv3bpv/4Jue0k2/QdUq4ug/86ih6VCT2lq22oUd mDvY4MmFgBrAId7ZV1Id3ZQCeLhIFqk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749102631; a=rsa-sha256; cv=none; b=xNZepEaA3b9n9UIrboAIEVhz0BadjTN9ycbftXSKidlPcllyov/Pyrl2n1K2mA4SFw3SD/ pctWXjtjYpUJDYP0rTckf4s4NmHLmTqMacRvr+XsIK4LYc7tCLBJpbryUahv5RikNa8e8L flJ8KsNKVWglX+he3F5PLYLDajXb3+M= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=odUf7l0g; spf=pass (imf23.hostedemail.com: domain of chizhiling@163.com designates 117.135.210.3 as permitted sender) smtp.mailfrom=chizhiling@163.com; dmarc=pass (policy=none) header.from=163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=+c +mkab3kXPQMWH8vwkjAB2WGK4xCiCRJaS9X7+OGvk=; b=odUf7l0gvvsK0+2ZLb XqdZdVumbFfPvNwAolsB2ujT2Vd4RLZWy/518ELIMjCwztJgDbhYQY+2wTAQkro4 EceChtPcn7HCau8jopzICHcqHiE5n3V6wrAn43p6xFCnkJs6uFrHKmgPoiCnx6M4 fOfYk7/0ZGr92BITx7ormjdq4= Received: from chi-Redmi-Book.. (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wAnbr8VMEFoKTpFGQ--.7585S2; Thu, 05 Jun 2025 13:50:13 +0800 (CST) From: Chi Zhiling To: willy@infradead.org, akpm@linux-foundation.org, josef@toxicpanda.com, jack@suse.cz Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chi Zhiling Subject: [PATCH] readahead: fix return value of page_cache_next_miss() when no hole is found Date: Thu, 5 Jun 2025 13:49:35 +0800 Message-ID: <20250605054935.2323451-1-chizhiling@163.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wAnbr8VMEFoKTpFGQ--.7585S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruw1rCw43Cr1fWr4fury8Zrb_yoWfZFc_Xr ykKw45WFsY9rZ2kr1ayFs8KrWI93Wq9rZxWF10qwsxt345Aas3WF1qvr1rtr17WrsakFZ8 JrsFvr1Ykr1qqjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8hSdDUUUUU== X-Originating-IP: [116.128.244.169] X-CM-SenderInfo: hfkl6xxlol0wi6rwjhhfrp/xtbBgAFjnWhBKYubXAABsy X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8F17B140002 X-Stat-Signature: crrgqx1s8ho4ayj64ds6xjqu5jprboha X-Rspam-User: X-HE-Tag: 1749102630-530357 X-HE-Meta: U2FsdGVkX19y75w24ceKvpEWg3+J2xQhB+NiLB/ySuj/21dfLlTYLJFr5GYjTm3HESf9PkUJjxzRqxT+37PPNyBzPH4lNXd1lNHu9XIjObX+5JmsNbpIITPDQQ6DIM6IgEk+xkbcmQgt0sUZgnSqQ33gRLezmKQ57rZHB5Q3ha4+/w/+qv5XXH+PGZFru3mCtCWtpqgh6b5L6G2cBU3i6HAW3rlNkHPzE6PqDfIDYmWZRTtKw+Gqlg6MGGFeGS9iY2TgbiMZ6y0OupPtCqoMgCWoH/I7o3vVQDejgQNeiwUASXWGa+tBZoE7OiCBXaDqdOflbcI9OJFEjavzSX2UAy5WbcO1zxDs30lpmHvfFkP91uEOQmVKw8mLqte4mSO1/ApN1rZSz1FiFRXFNoC8fq/MIOK+M9/1AFTssQfSce6VnDY5FCTXflazNShdCIkGuzYhLi6ideSw2WUWvkgGjepT6HoLN4+TZUI97PrdNLiS4fOnvU/nZvgYJv34WfzUDVGnyRjNSNjdl2PohVs1BC+OFABKOBLmSnJtMFVve3rMBxH5JBjROSftz1nWgRTT6Y516CB+BEck15osPYRnOCDOwHHKVbLKRfcHKFtzeJS1+4I0HTjH+dJUvVVbmB4039TgtnfUEOhCuh99gnU9nvCey93ScW/sqqQhGGWfTWdyFY7ZIVzLiV+2bAjdxepqH+cjPohSKYlNq1SW+1kgNU9k5BGhWY4p80Fsskt/EqTqIaAxAoEz2cUJEbw2xnd2BX1HmjuA9OM+1lGBMyIlLqoNBaeWrlUOiGx8sKron5XZjX/uuUGr00wkGXg36WznqvV7hFHG1W4JiA4OoqzGxnKHs2i2NLNg5zi3MW1sun22/IQUtaGisHYFXsRm4mOE6cpprkPKS6rHUEwJaXsqDNgtIKVTxMZcs2k67qzD6XLXhGKK0cC0S5IhsbYRV0wTAsTCboo89R/UbaR3o/2 OepF8BBI KTe/GS0gbvruG/q28NaKMi9It3jdcT1uOY86L0MniAtWtXEEQh2bNXZtPidrBUmJaC/ycsZUtLJF/L9wlPFsmQCWuRFGS6qECw6pmd4qCPsF6EId/+MfG/V+yTK+YMF6tww6feRr3DAHZAeytBzxbKgEEUV9rRZCWVoxVni2LKAmMTnQERquvuxGMzH1cj3HIUb73ZCcZgNTvIhAMLTOmeUubnAKNWtz/dNyAR0VasJrHXNBfW0L2GNV3l/Pq9KsCpZ8QOWKvzmFVtwTvJMIwdw+CyjX3lm7Z/RkVNfMQkWDYNEXGBcWfQaZmUn5AiYZdnLb26pSpZrJ7E5vaBaHeoWE1bGnIZMd0wY4la4NocqEn58dfIhCT2sz/9Cza11EX2gsWhkAI7NwY3NhF1i96UTSoY3xqMQXHy5PqwUu1vu4rgEQfHx7zfJY2zg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Chi Zhiling max_scan in page_cache_next_miss always decreases to zero when no hole is found, causing the return value to be index + 0. Fix this by preserving the max_scan value throughout the loop. Fixes: 901a269ff3d5 ("filemap: fix page_cache_next_miss() when no hole found") Signed-off-by: Chi Zhiling --- mm/filemap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index b5e784f34d98..148be65be1cd 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1767,8 +1767,9 @@ pgoff_t page_cache_next_miss(struct address_space *mapping, pgoff_t index, unsigned long max_scan) { XA_STATE(xas, &mapping->i_pages, index); + unsigned long nr = max_scan; - while (max_scan--) { + while (nr--) { void *entry = xas_next(&xas); if (!entry || xa_is_value(entry)) return xas.xa_index; -- 2.43.0