From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AA33C5B549 for ; Thu, 5 Jun 2025 03:34:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBEA36B008A; Wed, 4 Jun 2025 23:34:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6E856B008C; Wed, 4 Jun 2025 23:34:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5D8C6B0092; Wed, 4 Jun 2025 23:34:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 84FD16B008A for ; Wed, 4 Jun 2025 23:34:42 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EAFFE814AA for ; Thu, 5 Jun 2025 03:34:41 +0000 (UTC) X-FDA: 83519929962.05.9FE922A Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by imf17.hostedemail.com (Postfix) with ESMTP id 04D7F4000A for ; Thu, 5 Jun 2025 03:34:38 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=OP97vsE5; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf17.hostedemail.com: domain of hyesoo.yu@samsung.com designates 203.254.224.25 as permitted sender) smtp.mailfrom=hyesoo.yu@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749094479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vc8zTvJQzMXjROytgiQ4wLokBHguz3GHnutGwCHuygk=; b=tpGWyZgkUpMJobHfyevhmC3BByd0uAI0SrIXec/xMfm6OvwyDhJjGgvXwZ7/Xqme6gUh42 4xDE+VzWITiFEZY7oajS+sVvqwPW1k6Lt2YUuLsTV0ww6dmj6q22km9TGe1jEv9PLrYI2E poPdtQ3F3HqEfV4Rg3peyNmCV6djsug= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=OP97vsE5; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf17.hostedemail.com: domain of hyesoo.yu@samsung.com designates 203.254.224.25 as permitted sender) smtp.mailfrom=hyesoo.yu@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749094479; a=rsa-sha256; cv=none; b=krlAOtdfn19VigcLYXoPigtojHXA1xlz7qSDCS5Dk76I2ocfLZgXmgjnd90G/04nnVGEIt 99+qc3NMGWaVwu0fA0yMrhky+QjhatraYcwwHTgJX4aOZcBpJsaNHKwXwiWwhhO4RjtA/v Z9w0MsqT1rmA/OIUbtjrEu53yECQM1w= Received: from epcas2p1.samsung.com (unknown [182.195.41.53]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20250605033433epoutp0248ecca8f18fb06d1b716b011a0afe212~GCCgOgO2H3204232042epoutp02U for ; Thu, 5 Jun 2025 03:34:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20250605033433epoutp0248ecca8f18fb06d1b716b011a0afe212~GCCgOgO2H3204232042epoutp02U DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1749094473; bh=Vc8zTvJQzMXjROytgiQ4wLokBHguz3GHnutGwCHuygk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OP97vsE5LsLamLP9C97rWIKRGVLslDZzJ1I7X6JOMZ59Jqg6IMFCaY8NA+Eynri/O S7LXFxS/PbzOuBO46na7q8UvUDKrpqQiDxoIoVMx8Ptw5uyXt472Pq3ki+NSiSQ6bZ 5GYbiZgv1nBMWn01A6WcyQmV0vO+jXG6OkrQ7CEQ= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPS id 20250605033433epcas2p10450c216ecac4bae502143e408f9e61b~GCCf5XQ6C1696116961epcas2p1b; Thu, 5 Jun 2025 03:34:33 +0000 (GMT) Received: from epcas2p3.samsung.com (unknown [182.195.36.101]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4bCVS853Y9z6B9m5; Thu, 5 Jun 2025 03:34:32 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas2p4.samsung.com (KnoxPortal) with ESMTPA id 20250605033432epcas2p4c024a9d05246b18c217f3562b3f53551~GCCfHZFVE3146031460epcas2p4j; Thu, 5 Jun 2025 03:34:32 +0000 (GMT) Received: from localhost.localdomain (unknown [10.229.95.142]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250605033432epsmtip19ff455cb5c97d9e76a5b57caec500d79~GCCfBhtQC2776827768epsmtip1k; Thu, 5 Jun 2025 03:34:32 +0000 (GMT) From: Hyesoo Yu To: Cc: janghyuck.kim@samsung.com, zhaoyang.huang@unisoc.com, jaewon31.kim@gmail.com, david@redhat.com, Hyesoo Yu , Andrew Morton , Jason Gunthorpe , John Hubbard , Peter Xu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] mm: gup: avoid CMA page pinning by retrying migration if no migratable page Date: Thu, 5 Jun 2025 12:32:07 +0900 Message-ID: <20250605033210.3184521-3-hyesoo.yu@samsung.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250605033210.3184521-1-hyesoo.yu@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CMS-MailID: 20250605033432epcas2p4c024a9d05246b18c217f3562b3f53551 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P cpgsPolicy: CPGSC10-234,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250605033432epcas2p4c024a9d05246b18c217f3562b3f53551 References: <20250605033210.3184521-1-hyesoo.yu@samsung.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 04D7F4000A X-Stat-Signature: jtz7qxpdfkqez3sbk7t685jxzqunng6t X-Rspam-User: X-HE-Tag: 1749094478-275099 X-HE-Meta: U2FsdGVkX1+Z9uTsoAkJoEVIImSYKUKqhEtdIbbbvcUmPStqwvbS3SQSWaJpqu1q9K4MG1YCHIEP1Iu7Jj0nFG/W5+qt13/PdgygQiki5jg1Cw6MYpyiXWJfN8ILxprrLevUxmefU7o48U2qYOPbE2O7EaQ/Kgqz/EqrGjAQpczlYeOa2mCpXRNrOQ5M3vRJvwBnP2Uou53+ghOoTmGq7XOEePcQkAPkITEUhcdovoSYu3sbcjeaPv5WUY7kgglozOISWw/FODdVCktZD9nQc0/PB9cCStw/tskpacs1znvTts6p2I8/KeD4y2GXIvUHOKoiJB+m9ZDvC09ocN/GWf5tjonFRHPi3Jz77JXPHOo2vmVa/Eghqtmj3t7WjC1JcZabs2L+Jlg/MaAN+1cb0PlbqBLEoR/erYeGs62Fpj7S5MKIF3UVVOgE6urEWQvS601Ot0faDZ0Bj1zRbzAR4JTFgyw1nj6yxxo4bLPZnGXTGr7XhtHs/W4AcfUF3kzTWCIcQLFMHEf+559cuEnWYI4tpVA2XqXnMGDhI2sCVTuTjEJgC+VJbbQe150TpefNKo0TGZow3poAatfCTHSgFTvFPg9voEUxTwUycjuetQSuzHjzPFJq9dCXUOtCvVtaVe9Hd3K14nos6pbSk6FnAl19bVRrO0QPosAwYF6QrvjeeFIvp9qj2+4hQJhi6Z7LTlBqb1ujTKf7Zl+hVEcxlNrzHPdpEePtcvQfZvCUG6ez2bcgF7LfZ8UDUEiBWn6RA+Fzp+rn8Od1Jf66Eod5Kj2I2TPz6aqijx5dWxmm1HaCxVYFNbvzXp3vG4lMu4QNHhk1H0wEHWjvIGayxhJRJm7KVx1eL23xHn70rwl+aBcABmHnkSjcdU33ujK9pseHChEeiSufbz8yrHtMEbb4cj8v2GJrZYjgymJEDPPCYF047TbnHAAa28dlcM6XOdM1GTV+4DteP3q2nFbGfwH IENcEWs7 321xAbm0+DU9jpCcIuM/wO513zm0EUBst+10Sf57PaKUW+8MPU9XSDa/bhoF/5GCxRyhodYdr7YV7BwA5wI9urDt0AizRcrms+9MJD5Cq95T/VyoErMuLlQSyxDa/9rgSErn+f1nppSV/3gDXpxTuoIc6xUQNkQjYPLgw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Commit 1aaf8c122918 ("mm: gup: fix infinite loop within __get_longterm_locked") introduced an issue where CMA pages could be pinned by longterm GUP requests. This occurs when unpinnable pages are detected but the movable_page_list is empty; the commit would return success without retrying, allowing unpinnable pages (such as CMA) to become pinned. CMA pages may be temporarily off the LRU due to concurrent isolation, for example when multiple longterm GUP requests are racing and therefore not appear in movable_page_list. Before commit 1aaf8c, the kernel would retry migration in such cases, which helped avoid accidental CMA pinning. The original intent of the commit was to support longterm GUP on non-LRU CMA pages in out-of-tree use cases such as pKVM. However, allowing this can lead to broader CMA pinning issues. To avoid this, the logic is restored to return -EAGAIN instead of success when no folios could be collected but unpinnable pages were found. This ensures that migration is retried until success, and avoids inadvertently pinning unpinnable pages. Fixes: 1aaf8c122918 ("mm: gup: fix infinite loop within __get_longterm_locked") Signed-off-by: Hyesoo Yu --- mm/gup.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 68d91b000199..a25c8c894882 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2300,15 +2300,13 @@ static void pofs_unpin(struct pages_or_folios *pofs) unpin_user_pages(pofs->pages, pofs->nr_entries); } -/* - * Returns the number of collected folios. Return value is always >= 0. - */ -static void collect_longterm_unpinnable_folios( +static bool collect_longterm_unpinnable_folios( struct list_head *movable_folio_list, struct pages_or_folios *pofs) { struct folio *prev_folio = NULL; bool drain_allow = true; + bool any_unpinnable = false; unsigned long i; for (i = 0; i < pofs->nr_entries; i++) { @@ -2321,6 +2319,8 @@ static void collect_longterm_unpinnable_folios( if (folio_is_longterm_pinnable(folio)) continue; + any_unpinnable = true; + if (folio_is_device_coherent(folio)) continue; @@ -2342,6 +2342,8 @@ static void collect_longterm_unpinnable_folios( NR_ISOLATED_ANON + folio_is_file_lru(folio), folio_nr_pages(folio)); } + + return any_unpinnable; } /* @@ -2407,11 +2409,25 @@ migrate_longterm_unpinnable_folios(struct list_head *movable_folio_list, static long check_and_migrate_movable_pages_or_folios(struct pages_or_folios *pofs) { + bool any_unpinnable; + LIST_HEAD(movable_folio_list); - collect_longterm_unpinnable_folios(&movable_folio_list, pofs); - if (list_empty(&movable_folio_list)) + any_unpinnable = collect_longterm_unpinnable_folios(&movable_folio_list, pofs); + + if (list_empty(&movable_folio_list)) { + /* + * If we find any longterm unpinnable page that we failed to + * isolated for migration, it might be because someone else + * concurrently isolated it. Make the caller retry until it + * succeeds. + */ + if (any_unpinnable) { + pofs_unpin(pofs); + return -EAGAIN; + } return 0; + } return migrate_longterm_unpinnable_folios(&movable_folio_list, pofs); } -- 2.49.0