From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A7DC5B549 for ; Wed, 4 Jun 2025 23:12:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16F468D0054; Wed, 4 Jun 2025 19:12:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FA378D0007; Wed, 4 Jun 2025 19:12:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2A0F8D0054; Wed, 4 Jun 2025 19:12:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D0C748D0007 for ; Wed, 4 Jun 2025 19:12:18 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4D1C5140C22 for ; Wed, 4 Jun 2025 23:12:18 +0000 (UTC) X-FDA: 83519268756.27.6C9B68A Received: from mail-pg1-f202.google.com (mail-pg1-f202.google.com [209.85.215.202]) by imf30.hostedemail.com (Postfix) with ESMTP id 84B7180005 for ; Wed, 4 Jun 2025 23:12:16 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="tWU/2xIP"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3z9JAaAYKCMAy0xkthmuumrk.iusrot03-ssq1giq.uxm@flex--surenb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3z9JAaAYKCMAy0xkthmuumrk.iusrot03-ssq1giq.uxm@flex--surenb.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749078736; a=rsa-sha256; cv=none; b=rNa3xkZoENzJr4NDoc9PgV8CsgdQQRP71h06lp3SPjbXr0Wln9w/Dc19+2Lsyu7cEVzF4E dv0lKyoqQ69xyuugpd4yDj8yI2YuGjluJO9mmFQyjPLBzIqyJB1XOjov0vvCY1MjBjHIBt cjrM+kPOXn0uflaXZZj5sXhKoe8BhfA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="tWU/2xIP"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3z9JAaAYKCMAy0xkthmuumrk.iusrot03-ssq1giq.uxm@flex--surenb.bounces.google.com designates 209.85.215.202 as permitted sender) smtp.mailfrom=3z9JAaAYKCMAy0xkthmuumrk.iusrot03-ssq1giq.uxm@flex--surenb.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749078736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3EJSuX6VivEZXPaW3XME5tQsWEwW8pbNYvF2lTXxKJY=; b=cJkmz9Zt48yQeGKNbCr2R3UtPFkoJgtDffb9ZFlsL2B+L60BB5yO6Kr/iITMyBnuMjj7D+ J6lrof8yG0ZcYlocQ9bPe5Wc14+Xcl1Ixr5xeG6VtyUn1lKmpytrYiGLiE/CQcNvyShWS7 qVnde05I78YFL0wWrzWM8yn0RV75ozY= Received: by mail-pg1-f202.google.com with SMTP id 41be03b00d2f7-b26cdc70befso192450a12.1 for ; Wed, 04 Jun 2025 16:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749078735; x=1749683535; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=3EJSuX6VivEZXPaW3XME5tQsWEwW8pbNYvF2lTXxKJY=; b=tWU/2xIPA3K82uialXPfkp9/bh/BFxpTJI80N0b+bYMCPE8VXchk8fjpNHpEI1aqpY N5puft3dciPHeegZOdGiRZ8sfbaRkcylaiWrsicso0HJANZtKb02xwH+PhTmnEgqoFFy aeX1znaShXREm7U+67E7dnXhfIDgPpgoNBLlmJN/hlBUpRK8C8j+ZCITTDW6SSV5D0Vl iDYqbpxmXeiy2QPL1UkvBBvBLp6/iUvRSHlg+M0mZv3ZXwMSLKq8bTvzV92o7/IPQBOn e+W3W+xi8LsGUkCX/6cBbQa6BXjwdGHGdKhJrPd6JwbNqYusi4jZB1ZAZ9VSFsbXqJHZ c9sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749078735; x=1749683535; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3EJSuX6VivEZXPaW3XME5tQsWEwW8pbNYvF2lTXxKJY=; b=oW6RPwUgs69S5PpZhqi5XiY6ms9Nd2ca4zisHTzW17wz3cC26RLbhXPpSpP0rR0v7w Aiv/10THWjoJIzIrQMG8GW8LgaDSIhfSfPvxLn9jBn5Uo6eBE7dj8AceUsBDgWiGZ5/G BUryTc6dda8hQjAha0Vs8MtzYBWyFkot/KjjO0OdMR9FR8IHaGnCYwoRmrWzqsTF4Axu z42sybCXO0ETlqzFZoIev4fqJPMwIzRNd7BuJQtlG3p1PoF9KI/rPk4iJMZbRJnvScr7 jVaU54oftZTOEKs0etmI2BoyDRxx69Wc3zH0KBfjOh9RtpCkmX+AgK4nFoUDFYyN7VFU BQ8Q== X-Forwarded-Encrypted: i=1; AJvYcCWd/+0qzA4T2GLP7IAl26eJLKWwx3hcfezcJFm49QF6qay5WOk73CCNG3XOkDe42Wy9xgSH4Xk+xg==@kvack.org X-Gm-Message-State: AOJu0YzxTpw4exHuU346Qwysw2IromKdbx9X8zaGrCZ/cOmpS5zP/SNn pGS0Ldwqb165bhtMJPrjZu75JneQwRbVc/RWUKqGSVuDFoTEWeRCv2I6Cr0d5Afvn7KYYrZqKbf ZnfymCw== X-Google-Smtp-Source: AGHT+IHIqm60fqw2WryyH60UqB66621hhhJyFpfZGiBWNrQf8PvcWHbFtpXkM6N/7/aBYh63wkE29sbA5cw= X-Received: from pga12.prod.google.com ([2002:a05:6a02:4f8c:b0:b2c:4ef2:ca0e]) (user=surenb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:9990:b0:1d9:c615:d1e6 with SMTP id adf61e73a8af0-21d22a7a486mr6852001637.0.1749078735331; Wed, 04 Jun 2025 16:12:15 -0700 (PDT) Date: Wed, 4 Jun 2025 16:11:48 -0700 In-Reply-To: <20250604231151.799834-1-surenb@google.com> Mime-Version: 1.0 References: <20250604231151.799834-1-surenb@google.com> X-Mailer: git-send-email 2.49.0.1266.g31b7d2e469-goog Message-ID: <20250604231151.799834-5-surenb@google.com> Subject: [PATCH v4 4/7] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, jannh@google.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, tjmercier@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, surenb@google.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 84B7180005 X-Stat-Signature: awdks8wusj1ypd9pjihfo5n86i6minb5 X-Rspam-User: X-HE-Tag: 1749078736-428912 X-HE-Meta: U2FsdGVkX1+MqfxMYPFsu+rnO50zlokZan/gwJHx9t2dBd3/KYq+ChhTkRzAdQR7oU8esvL6AP4V/dANxuprY5LO1uq6+EtIMLAYLB3IMv9bTvBQSt6p4vWonsZYJD0YhmuIlHrzWYo1hcsP/aRK5E7d9VlTIVtwWTaqmBaxGVkJBwjbNYEeVodGMCsn+fL7tirp/5dAccGBXmYtfdLTKhULJmZwKKrt7XnLokqKZstI/XEe7Y16agkbLKJqlXxyy0Ojy0jqDfz5RwreXz/IKHt4nKl0EIz/z8ubWgi1bSWF+jGAsqXRWfG2vc5kMiIGZzvld1sQoFl0IEunLbcBH/15Txd/J80YMOiFncLcgVCbSoH/S7QZ6B/AeRxpRyYfqnezLW5t2XdXjw0SQyoaiZPbgodmhI8b0046iuaL1dodH4jL7CTwXgm6QnnMqPIGA8vMFlQh9VvkGPSBDRuZPkFgVLvFeR30tL/kDVzvihIKJ7GO2IEohJjflobSNE4+FBU4yarqU16uw+2WiWmh8EEavNWjCkiOpNMfo13GzT56biBEk2H6DnJUSgxqi5UkomFPiO6GCg+cfukaltQwXmeZfsPeUYd5g9bpbjBQqR1OP6SSp+ADYAIJCDKM0ieCaDXoHsJRwRgxS8N41HZ4TqQsvq5JtzNIHu79tQVP4Zq6mnsjFQ4iQ2IvRvrng81zTqi6Q/8FAbraNSz9R6zuq7qaj8bXrM3oQqjCWpRsq6yJWN+cGoGdopswyTJNvjNddhq9KE5WPeZRzIHmvNsrQq+zygYMxdqmx5sZZUos5Gm5WSqN337C9Z9KjuBLeGNavmUliaXiMkyJaRWJ6eFp8cfEbRUm7/jIIeds2cuYy8IB+Gko1iFKatsu9j7BtG2bmc5CAe/rVsLG8pVuEGDoP6StQVKiOLnrwCquNHyZUzPSHLQmbFiVWK5KzH2zmxI1u56vQG3qps68lTUsBUO FqSHijqe YxF0ptmNcVHw9pNgf9STJJy88snCakY1F9has5jEyK0iVbegWBYtFWajFQQlvkTGLEVcJYEv4UnfWaXW7LcyjH2IDOkE6FdD3X0fe+UhJ2Tuj/fe/CHmT07xpIfx74uK346FtNeb6vpCGbcWfBEg1yJIpIeoXUPe5tHCCGxn0xHf7g4rFMv2p9RZP+Xanl6AUACxQ9RRvfYrOpCmYYKtRR5W13Y0pp0UdGlD3/aGo3ZOZyGPAY2OEzNUQPTAZrmQ3EAlNO057Z1DryGBMz2awbwxJjlpO3SSckwRgcyHflU/Qr9ODaZrNFPgUYqAohfDa8hGxxWf6elda4CxjiRsSXj4vjH3qaIcfKty0N18yGPo4BuCecw81c9UW1xwiL2fm8ZiFQAzZAaEhr5Y+ZhWcdQhXOtuNECu5j+lipZA0YsU/xk4EK5uQwtm31mKE9UjWuzza6nDTERZZdjwna2rWGTOXPrFhDTenfGJYylNrA6evLqD/tdgopDy74NyecNhOvoYkQM4Rdt1O4fBw2Efe7HrsXlu5Js87a6gN3ocoA0H36Jxl/nk3MqxbOm9qI7pHMX32VV0vhjCBAcKnLItbxjLxsg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Extend /proc/pid/maps tearing test to verify PROCMAP_QUERY ioctl operation correctness while the vma is being concurrently modified. Signed-off-by: Suren Baghdasaryan --- tools/testing/selftests/proc/proc-pid-vm.c | 60 ++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/tools/testing/selftests/proc/proc-pid-vm.c b/tools/testing/selftests/proc/proc-pid-vm.c index 1aef2db7e893..b582f40851fb 100644 --- a/tools/testing/selftests/proc/proc-pid-vm.c +++ b/tools/testing/selftests/proc/proc-pid-vm.c @@ -486,6 +486,21 @@ static void capture_mod_pattern(int maps_fd, assert(strcmp(restored_first_line->text, first_line->text) == 0); } +static void query_addr_at(int maps_fd, void *addr, + unsigned long *vma_start, unsigned long *vma_end) +{ + struct procmap_query q; + + memset(&q, 0, sizeof(q)); + q.size = sizeof(q); + /* Find the VMA at the split address */ + q.query_addr = (unsigned long long)addr; + q.query_flags = 0; + assert(!ioctl(maps_fd, PROCMAP_QUERY, &q)); + *vma_start = q.vma_start; + *vma_end = q.vma_end; +} + static inline void split_vma(const struct vma_modifier_info *mod_info) { assert(mmap(mod_info->addr, page_size, mod_info->prot | PROT_EXEC, @@ -546,6 +561,8 @@ static void test_maps_tearing_from_split(int maps_fd, do { bool last_line_changed; bool first_line_changed; + unsigned long vma_start; + unsigned long vma_end; read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); @@ -576,6 +593,19 @@ static void test_maps_tearing_from_split(int maps_fd, first_line_changed = strcmp(new_first_line.text, first_line->text) != 0; assert(last_line_changed == first_line_changed); + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, + &vma_start, &vma_end); + /* + * The vma at the split address can be either the same as + * original one (if read before the split) or the same as the + * first line in the second page (if read after the split). + */ + assert((vma_start == last_line->start_addr && + vma_end == last_line->end_addr) || + (vma_start == split_first_line.start_addr && + vma_end == split_first_line.end_addr)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -637,6 +667,9 @@ static void test_maps_tearing_from_resize(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after shrinking it */ @@ -656,6 +689,17 @@ static void test_maps_tearing_from_resize(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr, &vma_start, &vma_end); + /* + * The vma should stay at the same address and have either the + * original size of 3 pages or 1 page if read after shrinking. + */ + assert(vma_start == last_line->start_addr && + (vma_end - vma_start == page_size * 3 || + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); @@ -726,6 +770,9 @@ static void test_maps_tearing_from_remap(int maps_fd, clock_gettime(CLOCK_MONOTONIC_COARSE, &start_ts); do { + unsigned long vma_start; + unsigned long vma_end; + read_boundary_lines(maps_fd, page1, page2, &new_last_line, &new_first_line); /* Check if we read vmas after remapping it */ @@ -745,6 +792,19 @@ static void test_maps_tearing_from_remap(int maps_fd, assert(!strcmp(new_last_line.text, restored_last_line.text) && !strcmp(new_first_line.text, restored_first_line.text)); } + + /* Check if PROCMAP_QUERY ioclt() finds the right VMA */ + query_addr_at(maps_fd, mod_info->addr + page_size, &vma_start, &vma_end); + /* + * The vma should either stay at the same address and have the + * original size of 3 pages or we should find the remapped vma + * at the remap destination address with size of 1 page. + */ + assert((vma_start == last_line->start_addr && + vma_end - vma_start == page_size * 3) || + (vma_start == last_line->start_addr + page_size && + vma_end - vma_start == page_size)); + clock_gettime(CLOCK_MONOTONIC_COARSE, &end_ts); } while (end_ts.tv_sec - start_ts.tv_sec < test_duration_sec); -- 2.49.0.1266.g31b7d2e469-goog