From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 442BEC5B543 for ; Wed, 4 Jun 2025 20:56:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C4B36B053E; Wed, 4 Jun 2025 16:56:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 975896B0541; Wed, 4 Jun 2025 16:56:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 88B4A6B0542; Wed, 4 Jun 2025 16:56:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 685B86B053E for ; Wed, 4 Jun 2025 16:56:27 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 140C6160918 for ; Wed, 4 Jun 2025 20:56:27 +0000 (UTC) X-FDA: 83518926414.14.39F68B3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id 7D307140014 for ; Wed, 4 Jun 2025 20:56:25 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ffOLn00/"; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749070585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aOT6Pvhi13/ksVdVauQaNYAc7cHEcr54CWEejctZORk=; b=jXu2WcFTNbDWCCdZFq9arG+yeLNaZgV+Ojaew3esLi2WEXllGOt6Wr88QSfmsqtKK+YV4E ZlvvmCZtBnfwUj6PSeUjHMuPG9F1VQpx9D5ce8QqpqWXYLSMyaZ0o2poUFQfZLWSKOFAF6 QQaCnQ6q9/5+FkFR6RauFnKfJjGaJUM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="ffOLn00/"; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749070585; a=rsa-sha256; cv=none; b=nKcgjBbtnO/PGh3TFUC1KuPkIzXPpY2sFuyrZGbsiNkIWbsDYj8VZNcMormuyh0vXV4Cln JrKXiHhQmCBasdvMjuh/vWSDl8bC9aV0Ec4QsZldwewAV1ZPLR9l7BHemousHDEjmM5GfL hUifmXxRwe/8KShljFLYXOcerhADBw4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A83435C5916; Wed, 4 Jun 2025 20:54:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FAACC4CEE4; Wed, 4 Jun 2025 20:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749070584; bh=Xrqp4qshtj+SrwBUZQ6jlW6C4TgbY0f+Gxe9VE3u0CM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ffOLn00/Fi1eLYMq8xonnGIUQ2AsEk1k2hn+xcR4W+Qcr+3pcUQ8/34gdM3EHdHr1 f39V/UjMTM0PZ9ChkBX2Y6SMTXDaXvTOjojZ+GeyyUQuBPoqlqykJH6GRnh58PddUW zgQGtH3rvVgi3gc4PeQTZYdyqfF3Fmk6RWW4q3wRRbSxKKuAAHPNr0USNXeTYncnfc 6mRYxz7er6KQuObqq/UKdTVdIYzJXathq5G9SGXZiGDjq2AZFIAESrnPHGw610JkL/ /fY/sF/BExRhHBZ7qodlOvpIGz12ZaB/zq82rA147OXjNLBNiPWePl3185sa79mc9x krSmKMAL/XjTw== From: SeongJae Park To: SeongJae Park Cc: Andrew Morton , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] mm/damon: introduce DAMON_STAT module Date: Wed, 4 Jun 2025 13:56:19 -0700 Message-Id: <20250604205619.18929-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250604183127.13968-2-sj@kernel.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 7D307140014 X-Stat-Signature: n9wukhtq1xcikp5edkzzb3iwg5ees11g X-Rspam-User: X-HE-Tag: 1749070585-342396 X-HE-Meta: U2FsdGVkX18ucapqdSv/OTipG5FarMzUs1c9C/bSlAYjbjf5eEv3LI1PhMhEPSF3JpDcMB+a9LUxBhRpKOHD7mjWCzhSc2/FSH6OSEHzfb4kgdhe2c19OFKqPRRI1cNYTvCW0IHdCk5wkqnHpM2BqwX3qGuTxT4hgwKR3KAi5Z50vM7YDI2c82Q5HaMcpkdynRsVJAsKzbEdXQgIcJEQtGdXEW13pLo6MIPCpyaXJVMXqV4lV7w5al4sjMUtRBJ7QvpU8NXMj78fF8XOwPz9B+UJKyyCr51h4FFMX2FTVTEHf+iebEESlXTgIJ9Fs6xTZna+Ww3uuhbtwxxJpz0R7tmJIZg9O8rxsxTAX8ARhDxQYTcNiSd3Jr2XJDk6BXkT9fl2iDKZkrbJ8feEAnKlTaokXPM06Shu7kH6hJDgtbTlnyTq3L1XYpGg+VoF44uJa4P+gBfw5qI9VALfSfYXXleRZvSXBeLFzGBVwiptN7PE9sP9R2LkZ/+wVzRUj3ElQHMSO2+nmLhHZxXk1Ndz6lRLdruAoJsSsCSxJMWitGR33lq8OOZfgJ7Nml3t9WpEN/uEdvsLWeLzozjNpLI3h0HplnTXfn1aMHCKMW7j13J7vXPP8ilgp8InVohS/Es71hetT99SzkLTLcNcKfpYWQWozQq8HJp9SNnKE/yty6SRV0XlMaBr5JlJa4ZPKa5Fnz0tjtYptI26sCiqblKoyIQtll/6fQHodX6voadUH3mB7ACZ8ci+JfcQyeReTlnPTZRR5rhVrcnd6x1kmb8+e5vgDub2CYmG0ImlIeL/DdhuiK4r1dkcL/dtfUtOFT8zW9n+Z3yhErPxo00+y+X1/LWx2ORt9gBnjMDgN9f4lisDXHeizufb5HCG5X2aDwA8Cu3uNRV8iFPeSGWDq9NTdGgbQVRVzB7S/POPClp6auWlTx1DWGScJeAHIzfUB6zZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Jun 2025 11:31:24 -0700 SeongJae Park wrote: [...] > --- /dev/null > +++ b/mm/damon/stat.c > @@ -0,0 +1,138 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Shows data access monitoring resutls in simple metrics. > + */ > + > +#define pr_fmt(fmt) "damon-stat: " fmt > + > +#include > +#include > +#include > +#include > +#include > + > +#ifdef MODULE_PARAM_PREFIX > +#undef MODULE_PARAM_PREFIX > +#endif > +#define MODULE_PARAM_PREFIX "damon_stat." > + > +static int damon_stat_enabled_store( > + const char *val, const struct kernel_param *kp); > + > +static const struct kernel_param_ops enabled_param_ops = { > + .set = damon_stat_enabled_store, > + .get = param_get_bool, > +}; > + > +static bool enabled __read_mostly = CONFIG_DAMON_STAT_ENABLED_DEFAULT; Oops, I forgot using IS_ENABLED() here. Andrew, could you please add below fixup? Thanks, SJ ===== >8 ===== >From bc2a2c580f6f89f3f7d4f92c2bde3f4a4fac3409 Mon Sep 17 00:00:00 2001 From: SeongJae Park Date: Wed, 4 Jun 2025 13:48:30 -0700 Subject: [PATCH] mm/damon/stat: use IS_ENABLED() for enabled initial value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The initial value of enabled parameter is set as CONFIG_DAMON_STAT_ENABLED_DEFAULT, so get below build error when the config is not enabled. Fix it using IS_ENABLED(). mm/damon/stat.c:27:37: error: ‘CONFIG_DAMON_STAT_ENABLED_DEFAULT’ undeclared here (not in a function) 27 | static bool enabled __read_mostly = CONFIG_DAMON_STAT_ENABLED_DEFAULT; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: SeongJae Park --- mm/damon/stat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/damon/stat.c b/mm/damon/stat.c index 7ef13ea22221..3686f67befc3 100644 --- a/mm/damon/stat.c +++ b/mm/damon/stat.c @@ -24,7 +24,8 @@ static const struct kernel_param_ops enabled_param_ops = { .get = param_get_bool, }; -static bool enabled __read_mostly = CONFIG_DAMON_STAT_ENABLED_DEFAULT; +static bool enabled __read_mostly = IS_ENABLED( + CONFIG_DAMON_STAT_ENABLED_DEFAULT); module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); MODULE_PARM_DESC(enabled, "Enable of disable DAMON_STAT"); -- 2.39.5