From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9B1C5B543 for ; Wed, 4 Jun 2025 18:31:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6629B6B0473; Wed, 4 Jun 2025 14:31:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 613B16B0474; Wed, 4 Jun 2025 14:31:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DBA96B0476; Wed, 4 Jun 2025 14:31:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3001D6B0473 for ; Wed, 4 Jun 2025 14:31:37 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E6F30C0543 for ; Wed, 4 Jun 2025 18:31:36 +0000 (UTC) X-FDA: 83518561392.19.E9FB2C7 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf20.hostedemail.com (Postfix) with ESMTP id 35D5B1C000B for ; Wed, 4 Jun 2025 18:31:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qMgVJ2NZ; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749061895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RZTMP5NJ3BmzeJN849gXiIqrpKmTktqWgD8AM6zP7ug=; b=4p3NyUA/UZJFVKZ5J17eNGGacbBc13NOQGjyqde57Jak8Sa5Rt5ez9horJ+YI9krzMdVsC oMKwTCs4OMrcJleTggUhirgs0E8VWQwwjcgv2Kw8GA/A9ShZDwhmIyNuadNQRbM5n+ZPKX u1MgnJ5XXMiiHKLnxJk5mxCs6rWEemE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qMgVJ2NZ; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749061895; a=rsa-sha256; cv=none; b=l4U49STCFOBWlkSbi5Eq+NCN6zm+n2uYpYY3D+OCw82dAj2WMvFXtZ4xTt0Ek3T/EH7ocp 91NHw8W0EG+IDkVDN1bQV+8zmm83BkVhL9sqF8mPXvH98Z5n2GLABcXzHvA4hpolql8sy9 IZSU0RhhiXuw77AbsyYlmmU3gA7Wga0= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id DF2A54A529; Wed, 4 Jun 2025 18:31:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92BCCC4CEE4; Wed, 4 Jun 2025 18:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749061893; bh=47rhffbSXH0eMjS6yxQtcQiXlFtplaL38A+e/fJH57s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qMgVJ2NZwHWTIMKdQksngEuUav5LtGTioJTTXkSWn1ES/eutudy+HRNgaT6b6YqwO eT7glfV597XfDhCBivlq1u61oe/6CXSPTsOkzf4AYShpRXAtTU+4mTMk8wlIl4TEt0 iMZ/V29a02+pY6+Qj8N9kKgLy7cbiUbJMODNxn1KkXlsCzULQTURqZR9Dqj0GebhaT z0X3HClR4R9y3LI1omzoUnQpTdgC92CdxcB9aOBq9819hvbF4WIMDpBi2fs2+WAwHc C2WqDHmb5Nxmvt0QlBeHnZITzvZhXyOp+5DbWtSg2lpRT18O2ESt217xLOB4GqxQT5 ehQaaWSoiMgsA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 2/4] mm/damon/stat: calculate and expose estimated memory bandwidth Date: Wed, 4 Jun 2025 11:31:25 -0700 Message-Id: <20250604183127.13968-3-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250604183127.13968-1-sj@kernel.org> References: <20250604183127.13968-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 35D5B1C000B X-Stat-Signature: q8u35rmmbzcau7p9d9onwoyhqh81a7ej X-Rspam-User: X-HE-Tag: 1749061894-652827 X-HE-Meta: U2FsdGVkX1/bKcCRmsLFAIDFU6J35vmtCy0ZODxGc183WZZFIjphpYtQ0ny4W+4QsCBUqKhhSqH4Aeyo0ZXKqwgHfJhqwE7g379Pfb/njCOpKuo+TwhwJdXpdsgbraWcO3H6IPkxFbvedBTcaUqO6CZo1tr45rJi9nod4iUK7fpEBaTxO2QcgwN2ZUXplz2gO0xgnCcPkUUOb4Y3pD/V1EAMp31uiZgY9TGK8RN13WRUkUANXzdDfi5j7TQYyROMB75aQzFpKHVvHdS5w8wr6+3qpNo/y7d8I1E31E/9jhQ4ikM77VAQgpT9eiUn1RUeD09kK2PtRnEdBe4F3TvbqX8NOMsN3IUmAsteSqLXuuKZ5fMfH+5TstHP7j3ojAKyXaNL6k6N8nBAxkfqCs4pWe2ZuWN/DYDf3xxwVWSkERd7ZiHI0a9kwALyFFq5dcMRowuA8GEnKsukdiOKFPYZVwWtUBQfO9WrByZJx1C7FWMLAMzDNFZ+4ipcavZ4DbmzVvMp0f4kgp0TN42iQZdNGs6pp01jsN6pdUaqDr1H90soOjqAD0x4j7jhQHCq4krrbdaASr2EFLd9i1tFzNqAepWW9LozFUs5er41gsWdXjh/66p1RCcz8Sh0h/lVY1SJFy9BE4YjouuLxB/tZ7xX+yWZ2pmIAYH5w/M/5K3yWY/MTHxvPbOLlM/G1+ADg2s6M6v1UHnFPNcF4hiXJd2DYrNdc9swHZyHK5v0Gm9FElkzmg97BEb7Z6FIigMSMof+sMpombkxGVlWsNogvdIaGecVHYwpQE+YEpKjFq5uMEA5j4ae16JuQGNveVPrUet1M3f7byW2EoWn6HtTqEzlvfnDpoo5RDMTeblHjE8Fe6kUbb0jC3wXC1U2N3PeCwY99QLMN1yoXulqV0n479MXEdCk6occPxuDIVqkOft+u7bVIoJXZeM8eLwN0iEdpRtn5ddlM/CfyelYZRKWbqM 3tGRx+Fk yBne6j8RCTsIK2DGMEMq6VYWgkuBG821WEJ7LBBEEzRavU+Hgcwe6uj9F16TKlmxfm4HFNYiiP1KgPvyDBXw5TiE+CHlME52Wh+20A4KaOsUGmrRSh3bwRb5lDPcSDp/nkA8idYL0oogBk1yBeaKEvSHe3ZOlhN987hLsX5Yape91UZLIUE+lMwkucyYO4BhFrF9/TOTCTYN1fyEdpgD47ZA2kOZsgg5EOFeQRQTlEEu3VTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The raw form of DAMON's monitoring results captures many details of the information. However, not every bit of the information is always required for understanding practical access patterns. Especially on real world production systems of high scale time and size, the raw form is difficult to be aggregated and compared. Convert the raw monitoring results into a single number metric, namely estimated memory bandwidth and expose it to users as a read-only DAMON_STAT parameter. The metric represents access intensiveness (hotness) of the system. It can easily be aggregated and compared for high level understanding of the access pattern on large systems. Signed-off-by: SeongJae Park --- mm/damon/stat.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/mm/damon/stat.c b/mm/damon/stat.c index 852848ce844e..f9ae44db265b 100644 --- a/mm/damon/stat.c +++ b/mm/damon/stat.c @@ -28,8 +28,42 @@ static bool enabled __read_mostly = CONFIG_DAMON_STAT_ENABLED_DEFAULT; module_param_cb(enabled, &enabled_param_ops, &enabled, 0600); MODULE_PARM_DESC(enabled, "Enable of disable DAMON_STAT"); +static unsigned long estimated_memory_bandwidth __read_mostly; +module_param(estimated_memory_bandwidth, ulong, 0400); +MODULE_PARM_DESC(estimated_memory_bandwidth, + "Estimated memory bandwidth usage in bytes per second"); + static struct damon_ctx *damon_stat_context; +static void damon_stat_set_estimated_memory_bandwidth(struct damon_ctx *c) +{ + struct damon_target *t; + struct damon_region *r; + unsigned long access_bytes = 0; + + damon_for_each_target(t, c) { + damon_for_each_region(r, t) + access_bytes += (r->ar.end - r->ar.start) * + r->nr_accesses; + } + estimated_memory_bandwidth = access_bytes * USEC_PER_MSEC * + MSEC_PER_SEC / c->attrs.aggr_interval; +} + +static int damon_stat_after_aggregation(struct damon_ctx *c) +{ + static unsigned long last_refresh_jiffies; + + /* avoid unnecessarily frequent stat update */ + if (time_before_eq(jiffies, last_refresh_jiffies + + msecs_to_jiffies(5 * MSEC_PER_SEC))) + return 0; + last_refresh_jiffies = jiffies; + + damon_stat_set_estimated_memory_bandwidth(c); + return 0; +} + static struct damon_ctx *damon_stat_build_ctx(void) { struct damon_ctx *ctx; @@ -75,6 +109,7 @@ static struct damon_ctx *damon_stat_build_ctx(void) damon_add_target(ctx, target); if (damon_set_region_biggest_system_ram_default(target, &start, &end)) goto free_out; + ctx->callback.after_aggregation = damon_stat_after_aggregation; return ctx; free_out: damon_destroy_ctx(ctx); -- 2.39.5