From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1DC4C5B543 for ; Wed, 4 Jun 2025 23:35:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67CD98D0053; Wed, 4 Jun 2025 19:35:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62D7E8D0007; Wed, 4 Jun 2025 19:35:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 544088D0053; Wed, 4 Jun 2025 19:35:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2E7F08D0007 for ; Wed, 4 Jun 2025 19:35:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CC2C1EDD3D for ; Wed, 4 Jun 2025 23:35:46 +0000 (UTC) X-FDA: 83519327892.24.C2B8D4B Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf14.hostedemail.com (Postfix) with ESMTP id 30EC3100007 for ; Wed, 4 Jun 2025 23:35:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KTkevKoi; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749080145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OwW8fHvQvgZggCEBXvKarbuwmX673z1w+BrmckRykVY=; b=7JTtyzbe5uwS+VCDhotgZgR2tl/hvOnf9KA6tP65GhxtrcFi6qwZZTLkiooLl5NR+iQYrR 8Ykq0ZR7RAwJ8M4VA4LIoUZnEJsstDEzxDArDBl2vJ7zox0HI0mAHl+A+8dSgyXwy0/nyr k7UoQGHyP8wQdLw14GX0tHt1ex/f6ek= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KTkevKoi; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749080145; a=rsa-sha256; cv=none; b=gMnLBvS5eJyJQ9tv0HoVDxXxfK2aKKSdRCItcEf0+21UFs+2uVOWfF1QQCMf8dh29RnrQ7 ufENqxu22dx/zHz41TAV3LvtsdH15yeA9wzOoa+spabFXxvu62u69/jNAi/nCMZwJV0NZI k+dRoiLo2SlUYV01HXf4QyO9plS6n9o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2645F61139; Wed, 4 Jun 2025 23:35:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DA23C4CEE4; Wed, 4 Jun 2025 23:35:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749080143; bh=Al+b9iBLmj7gkjnUaYuFmAa3gwdNmm1ixJqx06DYImg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KTkevKoiGVaAt/gwIotZ7GoH52+lXpkIp6geyI4MgOgZOuco6/xu+wvQPq9XWJRZ3 uRH/9BBUxhOz7uAiSrp7RJde2kikpnWWC/y1y5pMIWPSPh4ItI5N8bjujTzei5hgMW Seq8rQCI6h/wPxe3nn8G7YCxmDA+b43zAfIJ6ufE= Date: Wed, 4 Jun 2025 16:35:43 -0700 From: Andrew Morton To: Vivek Kasireddy Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org, Steve Sistare , Muchun Song , David Hildenbrand Subject: Re: [PATCH v3 1/3] mm/hugetlb: Make hugetlb_reserve_pages() return nr of entries updated Message-Id: <20250604163543.62d543d7ecce5afb835aae98@linux-foundation.org> In-Reply-To: <20250521052119.1105530-2-vivek.kasireddy@intel.com> References: <20250521052119.1105530-1-vivek.kasireddy@intel.com> <20250521052119.1105530-2-vivek.kasireddy@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 30EC3100007 X-Rspamd-Server: rspam09 X-Stat-Signature: 1h1y9pff4t3s4dixawnoqy5kyda4pxh1 X-HE-Tag: 1749080145-931263 X-HE-Meta: U2FsdGVkX1+KdXAfg/5plKfCYcG9pjVrJNjUyT2ktIVLMxP3zcZbf3lNBsKH9CPmzY+5f6arqcxQ98XKtENxYMsXaRshRu3MXX8DwsE4Ep5xHcxCC9om1AgiVWEia7Jos9k8vmc8DWgZo2OPYuHRIx227JKWj5auFA8tT+WF+MhTolSllatgll9ulAdNfNPeI+vMSZE6sKnN99iIY5Rkp9OZEkM+xxJnHHnt1DwFz4ot9+heigoX8GVreNacOWpOZn9w/yGp4uaP50adqOs7Z8Hu6d8LZpDE9px95TjSlLYaGJpmLUIZswzKFBHMwzYv1VbjcVRkCjBaIlNjneZ6dJ0RGv//2cq60h008Z02xeTmbwiagGhHQCFW1YBd12CEvshP3u0/AphgX4o+q++yG94oWPQM7W9feobmlw71JpjRX1NIP/D2HBhkpyuilbiDAcKmwv7lxM5nn6owy07aW1bNJIIc0ZOyZaIkDZiaP8teaDpywkt/L6RrMeQVzYK0FLFz+T0qutoPTrTCy/Cf1KE4YCAqQ0dXvZkZz1/M9VuIQvjdJ411WlRmOcb1EDUnbp03b2VFNAIk1RnC1OvOb/ot7ay80Sy2wpJv0J3ZoWynTrtuS8zKBRkbnlXrNx8gtB6Iz+vuPDzlKbAmpD/sNbQDAido5Ly6M71xXO2I+RQC2CLPWME1wUXWobhpJI6y3urEt7a3m8P+pNPuUMFkpk07McEKY+u082jjFopKYuHHIA9RTBZF0GmIsEJrTLYinhxYWDsGRlOV/NlQ+dyUXO3sfOoUuDMr5lznq8JnppWggwOGi3eEf7YUdHbHXoiycgyPuUX7gv/nkapEyIGyIuDLHVmqAbMgzzJFQweCN2yWdO4AfrbgLUBBBvD7Cr5Cw6cCmPaeq0zK7odRamGQfeITQqyZVoxqjp8Ipepjcf9KWEAgi390/urCIaK4DVuTW7ySxkErVK2zWD3QTak nsJQ5Ehf fKM8Ja0ujNp0l+k5bn8jWbYoPDCBfX8Vo/9ZbDlb0JwzGLHN/yjXAhC8LnoTBTCThulRMMsVHY8vUmAGVLdTXijb4Zq4xaewj0dYyHNfn18NsqOFSIMNkhGnNC4t1qOuL7yI5BlNrq+rnH1637QRhtBN4QiLwfPAmHzbsN3OTIzeAhEfAnNp39DBZsrZ0KUBqXffPv0j2KbBO5nIlKzQ/I01eLGYG3yQ5Y7EJbQc4iofKnD823xUbW4ufEW0RX60CFzIFHxpg0n2+tVsVg/gwSofQ2vC9XzJOOQc/KP07eXQtpt3iQoV03MjpoHJ/4S5g3sP/Cytfzlj8XPYV7CQt8D+iB3TPHhWNHr7swtkgYnlDDyx89/eON/1JpMlPYuTE2+lG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20 May 2025 22:19:35 -0700 Vivek Kasireddy wrote: > Currently, hugetlb_reserve_pages() returns a bool to indicate whether > the reservation map update for the range [from, to] was successful or > not. This is not sufficient for the case where the caller needs to > determine how many entries were updated for the range. > > Therefore, have hugetlb_reserve_pages() return the number of entries > updated in the reservation map associated with the range [from, to]. > Also, update the callers of hugetlb_reserve_pages() to handle the new > return value. Everyone has forgotten, so please refresh, retest and resend after -rc1? Also, patch [2/3] addresses a BUG which was introduced into 6.12. Presumably we want to backport the fix into -stable? If so, it's better to present this as a standalone patch, including the cc:stable tag. This is because I'd be looking to fast-track the fix into the 6.16-rcX cycle whereas less urgent things would be routed into 6.17-rc1. Also, [2/3] has Reported-by: syzbot+a504cb5bae4fe117ba94@syzkaller.appspotmail.com which is kind of annoying if one wishes to see the syzbot report. OK, it takes takes 30 seconds of googling, but adding a Closes: link is nice.