linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Vivek Kasireddy <vivek.kasireddy@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	Steve Sistare <steven.sistare@oracle.com>,
	Muchun Song <muchun.song@linux.dev>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH v3 1/3] mm/hugetlb: Make hugetlb_reserve_pages() return nr of entries updated
Date: Wed, 4 Jun 2025 16:35:43 -0700	[thread overview]
Message-ID: <20250604163543.62d543d7ecce5afb835aae98@linux-foundation.org> (raw)
In-Reply-To: <20250521052119.1105530-2-vivek.kasireddy@intel.com>

On Tue, 20 May 2025 22:19:35 -0700 Vivek Kasireddy <vivek.kasireddy@intel.com> wrote:

> Currently, hugetlb_reserve_pages() returns a bool to indicate whether
> the reservation map update for the range [from, to] was successful or
> not. This is not sufficient for the case where the caller needs to
> determine how many entries were updated for the range.
> 
> Therefore, have hugetlb_reserve_pages() return the number of entries
> updated in the reservation map associated with the range [from, to].
> Also, update the callers of hugetlb_reserve_pages() to handle the new
> return value.

Everyone has forgotten, so please refresh, retest and resend after
-rc1?

Also, patch [2/3] addresses a BUG which was introduced into 6.12. 
Presumably we want to backport the fix into -stable?  If so, it's
better to present this as a standalone patch, including the cc:stable
tag.  This is because I'd be looking to fast-track the fix into the
6.16-rcX cycle whereas less urgent things would be routed into
6.17-rc1.

Also, [2/3] has

	Reported-by: syzbot+a504cb5bae4fe117ba94@syzkaller.appspotmail.com

which is kind of annoying if one wishes to see the syzbot report.  OK,
it takes takes 30 seconds of googling, but adding a Closes: link is
nice.



  reply	other threads:[~2025-06-04 23:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-21  5:19 [PATCH v3 0/3] mm/memfd: Reserve hugetlb folios before allocation Vivek Kasireddy
2025-05-21  5:19 ` [PATCH v3 1/3] mm/hugetlb: Make hugetlb_reserve_pages() return nr of entries updated Vivek Kasireddy
2025-06-04 23:35   ` Andrew Morton [this message]
2025-06-06  6:14     ` Kasireddy, Vivek
2025-06-08  0:25       ` Andrew Morton
2025-06-11  5:05         ` Kasireddy, Vivek
2025-05-21  5:19 ` [PATCH v3 2/3] mm/memfd: Reserve hugetlb folios before allocation Vivek Kasireddy
2025-05-21  5:19 ` [PATCH v3 3/3] selftests/udmabuf: Add a test to pin first before writing to memfd Vivek Kasireddy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250604163543.62d543d7ecce5afb835aae98@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-mm@kvack.org \
    --cc=muchun.song@linux.dev \
    --cc=steven.sistare@oracle.com \
    --cc=vivek.kasireddy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox