From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92EE7C5B549 for ; Wed, 4 Jun 2025 21:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C5E38D0053; Wed, 4 Jun 2025 17:20:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 276238D0007; Wed, 4 Jun 2025 17:20:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 164988D0053; Wed, 4 Jun 2025 17:20:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DFB8E8D0007 for ; Wed, 4 Jun 2025 17:20:47 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 58C6E8050D for ; Wed, 4 Jun 2025 21:20:47 +0000 (UTC) X-FDA: 83518987734.01.A88BED0 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf01.hostedemail.com (Postfix) with ESMTP id 9E42140007 for ; Wed, 4 Jun 2025 21:20:45 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FLmgmfnU; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749072045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tbvr0J7K/ojnuFTVb3BrnXZRX9iUuLIfso8jF0gTs84=; b=MciQvADhW+2tjDqGDAXwmN/w+eP48X/8d395wy7eyIfc5ffCHoXRFZ5lJnKZ8JYVo5WwsH tcm9YGS8UxiJCztZBebpCHZhSxaufGqvW1cnHCpAg4qEcxMAsYC13W55UXTAtyHOhil60m R0lmc+tRSYCcnhCMy+NzUz+QlGw6s3M= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=FLmgmfnU; spf=pass (imf01.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749072045; a=rsa-sha256; cv=none; b=BmI6Zp2IC/lyxKsyh1P+tmN75Eibyd4ztfNIXza9jDHlEueeB/hQrhWwBKVIXqg7cRvt2U kDGBpTUi5ZpWjgKOxlzK5UIgpc75WsUZb9OhpNAYGk7TIVZI6VdlsoAlzDDHGIBnS/ev17 CVGGqxwCzMVjQFTAX86qL595RazoM2s= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 99FDAA50729; Wed, 4 Jun 2025 21:20:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEC13C4CEE4; Wed, 4 Jun 2025 21:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1749072044; bh=/apZxI8yjQIUYPM0hx5/EK/wgVk2YNwjbyetEn0vZgc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FLmgmfnUs6GrZhYrEeKHhABEzJMZMeiIl+qQP/uaZzZVn8bzUAiR8H+OaNVg9ahEs 56DIojzHSx0Gpz/xDigHqYYCCVLek9JhBC6sKeSI2q959OGsubtrhK3KJiv2yWc3ic 55mii2V1oZGnNM0vV2qhO2AwZs/TD+j2q79yOtu8= Date: Wed, 4 Jun 2025 14:20:43 -0700 From: Andrew Morton To: Vlastimil Babka Cc: "Kirill A. Shutemov" , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Randy Dunlap , Konstantin Khlebnikov Subject: Re: [PATCH] mm/vmstat: Fix build with MEMCG=y and VM_EVENT_COUNTERS=n Message-Id: <20250604142043.bdfdf4f9a6a6cbb57946f1a5@linux-foundation.org> In-Reply-To: <6fffd2fe-0cee-405f-af78-b57b5e5d02e8@suse.cz> References: <20250604095111.533783-1-kirill.shutemov@linux.intel.com> <6fffd2fe-0cee-405f-af78-b57b5e5d02e8@suse.cz> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: rbs91mf4af9ap6k3xt9b4nbowcgh6pu7 X-Rspamd-Queue-Id: 9E42140007 X-Rspamd-Server: rspam11 X-HE-Tag: 1749072045-724905 X-HE-Meta: U2FsdGVkX1+ZJe0wC8E4rL2cKysnNTGUFk7mNefvLg3xj3IXI5TCFrdQfnGykhtkzw+aHhBDYW8R9VxLLm7yeRCe3aCXzBaxGZWnFwROMC589+F+IPl+3lbfVET/mG1Jd2udSaqqPEYBIh6J3L02SUf8b7CK/H7lXVMtdx0c/E5XYID05zdGoqranOYLWGDGbERqGVWNAY2YOtYnMxwMNf5xv3Ff/Y/eBbnsSt1dBg7OFEqvDlSIlCiBIzbNJITrgW9MHmB36E2M7UmzHN9KG9h5KVypdsSpWK4SNIuJ5GMLi5iCgh+6iLgiaRIgLQL5DQBN7cAk7svfSi86q2et+19yvkmGcMZb/Bws/SPnZe/EfqltEvkEoEOTO5dcRKewR0I5m/Jh9b1zkUZo8+goRFzSDVAcP9uT9/72IG9puesFCEYBf69FvwDcEpY4tZBlAlucpSAeWDxTmICWucxdY/x3VzKnoCHYPNnORTwf2r/hSCwx0T8fMb/A/fOl6+QbCSsEN0XqwDZ1p2xoIfCnEvGypKyPWwzrzu/5jKA1RGWQgwjtmuw47HK3yiRYCykuITKfAixqLms5n1ntOgo3XP1jTLZ0Z/aRTJMV1h7g0xSmLfd2l3fXANc/o2s9hgLnyjYlxECpheK7RIDgLQsXWIV944NeCrhKx/ZJXv7j2rAV7Nwah93KMordH+YIVSfgf+CGDSKoGLJOd2qOUQ0jYoh7ewRL3+TDMVj/JD2EBQ+hkyqkfl1TAV+y8ArZrQELhBL+IH/JKcwO/c52i7XCTpg1n31VIOR3Kt8JzWKSG1FL0ojU/PwL4kPNDxpDeGx44OwzPJM3CuZsRIpKuLY8qhF2j73W9p/9Zt7ObAaQQLXAvBm4Gv2SfEm1s/GV3eyP/95xbpoto4eg6iHlyv/yEbuPw8Ly4H1sox0uxXUZkkF+IwiN/86fKdWqOKKGJ4qsE7vwTwHy+GxVaOHbnOu Nt3Mlf8r KQ3lHa+cV0ov21tBkATkzVhTc7hp/3KUEuohbnatD24gPn8jiiY7sL7LhHEF7vYmydLn1eRh4eY8m8khPQWIDnCl2FN9Tc9xJntR7Uy8EBNoLxantqJF6O2YZH4Y1SwkvR3XENMpj4JRbzQBiXYU529bneXiUxUf/2pBtpI6DnBe32zcsmQS+jXPkT9RCff0S3S6UyL1BE5IUZV5nnjtoPzCJZ+E0hnm0Xw8Yn3ezwrY2xWP9Nb1EAXaHc0jzeNpxmbs6NHXdlchsmKSbKFoYxkE9IBxh4oqCz8LT/WDdL6z3JRZHvcDZjCCE/k2pCm03KxZYyLB2+VbYoPJshxp+MXbDfEszLy862h8xxNmGbYPkju5ttLr2xIBqhDdnb1PZn10S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 4 Jun 2025 11:56:42 +0200 Vlastimil Babka wrote: > > There is no need to backport this fix to stable trees. Without the > > strict BUILD_BUG_ON(), the issue is not harmful. The elements in > > question would only be read by the memcg code, not by /proc/vmstat. > > > > Signed-off-by: Kirill A. Shutemov > > Reported-by: Randy Dunlap > > Fixes: ebc5d83d0443 ("mm/memcontrol: use vmstat names for printing statistics") > > Well in that case I think we should put Fixes: to the BUILD_BUG_ON() change. > And if it's not yet a stable sha1, squash that together with this? > It doesn't seem ebc5d83d0443 alone needs this fix. I shuffled things around. I moved "mm: strictly check vmstat_text array size" from mm-hotfixes and back into mm-new for the next cycle. I reworked "mm/vmstat: fix build with MEMCG=y and VM_EVENT_COUNTERS=n" so it precedes "mm: strictly check vmstat_text array size". I reworked "mm/vmstat: utilize designated initializers for the vmstat_text array" so it comes last. So the applying order is now mm-hotfixes: mm-fix-vmstat-after-removing-nr_bounce.patch mm-new: mm-vmstat-fix-build-with-memcg=y-and-vm_event_counters=n.patch mm-strictly-check-vmstat_text-array-size.patch mm-vmstat-utilize-designated-initializers-for-the-vmstat_text-array.patch and everything should land nicely.