From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6790C5B543 for ; Wed, 4 Jun 2025 13:21:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77C766B05E8; Wed, 4 Jun 2025 09:21:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7050E6B05E9; Wed, 4 Jun 2025 09:21:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CDC76B05EA; Wed, 4 Jun 2025 09:21:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3B12D6B05E8 for ; Wed, 4 Jun 2025 09:21:30 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E5EE5EE520 for ; Wed, 4 Jun 2025 13:21:29 +0000 (UTC) X-FDA: 83517779898.21.36EC842 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf21.hostedemail.com (Postfix) with ESMTP id D6F401C000F for ; Wed, 4 Jun 2025 13:21:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="Js/jSJAC"; spf=pass (imf21.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749043288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9FoPPyZXh48zUhjz0K7ZmNXk3NCW+1EH6zXuwMWdtUo=; b=C2QZdcRhqtUHPhAAFgewMC8UhJKNW0N8Vuk0+R6qpDQDgQpeOfzFQMPoV44RCHwjfH6k88 GlOO0InqbG7AdBxhjsyHRAo4B1Gs+UlE2mdk0P9ZirQD0Dnrlzmw0BzBVpYws8lFcA1YVH BbdUhNBKU38OKyClBg0N8+2Ms8KzSRo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b="Js/jSJAC"; spf=pass (imf21.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.46 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749043288; a=rsa-sha256; cv=none; b=Ulq+vY7MyC1Ydl+gzTcZIDxTOf5Ud7rApgN9EiBOGgeeSgkEQSfzJ7gvq+V0slfyfV36Fh ixZfCv6V8j2HE/MKsVJI/b9gwp5M3GS4Ga5zHRoomkV5RfetPIhmlgqJj1cfYMobuEVVam tvSWu+0TvIORs3nkSWYJAkKD/CphuPg= Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3a4f72cba73so734827f8f.1 for ; Wed, 04 Jun 2025 06:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1749043286; x=1749648086; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9FoPPyZXh48zUhjz0K7ZmNXk3NCW+1EH6zXuwMWdtUo=; b=Js/jSJACzofh2zewI0YDGaCDZlq1je2CjyrNf6w967XqjGL3BNYEZbTUsZAIUvSgXr xMstAJpN1YzwkE0Qop6c0zC6bZvx3cX4h5l1qucbSafwqDRNGa8QN6BdmOyenKCyHCIf 3hpBdFTLGteOa3bqKC+O0yVEFKHtlqBuxaobzFs8lWwazZeIH8obm9Fj0ga+A5KWBWjv /2CZ97Ly3ZKIyLKRV0gwQvlPylfPqIHlSbNXskKgZNfuy3JWsxq4zs7vg98Rc1qb5NPn xO1VLIS4HC6QPtT1lSV+8JdCQNcIT50nak1wttiTthjLEcHyzbSxc3d5QouEcXHlzjc7 BiPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749043286; x=1749648086; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9FoPPyZXh48zUhjz0K7ZmNXk3NCW+1EH6zXuwMWdtUo=; b=Xa3xA7YN8WVjnyUxxLMSr7c+kTaj9VBVQi1Ys7kTXLnyR09+dB/Uhgq+Jm4XwSYd2z NJWOuqJQoR7P7M0njvf2CdyceCYBxg8tlN49FD2timJNRfZ5NA1/pxyxtRWvVan3AQ2j eMxELujUfQhPjCzEInfm0yaam+dNEtg+hBXkoUSbZbH1VoWQNTqzqxQzxdl8EPJ9DmXL fx+RMEOwfbOKB0lca6JB2JProV+yVJpqJwXkZQbq0VKDKQc0BQknk2igYdOWQAF94wLo NXXBlJVN2MUM86ovDpIAf23NYjRo1SsAlHfuFzpAh3UwLieF16zjsIiSMzYE8aAxOpPE UaFw== X-Forwarded-Encrypted: i=1; AJvYcCUbTUNDQl8HyAakiCPU75AskXU5yTiOzkprUmAEkERgLN6/8Uvm7fHyaNpZ5csPQW1Vq4EJac6N0A==@kvack.org X-Gm-Message-State: AOJu0YyRWZe1mGrqalK1Fu4YQmenlB/c2VokoC/PFPVg4jxRHvc3YX6Q 2tkbIH33ZJCl8L/pIfHJZhyAv3WayKp0oZCcPMl5zIxhHuQ/P/OQ9akl6NrUtemtrzo= X-Gm-Gg: ASbGnctGzvce3tUpM4+PHXKfynFbeopjMek/VmZOAcoemlb0OfAkKmCXnm8yN/vPZpO 3S1dsBTo7Up6n4FvC14+lSSm94S6VoWibp2szXjYgg77mQ192G83kjocnK3P+5o6DUDNAO2tNxc d19xligj3eMY7x1F1/ZZ3vH56meWpgWmBZyyAGMQUUsbbnV3NB9kqKaPw1Z0jxXhLCtVRsoJ5ev cIl0sJPT69zGQufB98HeG9Xqr/9CjK1IjOeRBrepmS2GgWeY2+pV41ZYF8hYPrcvEke1Sp4pgpq Us+zYNIZmV3oK3GInBSV8pwR01VCNBRAYgikmWXdbxUA2Xnm X-Google-Smtp-Source: AGHT+IGwF9eqMWG6go6awjyG5qynWmhDup7h3GdgJcJVmsx6gfF7MJu3xHvCKuQq4UMz9D9H9ckNww== X-Received: by 2002:a5d:45cc:0:b0:3a5:24cc:6d5e with SMTP id ffacd0b85a97d-3a524cc711amr548854f8f.3.1749043285998; Wed, 04 Jun 2025 06:21:25 -0700 (PDT) Received: from localhost ([2a02:8071:6401:180:da11:6260:39d6:12c]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3a4f00972e8sm22115596f8f.67.2025.06.04.06.21.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 06:21:25 -0700 (PDT) Date: Wed, 4 Jun 2025 09:21:21 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: Lorenzo Stoakes , Andrew Morton , Shakeel Butt , "Liam R . Howlett" , David Hildenbrand , Vlastimil Babka , Jann Horn , Arnd Bergmann , Christian Brauner , SeongJae Park , Usama Arif , Mike Rapoport , Barry Song <21cnbao@gmail.com>, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Pedro Falcato Subject: Re: [DISCUSSION] proposed mctl() API Message-ID: <20250604132121.GC1431@cmpxchg.org> References: <85778a76-7dc8-4ea8-8827-acb45f74ee05@lucifer.local> <20250529211423.GA1271329@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D6F401C000F X-Stat-Signature: cb13kd37girzmdb5uawc5x74ojzkwib9 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1749043287-892219 X-HE-Meta: U2FsdGVkX1/RcD/Ehlj+vS5gbiwL5m5yU4QETel80qfwZVNuGu1NA2aIQ/VPsZPMHq2M+88Y9tdHBbnQrpTsIrw0Uhh9nHHlJV5s6cblREjYsSuGgNAPv3SRhJHamXeqhJ/7bkns/hmdVRyyv45om9jp+/W4JXcysAT1pnnFFmXQ72xZjffs7Kv6BHndtMo4o+MLbFalCrO1dFV5PTeBXZ+AbAwVhVO2zr8pdGBrwxhZAdug7msGULfOyNImP9JMHjalfjHUyyOO+jR2eoztzrPnezJhwr0G0DfMi9GV2yHAGyy+19iy60hpyvrok0WNDPi/11iCig3Mx0KSeU860tln2dksnh3YUmSAlTHsTpsmL45GzjGfYfVg8Z5djh8R/7F5oLvGFNemRXnLcXZ08uJfZl8hGe6wqb4kpXaZQ/vFOrV7ozP1VrsW++Co0hf0/e2mvJ9A5OXlxE4aDPAd7lPqrjCue3qkFkaiF/y/yWWn+KedmNcKR+5iJoR9YBHbrESWUXgKGX31DBAzvxqXQ4e1fm6Voq4Fa+9iih4ma+Dtg1xUKwv1Le5r23vQk2afrcgpYIQBRLg/rwTvY0Jd7vQ/PBU82oE8cDhfjL0nA5iVzwTHSA5IciOg0DEtiy9fz5Nkk5mmxim4sxHZBpNeIcB6/ZIchwQUL7x+xq0vh07PUwcZCCU7P+KWKHn+0oDqRJaL+3pPYboeSeilCHKmbUIgsxSRvXs0vQBtN58yBuTqw+B4eLzhBp1PCOm8DGm4PcziwSaOBBOBH2i3iG5SYw/G8KmEMoCsSP+eWgtsZ4cMZylCytiL4PwXeVuX2XeHxbCAkR11cq1kvl6xR6wXyc7p+GCo/2UofumMLCXvcbwWfBlIb8WJPCKuUQ50BqneMHxhiDYQt+xU/D/nBWpP65iie9UHcZY4v2cCayogMFeMw+MaeH2eumkb/J2BCKuztuyC7GXcD1MtGyMeIyR E+WymAhf boj7ig+f/Sjnum3WyO/jm+VoGT16jFIyx4SUbtgNWIKXEowirwszxKRpzzphvFNuqRiPeUwm3N9ImWWvkBxve2i9lGU622Gle00+jObGl0hX3bQDqwi4Bv/se0xQbEbTM4lCjt5yg6Ri1VETkUAE3tXQzMygOJNJpxUvjwfn9/lEZHLXUFT3jKsdmHAFom1dlDvmGpF9NNvthGEcJtn0QkNqeF2YObNYQANA8jGBQHDjCIQ/uw3jAVToknXvk7vRhpsoRsWT0d10pTCN5i+irLoQM3rPWTMllKRyz66upgrxcTjI7Yd3icavfjBDV7eQhmSslpuGiGmVMKrQr0w+RWiqlkwHZ+W8TDEkVuPjQHtyQI+4CMOWk672iIoFthjW3syWp5Pg3IQ6AgLLQqhoql3ixneB+KCQCHpc3zrCNY8EGchsUoCmjP/FGY6PtUPnsQA+ce18qBbRhPLmWAldPmWB6eA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 02, 2025 at 07:01:56PM +0100, Matthew Wilcox wrote: > On Thu, May 29, 2025 at 05:14:23PM -0400, Johannes Weiner wrote: > > On Thu, May 29, 2025 at 04:28:46PM +0100, Matthew Wilcox wrote: > > > Barry's problem is that we're all nervous about possibly regressing > > > performance on some unknown workloads. Just try Barry's proposal, see > > > if anyone actually compains or if we're just afraid of our own shadows. > > > > I actually explained why I think this is a terrible idea. But okay, I > > tried the patch anyway. > > Sorry, I must've missed that one ;-( Apologies for my tone. The discussion is spread out over too many threads... > > This is 'git log' on a hot kernel repo after a large IO stream: > > > > VANILLA BARRY > > Real time 49.93 ( +0.00%) 60.36 ( +20.48%) > > User time 32.10 ( +0.00%) 32.09 ( -0.04%) > > System time 14.41 ( +0.00%) 14.64 ( +1.50%) > > pgmajfault 9227.00 ( +0.00%) 18390.00 ( +99.30%) > > workingset_refault_file 184.00 ( +0.00%) 236899.00 (+127954.05%) > > > > Clearly we can't generally ignore page cache hits just because the > > mmaps() are intermittent. > > > > The whole point is to cache across processes and their various > > apertures into a common, long-lived filesystem space. > > > > Barry knows something about the relationship between certain processes > > and certain files that he could exploit with MADV_COLD-on-exit > > semantics. But that's not something the kernel can safely assume. Not > > without defeating the page cache for an entire class of file accesses. > > So what about distinguishing between exited-normally processes (ie git > log) vs killed-by-oom processes (ie Barry's usecase)? Update the > referenced bit in the first case and not the second? In cloud environments, it's common to restart a workload immediately after an OOM kill. The hosts tend to handle a fairly dynamic mix of batch jobs and semi-predictable user request load, all while also trying to target decent average host utilization. Adapting to external load peaks is laggy (spawning new workers, rebalancing). In such setups, OOM conditions are generally assumed to be highly transient. And quick restarts are important to avoid cascading failures in the worker pool during load peaks. So I don't think OOM is a good universal signal that the workload is gone and the memory is cold.