From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D091C5B543 for ; Wed, 4 Jun 2025 13:16:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F14876B05DB; Wed, 4 Jun 2025 09:16:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4E26B05DE; Wed, 4 Jun 2025 09:16:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDACD6B05DF; Wed, 4 Jun 2025 09:16:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C3CC96B05DB for ; Wed, 4 Jun 2025 09:16:53 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 69DFF80F83 for ; Wed, 4 Jun 2025 13:16:53 +0000 (UTC) X-FDA: 83517768306.21.A95C9DE Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by imf14.hostedemail.com (Postfix) with ESMTP id 7979910000C for ; Wed, 4 Jun 2025 13:16:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of xialonglong@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=xialonglong@kylinos.cn; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749043011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CLgyRMZGlQMXVALD9MvwzppR1pFD5v7N9JlkkQBPUkM=; b=Oyad8aiAyC01v5HqULPyqAXgD+2egQ283xsEHvfRatx3EhYPlbG36TMQDtJiTaCmW4DeKU 3rFjhx15vnRPN1o84bznqYA0aeQ4dvAKZ2IVx04PQcGTXfyiyJ7hHW3prsSWM4ZSc9PSBG asXkg/6ZQspgXEq87J1JQahR1nyvUL4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of xialonglong@kylinos.cn designates 124.126.103.232 as permitted sender) smtp.mailfrom=xialonglong@kylinos.cn; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749043011; a=rsa-sha256; cv=none; b=f6U51nbfWdRhPeQmXzi4eF9FUDqG3hukaMgQAhshGaBloD89izal07GpI2NtCQn2r1gO0l EBxVIaWZUlHOdWkJBYpaYCYMXIq5BcFx9iqVKTHT7PL02VJ2bbr9PX/dri4ILtXUBeOoYx dm8fuEKyYw+2fqSGgaabAMgXo/3U9FA= X-UUID: 859e940e40f211f0b29709d653e92f7d-20250604 X-CID-CACHE: Type:Local,Time:202506041104+08,HitQuantity:1 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.45,REQID:7c393c9e-0f25-4b82-a4b7-5efc9c34e84d,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:6493067,CLOUDID:bdac3ab60b7254cfaf95c3a7cf35d4d3,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102,TC:nil,Content:0|50,EDM:-3,IP: nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,L ES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 859e940e40f211f0b29709d653e92f7d-20250604 Received: from node4.com.cn [(10.44.16.170)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA) with ESMTP id 1682041122; Wed, 04 Jun 2025 11:18:01 +0800 Received: from node4.com.cn (localhost [127.0.0.1]) by node4.com.cn (NSMail) with SMTP id 789D316001CC7; Wed, 4 Jun 2025 11:18:01 +0800 (CST) X-ns-mid: postfix-683FBAE9-333779653 Received: from kylin-pc.. (unknown [172.25.130.133]) by node4.com.cn (NSMail) with ESMTPA id EA3D816001A03; Wed, 4 Jun 2025 03:18:00 +0000 (UTC) From: Longlong Xia To: akpm@linux-foundation.org, xu.xin16@zte.com.cn Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Longlong Xia Subject: [PATCH 1/2] mm/ksm: calculate ksm_process_profit more accurately Date: Wed, 4 Jun 2025 11:17:54 +0800 Message-ID: <20250604031758.4150209-2-xialonglong@kylinos.cn> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250604031758.4150209-1-xialonglong@kylinos.cn> References: <20250604031758.4150209-1-xialonglong@kylinos.cn> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 4kbp57fntbhdyb7ao8adkne6ak11w1ij X-Rspamd-Queue-Id: 7979910000C X-Rspamd-Server: rspam11 X-HE-Tag: 1749043010-356304 X-HE-Meta: U2FsdGVkX1+coDd3+ezek3RBUbgPc3bcdVRZVImDtLv5cGlx81XyGBcu30/5As3+D4Hjkr7kilS27G8fN3w+2buHeompkVfMwkF/EcMa6GVV6J6HirKKo6eVqcUCZXr2yvYaHMH5e54vwCpsM2N8p7BtNzOxn3AGZCW6LCCLB1/YQbnx2QWCMNf3NY1iu77hAeLLkW++oaK5xD6i/RXi9pndv/D2qgKCrziDggXLm5S2KgJ/Hsf/sZbdakV5R1kv67oMjXoIHB/40WFBeTCCLNy1Pg/bnH5w664BO/NK0CXXER7veqCkDOZ0DSX+C9F8sLAqhsConrimXfRspQuFnx1Hbyw1gBrwkrfI1tS+buhpUa7NJwQXWTiF7s1jY4A7Iud8SOtJ8TM02hCZAv54UreP1cHdx2M6KuAqAw1UOViHQnHk+v2i4bcc8pDLk8mhN4BpMDg3N75NZMsSGgfDLcg4QDfSn412/juZsd3gCmhneTXSb3WPphhzFZ8T8oSuSo8//NmRLeuyKx8FKB9SyQTrnPx5w+OT7JM8jJMF2D1zC3J/J1Ikt3RxlJeQBR5LI0yphBaSvAjikT8JiKvzx1k0qSjpNIL2G1WiL08CEaYjoT3VapIs5g406ffacJdZWIUltk3NF47rQojsdsML7eIPrsZ062zvIDFq8cVoSzuec52i01na7NPIjiKgmutF7u8FBA4kjbH0u27gzYge00a0HBG+sZ80Ai6ORuV5lveDJ1zachooCJbM+rhBg2PlmeaELq0kxbBLIG1fUdmD3lOsibQeTHJpygXCNGQ28047I1ZLBwRbkbkabHnAmZgLoj8gLaQD/XcdhFl2IJqeDWMFnMmmYxYkvyUqCFLAXAR4Oltpswr1jmuJQ8QqaMziO1F+bySo3RpMmnvWsyombhd63aXYD30ZSWoBMIfRmBhXEhLWtPk5wn33B6vxW4VVfGZtDrBeSiSK7Of6562 XwJCpDEn e2R0+DtoCTW0iQWhHvIRzpUiRbBH7lwsoeioN88dKcrl+FU3bqvJVCxK2ihSp0odxmLac5L6x5iG2MlPVq5Q2FB2mRHShErQaLovc28lmYAKXhEO1NhaRavxaTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The general_profit_show() only considers ksm_pages_sharing, whereas ksm_process_profit() accounts for both ksm_pages_sharing and ksm_pages_shared for each process. This discrepancy leads to the sum of ksm_process_profit() across all processes not being equal to general_profit_show(). Fixes: 7609385337a4 ("ksm: count ksm merging pages for each process") Signed-off-by: Longlong Xia --- mm/ksm.c | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index 8583fb91ef13..fa4e1618b671 100644 --- a/mm/ksm.c +++ b/mm/ksm.c @@ -824,12 +824,10 @@ static void remove_node_from_stable_tree(struct ksm= _stable_node *stable_node) hlist_for_each_entry(rmap_item, &stable_node->hlist, hlist) { if (rmap_item->hlist.next) { ksm_pages_sharing--; + rmap_item->mm->ksm_merging_pages--; trace_ksm_remove_rmap_item(stable_node->kpfn, rmap_item, rmap_item->m= m); - } else { + } else ksm_pages_shared--; - } - - rmap_item->mm->ksm_merging_pages--; =20 VM_BUG_ON(stable_node->rmap_hlist_len <=3D 0); stable_node->rmap_hlist_len--; @@ -976,13 +974,12 @@ static void remove_rmap_item_from_tree(struct ksm_r= map_item *rmap_item) folio_unlock(folio); folio_put(folio); =20 - if (!hlist_empty(&stable_node->hlist)) + if (!hlist_empty(&stable_node->hlist)) { ksm_pages_sharing--; - else + rmap_item->mm->ksm_merging_pages--; + } else ksm_pages_shared--; =20 - rmap_item->mm->ksm_merging_pages--; - VM_BUG_ON(stable_node->rmap_hlist_len <=3D 0); stable_node->rmap_hlist_len--; =20 @@ -2202,12 +2199,11 @@ static void stable_tree_append(struct ksm_rmap_it= em *rmap_item, rmap_item->address |=3D STABLE_FLAG; hlist_add_head(&rmap_item->hlist, &stable_node->hlist); =20 - if (rmap_item->hlist.next) + if (rmap_item->hlist.next) { ksm_pages_sharing++; - else + rmap_item->mm->ksm_merging_pages++; + } else ksm_pages_shared++; - - rmap_item->mm->ksm_merging_pages++; } =20 /* --=20 2.43.0