From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94601C5AE59 for ; Wed, 4 Jun 2025 02:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 422DE6B055E; Tue, 3 Jun 2025 22:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FB366B0562; Tue, 3 Jun 2025 22:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EC666B0564; Tue, 3 Jun 2025 22:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 03DA16B0562 for ; Tue, 3 Jun 2025 22:53:09 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B2EC28D330 for ; Wed, 4 Jun 2025 02:53:09 +0000 (UTC) X-FDA: 83516196498.16.0CA0F0C Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf08.hostedemail.com (Postfix) with ESMTP id D1FA5160002 for ; Wed, 4 Jun 2025 02:53:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749005588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=h/VmdDP7Sj/IDHQMM5aQkhuZ+VxQq1DdNoS1nXlKBUg=; b=vwjZL324qd65ClkDG2KyS3mZNwZnAPs9b5mfa4GEGKAW1dHqccA89BI4cEUjamWIegt7/9 MAhjYeHIsxg/7ZsYuDL3qhz34cI9+cCC2G2/H0ObpAbfl4V6McYHoAb1SEpH8Y2feFdt8y 7xG1KG5UgoPY/FS5+2vf0x7plFacS1Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749005588; a=rsa-sha256; cv=none; b=Yn5KrckAV8hKtARNNPTdjZNFwfoRP/OeNgq5lceVAaPXFvZg+QF4O+Pd06NvRg6HFaUUj+ OaPm2bQPmfFlr69BzL2tg6lkRZe4GBHs2T64AiiLKADj2lB4ph1Zx6GlXZC+5JpZmf/nYG 8fjcpCC4BYYpcPp/X0gyLoSDKPHCu2U= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf08.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com X-AuditID: a67dfc5b-681ff7000002311f-46-683fb50abef6 From: Byungchul Park To: willy@infradead.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, kuba@kernel.org, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, hawk@kernel.org, akpm@linux-foundation.org, davem@davemloft.net, john.fastabend@gmail.com, andrew+netdev@lunn.ch, asml.silence@gmail.com, toke@redhat.com, tariqt@nvidia.com, edumazet@google.com, pabeni@redhat.com, saeedm@nvidia.com, leon@kernel.org, ast@kernel.org, daniel@iogearbox.net, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, horms@kernel.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com Subject: [RFC v4 14/18] page_pool: make page_pool_get_dma_addr() just wrap page_pool_get_dma_addr_netmem() Date: Wed, 4 Jun 2025 11:52:42 +0900 Message-Id: <20250604025246.61616-15-byungchul@sk.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20250604025246.61616-1-byungchul@sk.com> References: <20250604025246.61616-1-byungchul@sk.com> X-Brightmail-Tracker: H4sIAAAAAAAAAzWRa0hTYRjHfXfOzi44OKzbm0biwiQl01J5sDLpQm8QdKMP2Qc9uUNbeWNT UyHQspupXanQRbPwNpXZMjfFIs3UMvPWYuUVZVrgpZyJusq84Lcf////+X15xJT8He0mVscm 8JpYLlrBSGnpmGv+VunLPSr/5nJP0BnLGCidSYaiAYsQdIYqBFOz3SJwNDQx8Cx/mgJdWwYN v41zFNgbB0XQXzhMQ+01MwWDt5oZyM5wUnDJUiyA9qocIdyfK6DAnDYggq4aHQN9ZfNCGK7P puF9bgkN/Tlh0KhfC9MtowgajGYBTGc9ZuBep56BoYx+BJ1vB2nIS89BYHxtE4JzRseEeZLK kq8CUp3bKyJ6UyJ5UexDMm2dFDEZbjDENHlXRHq+1DKk+ZGTJtUWh4BkXx5nyC/7N5pMvLYy xFhppclHfYOIOEwbj7Lh0l1KPlqdxGu2hUZKVW32ERT/RJJ8x5lOpaEZUSaSiDEbiIfme+kV NlxtQYvMsN7YZpulFnk1G4Adg00LG6mYYseF2K5zChaLVew53Gp+viSiWS/8r9i6JJKxwfjv aI5gWeqBSyveLIkkC3nP+MOlXM4G4WzLZ2pRitkxETYW2anlg/W4rthG30YyPXIxILk6NimG U0cH+qlSYtXJflFxMSa08NzCi39OW9Bk+4l6xIqRwlVm6QlVyYVckjYlph5hMaVYLfPYshDJ lFxKKq+Ji9AkRvPaeuQuphXrZNunLyjl7FkugT/P8/G8ZqUViCVuaejICPfCcbhmwrlJmcZl tLe9Kp0LUgXt21mRFeXrj0d9O+qsEVdyI/GaJ0+/ByeHN10/2+p1rKV76kdqTM/uM24pXae0 feabO8a9ew8NhNS1Kk5aD46Ewc+5D24FuG6/xHkA+RmESs2QH3nQUXncPcRF4GLRcXktmw17 XT5tKKcUtFbFBfhQGi33H2scw7nYAgAA X-Brightmail-Tracker: H4sIAAAAAAAAAzWRW0hTcRzH/Z9zdradGhyX1MkelEGImpai8YOFCSKdIiQKuviihzy45ZVN xSWCphVJmjcodNJqaXOTpmZuiknN4QVNy0vOMhVr1oOZd9Rl5ozePny+fL8vXxEuNRDeImVq Bq9K5ZJlJEVQMfKCIOrVacWJ13opaM0NJJg2suH5jFUAWmMrgtXNz0JYsfeQoH+yjoN2qJCA NfMWDs7uWSFM180R0HHXgsPsg14SigtdONyyGjDoqukTwPvWEgFUbtXiYMmbEcJIu5aEqYYd AczZignoq6onYLokErp1B2G9fx6B3WzBYP1+DQkVwzoSvhZOIxjumiWgOr8EgbnTIQDXhpaM lLEt9RMY21b1RcjqmjPZl4YAtsgxjLPNxnsk27xcLmQnP3aQbO8jF8G2WVcwtrhggWSXnJ8I 9lfnGMnqfyxirLlljGAHdHbhBc9Y6lQCn6zM4lXHI+IpxZDzO0p/LM4uc+XjeWhDWITEIoYO Y4x3+pGbSdqPcTg2cTd70SHMymwPUYQoEU4vCBin1oW5gwP0DeadpWmvTNBHmT+GMcLNEvok sz1fgv0b9WFMjW/2hsS7fnLh4Z6X0uFMsXUUL0WUDnkYkZcyNSuFUyaHB6uTFJpUZXbw9bSU ZrT7X13u7zIrWh05Y0O0CMn2S6yTEQqpgMtSa1JsiBHhMi+Jj/+ukiRwmpu8Ki1OlZnMq23o iIiQHZKcu8LHS+lELoNP4vl0XvU/xURi7zykdA1efPrt8Pz40tozv2ONH1541sdQvnC1ctUk XIoONfNRg9fi9+1kUJP+lRA4WLSo96YtPw2cJnH8rTzIfrm7cqqhCeo4csy43lgebdpYTp8I VVK+HWdzR7dNA6aoshw9Jq+1B1rk5+Mq9JkeQeh2ju+lsKVprr1aE1sqI9QKLiQAV6m5v1yZ 1AW7AgAA X-CFilter-Loop: Reflected X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D1FA5160002 X-Stat-Signature: h1n5jdjks8hph4ikmtokg7h87sa8yfc3 X-Rspam-User: X-HE-Tag: 1749005587-267294 X-HE-Meta: U2FsdGVkX1/+iWIEsLu+8AThaslGiZuDtwOQl/e7XGrmyymy7M2HkvZlfJuzIZlqvekfCi6ubRkn4GLr07u/jZ16Uuah+1C4yBcpb7ttq+1YMCNM7mR1V6qJm8ysllL0xVP9vNGdqubifjt7t7Tn+sAg64vVXAFADIk83RIKaUr+NcK+S/u4GtRPF6p+YML9KKfPgfRaVtSLfk25ADMQBSABQyGtBeUc6QTZuhk5SP5SWA+mcy4XvaVbdeN7AeEuh+B9RU4ERX04XYxOGULG4ahQetGlFB8KW4ZfOgYJfhXZsgYtVS9GAjTMldayC5NsRV5Ab//hcOe2XPklYHWYtB+18Q7Tprn6S3N/z3weSZTiWclT8/ilcgz8KIyNBXA1z4KiZBGJdkTvbIVkv9alv2sH1wNEEDZXfTiuUy+lAKW+hxs2LeVZicwEVGiMUNLpBstBvYf6PltnNvljckUdbejhlCx+K4HmtxpvApH2Do0JKGIK0z/hXSAdOSSiCR0ODMeNfREyVzyzB1rW/EkRje8H6+IanwH8yYVQlyvXPj7+lDLC/1lohDRi9rXYj2lRwyiZjScM1aDOJB0Rgi3IuKWBR7p0Ni6u2D0OG/IRVtWV7s+AxDtz/sdKz9tD1IhPqS1LuYiw09+q1VKUWpzQB3K581bXGivVomf/TkyWJSQkzpzXHtlQtWaqLyRBLjR2FqTN+zjXIn/Zc1Mars2aI5G23hExKuXVVwNULkKTm8Z5p6EHdxMOubT70uqGN//1Ltl44ubTiLVBEYj5Kswlmmt0Xc+N/Z+E1ZQaOXI2dcRqcvyByP9ihUDRXfcUT7p9s8xAkYc2CFTFi3dVkiDuC7vdfL2DSnYrQ7c1yCH97xKOWMHLuesoWzw+AuDo2FXuk4hpV7W42WiwtxinWcnq1GTGYR6xnp7JM7FwMXfN/BsVLC4HVStvMskUXZInFp19HpCW+NwiyKDesF3/zS0 GwfG/HVT Od+t2MhRJsoWmvswW0WGPd4HP0a+Lsbg0jw3+VfYIGuIRlyvxLign6+BgTN58nDvuK0Vambcm+lpgwfLpp4nDiTtcAyp77mVBAOKwLXHUXzqspnD/cd+qH2+GdOuJ50Aw5yQU8apBB+oIpAgx35DNw5u3hAgGoLL8qGeWD+vKAETAEj0aFBj05Rvrj0/dK3ufsBkUac44Vv9HcdM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The page pool members in struct page cannot be removed unless it's not allowed to access any of them via struct page. Do not access 'page->dma_addr' directly in page_pool_get_dma_addr() but just wrap page_pool_get_dma_addr_netmem() safely. Signed-off-by: Byungchul Park Reviewed-by: Mina Almasry Reviewed-by: Ilias Apalodimas --- include/net/page_pool/helpers.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/include/net/page_pool/helpers.h b/include/net/page_pool/helpers.h index 93f2c31baf9b..387913b6c8bf 100644 --- a/include/net/page_pool/helpers.h +++ b/include/net/page_pool/helpers.h @@ -437,12 +437,7 @@ static inline dma_addr_t page_pool_get_dma_addr_netmem(netmem_ref netmem) */ static inline dma_addr_t page_pool_get_dma_addr(const struct page *page) { - dma_addr_t ret = page->dma_addr; - - if (PAGE_POOL_32BIT_ARCH_WITH_64BIT_DMA) - ret <<= PAGE_SHIFT; - - return ret; + return page_pool_get_dma_addr_netmem(page_to_netmem(page)); } static inline void __page_pool_dma_sync_for_cpu(const struct page_pool *pool, -- 2.17.1