From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9FA7C5AD49 for ; Tue, 3 Jun 2025 18:05:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 680126B04E1; Tue, 3 Jun 2025 14:05:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 631296B04E2; Tue, 3 Jun 2025 14:05:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 547D46B04E3; Tue, 3 Jun 2025 14:05:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 35D3A6B04E1 for ; Tue, 3 Jun 2025 14:05:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4C021C134E for ; Tue, 3 Jun 2025 18:05:22 +0000 (UTC) X-FDA: 83514866484.08.5A8ECEC Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf19.hostedemail.com (Postfix) with ESMTP id C72911A0005 for ; Tue, 3 Jun 2025 18:05:20 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=mph5=YS=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=mph5=YS=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748973920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jp2nTedbdiziM0zzYV6J77kD4GNLrxpLNeiQUYQN2eA=; b=GdM7DuxHi0tx1oCxd9dYhg0r9eQo4IZW7NAQrnf+l1aC2+F0GN8yLq/+4jkpigIxi6vAgo kMQOcY7XWlH0o9r/aQMTS3x71o3S7+3zBBDfMQ+M6ZGmhlxM7b/49H+SFC6MuvbjUrnkzL 6DHR162ZF7BbusdQEAxGgKds8xmR9d8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748973920; a=rsa-sha256; cv=none; b=AbWzKOYSGxSjH89N/9gp04DSAiW586djZgL9/DIt9UMar3G7d7FLZRAs8ayAhnWjYPVk58 CRDgBpVFQ/WizXnakRt6vtoHRK8d8a+DfxuDNdNCXT5KD3sI8bUG8yqdMq8fum/sGu6zB/ 4uty1QRG2oeJRTLwdk1wJj0UX3SnlL8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of "SRS0=mph5=YS=goodmis.org=rostedt@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=mph5=YS=goodmis.org=rostedt@kernel.org" Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id EEF9DA4DF09; Tue, 3 Jun 2025 18:05:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF51CC4CEED; Tue, 3 Jun 2025 18:05:17 +0000 (UTC) Date: Tue, 3 Jun 2025 14:06:32 -0400 From: Steven Rostedt To: Linus Torvalds Cc: Matthew Wilcox , Hugh Dickins , LKML , linux-mm@kvack.org, Andrew Morton , Christian Koenig , Huang Rui , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: Re: [PATCH] mm: Fix compile error when CONFIG_SHMEM is not set Message-ID: <20250603140632.168190f9@gandalf.local.home> In-Reply-To: References: <20250602170500.48713a2b@gandalf.local.home> <20250602171458.7ceabb1c@gandalf.local.home> <20250603102959.20c85adb@gandalf.local.home> <20250603132736.554f611d@gandalf.local.home> X-Mailer: Claws Mail 3.20.0git84 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C72911A0005 X-Stat-Signature: igeh48d437ycuhcmndpj3u9emz5k3ngu X-Rspam-User: X-HE-Tag: 1748973920-942030 X-HE-Meta: U2FsdGVkX1/4xYECv+hg+V/d+KQO+ogMHFg9qMzwO4DDwY3sdof551StR7Bwddym3nueFOLCsXjuLu3ymHMLuN7aaNeZjCXrf8pmj7klh/R1bRoYHSGivI7ou/5Dk6WFKodlu81a74N+/P6/zsuRpOLH1eL9TKObInwQM/15mtefEsKgMEoaDU3VM8ERwF4OcTcQ90iwlqDPiyciQPlPKBa/bNhyYysmcUz7bs4HWmYmw1IolZqZTyniCnXV5pZoB0Ubg4R5JeBJ/dYYtQv3KQg7SqBg9k31/nULeH3XD3NvCTyF6ey13D1k5bRp9VZicqjBXRLMeyAmmUzmH3eTISay+nmBMIzBeiN8eYIHadwUJSnPEPDVJEPy+pOmjVP24jTY3He3TQQw45cHPNGRdFGvjCm7jsbNLR7Ik7J6Unuq9nQ3mVfFKrwmGm06TVY1GpXrE0SsjnW6YtXnZh2SA/iP+K68YefPpFvBGZURZ1vu/nIN2UcSjulOuhlxG9GRkgpehWLmIq6ETfKqVja3c7vXIyn55BJUVX6upv+ed4LG53yC5T/Phwdu91ZgdQtuiGiVYk6d9fFKa+1R1e+lvznVSJssrYX94ZFtbrVB5d7PAAdRCiFX4Nms5fcOIwK6n4Xs7P/QrUDIE3cQI0aQ1WjuZU91yhvDnHuNAp0SbzPmsv/wjnuJZGF2meYTcMyYAGYoF1sqoCzn75BDRfIJRmWqGF8qCgg7Ouu+9Tq8j2ieAX/geyeDpmNJLZyzPsq6j2xleGHYVritBeqUePZuQvHcX9aV0b9VVhSQl5rjeU4xb73g3k3nbVQ+H7vwv0bv1O9go0BlL7s5zM6E+ayBg8+YOq1ea+szlpmyFwieYj7vOpcC/T0L71Pi82j1pw16UlIgxKkpoqxTJUFIfMPwssnere1SPTJu61kLyzEqRc9WFUONAer0/tYvgRkEYkbHgnoXKDGwv+VSRoFqFKM vOlQ87Bu L48Hnc39W34TccLqoGR4+IXckyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 3 Jun 2025 10:54:49 -0700 Linus Torvalds wrote: > On Tue, 3 Jun 2025 at 10:26, Steven Rostedt wrote: > > > > config DRM_TTM > > tristate > > - depends on DRM && MMU > > + depends on DRM && MMU && SHMEM > > Yeah, except I think you should just make it be > > depends on DRM && SHMEM > > because SHMEM already depends on MMU. Yeah, if I had made this a real patch I would have done that, but this was only for seeing it it would work. > > That said, our docs already say that if you disable SHMEM, it gets > replaced by RAMFS, so maybe just having a ramfs version is the > RightThing(tm). > > I don't think such a ramfs version should just return 0 - much less an > error. I think it should always redirty the page. > > IOW, I think the "ramfs" version should look something like > > folio_mark_dirty(folio); > if (wbc->for_reclaim) > return AOP_WRITEPAGE_ACTIVATE; /* Return with folio locked */ > folio_unlock(folio); > return 0; > > which is what shmem does for the "page is locked" case. I'll let someone that understand the code a bit more than I do to make such a change. My patch was just a "this makes my system build" thing and let those that know this code do the RightThing(tm). -- Steve