From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B474C5AE59 for ; Tue, 3 Jun 2025 13:48:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F05E6B045E; Tue, 3 Jun 2025 09:48:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C80F6B0460; Tue, 3 Jun 2025 09:48:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B99D6B0461; Tue, 3 Jun 2025 09:48:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 673EC6B045E for ; Tue, 3 Jun 2025 09:48:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D99F7BCFF8 for ; Tue, 3 Jun 2025 13:48:47 +0000 (UTC) X-FDA: 83514219894.26.E31BCFD Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by imf21.hostedemail.com (Postfix) with ESMTP id EF3791C000B for ; Tue, 3 Jun 2025 13:48:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=gcogmqgf; dmarc=none; spf=pass (imf21.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.45 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748958526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZSTZfPDDH1MLe7AQH4Yed2Uaqt/hLn+gokhyp0JhueY=; b=MrjRDu/ZCrWZocG4kfkmzk1wQRKx/QNaTJUOyi3B/LIfururkjauDdG8XVcGbOON7Tib60 HOOM3JBtaEkFbrw+TR2XPuWusWKZkr4XcEEIu6Q3jovbZjckVH1USkTj7aqFmJ/qZvqVHM EriAsYo7FsbTKB28h01yW9WvOj/P5AM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748958526; a=rsa-sha256; cv=none; b=fbLsOcZXPYUwefxceTE2HgYrbTR3sp5V3L5ySXfa/ct1auE6SzyEZROQu3v1nTac8/vfQZ zIdSoGKXO4+44WinFdFrzgSpO8S3gxwUn3vo8RPvWcDKmiuVbBpaRCHN5FgBTjr+G5bjcR VuEJKByGnr4M4WHnuZd/Othunvn0WiI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=gcogmqgf; dmarc=none; spf=pass (imf21.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.219.45 as permitted sender) smtp.mailfrom=jgg@ziepe.ca Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6f8aa9e6ffdso51296896d6.3 for ; Tue, 03 Jun 2025 06:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1748958525; x=1749563325; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZSTZfPDDH1MLe7AQH4Yed2Uaqt/hLn+gokhyp0JhueY=; b=gcogmqgfko571NvAPoh+U15acEgJluUOI3Zp5cojzWLzW2AY2xGFohwg2I+5Hv9FqU a+R2AOfyhKC7FqbVLgNfZVl+uTh3Ne6Zd2HpjwUgBIJ5VGeVdFemd2HH6VNjHVuY+A8M y1moSPo5UcZOF2nCN6msX5M70L19dWvb2PxwGUPheXxOUB1oPV5VOFeKpBOSFXByoLh+ tOFSMQa2DUyJMll9/xUoEJFHBPIIp4RyaKR0bSZG/eH1M6/L5jlsOls42Ti4nWZcMac4 wK7eJbNgjMEw7BxSF87fL+bNzU4U4ewvcp6F4navcn6K+IgKrfzewaDCdq8P4bLXFJIA hXJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748958525; x=1749563325; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZSTZfPDDH1MLe7AQH4Yed2Uaqt/hLn+gokhyp0JhueY=; b=tHmL6NXLUiwM0g8hCZbgQgfZMHEE7oEYSLwbvpXk9TssYDqKf841oONrMwicJvpqDo bnSZTv0v0LF/E2ISApQ0M3195qqdk2L1z1FkQ/cLcVYY3gBonyovqIRZHr1WaiUuYu9t jm1laLb+ZwrFqcKRNItpYRLjFcMsuv+037n+bjHp4axnl1BnSSSHpFGxxnzRW1vFJxjj mrv4PP0OblSIJFRIAIGcB8vQwO7jhfJP+Iv/mp/zHl9lebFCjevnfwbIRsU8zAsnJyqz UtaTzlJLr6npRWTLOIgNTUi3sqjGtsF/KrVKkyLACtL5s/GwWi6gfUFR4/5i5UGwc9EO yNqQ== X-Gm-Message-State: AOJu0YwDRGXvqu7CdNEVSCEoOMlEeuMQ1s71z6OZlPENeYGyNzR/pFAc rtvdR5LyVDwGul+balgTx+3fXt+DPNXep7aEYNVRhLIarouf4QEld14pT4cKJLHoTJQ= X-Gm-Gg: ASbGncssoV2MpAhSd1I7DxsflAb9eOROla5gTWXFMgEYUYPJkI2K8/ACfYViRcH0eeD N9CiIR/ps2hKcRFM+0IrfW6YTUuO13ebmJ5t9jyjkMIIE4SByYGS9kYXeEg4wtp8UMk3hCglcjm 8Az/LVEJKTxqcLhHJCn8+miOXLJEJ3rd4j+IBoAvIJvSJx2Js/CtR3DwvrZYeUO8vnhsENLYmR4 xShNnljPlywRweryCR7wNT8ArZbBNNNiwu9FZ3AWmZ+vwSDx4Z2rilP8rE92ua8nZNLx2QQlHRC YhBH956ehu5VSNXlizGFFHUM4BnXZv9je9epw51JjAYOUN9jMom7csRB21s/6N8vjF8QodUXfwA P/+t+y+xzRuz9oQP/lYldrkGPzko= X-Google-Smtp-Source: AGHT+IH3Vn4y24ccOnNjvyrMKRdXMvoXmINXxWtKUHHRDjsnlypx2qCEJce143rhCfMATkU1PKi1PQ== X-Received: by 2002:a05:6214:27cb:b0:6fa:acc1:f077 with SMTP id 6a1803df08f44-6facebef794mr265266426d6.35.1748958525108; Tue, 03 Jun 2025 06:48:45 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d09a10e844sm842209085a.49.2025.06.03.06.48.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 06:48:44 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uMS0S-00000001hBt-0o7d; Tue, 03 Jun 2025 10:48:44 -0300 Date: Tue, 3 Jun 2025 10:48:44 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net Subject: Re: [PATCH 08/12] mm/khugepaged: Remove redundant pmd_devmap() check Message-ID: <20250603134844.GI386142@ziepe.ca> References: <2093b864560884a2a525d951a7cc20007da6b9b6.1748500293.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2093b864560884a2a525d951a7cc20007da6b9b6.1748500293.git-series.apopple@nvidia.com> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EF3791C000B X-Stat-Signature: 7f3szbh5kmat9hhcgecooauz6gydhhbr X-Rspam-User: X-HE-Tag: 1748958525-135036 X-HE-Meta: U2FsdGVkX184WzOULvfi6yii9BOzn/OUGiUDexxZDXVewt6szpuQcTqnSeaToPEr3ouMiOeKcPX5Gpkd+qe/G0BqVW3NVtBHNfM57cVy2ycZ/CcMQ3dJkgGpYEVHuzyOP0HSGqawuiqgraKgGwah2SVHOxuAg1vX2CeZn/DDBzkrJAHJIIFP3rNWwK5sAbf1nBkIx+ZLlW8he6EQKFyz3SRlBrbYYkLhgtdE2FguUfvzqGNCZD5EB23T6RATHk5oGqEaCCZiZTaKUAV+vReeRzv++G8k2Xl3QlmwKeZvuhTAQNVi9kZXJQfBTYJt1Dn1FDkujTGSJz1g1z1MEwmuJ5Q83UqF9qdtm65wm78HEMeIIv5GZa8RFplBYKsGjYSK8zFGuWiO3MXb+gj5b9b+gAACqsXf5TUgp5QBchul4naA1U+p6/LdgZ/WsyRVnoI6WudwYtqP0U2y/5rljOShOFAFyW49AfgQ8DH/hhUlg2RUhPFRPr7GxPZ6dNzfIORHqJZ/0DTFs0cS/OCnLj8X2KuIZ9I4GU8N/+myFA1q/XGqKMwssUlb4INm6WEhACgezLAB07q01oczViulSaUcYSRDP5Umex7NPmmOMDvbgBTZwYWOZ/K685yGcvbMFzw8fuzXZlc7afTwTama1WRk1AQT3unXyNHzSUpVzu8gXFrNFTFnP67YcErhsXMwlSw3bjErvMXsGZ9gp5n6rhjmJGTtLIovJ3hiMBAxyH9vdQNVStU1j3rwMjz6mlvc1gEttM0iVNCFTq5b7jBh/+SPzgAlmTIrsVPkkHL3e1QSs//UUowPbJ7Z9OyhXWRGjgz/aGISTkLG9K1kw88SJf0XU/Ge5CVGYKTtiEcEdRBj1L6YE7YYZet4k6ipZ3tIa0rMo/jg4gyRS6KZy72l4gfbz+P3tnUhnbT1IWmGSfonklqgdw7/iNPcqv9ObZoTSCszlrEd18TMHCK2FY+qZPO rr8O/pT1 DMlGffZme+XmtUCxUKb0O+LjaDCkIOeytaLxq1IGTEqmP9W+rmkGans4ZkK5FLDQo4qzBLhwFvCX7Bd0AfUo+nzKLzz3K7ISYMN6t5g6XrwNE1JEgF77ygoSxyL/gGdBv6slA6ulrzO4+cL5LqFC+IFs16Q/FKz+Rddh4S/z76KwpkdaxJp5OyzAyECMFDv/ezkwigRIkeNkiPVtgrxglw3pVUsoO4VUgePwPkOA/kGKBSRoIoL++4DZyNFayEFYHULPLi0L7i5j8t6yZrDGTX1ipThIXVXYLjsu3icH/6q9OXlal1AmbyUwmuoPgNDZ1kgpBnvfPOJ4qFI1Gs+NnIG1l3OzOzmIUVDBi5eHgi+Zj7Chxg3C28VDZaIXOZL9wuLyC7LVsEoYYjiAikzFn245yM7ANzWgVO0iO4Tz4QTMA/bo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 04:32:09PM +1000, Alistair Popple wrote: > The only users of pmd_devmap were device dax and fs dax. The check for > pmd_devmap() in check_pmd_state() is therefore redundant as callers > explicitly check for is_zone_device_page(), so this check can be dropped. > > Signed-off-by: Alistair Popple > --- > mm/khugepaged.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason