From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA3AC5AD49 for ; Tue, 3 Jun 2025 13:48:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C2E16B045C; Tue, 3 Jun 2025 09:48:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 273C06B045E; Tue, 3 Jun 2025 09:48:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 163056B045F; Tue, 3 Jun 2025 09:48:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EA2FE6B045C for ; Tue, 3 Jun 2025 09:48:18 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 985731D5FB3 for ; Tue, 3 Jun 2025 13:48:18 +0000 (UTC) X-FDA: 83514218676.26.C723A0D Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by imf24.hostedemail.com (Postfix) with ESMTP id D1099180003 for ; Tue, 3 Jun 2025 13:48:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="KLUL+1U/"; dmarc=none; spf=pass (imf24.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.180 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748958496; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ag2KSfmpizoceiuoj+cZXZUUA1usyi82jYygfJs/Bg=; b=TgBOg20IpjXVlDH95bX/S1XGdMDmBB8Ssd+Yy8x3w1/6wA4OZtIcpwv2SfdDDKt50xdCaW 8q6fV31toBkWUxinwq5gMcBaUJSRcMd/0Z8RfYyDAKi9aLM3YPsPBdturIUr82h7qZXtro ZNDs8SguBZz5g1YSjCFHnhZYnErPrN4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b="KLUL+1U/"; dmarc=none; spf=pass (imf24.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.180 as permitted sender) smtp.mailfrom=jgg@ziepe.ca ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748958496; a=rsa-sha256; cv=none; b=EsM+87foV+wiNvgAEcEk/wcb5kuSr7Ze1mq5IU3fadNKPdEy9drmVvuCpxu9ll31KW3jXY 98hDwZHw7PxoZy5/J6tW/ZF24IzGZTunWllFFHGHskpKa1GM4Redl/6yvGNAQd0/W13RAv je9TCn3YFqUYeh8u0Y/zBMykl2TwomY= Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-7c59e7039eeso777947085a.2 for ; Tue, 03 Jun 2025 06:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1748958496; x=1749563296; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0ag2KSfmpizoceiuoj+cZXZUUA1usyi82jYygfJs/Bg=; b=KLUL+1U/jWr8P1wgmyuCOENGN/KWmWh5IVYrD3F1Y5nde5aKrnmlW9OPJqo+9KiEGG wd6/xmv3DPMdztjYjoICA/AbxFhHk/MUIDOQ5TkV2yurzBpAlwLl0qxq2asOQAjdzB7D 9iXip/eAmIFRlp59AOCqNvpnnTtVM70Wo+Xjh1vysgoGnA5AD8QZx+s5bi8xFpq0Sogl 2Cr+UM9M4essLEsUKBlYPCttsUZjJaP7N1eCohoina6sKNiRNuFrIt42eiM3N954xbJg +lunIrFzEtnn2zOZ/BIZplpArHldNEs2LQWt+FaT+3I3fqu4k6N6JnylLZDmNbx7yTv7 /TNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748958496; x=1749563296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0ag2KSfmpizoceiuoj+cZXZUUA1usyi82jYygfJs/Bg=; b=jHVxpp6fb6fvi7lCjT2WK1urIAvuPL8WTMteLfZ/p7xMM5QwSTQ3zfiz7mGpc5xQfX it1l1n3thqgX5q+C/X8PHjiDTfGNbw4Km9Z8wCdXAouWM7jM/+ruXMOp18i5e1LwNizX d5HFXWpabUa16O3jSBSEqofs4M90/nVu6OJ7cMx9qMmgOwHejM1UEMfZzAylIKQ44inB 99HgOT+2DiUmY3Tv7H7a9GTOuQUyqzGif6h6887v1NhxPuh6fifJ4sqO+I4JzztjbBtC /BLR53Gh5QdKSdUyAJ4xGvWK/QtG39TIWiH9e+LN5Ue7YWsGA4ydt7pnSNe1PpzNOz3/ lKhQ== X-Gm-Message-State: AOJu0Yxxl0MEr3+DnpV/wCYEYIYZh2M3kxOBKmDu3ULODrgURRjUb+0z KhpkaRpfIvpUZhM8uPFKyV2NFxDZ1ggDPJ52fn+Ypev90iU+RTy9+Cw4DrsSZbWjMHU= X-Gm-Gg: ASbGncubIIfXPYiWEvkz7IRPVPB8mPB5Ro6fiGeqqr/HkacQcLma7JtvxIj78o5DsLE 4C+GHoqS7b8zx1UZtBYJdERKJbzf0FmKezaI7SenNYmZj6nB3GmFq2yLqATXjA1UP2x5G6vVG86 8juQPIBqb/sEd4ccnvp5W3IPoOq65xcle4QpiD7qYuvovpAEjiqEn1cYN/M4OgHTXjEcJbG/FVK +whyRZdabQVrAKXbWcghUsx4Y6zDO6r4SyL8mtC8XqhV8wHFKDZXVsd+UB419VN022X7IYk4EKZ XFZpMYc+Hr2PyR25rSoEbU8oFNtO0GUDr4tWgoCjqTD+K/nGsHfwGn1cYMKkwpDEeBk+WtZdkav pDc0btYu81uB1QQiyRgMJz5GqE7o= X-Google-Smtp-Source: AGHT+IEC7tetoyd4MWB27Cys7lEZRwLgg/tDNDKGL2nO8t1WlsQDGW4e4zhoToAJp9Wky9F+fr/2kQ== X-Received: by 2002:a05:620a:290a:b0:7c5:544e:2ccf with SMTP id af79cd13be357-7d0a4e57644mr2655730585a.57.1748958495697; Tue, 03 Jun 2025 06:48:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d09a0e3fa9sm838696585a.24.2025.06.03.06.48.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 06:48:15 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uMRzy-00000001hBT-2tOq; Tue, 03 Jun 2025 10:48:14 -0300 Date: Tue, 3 Jun 2025 10:48:14 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net Subject: Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls Message-ID: <20250603134814.GH386142@ziepe.ca> References: <2ee5a64581d2c78445e5c4180d7eceed085825ca.1748500293.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2ee5a64581d2c78445e5c4180d7eceed085825ca.1748500293.git-series.apopple@nvidia.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D1099180003 X-Stat-Signature: r43kgkcbxkmzwb31ghz59gh6i66ac1xt X-Rspam-User: X-HE-Tag: 1748958496-123868 X-HE-Meta: U2FsdGVkX1/aT2n+cteJYsObHXsfGaeXSkJayIg3hjQDZmLDJRgWnyyFUlnc/jxtst03VFuz6XLp3E5LUsBuYoNMpnm6KaH4Kj1H7sCsjczTK/x3ZGTKbMaFzP+UoFIQu2qPqstmFXpJdQgBkSFngO3O4jLbmGnMqMXYYsdfI1Gg+jDVuYS/DCrGYPrkjo0G8+U6iADD71Ql882Jj1drKG2PqkMaRDKI40oM0P5WgUgFMESK8rRt4OCnA4OzlT3CX90180WDm4qsaO4nWFZVVNWw//kAUf/p2Crs00z2oX4BItVUAFXaKgjXtZHOyIO8MKXAN/aBQkhmXFuYFEj5akLsEN0reUYzccNT3SJAK00mcoywHCumhg5Jb3QHxuev2KGW3djvEPJ2w5ub00aj5eO6aK1+Mf7VuBc+PYrvz0pPH0u1PD/Hyu6KMa8pH+/WBZxstK+Ps+MkGTxFx5Qd+AjJ/6DfjiUP2FvxZ1wFRI1dtKJoKrVezBw55F3DWRfN4H1o2yQ21Dp81AbsYcxGRjXeoVDFspzx1C+HaJp5GTBy/Jn4crK/YYsJaoAVMOqQ+FtwoT3LbUCanZjmBkv/Wz8hyICn3b12G5WCsF+fB32jeK8cW4D6a7I6xPSQIWug0Q8UXm+sb6YE4qfnu17YmWOY0waoMHK3x/Ba40C5hv6xigpsrV0hn4m9oNflXTuVYobr4D4t6CQPaZq0LlwUG1d0bgrGrLvUbu4ugETai4jYGV6XS9v6HnudbKnRBAMUAuR/2c7X6ZBk9FvxrLT+r0GTfIPZ2zZKxCoPmuSqRE7iEy4UdFbkoKevMHJfig8DEB4gBwfrXqUgFSlfpGy8lTrdjCiDZxnV/Id5QRaWWLLHIHnc0abZCXogkUMzSP85QwzW7F0LXZNCCiMgBZiP05nkSJaz2zmD4Hwew/xaZegLpfdriWbzPq/MYU/wDNakx6bD95h9/RNzuKCX4rm 5UG4Y9wb XzqBAq5towx8TYXlSW47sMpvHAH0Gypz/28x+7rnzZYqOR44+5YeNWjV1OnENmkDyRgy8r+GGMBzYCK06dSBypGt897ntS3PzLUw2D0mZAxdIhOdo9sPHEAR2OeMeKjReKPvmWl1FfaE/SIrBCVrx/e+bqQUm11XyIor2coU8RuniE41nLT46HSyIoCKJFf+F/ihQWGh4k+Ym15Nn9imOm7y4vUqZcXnP1z8z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 04:32:08PM +1000, Alistair Popple wrote: > DAX was the only thing that created pmd_devmap and pud_devmap entries > however it no longer does as DAX pages are now refcounted normally and > pXd_trans_huge() returns true for those. Therefore checking both pXd_devmap > and pXd_trans_huge() is redundant and the former can be removed without > changing behaviour as it will always be false. > > Signed-off-by: Alistair Popple > --- > fs/dax.c | 5 ++--- > include/linux/huge_mm.h | 10 ++++------ > include/linux/pgtable.h | 2 +- > mm/hmm.c | 4 ++-- > mm/huge_memory.c | 30 +++++++++--------------------- > mm/mapping_dirty_helpers.c | 4 ++-- > mm/memory.c | 15 ++++++--------- > mm/migrate_device.c | 2 +- > mm/mprotect.c | 2 +- > mm/mremap.c | 5 ++--- > mm/page_vma_mapped.c | 5 ++--- > mm/pagewalk.c | 8 +++----- > mm/pgtable-generic.c | 7 +++---- > mm/userfaultfd.c | 4 ++-- > mm/vmscan.c | 3 --- > 15 files changed, 40 insertions(+), 66 deletions(-) Reviewed-by: Jason Gunthorpe Jason