From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 163F4C5AE59 for ; Tue, 3 Jun 2025 13:37:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9F026B0456; Tue, 3 Jun 2025 09:37:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A76D16B0458; Tue, 3 Jun 2025 09:37:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98C5A6B0459; Tue, 3 Jun 2025 09:37:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7B8876B0456 for ; Tue, 3 Jun 2025 09:37:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3E2F7160A31 for ; Tue, 3 Jun 2025 13:37:44 +0000 (UTC) X-FDA: 83514192048.21.1B92AC7 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 64952A000A for ; Tue, 3 Jun 2025 13:37:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Cp9y8It9; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.180 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748957862; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UoX6ZYAbWcKDR6KFcgyyRoqI5kTXzqc7rOw8qvSUCMg=; b=TVDpl1yWKZymMV3u3dN+H+GvquDR74jOonTejuv43Xx4ixJyjJ4HmTnZ/c+yblmY8QOQmH rfIROX2ZCjTFzyRCWwfSz9YpvzA1WH9IodMgSA1YmNxCBDFGu075/XCFnZ8Z8qO7rxtVBu yfvT9ddZUUi4DB2RnRg4xlp63cgxL74= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=Cp9y8It9; spf=pass (imf25.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.160.180 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748957862; a=rsa-sha256; cv=none; b=yvUztg5mW7pcRuA/NgyZg55Tetyu8qfuwoBiL4/1PJkIC0N7UQ5CAhCGDY/K/U40JpiQP1 d8b6DQfOfwIft0POMmAjP8Ab3z454kd5CQPdrE+MKsFikSOzLPGyqMfjHWJuNwwWDbgD/Y Xt+IdWjqbn8BTtdqM3FCgIRh82uaSr4= Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-4a5a196f057so5698441cf.3 for ; Tue, 03 Jun 2025 06:37:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1748957861; x=1749562661; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UoX6ZYAbWcKDR6KFcgyyRoqI5kTXzqc7rOw8qvSUCMg=; b=Cp9y8It9dwHI9XjHFyGmyxRDqiPAZGl4SuIHlqALi9IDdu+AWMcShOYKzYEduknnqg Awj7FvA2AhMkp+rreKGA/8FLApWZanZNwTK0vGmUPdNYr4V835U7VP8TnuShnE/BGJ3B Yr1shUYmWr+8ndm3zzL2W6InglveQPcCnpjIOUREgyyUyX18CN9bNFCUR4sHOwqGs9ZP 8MazbawjlVm45hK8IYBt0MxXtMZkF4EBLcwDCd8hJiAgOq08N7Qz2YtUwetIjbuVy9eJ k472kxIsXj4J0CbGpB877Ivq1J3SlzI179uOCDBQKfCu+r/LSv5aL53wH6Bj/bk/mpup xngA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748957861; x=1749562661; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UoX6ZYAbWcKDR6KFcgyyRoqI5kTXzqc7rOw8qvSUCMg=; b=aoBz8ETLqeAaD5y2PHrSab5pDCXme1D33fob2SAXgzBtCIg3KlPclHZAe58688GqiF iY0VHPe9W8bQrL+a+JrwI7BK5o4arlWix3f9n5b4hMkmnc6634DJhadzUCVYT5CR2PIm 5ZIBEQBqiag94FfIrTZnTQBq6X3loJLjHf/vGgoobDkRgSQWERKhvVNJK6GdocO13N26 riVaWiUcTqQ0eWtYy9tSeJA0SxQsKx+26H9YtmYgJzAHvlCeUTevDcU4XH4RDtKkNru3 uFr0C/a0+6g6IrMUEG1O6I1W3Ei7JQZ1Qy7FTasi4Jh0c6C90CphEpSRt2HcZMXwbsMP nypQ== X-Gm-Message-State: AOJu0Yyi71k/YVtB0YQlvC7khPGZ7k6HdBtz3g8H8vVhpRzj24n7WPn3 OSDcPbBBtwybjG/8q7wj5bamrHIVf5+H7kLE5EbkE2/QvoB4hN0Vs6Ki4OHpLAreOaebmfyBfR0 ltkd/ X-Gm-Gg: ASbGncuSKw4tJK5oizzzkR5lfTQtdSG4o3JZnuMLcP7JMjTLEJcKELEgYb0fhhKHSQb onjmCcIyEgjACZyHXdJA754C+Q+XZODikM8yfxw3aA1DddrxKiO/GNqER0wnYsUXXDUFtgsfN6C fTqAEUfEBiMGEeJKD08aZjQpeiE7VwNvOQI/EKT006zQGtA9R/z6pAhy0lZ0jS7vrhXA4WPdF23 ez7s/bAWa23JZ5+4X3GKoP7MVYT2PsklLN66DVIULUmEFaiF3V+q7itB0S1nWbXO7hYZv/8Ww94 dPf+a89G84eDALG1kklCQ9NMeuC9RMSVAvvOHWUZoj3rwcXKNf3neUTgffdrEa+Om4cMkSEU04J kicr5knzGB3G5m2oqtwcWBmNFIoD4MIlBK6p95Q== X-Google-Smtp-Source: AGHT+IHIja21FGplZEuqybwyfzBxoI5k6ggct08qhelvg2n2Sr3vDQGi+qZrCCr84f/KmAHse8r0Yw== X-Received: by 2002:a05:622a:4c16:b0:4a4:2e99:3a92 with SMTP id d75a77b69052e-4a443f2d1a2mr265367291cf.38.1748957861491; Tue, 03 Jun 2025 06:37:41 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a435a36e1bsm73924021cf.62.2025.06.03.06.37.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 06:37:40 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uMRpk-00000001h5v-1tYD; Tue, 03 Jun 2025 10:37:40 -0300 Date: Tue, 3 Jun 2025 10:37:40 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net Subject: Re: [PATCH 04/12] mm: Convert vmf_insert_mixed() from using pte_devmap to pte_special Message-ID: <20250603133740.GE386142@ziepe.ca> References: <171c8ae407198160c434797a96fe56d837cdc1cd.1748500293.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171c8ae407198160c434797a96fe56d837cdc1cd.1748500293.git-series.apopple@nvidia.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 64952A000A X-Stat-Signature: 64gudqbopqobnz613wdbisc9yd6grz47 X-Rspam-User: X-HE-Tag: 1748957862-837831 X-HE-Meta: U2FsdGVkX19AcLKxfW6inQVWIWsS4lRNt58MKdZrtqjlxJwfvpSl8e74Vy17eAif6tQcamL5eYYfKQe2MfUwqQfeBNwZAXgi3SfQsjG3H/2yxy19yUKDtSwZiY3AMO8g0g5kfn87HKZnIFrfEBZ/hJxRkZp1L2No6wZ3wphSIl08UGR/VyP2bN4NaxcrdsvIfuWLWXJmW4+SUdK4HdAa4W+s75/M8gLLYTPKL8lqv5J3DZe0tye7A3MeaydYLELnOCLrjW704idK6XwXF0GQoBeGUvoYKLH/d8BWyaBvVJMIXEoIzJnhlF1gwcI8WOTfpQbuZSMdvpoRFKvZKwWHRXO33VU7exJ46WtkTVdreACh3+fhXnQ0+FquvrS0m+x3wxB1pq5Eio4mG5E7Z2EUvpdI2Z+2fOeYcPQLGPCqRwflHNTTr5ykYNcmssg9klhtUEh+ogR/Yzp20Pp/HxsgU/O0sOyJfUOApvVFCFhqumpf8LU7SQbEWP5z07wkhHYlsP0QZJmz66WSz5vRaIGCVMlL57P2NVQ+uGXvpuxIf5eqVsiRUfZpXN09NW6SE9lVNXMNatrzzP8shOoky+l+vavWyjFFDmkjViH53Da8lHV3ShYStonvKCKMih2snhMXt8mPbPLR5FXwxuysdAvQ6yuCKN6XnZvh8D2HicB9LymgZhv3+ZbI2sT0L5bWrEXqnLnVi2JeaZ2Sy7UgCPCitWrQrRLvBxvMcsncDHk0jgTf/QJYiMOe+/vYz4s6Z53TQ8BmDHy45Vfg4VNbBDiXwQEVdv1q2Sdjmn8cdfCTqxiQyFEHuMSAE/dE9g0Ueqv4pOMIlXvn92f43L8xqKvNUkTdwV/xRr66kPt6iRjoVHEFOaoXEDmRbEfaCNGoCUFw0ZeLRo7uhZnd3s+U8O6xar8f6DjW+O66/K72/oQL7HIXVyZD5gpj8zoACUNuqeFThaAk2ImswIwX8MPvCCr t4Q8exlc 3mGGXcjitJHrn1Er2LowppVbcsslpadhx26YMrwykuuLUPvQ/U9p68ykTRunTaCKPNkFlZju72NPov+jwwoyREa2/an4Sm5SpWJKW+mOeCvMN4LkjEREeQaSb5E6I/SyjmZgzgzY0CZnlNCc91R6cp+3aquW+KdU6zUjE8U7SmDVt5qgWvhNN/GCOuJA0KQ59GxMBXyArYxM2/IsA66jMWEMTwcE+zV/rliD8zsrPPYF1+Oykkq4/l8GkQvMmCfd3nnLFdS+ZMaeLeLYZqXoHQQJqx/GnTssZW6Y3ExgcSfyy/JGMr/K8oro+0nqJ5KqJPVpxLhtdx2qvycSYVH3BzJ5FIkxRqrlBTO0pB0kO2uQ5oH4Qr6fjV4EskQl2BLjFyZI4WUqOzatB95XFl7xDfIuxEmr0GXdlBw6yJX3RCHrHv/Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 04:32:05PM +1000, Alistair Popple wrote: > DAX no longer requires device PTEs as it always has a ZONE_DEVICE page > associated with the PTE that can be reference counted normally. Other users > of pte_devmap are drivers that set PFN_DEV when calling vmf_insert_mixed() > which ensures vm_normal_page() returns NULL for these entries. > > There is no reason to distinguish these pte_devmap users so in order to > free up a PTE bit use pte_special instead for entries created with > vmf_insert_mixed(). This will ensure vm_normal_page() will continue to > return NULL for these pages. > > Architectures that don't support pte_special also don't support pte_devmap > so those will continue to rely on pfn_valid() to determine if the page can > be mapped. > > Signed-off-by: Alistair Popple > --- > mm/hmm.c | 3 --- > mm/memory.c | 20 ++------------------ > mm/vmscan.c | 2 +- > 3 files changed, 3 insertions(+), 22 deletions(-) Reviewed-by: Jason Gunthorpe Jason