From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF51C5AD49 for ; Tue, 3 Jun 2025 13:37:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C3F36B0454; Tue, 3 Jun 2025 09:37:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19B626B0456; Tue, 3 Jun 2025 09:37:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D8B16B0457; Tue, 3 Jun 2025 09:37:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E3DAA6B0454 for ; Tue, 3 Jun 2025 09:37:03 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9AF2D120A03 for ; Tue, 3 Jun 2025 13:37:03 +0000 (UTC) X-FDA: 83514190326.15.0EA48CE Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by imf06.hostedemail.com (Postfix) with ESMTP id B3092180006 for ; Tue, 3 Jun 2025 13:37:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=NOTjiH9b; spf=pass (imf06.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748957821; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M2tOvYIRYhJ3zgazeT9iy9SxHIfkqCxujQJZWAlLZ4g=; b=K3vFT907ET1G3YEFqAjxsK4Iv91qCVrnMvCw9K4tlbj3bR7GkJaIBXw3Ui/IRLYXwJ99U8 FsLsqBOQsbIg3bznbkmQ4gd7hWGi1VdLSKPqlLP2KgBpnBRuZvb4g9lat3Miqciv7CXELx 3pfa6sL2hJdEEHSKhjKtmHfw+BC+jts= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=NOTjiH9b; spf=pass (imf06.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.179 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748957821; a=rsa-sha256; cv=none; b=Oo1PkXxgVJH9OpPdjkM5Dld1G7Diz9mfokGuxofZoyOkz3hqtWWwIkr08wJXr8yvM/Afep Z2Bf80ThHqGlFxCm3uJfPJpDXDheyB7o5QbwiyP/B1Hjq4iy9y+Kmv44bcT1gIsd4uXK6k zWkl2tByQZOJeMvTMelpR52sw9AsrUI= Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-7cadd46eb07so557337885a.3 for ; Tue, 03 Jun 2025 06:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1748957821; x=1749562621; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=M2tOvYIRYhJ3zgazeT9iy9SxHIfkqCxujQJZWAlLZ4g=; b=NOTjiH9bswYKowJoGbHBF7eRPqdcAVLPHu/gY7SoV3sKdqgnaAJuMpa+Q1BJSHrWay Z5auaRMb9TltxRzA15fQNHYGv5YTMJJ+moe/EVl3/FR3qsEw4NaqA/pUOhWXsnWREUVZ cYtJnonOmXKFajevT3MQRYjP9KAz5jYffrG3FneO9hg3QQ2wmkG3gI+pIi6EvRhvKUZK BF6EewByIOqQjUz63z2gJTToXA2wHJgSnbrcFVjAu+yR1x4qrr43lUmedUQjUL30YNc8 UsBUpVnxMLE/u99OV80m5mLuhX6Jwgp7+zjzkzBWOri7/FaKlaKf3iivlHKiLgWPVE1E hMrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748957821; x=1749562621; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M2tOvYIRYhJ3zgazeT9iy9SxHIfkqCxujQJZWAlLZ4g=; b=wFzfeLHLXrd6ToXjfT9+8DQ/J5DcwkrYwKH5+n47aeSz8K/K29VVCqNLd20XuWQrlR mTeaFQyR1hFAbsgj3fKaCCrSjEFWzAeroDo/Xvc+y0Bcr3VjU8Ahi1k90cuzia743cSQ 9o7KIFpMeCRw+cTnfz5dGdT7Q8nGghX8Efce6bTqKYvsnqhqrwzwdxm7b7JfNebrfuhR BbcwMIcGEHndi6NDQyx2DPWlO09bE3pU3B5XQT/e9mCHB0IyeyK2x2GL1d/0biRelizk WPnr7T8LgkmaBgWzpG43y+tt4gKT3VcdopfHqouu3udZTsyS4YlMYH7lkQ5PBT870NPi t/1Q== X-Gm-Message-State: AOJu0Ywj+JBwMiykvS+8egRzG3PhxcK+vxD9dVoOwyXa1dS20cweqJ/D gnQf7B0nWcMRDhPaS2LLUHAkpFGzf6RY75Gzi1PT7HHcE+X1484YeoN3PydDlAijmos= X-Gm-Gg: ASbGncuJa35tleckfEyGMGKu03EAQq67Teb0t/svCC6VkLL9ivUVIVGNSs3tlLfckpJ NcuzF3sWRPf9ndpxuqUKaKnUaqmihNFKJPq2jYtBpFwQdjpXoXwGXOViTYT2JRsXca5y+tpkOPn 59PbvEu/cUe4yFdxLhDPA4Ew6Lqtb4YfVeqSZjGtqR9Vm3LcJVN9REB7OBT7h6c4bxK5cJVx8lT AGA9AwErjK7ao/gHg6y+0DqPVbcd+XKwTC+lPcKY6c0KCS0YNlRi3a80p0Q1201WHEvoXUzb3G9 kgZu8GpcXlse3vu9HR6O6EU2INdUa09Tb666jGVFSZfJ9W+24Lg2pDs5CU8gQMXp59xmXjEuwpY IaHGoC4vX8ujxiqcd60DIMyDOPuQ= X-Google-Smtp-Source: AGHT+IF/1nQKKWghBymIv6kapapYp3T/T+mDb2uBcjAQYD1rkFwd/p2CMx7wy82AG8RXeUKzw729SQ== X-Received: by 2002:a05:620a:4408:b0:7c5:3d60:7f8d with SMTP id af79cd13be357-7d0a1fb91a0mr2626422385a.19.1748957820692; Tue, 03 Jun 2025 06:37:00 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-167-56-70.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.167.56.70]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d09a0fa38fsm842635185a.35.2025.06.03.06.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 06:37:00 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uMRp5-00000001h5Y-2rWO; Tue, 03 Jun 2025 10:36:59 -0300 Date: Tue, 3 Jun 2025 10:36:59 -0300 From: Jason Gunthorpe To: Alistair Popple Cc: linux-mm@kvack.org, gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, willy@infradead.org, david@redhat.com, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@groves.net Subject: Re: [PATCH 03/12] mm/pagewalk: Skip dax pages in pagewalk Message-ID: <20250603133659.GD386142@ziepe.ca> References: <1799c6772825e1401e7ccad81a10646118201953.1748500293.git-series.apopple@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1799c6772825e1401e7ccad81a10646118201953.1748500293.git-series.apopple@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: B3092180006 X-Rspamd-Server: rspam09 X-Stat-Signature: uabxmaugoxzo6kbst577uhccg7mgzg71 X-HE-Tag: 1748957821-402622 X-HE-Meta: U2FsdGVkX196Sv2QPydOVv7VXAIjMc5fRUS52tmzXcoFyuEeQU0BNsrcc4MqAs6yr14dzabfo6xz2euX2R9HqlVyoOLmvlQF2u2N3+8gUG2x3cKcvFkbyl4uIYViDkJeGGtovR9TkcGETFmNcS1/gJk23ybkf5q/VqRj1LOj+B7TnBiGbrJf271mXHOpZwtwcAMwY6koF3rE7aVxRRrHP2ky4ql/t7vGuUYlxqcUMFCbDSSCsDSaRgba5gtOXBTeKaDIvzOtitnsZ5OivNcpC9cKZBBQwDc5WxgNzCl58L/kmM0bak7hHTdNqBktT4c/pWGXzlLmxdWCd+R7dx4XA50BVA0rhyJ5ehUkTjcpymleD6+qet1oDBxRsTAq8EjuXkrXvbGQiiRuuGrFkrmteaXHMiJrz7DlNM0l6T41711yZM+H/MgVO+GM8NrlQOJ8+dp8FEcet77Axe8rjG4O90lICGvMvtjvfFjo8EUXCyUkSfi2sV6XIxRd74MvQF5+fpUCABeILxigePhunxgrdu/G6B3CyVzOyzLagdeOWVqL6rNuscX9EQKojw+oSJvFhF06etYL9XiLvotDKb4MfuDkHbAyyALJwXpj84UKKBzjEh9tMKC/stqoiNg82MGfM92hTAm4iRE8ZNGyN+q+FmjjXqJlk756KXp5+txn8fXWi4ypKQ+SJYytQPjgxkiovsi3FuFGy1X/SErRI+CU2QO1HakRi20gg3Z+hd1BkTjJdsd4GRJeBGBZ23ihpZgI8nu52PxZEoQQk7V3AaUNGP4LQyXldu0aQXalgJ0YJeZkX0t9cPJRXgfHy57L979vGCu3B3N6UAqdZFE6L21BqNMxG6W/SmEtUx9mYFiygPU3kXU5SHgqtu0KhcSdUflGuH3H4aAA+20WW/pTPjQS4KAtIOKohN3GSlK5Z5i0srQTTgAs9jJMqQUEFQA5oyRuRamCssUDC1tSUyRFa4u mPP9VZJZ 63OijSy93Dn3M+OdaNAmLYwRr0cCdtIerD0TajMobEcl4kx1tpQciKRUWoccF5eHV6wzS+JBlL7v3ElSSul1aPJw+Wdp/s0/SLZOhgPzZTJlmwunLxdl0C/b2YRiwpGwR4jtl1uHpxLeH/VehnhraUqndBtHFawa5oCS9SXFfn1MKmxfNSFbGX9VwAUFYMfWwYAxvap/eCC8+tzp94KPGGHg9JRUpNzgHJgq62tQswUGNzU64atFqnOAKOi+lSVEBGwOr+jed4TSrpNCMTSkyYShJ8AMxciy6QOPynb9Q4t0Xh6aFfUyiN0YmPHX5pTOWKD+76j7kNxK4c1iBzSdqfQY1fOO6seXg+0zPhI60VJL5cL8vvLbMQ5F+iAHZJXusXlBd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 04:32:04PM +1000, Alistair Popple wrote: > Previously dax pages were skipped by the pagewalk code as pud_special() or > vm_normal_page{_pmd}() would be false for DAX pages. Now that dax pages are > refcounted normally that is no longer the case, so add explicit checks to > skip them. > > Signed-off-by: Alistair Popple > --- > include/linux/memremap.h | 11 +++++++++++ > mm/pagewalk.c | 12 ++++++++++-- > 2 files changed, 21 insertions(+), 2 deletions(-) But why do we want to skip them? Like hmm uses pagewalk and it would like to see DAX pages? I guess it makes sense from the perspective of not changing things, but it seems like a comment should be left behind explaining that this is just for legacy reasons until someone audits the callers. Jason