From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE9FC5AE59 for ; Tue, 3 Jun 2025 11:09:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 177556B0416; Tue, 3 Jun 2025 07:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7226B0418; Tue, 3 Jun 2025 07:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDFC06B0419; Tue, 3 Jun 2025 07:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD5F86B0416 for ; Tue, 3 Jun 2025 07:09:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 72E4EEBE75 for ; Tue, 3 Jun 2025 11:09:23 +0000 (UTC) X-FDA: 83513818206.14.E56E88C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf24.hostedemail.com (Postfix) with ESMTP id 585FE18000A for ; Tue, 3 Jun 2025 11:09:21 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eRSudXXo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CfcGZjSk; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eRSudXXo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CfcGZjSk; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748948961; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v3T6HW81h0XzS8jybn8Y/92YLvaK8uvlq2un4GuekM0=; b=uuAXB2OTuA+iDjtZ8BZIg0WBiB2+E9mI6yrQuIiKbVx7WjBhQcd/0tmwqrJQ2JC0blBW2I 9/PwI1jc5gMB8YvA/Jqw4FeO1ghEBU+FiLf/u4j3FG+aBIUl6lMaj0NLT0rDXC60UKt30W iQfD5kEJStQTAazfOqwAecPsHUhsJpc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748948961; a=rsa-sha256; cv=none; b=gvT7VjUs7fnnj1ZQX6+9nfHLxtMF/DGvTMHgvVmYo3KXINaaroDvOGsV36rgbHrJaq4rEn C1o6sFnniSdg36SQTYVhW4uqgH3GqgGtmo+FOq8wpw+Oyc6VFV+W/35vKWjGRmLR9NIdcm YIvoEAjZ+Sa5m9URijYLfkg2smpF5M4= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eRSudXXo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CfcGZjSk; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eRSudXXo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=CfcGZjSk; spf=pass (imf24.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5685D21256; Tue, 3 Jun 2025 11:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748948948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3T6HW81h0XzS8jybn8Y/92YLvaK8uvlq2un4GuekM0=; b=eRSudXXoe/KO53hyguG0vF4zfNUdzckyyxsOvJNaKwUzp7eX1wHjP01HpYiAuIzF30XsBx +djvCgTFOBh2GdpBIn5yvhFSVpUyd3fPdhFtYsc6XuXIdQ8bTUa7Z8trmXEtoipgldhKUk s2GapSM4mY77bafcKMs+egVwhKcr6io= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748948948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3T6HW81h0XzS8jybn8Y/92YLvaK8uvlq2un4GuekM0=; b=CfcGZjSkvc8lkzuLOdCdB5dz3ZEHB3H4XpvVMTpxNYfjYIKRCYHnThj9T78txXil2t8B+U Q2z0V0La2aFl1cDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1748948948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3T6HW81h0XzS8jybn8Y/92YLvaK8uvlq2un4GuekM0=; b=eRSudXXoe/KO53hyguG0vF4zfNUdzckyyxsOvJNaKwUzp7eX1wHjP01HpYiAuIzF30XsBx +djvCgTFOBh2GdpBIn5yvhFSVpUyd3fPdhFtYsc6XuXIdQ8bTUa7Z8trmXEtoipgldhKUk s2GapSM4mY77bafcKMs+egVwhKcr6io= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1748948948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3T6HW81h0XzS8jybn8Y/92YLvaK8uvlq2un4GuekM0=; b=CfcGZjSkvc8lkzuLOdCdB5dz3ZEHB3H4XpvVMTpxNYfjYIKRCYHnThj9T78txXil2t8B+U Q2z0V0La2aFl1cDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BD6A213AAD; Tue, 3 Jun 2025 11:09:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KOd+K9PXPmjfXQAAD6G6ig (envelope-from ); Tue, 03 Jun 2025 11:09:07 +0000 From: Oscar Salvador To: Andrew Morton Cc: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v4 3/3] mm,memory_hotplug: Rename status_change_nid parameter in memory_notify Date: Tue, 3 Jun 2025 13:08:50 +0200 Message-ID: <20250603110850.192912-4-osalvador@suse.de> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250603110850.192912-1-osalvador@suse.de> References: <20250603110850.192912-1-osalvador@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 585FE18000A X-Stat-Signature: yqi56kqk81qfpgdndr4e1ce9439xw88q X-Rspam-User: X-HE-Tag: 1748948961-440997 X-HE-Meta: U2FsdGVkX188BWKx2V/d+O1Xf6TFCjoX0ALwZH24JpUJSVztL3rPuRxsq9f6/ALXp3JpE2s+0pXm8VK4yf4atg4F009silW3WX3t/8h7tOj9k3QVxrlpM/kGpLX3Fgi1CMHBp+X8/L5JJfsCgpm8NXqnBQQoVgTkqUvIMinpCuAB2NF39POvVUzCo3wtBO7DR1lz5UYbQWLHLrKpfE4eR/VMMyOK6TbeJgnNi9vFZywu6zCQ1Dn9oRRaR74lgLtqvFnyeI7hI2JvRA1RIJ04ChOvC9HidHysoHJwYGryseja5+txCh30LX2xvioV9wBgKqIbJlBITFsjW0oo9OiEJKRvzYm5JaOZw41xnYxIAFxUSTgb/3RduMraIT6y4D/29MU+vM1hZbyTo3wCEadEO6eToznKYLUIIPCV5epBu8A5Eg5IDBRx02Gm9pE0pDFd8/VOO+xi5YEne2NV+8mZTtzKzq4/TCXACBGT8M8fOk06AaSzuKVFQ+E6rBtGm5DgETrKYY0/2d1pS43LNjbmbCBj3/6/8g7Oh7PsH+EXp1yTTwQIonzpoy7X8w740JmtSedGheMGXkb5mhE9eipIxjpBqmw+lglDfrVfgLMDJ6mgwZ8HZFr8ZfBkXK7j0fZasbmR08BsjoXx7Z6rk1NquTTbBSBQrR7nPI6ri2Smjh32OL+Oud8o6xFcYS4y1b6i6/5w9fQOPwTQh4cK8x1YTW2bmql6hHjiFPzlFhnB4J2vQMmSLkzm4LS6M/46sFEyie5lEEF6Lst+Xr70EoSVs0XjgpQ3KPqZy2IIKD1dnfkjftEDtGui77554ADwoFO9grAt/h/kaNbsy9unAzW+ZM5Y5axDsKg3rpkBLqSMEZIwYSxsG7VWqSYQdNLfyRA6fiIdr/S9qQ8zZXzXKdluYQEa/6hR99FfwBMpwL76LyCkIf4GHgBuah511tXEwPSoKxC/wwdiJEf6Wt6cnNO wCMpsgOL Dgl2S8wA8mJi5gjncYnOvMUD2h44erH6LPrcoBdi9bhGB304zd3RCm40AYfQyxorczz1ddqZ6Z0nfKs0Pq5q6j96srIMr94yoSxuJi1LzFVGre6bLbI8HkpLFOoWqmHatmWuqvd4VORRNs0m3qOSxLem53oPJmUcdpTO3XetbohEw4hcrcRtt1FgY0oeR4LD+MobPu0p36x8+LNF3DfyzsSkdpQiu3N9NWRre4fXDeAijpbAJhfTIDkN/hBZ1Nas9YD/VvJKmzWw9ZBxuYxcs1SeQmufL/9umfp+xrcfFGErlMAGvfa6BiW8r5BIt1oNd/6DD2HJWtlEwwKAQd+vMF2rqX+7zdpiTXaaaUSefG0GobDauuoyzIEzZQCGcWmM+m46LYq6DKqenNsyZPVoFirnFu7aWAcy/T5iQRP1oFUafPpY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The 'status_change_nid' field was used to track changes in the memory state of a numa node, but that funcionality has been decoupled from memory_notify and moved to node_notify. Current consumers of memory_notify are only interested in which node the memory we are adding belongs to, so rename current 'status_change_nid' to 'nid'. Reviewed-by: Harry Yoo Reviewed-by: Vlastimil Babka Signed-off-by: Oscar Salvador --- include/linux/memory.h | 2 +- mm/memory_hotplug.c | 4 ++-- mm/page_ext.c | 12 +----------- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/include/linux/memory.h b/include/linux/memory.h index 8c5c88eaffb3..3c482f189d14 100644 --- a/include/linux/memory.h +++ b/include/linux/memory.h @@ -117,7 +117,7 @@ struct memory_notify { unsigned long altmap_nr_pages; unsigned long start_pfn; unsigned long nr_pages; - int status_change_nid; + int nid; }; struct node_notify { diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 777c81cd2943..3a62d90d416d 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1186,7 +1186,7 @@ int online_pages(unsigned long pfn, unsigned long nr_pages, cancel_mem_notifier_on_err = true; mem_arg.start_pfn = pfn; mem_arg.nr_pages = nr_pages; - mem_arg.status_change_nid = node_arg.status_change_nid; + mem_arg.nid = nid; ret = memory_notify(MEM_GOING_ONLINE, &mem_arg); ret = notifier_to_errno(ret); if (ret) @@ -1990,7 +1990,7 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, cancel_mem_notifier_on_err = true; mem_arg.start_pfn = start_pfn; mem_arg.nr_pages = nr_pages; - mem_arg.status_change_nid = node_arg.status_change_nid; + mem_arg.nid = node; ret = memory_notify(MEM_GOING_OFFLINE, &mem_arg); ret = notifier_to_errno(ret); if (ret) { diff --git a/mm/page_ext.c b/mm/page_ext.c index c351fdfe9e9a..477e6f24b7ab 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -378,16 +378,6 @@ static int __meminit online_page_ext(unsigned long start_pfn, start = SECTION_ALIGN_DOWN(start_pfn); end = SECTION_ALIGN_UP(start_pfn + nr_pages); - if (nid == NUMA_NO_NODE) { - /* - * In this case, "nid" already exists and contains valid memory. - * "start_pfn" passed to us is a pfn which is an arg for - * online__pages(), and start_pfn should exist. - */ - nid = pfn_to_nid(start_pfn); - VM_BUG_ON(!node_online(nid)); - } - for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) fail = init_section_page_ext(pfn, nid); if (!fail) @@ -436,7 +426,7 @@ static int __meminit page_ext_callback(struct notifier_block *self, switch (action) { case MEM_GOING_ONLINE: ret = online_page_ext(mn->start_pfn, - mn->nr_pages, mn->status_change_nid); + mn->nr_pages, mn->nid); break; case MEM_OFFLINE: offline_page_ext(mn->start_pfn, -- 2.49.0