From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F397FC5B549 for ; Tue, 3 Jun 2025 01:32:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 752F66B0385; Mon, 2 Jun 2025 21:32:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 704816B0386; Mon, 2 Jun 2025 21:32:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6188C6B0387; Mon, 2 Jun 2025 21:32:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 40FAA6B0385 for ; Mon, 2 Jun 2025 21:32:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CC62C12194C for ; Tue, 3 Jun 2025 01:32:06 +0000 (UTC) X-FDA: 83512363452.22.F4D22AD Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf14.hostedemail.com (Postfix) with ESMTP id 10BE8100009 for ; Tue, 3 Jun 2025 01:32:04 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Rrls1Ntq; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748914325; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=4Bojv3M+4ciWgsmcsFZ9XbWm7Qt7ckhMnQSLXNPu4AE=; b=LoiFdVeaEs8GNGIxYYgAzwX08P2jW5HuG6eNCAtykvzZxpH4kxl1xlcth9S00wb9V9Fd5i dGp0W7/NbsqcgjZUBqB07Zul6Zc42jHQ4wHU+30KPo03GYu7bpV02Zc8ULD87z9E/yl9Hr vmr3WMbNetMFb15ZuCPnQsrH3/lac90= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Rrls1Ntq; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748914325; a=rsa-sha256; cv=none; b=aPnHa5dNaVln50rlLutVF8Sw3O2e+v+pZ8pfcCd1hRLzsO1cYRHpcWjaiZw45eltIrOa44 toRJl1+5u/E/hNo8k4lC5pJK6kijLX3qsjSGu8IR81WOT0nHlVybD3/z5jboU+vd2KVedA s/2BfODQc4nZvcCg1gJY0c6crKDyGtU= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-742c5eb7d1cso5506032b3a.3 for ; Mon, 02 Jun 2025 18:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748914324; x=1749519124; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4Bojv3M+4ciWgsmcsFZ9XbWm7Qt7ckhMnQSLXNPu4AE=; b=Rrls1NtqGQcADIjorP7JjsQdv2zo89Fp6QXeU/So1TvsdzertVf4fdiH1SQOEaQxBs YP/i069eERZNGzlRzyQSsm5PVe2Hi14K2TZyri+rrptPLY1PQocivmWiz0oNR1JYQPd1 HWt+RPiHEbgkMWYDITDCaK4fZ3YlQ8sXybD/n2/EQvaJsiMTnpynATj4ZmQdfVS2BGrv RXjIr0qG75Ok7qf/nDj0lkSef6gl/UBcqE4OOgO4qbcfPv2NOiYuvc5izkfqrO1Iffw/ 2RwNUwykKNey4Fsj9Ry0xwH0+7p9v/wlZNY1jz/4f0PLcQLxyGje+yDD9KDhHnWsPouM m/HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748914324; x=1749519124; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Bojv3M+4ciWgsmcsFZ9XbWm7Qt7ckhMnQSLXNPu4AE=; b=EaG95TWXLtF+Yo5kmeIiaGgzOjcPFrfAAbTnI4hg0kaB56DpqoMkWViHX/r1GpW4xT YLs22l0i+HhDoX68sonJTqR7x5XdR2LCCJvA/ji6c6ullv/t1QRJZGrE9nc+r3q5djR7 llVjnH8nxdyhCijWv1EtKbN4/JlQCNCmXeANqdn1nPn0fZ3WWzILPN/r1wxHD4maindG uK5H2RPWsg+OLqCBdMdz69/YgX7xloTxJieDShIoYriXP0YUeTnT46jsw2xymEQ2d7YT HlL/nsKVbnpU9n4ApE7fgdLjo6fago++03YYpC7MS6TXqYYj+L3mpWqwqhNzB1V5/pRy Q6Yw== X-Forwarded-Encrypted: i=1; AJvYcCVQRQEjiO1nKfu7j67/tGMN3N/ZJjKjJC2S2Cdr2sCp8WsRkavO4jPqv9RKcNbJ8IF1Jm3ZEJU5iA==@kvack.org X-Gm-Message-State: AOJu0YxRMYGRbDiX9fg38HIl0XTwu8D7tBb5ObIWDnI3517F6l85xXnf NtuWZXzG71dD3mueAma9y7o48vzjsIWbm1HoLzyN451KaBgF6axaEvUT X-Gm-Gg: ASbGncuckRWOzjF8CyEn/16v7udWMgLk6WsSIRyhLao/MxPaBqSIJx5nwnRG5ocWuGN CJeW4zNI4HG22MpOBb0ImxkBiaBgb0qcB2seq3gNt0rzxJg+bqziInoKfLmivPq+nIRRWsgwAoi JrGLv3hO37oRfe5sfAmlFBFmAXb1Ch7wlid6Bee48ngCoDJRYYQjNwVzmJ/KLmrbzWfhY4b8IT8 pjXzM8uKckTn8xMIwb9KnQChJ55i4lDPYmper3162kqlfS/6FwlNuro5wE09KFUYAtDF5UdOWta bCHpsWunVeTquBDMBGMtaw2+v7a8vXi1EKBJYxl2oXkd6lKnjQw/u3Dv3vRrIyHWuc9swlwGUpf l2N4= X-Google-Smtp-Source: AGHT+IEBvCo+zKvd7j7mdsU9DQLa79UighTNoRN94FnbTa2xsd5YbzSKsqrLSptrGQDaJf+xCO0s5A== X-Received: by 2002:a05:6a00:2e86:b0:746:2ce5:a491 with SMTP id d2e1a72fcca58-747bd96b90dmr20446518b3a.10.1748914323756; Mon, 02 Jun 2025 18:32:03 -0700 (PDT) Received: from Barrys-MBP.hub ([118.92.145.159]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747afed33casm8265907b3a.73.2025.06.02.18.31.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 02 Jun 2025 18:32:03 -0700 (PDT) From: Barry Song <21cnbao@gmail.com> To: akpm@linux-foundation.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Barry Song , "Liam R. Howlett" , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Jann Horn , Suren Baghdasaryan , Lokesh Gidra , Tangquan Zheng Subject: [PATCH RFC] mm: madvise: use walk_page_range_vma() for madvise_free_single_vma() Date: Tue, 3 Jun 2025 13:31:54 +1200 Message-Id: <20250603013154.5905-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: 889mm4dokif1y4a68srwss9pgbd4nd53 X-Rspamd-Queue-Id: 10BE8100009 X-Rspamd-Server: rspam11 X-HE-Tag: 1748914324-571775 X-HE-Meta: U2FsdGVkX1+Cv7qCiDPN/whFp/7VIVuKjEfWWRS8FuCZ9TF0TdjskE4l8QbMwTQ1EpxLxHKx8SL1PkpMaFwq2XvZg3lXw/vLSvgFFZ2leiXXOm6V7XM4FdcwUNYMBI3FEltNgP6tZyFa/0cCzXSjjalHb01YgZR2r361VumS8E0zKVO/qDYx/wAJar41Y9i5fK3laXcrgfDDwb891+33yCpdJp8smzO5STn077rzEgCtey1sak/A69I89RlRlFFa/q4rKqf03DWbysd2Sf9SlL8e35okBeM0o0S/mLW3Agp9B5FbxC6bwTnWzC4BO6C5c1CfrcGJfCgzItSPxVNPKvuRXB9oJZIlhwyQbZAWKxM/crPktz0WeMtpF63lIPfeKG5qU4Dajmt3G2fkqy1SF/4cmQ7WoUAT51RtbAVwq7r/5mS8dmh9rpfUqB3Me9pWtmYTTv+7m1Gg1cAZFLQE+20dBONASX1gCXGhHf44W+8GKsdk57zzrrrwV4/b4wIQYhHt69dw22tkizw5BwpLgEU5uQFEvdtV7jILXEzDsMao1jLLd5v8Q+FqgtKF20MoHpRJ8WR3na0Uk6zILVVvlw+daePpASx4a5z0WPYw69eEiKM03KpLDH2ViIhxvJEG6xYilVK7/2Lwu2k472IZu7tcLnb2AwD+ikYqr/WeSvZS542IKWf6sHdmsoUKXbkD24IJs3q8X0IYUHF3rxsHayLtj49uDXfKLunRtkEKgC8OJEIgZ4omEPvsL3pg9T6ph0/MbnLZ7K/d1shjreISKwWSByqqloGNedLEi4tRp72LIuaj+zjBjp7clmztSACxXyx2H+Z71krLaOTyVwi6rjktXSZPj30OeMyVoDHRkgKbGjo53xXI1KSyBCdbLAY+mb77I1fnb1+n26DwfthBtQL7pAZfsRPrLb/s48HvF6KdbCiwHbxybrE4UUBeiM3ISbs6SVIJUC16W3XCH3C Xag03bg5 xprKKFwrnKgdYQzassWXqmQv95jtQTCX+8k2tDdvm3l2Ut4yeJnNwN/qy3fVEijtSz7Xd/zwxVdaLtIFbTuoI3uOKp3DVOHfMFfLfNkzzTmYNXSmUlfwiiidceKAGys5rlVscFbTdPSA0e3sydiHtyt6Mt0dIeuBgHFvxougOjdxTeDvpUOsKKGYS18zGTUmVZqKb4WOi8Qt6lPe/dyKz6Q/MFKzKA0hvmehpJ8Tw1VeGB5it/pyxW4g0pSd8XC7S3XLnSgrezeWOT27aQmyn7jWDRzufMg7uxUxTq55F7wVqGLjg8Qg+YTSPhwN1NZh+1A/RZHbrLnSF335ZATywC6wcjhN7tPkViXGci0HsEZHz7Wr1Hr52gSlAbHLPueTXBaFwGDjifp9QvMm5bQ6TkIgv+tdRcCJRPhV06Jbml+piSH0Pqy2ElRWjoKw0WVUPx2duk5ktGCzg5hiEzWoHQEo+DbvgvZ+IsCPvNp16EMTYBs8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Barry Song We've already found the VMA before calling madvise_free_single_vma(), so calling walk_page_range() and doing find_vma() again seems unnecessary. It also prevents potential optimizations for MADV_FREE to use a per-VMA lock. Cc: "Liam R. Howlett" Cc: Lorenzo Stoakes Cc: David Hildenbrand Cc: Vlastimil Babka Cc: Jann Horn Cc: Suren Baghdasaryan Cc: Lokesh Gidra Cc: Tangquan Zheng Signed-off-by: Barry Song --- mm/madvise.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/madvise.c b/mm/madvise.c index d408ffa404b3..c6a28a2d3ff8 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -826,7 +826,7 @@ static int madvise_free_single_vma(struct madvise_behavior *madv_behavior, mmu_notifier_invalidate_range_start(&range); tlb_start_vma(tlb, vma); - walk_page_range(vma->vm_mm, range.start, range.end, + walk_page_range_vma(vma, range.start, range.end, &madvise_free_walk_ops, tlb); tlb_end_vma(tlb, vma); mmu_notifier_invalidate_range_end(&range); -- 2.39.3 (Apple Git-146)